On Wed, Mar 27, 2024 at 10:59 PM Tom Lane wrote:
> Richard Guo writes:
> > On Wed, Mar 27, 2024 at 4:06 AM Tom Lane wrote:
> >> I'm less convinced about changing this. I'd rather keep it consistent
> >> with mark_dummy_rel.
>
> > Hm, I wonder if we should revise the comment there that states
Richard Guo writes:
> On Wed, Mar 27, 2024 at 4:06 AM Tom Lane wrote:
>> I'm less convinced about changing this. I'd rather keep it consistent
>> with mark_dummy_rel.
> Hm, I wonder if we should revise the comment there that states "but not
> when called from elsewhere", as it does not seem to
On Wed, Mar 27, 2024 at 4:06 AM Tom Lane wrote:
> Richard Guo writes:
> > I happened to notice that the set_cheapest() calls in functions
> > set_namedtuplestore_pathlist() and set_result_pathlist() are redundant,
> > as we've centralized the set_cheapest() calls in set_rel_pathlist().
>
> >
Richard Guo writes:
> I happened to notice that the set_cheapest() calls in functions
> set_namedtuplestore_pathlist() and set_result_pathlist() are redundant,
> as we've centralized the set_cheapest() calls in set_rel_pathlist().
> Attached is a trivial patch to remove these calls.
Agreed, and
I happened to notice that the set_cheapest() calls in functions
set_namedtuplestore_pathlist() and set_result_pathlist() are redundant,
as we've centralized the set_cheapest() calls in set_rel_pathlist().
Attached is a trivial patch to remove these calls.
BTW, I suspect that the set_cheapest()
