Re: checking snapshot argument for index_beginscan

2022-12-22 Thread Pavel Borisov
On Fri, 23 Dec 2022 at 00:36, Ted Yu wrote: >> >> Hi, >> I was looking at commit 941aa6a6268a6a66f6895401aad6b5329111d412 . >> >> I think it would be better to move the assertion into >> `index_beginscan_internal` because it is called by index_beginscan and >> index_beginscan_bitmap >> >> In

Re: checking snapshot argument for index_beginscan

2022-12-22 Thread Ted Yu
> > Hi, > I was looking at commit 941aa6a6268a6a66f6895401aad6b5329111d412 . > > I think it would be better to move the assertion into > `index_beginscan_internal` because it is called by index_beginscan > and index_beginscan_bitmap > > In the future, when a new variant of `index_beginscan_XX` is