On Fri, 25 Nov 2022 at 09:31, Tom Lane wrote:
> If you wanted to be hard-nosed about 80 character width, you could
> pull out the PageGetItemId call into a separate local variable.
> I wasn't going to be quite that picky, but I won't object if that
> seems better to you.
I wasn't too worried
On Fri, 25 Nov 2022 at 09:40, Ted Yu wrote:
> Patch v4 stores ItemId in a local variable.
ok, I pushed that one. Thank you for working on this.
David
On Thu, Nov 24, 2022 at 12:31 PM Tom Lane wrote:
> David Rowley writes:
> > After running pgindent on v2, I see it still pushes the lines out
> > quite far. If I add a new line after PageGetItemId(page, and put the
> > variable assignment away from the variable declaration then it looks a
> >
David Rowley writes:
> After running pgindent on v2, I see it still pushes the lines out
> quite far. If I add a new line after PageGetItemId(page, and put the
> variable assignment away from the variable declaration then it looks a
> bit better. It's still 1 char over the limit.
If you wanted
On Fri, 25 Nov 2022 at 04:29, Ted Yu wrote:
> Here is patch v2.
After running pgindent on v2, I see it still pushes the lines out
quite far. If I add a new line after PageGetItemId(page, and put the
variable assignment away from the variable declaration then it looks a
bit better. It's still 1
On Thu, Nov 24, 2022 at 7:11 AM Tom Lane wrote:
> Daniel Gustafsson writes:
> >> On 24 Nov 2022, at 13:42, Ted Yu wrote:
> >> In _hash_pgaddtup(), it seems the indentation is off for the assertion.
>
> > Indentation is handled by applying src/tools/pgindent to the code, and
> > re-running it
Daniel Gustafsson writes:
>> On 24 Nov 2022, at 13:42, Ted Yu wrote:
>> In _hash_pgaddtup(), it seems the indentation is off for the assertion.
> Indentation is handled by applying src/tools/pgindent to the code, and
> re-running it on this file yields no re-indentation so this is in fact
> On 24 Nov 2022, at 13:42, Ted Yu wrote:
> In _hash_pgaddtup(), it seems the indentation is off for the assertion.
>
> Please take a look at the patch.
Indentation is handled by applying src/tools/pgindent to the code, and
re-running it on this file yields no re-indentation so this is in fact
Hi,
I was looking at :
commit d09dbeb9bde6b9faabd30e887eff4493331d6424
Author: David Rowley
Date: Thu Nov 24 17:21:44 2022 +1300
Speedup hash index builds by skipping needless binary searches
In _hash_pgaddtup(), it seems the indentation is off for the assertion.
Please take a look at
