Re: releasing ParallelApplyTxnHash when pa_launch_parallel_worker returns NULL

On Thu, Jan 12, 2023 at 8:25 AM Ted Yu wrote: > On Wed, Jan 11, 2023 at 6:54 PM Amit Kapila wrote: >> >> On Wed, Jan 11, 2023 at 9:31 AM Ted Yu wrote: >> > >> > On Tue, Jan 10, 2023 at 7:55 PM houzj.f...@fujitsu.com >> > wrote: >> >> >> >> On Wednesday, January 11, 2023 10:21 AM Ted Yu >>

Re: releasing ParallelApplyTxnHash when pa_launch_parallel_worker returns NULL

On Wed, Jan 11, 2023 at 6:54 PM Amit Kapila wrote: > On Wed, Jan 11, 2023 at 9:31 AM Ted Yu wrote: > > > > On Tue, Jan 10, 2023 at 7:55 PM houzj.f...@fujitsu.com < > houzj.f...@fujitsu.com> wrote: > >> > >> On Wednesday, January 11, 2023 10:21 AM Ted Yu > wrote: > >> > /* First time

Re: releasing ParallelApplyTxnHash when pa_launch_parallel_worker returns NULL

On Wed, Jan 11, 2023 at 9:31 AM Ted Yu wrote: > > On Tue, Jan 10, 2023 at 7:55 PM houzj.f...@fujitsu.com > wrote: >> >> On Wednesday, January 11, 2023 10:21 AM Ted Yu wrote: >> > /* First time through, initialize parallel apply worker state >> > hashtable. */ >> > if

Re: releasing ParallelApplyTxnHash when pa_launch_parallel_worker returns NULL

On Tue, Jan 10, 2023 at 7:55 PM houzj.f...@fujitsu.com < houzj.f...@fujitsu.com> wrote: > On Wednesday, January 11, 2023 10:21 AM Ted Yu > wrote: > > /* First time through, initialize parallel apply worker state > hashtable. */ > > if (!ParallelApplyTxnHash) > > > > I think it

RE: releasing ParallelApplyTxnHash when pa_launch_parallel_worker returns NULL

On Wednesday, January 11, 2023 10:21 AM Ted Yu wrote: > /* First time through, initialize parallel apply worker state > hashtable. */ > if (!ParallelApplyTxnHash) > > I think it would be better if `ParallelApplyTxnHash` is created by the first > successful parallel apply worker.

Re: releasing ParallelApplyTxnHash when pa_launch_parallel_worker returns NULL

On Tue, Jan 10, 2023 at 6:13 PM houzj.f...@fujitsu.com < houzj.f...@fujitsu.com> wrote: > On Wednesday, January 11, 2023 1:25 AM Ted Yu wrote: > > > I was reading src/backend/replication/logical/applyparallelworker.c . > > In `pa_allocate_worker`, when pa_launch_parallel_worker returns NULL, I >

RE: releasing ParallelApplyTxnHash when pa_launch_parallel_worker returns NULL

On Wednesday, January 11, 2023 1:25 AM Ted Yu wrote: > I was reading src/backend/replication/logical/applyparallelworker.c . > In `pa_allocate_worker`, when pa_launch_parallel_worker returns NULL, I think > the `ParallelApplyTxnHash` should be released. Thanks for reporting.

Re: releasing ParallelApplyTxnHash when pa_launch_parallel_worker returns NULL

On Tue, Jan 10, 2023 at 9:43 AM Ted Yu wrote: > > > On Tue, Jan 10, 2023 at 9:26 AM Ted Yu wrote: > >> >> >> On Tue, Jan 10, 2023 at 9:25 AM Ted Yu wrote: >> >>> Hi, >>> I was reading src/backend/replication/logical/applyparallelworker.c . >>> In `pa_allocate_worker`, when

Re: releasing ParallelApplyTxnHash when pa_launch_parallel_worker returns NULL

On Tue, Jan 10, 2023 at 9:26 AM Ted Yu wrote: > > > On Tue, Jan 10, 2023 at 9:25 AM Ted Yu wrote: > >> Hi, >> I was reading src/backend/replication/logical/applyparallelworker.c . >> In `pa_allocate_worker`, when pa_launch_parallel_worker returns NULL, I >> think the `ParallelApplyTxnHash`

Re: releasing ParallelApplyTxnHash when pa_launch_parallel_worker returns NULL

On Tue, Jan 10, 2023 at 9:25 AM Ted Yu wrote: > Hi, > I was reading src/backend/replication/logical/applyparallelworker.c . > In `pa_allocate_worker`, when pa_launch_parallel_worker returns NULL, I > think the `ParallelApplyTxnHash` should be released. > > Please see the patch. > > Thanks > Here

releasing ParallelApplyTxnHash when pa_launch_parallel_worker returns NULL

Hi, I was reading src/backend/replication/logical/applyparallelworker.c . In `pa_allocate_worker`, when pa_launch_parallel_worker returns NULL, I think the `ParallelApplyTxnHash` should be released. Please see the patch. Thanks