Re: small_cleanups around login event triggers

2024-03-18 Thread Robert Treat
On Thu, Mar 14, 2024 at 7:23 PM Daniel Gustafsson wrote: > > > On 14 Mar 2024, at 14:21, Robert Treat wrote: > > On Thu, Mar 14, 2024 at 8:21 AM Daniel Gustafsson wrote: > > >> - canceling connection in psql wouldn't > >> cancel > >> + canceling a connection in psql will not > >>

Re: small_cleanups around login event triggers

2024-03-14 Thread Daniel Gustafsson
> On 14 Mar 2024, at 14:21, Robert Treat wrote: > On Thu, Mar 14, 2024 at 8:21 AM Daniel Gustafsson wrote: >> - canceling connection in psql wouldn't cancel >> + canceling a connection in psql will not >> cancel >> Nitpickery (perhaps motivated by english not being my first language),

Re: small_cleanups around login event triggers

2024-03-14 Thread Robert Treat
On Thu, Mar 14, 2024 at 8:21 AM Daniel Gustafsson wrote: > > > On 14 Mar 2024, at 02:47, Robert Treat wrote: > > > I was taking a look at the login event triggers work (nice work btw) > > Thanks for reviewing committed code, that's something which doesn't happen > often enough and is much

Re: small_cleanups around login event triggers

2024-03-14 Thread Daniel Gustafsson
> On 14 Mar 2024, at 02:47, Robert Treat wrote: > I was taking a look at the login event triggers work (nice work btw) Thanks for reviewing committed code, that's something which doesn't happen often enough and is much appreciated. > and saw a couple of minor items that I thought would be

small_cleanups around login event triggers

2024-03-13 Thread Robert Treat
I was taking a look at the login event triggers work (nice work btw) and saw a couple of minor items that I thought would be worth cleaning up. This is mostly just clarifying the exiting docs and code comments. Robert Treat https://xzilla.net login_event_trigger_small_cleanups.patch