Re: [HACKERS] [PATCHES] Proposed patch: synchronized_scanning GUC variable

2008-01-31 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: OK, but keep in mind if we use synchronized_seqscans in pg_dump we will have to recognize that GUC forever. No, because it's being used on the query side, not in the emitted dump. We have *never* promised that pg_dump version N could

Re: [HACKERS] [PATCHES] Proposed patch: synchronized_scanning GUC variable

2008-01-31 Thread Alvaro Herrera
Tom Lane wrote: in fact, personally I'd like to make that case be a hard error, rather than something people could override with -i. +1 to this idea. TODO for 8.4? -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom

Re: [HACKERS] [PATCHES] Proposed patch: synchronized_scanning GUC variable

2008-01-31 Thread Simon Riggs
On Thu, 2008-01-31 at 11:20 -0300, Alvaro Herrera wrote: Tom Lane wrote: in fact, personally I'd like to make that case be a hard error, rather than something people could override with -i. +1 to this idea. TODO for 8.4? -1 without some more planning about the effects and

Re: {**Spam**} Re: [HACKERS] [PATCHES] Proposed patch: synchronized_scanning GUC variable

2008-01-31 Thread Dimitri Fontaine
Hi, Le jeudi 31 janvier 2008, Tom Lane a écrit : We have *never* promised that pg_dump version N could dump from server version N+1 .., in fact, personally I'd like to make that case be a hard error, rather than something people could override with -i. Are you thinking about next major or

Re: {**Spam**} Re: [HACKERS] [PATCHES] Proposed patch: synchronized_scanning GUC variable

2008-01-31 Thread Bruce Momjian
Dimitri Fontaine wrote: -- Start of PGP signed section. Hi, Le jeudi 31 janvier 2008, Tom Lane a ?crit?: We have *never* promised that pg_dump version N could dump from server version N+1 .., in fact, personally I'd like to make that case be a hard error, rather than something people

Re: {**Spam**} Re: [HACKERS] [PATCHES] Proposed patch: synchronized_scanning GUC variable

2008-01-31 Thread Dimitri Fontaine
Le jeudi 31 janvier 2008, Tom Lane a écrit : I'm thinking next major. In principle there could be cases where a minor update could break pg_dump, but it seems unlikely enough that it's not reasonable to embed such a policy in the code. As for next major, though, the mere existence of the -i

Re: {**Spam**} Re: [HACKERS] [PATCHES] Proposed patch: synchronized_scanning GUC variable

2008-01-31 Thread Tom Lane
Dimitri Fontaine [EMAIL PROTECTED] writes: Le jeudi 31 janvier 2008, Tom Lane a écrit : We have *never* promised that pg_dump version N could dump from server version N+1 .., in fact, personally I'd like to make that case be a hard error, rather than something people could override with -i.

Re: {**Spam**} Re: [HACKERS] [PATCHES] Proposed patch: synchronized_scanning GUC variable

2008-01-31 Thread Gregory Stark
Bruce Momjian [EMAIL PROTECTED] writes: Dimitri Fontaine wrote: -- Start of PGP signed section. Hi, Le jeudi 31 janvier 2008, Tom Lane a ?crit?: We have *never* promised that pg_dump version N could dump from server version N+1 .., in fact, personally I'd like to make that case be a

Re: [HACKERS] [PATCHES] Proposed patch: synchronized_scanning GUC variable

2008-01-30 Thread Simon Riggs
On Mon, 2008-01-28 at 16:21 -0500, Tom Lane wrote: Simon Riggs [EMAIL PROTECTED] writes: Rather than having a boolean GUC, we should have a number and make the parameter synchronised_scan_threshold. This would open up a can of worms I'd prefer not to touch, having to do with whether the

Re: [HACKERS] [PATCHES] Proposed patch: synchronized_scanning GUC variable

2008-01-30 Thread Tom Lane
Simon Riggs [EMAIL PROTECTED] writes: I'm still not very happy with any of the options here. BAS is great if you didn't want to trash the cache, but its also annoying to people that really did want to load a large table into cache. However we set it, we're going to have problems because not

Re: [HACKERS] [PATCHES] Proposed patch: synchronized_scanning GUC variable

2008-01-30 Thread Heikki Linnakangas
Tom Lane wrote: Simon Riggs [EMAIL PROTECTED] writes: I'm still not very happy with any of the options here. BAS is great if you didn't want to trash the cache, but its also annoying to people that really did want to load a large table into cache. However we set it, we're going to have

Re: [HACKERS] [PATCHES] Proposed patch: synchronized_scanning GUC variable

2008-01-30 Thread Simon Riggs
On Wed, 2008-01-30 at 18:42 +, Heikki Linnakangas wrote: Tom Lane wrote: Simon Riggs [EMAIL PROTECTED] writes: I'm still not very happy with any of the options here. BAS is great if you didn't want to trash the cache, but its also annoying to people that really did want to load a

Re: [HACKERS] [PATCHES] Proposed patch: synchronized_scanning GUC variable

2008-01-30 Thread Bruce Momjian
Tom Lane wrote: Simon Riggs [EMAIL PROTECTED] writes: I'm still not very happy with any of the options here. BAS is great if you didn't want to trash the cache, but its also annoying to people that really did want to load a large table into cache. However we set it, we're going to have

Re: [HACKERS] [PATCHES] Proposed patch: synchronized_scanning GUC variable

2008-01-30 Thread Bruce Momjian
Bruce Momjian wrote: Tom Lane wrote: Simon Riggs [EMAIL PROTECTED] writes: I'm still not very happy with any of the options here. BAS is great if you didn't want to trash the cache, but its also annoying to people that really did want to load a large table into cache. However we

Re: [HACKERS] [PATCHES] Proposed patch: synchronized_scanning GUC variable

2008-01-30 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: Another question --- why don't we just turn off synchronized_seqscans when we do COPY TO? That would fix pg_dump and be transparent. Enforcing this from the server side seems a pretty bad idea. Note that there were squawks about having pg_dump behave

Re: [HACKERS] [PATCHES] Proposed patch: synchronized_scanning GUC variable

2008-01-30 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: Another question --- why don't we just turn off synchronized_seqscans when we do COPY TO? That would fix pg_dump and be transparent. Enforcing this from the server side seems a pretty bad idea. Note that there were squawks about

Re: [HACKERS] [PATCHES] Proposed patch: synchronized_scanning GUC variable

2008-01-30 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: OK, but keep in mind if we use synchronized_seqscans in pg_dump we will have to recognize that GUC forever. No, because it's being used on the query side, not in the emitted dump. We have *never* promised that pg_dump version N could dump from server

Re: [HACKERS] [PATCHES] Proposed patch: synchronized_scanning GUC variable

2008-01-28 Thread Zeugswetter Andreas ADI SD
I liked the synchronized_sequential_scans idea myself. I think that's a bit too long. How about synchronized_scans, or synchronized_seqscans? We have enable_seqscan already, so that last choice seems to fit in. Yes looks good, how about synchronized_seqscan without plural ? Andreas

Re: [HACKERS] [PATCHES] Proposed patch: synchronized_scanning GUC variable

2008-01-28 Thread Simon Riggs
On Sun, 2008-01-27 at 21:04 -0500, Tom Lane wrote: [ redirecting thread to -hackers ] Neil Conway [EMAIL PROTECTED] writes: On Sun, 2008-01-27 at 21:54 +, Gregory Stark wrote: I liked the synchronized_sequential_scans idea myself. I think that's a bit too long. How about

Re: [HACKERS] [PATCHES] Proposed patch: synchronized_scanning GUC variable

2008-01-28 Thread Tom Lane
Simon Riggs [EMAIL PROTECTED] writes: Rather than having a boolean GUC, we should have a number and make the parameter synchronised_scan_threshold. This would open up a can of worms I'd prefer not to touch, having to do with whether the buffer-access-strategy behavior should track that or not.

Re: [HACKERS] [PATCHES] Proposed patch: synchronized_scanning GUC variable

2008-01-28 Thread Hans-Juergen Schoenig
On Jan 28, 2008, at 6:14 PM, Simon Riggs wrote: On Sun, 2008-01-27 at 21:04 -0500, Tom Lane wrote: [ redirecting thread to -hackers ] Neil Conway [EMAIL PROTECTED] writes: On Sun, 2008-01-27 at 21:54 +, Gregory Stark wrote: I liked the synchronized_sequential_scans idea myself. I

Re: [HACKERS] [PATCHES] Proposed patch: synchronized_scanning GUC variable

2008-01-28 Thread Simon Riggs
On Mon, 2008-01-28 at 16:21 -0500, Tom Lane wrote: Simon Riggs [EMAIL PROTECTED] writes: Rather than having a boolean GUC, we should have a number and make the parameter synchronised_scan_threshold. This would open up a can of worms I'd prefer not to touch, having to do with whether the

Re: [HACKERS] [PATCHES] Proposed patch: synchronized_scanning GUC variable

2008-01-27 Thread Tom Lane
[ redirecting thread to -hackers ] Neil Conway [EMAIL PROTECTED] writes: On Sun, 2008-01-27 at 21:54 +, Gregory Stark wrote: I liked the synchronized_sequential_scans idea myself. I think that's a bit too long. How about synchronized_scans, or synchronized_seqscans? We have

Re: [HACKERS] [PATCHES] Proposed patch: synchronized_scanning GUC variable

2008-01-27 Thread Michael Glaesemann
On Jan 27, 2008, at 21:04 , Tom Lane wrote: [ redirecting thread to -hackers ] Neil Conway [EMAIL PROTECTED] writes: On Sun, 2008-01-27 at 21:54 +, Gregory Stark wrote: I liked the synchronized_sequential_scans idea myself. I think that's a bit too long. How about synchronized_scans,

Re: [HACKERS] [PATCHES] Proposed patch: synchronized_scanning GUC variable

2008-01-27 Thread Tom Lane
Michael Glaesemann [EMAIL PROTECTED] writes: Neil Conway [EMAIL PROTECTED] writes: I think that's a bit too long. How about synchronized_scans, or synchronized_seqscans? Would it make sense to match the plural as well? Actually, the best suggestion I've seen so far is Guillaume's