Re: [HACKERS] ALTER INDEX .. SET STATISTICS ... behaviour

2017-09-06 Thread Simon Riggs
On 6 September 2017 at 10:27, Tom Lane wrote: > Simon Riggs writes: >> Other than that, I'm good to commit. >> Any last minute objections? > > The docs and comments could stand a bit closer copy-editing by a > native English speaker. Other than that,

Re: [HACKERS] ALTER INDEX .. SET STATISTICS ... behaviour

2017-09-06 Thread Tom Lane
Simon Riggs writes: > Other than that, I'm good to commit. > Any last minute objections? The docs and comments could stand a bit closer copy-editing by a native English speaker. Other than that, it seemed sane in a quick read-through. regards, tom

Re: [HACKERS] ALTER INDEX .. SET STATISTICS ... behaviour

2017-09-06 Thread Simon Riggs
On 4 September 2017 at 10:30, Adrien Nayrat wrote: > On 09/04/2017 06:16 PM, Alexander Korotkov wrote: >> Looks good for me. I've integrated those changes in the patch. >> New revision is attached. > > Thanks, I changed status to "ready for commiter". This looks useful

Re: [HACKERS] ALTER INDEX .. SET STATISTICS ... behaviour

2017-09-04 Thread Adrien Nayrat
On 09/04/2017 06:16 PM, Alexander Korotkov wrote: > Looks good for me.  I've integrated those changes in the patch. > New revision is attached. Thanks, I changed status to "ready for commiter". -- Adrien NAYRAT http://dalibo.com - http://dalibo.org signature.asc Description: OpenPGP digital

Re: [HACKERS] ALTER INDEX .. SET STATISTICS ... behaviour

2017-09-04 Thread Alexander Korotkov
Hi, Adrien! On Mon, Sep 4, 2017 at 3:57 PM, Adrien Nayrat wrote: > On 08/30/2017 02:26 PM, Alexander Korotkov wrote: > I reviewed this patch. It works as expected but I have few remarks : > Thank you for reviewing my patch!. > * There is a warning during

Re: [HACKERS] ALTER INDEX .. SET STATISTICS ... behaviour

2017-09-04 Thread Adrien Nayrat
On 08/30/2017 02:26 PM, Alexander Korotkov wrote: > Patch rebased to current master is attached. Hello, I reviewed this patch. It works as expected but I have few remarks : * There is a warning during compilation : gram.y: In function ‘base_yyparse’: gram.y:2090:6: warning: ISO C90 forbids

Re: [HACKERS] ALTER INDEX .. SET STATISTICS ... behaviour

2017-08-30 Thread Alexander Korotkov
On Thu, Jun 1, 2017 at 4:10 PM, Alexander Korotkov < a.korot...@postgrespro.ru> wrote: > On Wed, May 31, 2017 at 7:18 PM, Alexander Korotkov < > a.korot...@postgrespro.ru> wrote: > >> On Wed, May 31, 2017 at 6:53 PM, Tom Lane wrote: >> >>> Alexander Korotkov

Re: [HACKERS] ALTER INDEX .. SET STATISTICS ... behaviour

2017-06-03 Thread Amit Kapila
On Sun, Jun 4, 2017 at 10:11 AM, Tom Lane wrote: > Amit Kapila writes: >> In order to avoid losing track of this patch, I think it is better to >> add it in open items list for 10. > > This is an entirely new feature, not a bug fix, and thus certainly

Re: [HACKERS] ALTER INDEX .. SET STATISTICS ... behaviour

2017-06-03 Thread Tom Lane
Amit Kapila writes: > In order to avoid losing track of this patch, I think it is better to > add it in open items list for 10. This is an entirely new feature, not a bug fix, and thus certainly not an open item for v10. Please stick it in the next commitfest, instead.

Re: [HACKERS] ALTER INDEX .. SET STATISTICS ... behaviour

2017-06-03 Thread Amit Kapila
On Thu, Jun 1, 2017 at 6:40 PM, Alexander Korotkov wrote: > On Wed, May 31, 2017 at 7:18 PM, Alexander Korotkov > wrote: >> >>> >>> Don't like either of those particularly, but what about just targeting >>> a column by column number,

Re: [HACKERS] ALTER INDEX .. SET STATISTICS ... behaviour

2017-06-01 Thread Alexander Korotkov
On Wed, May 31, 2017 at 7:18 PM, Alexander Korotkov < a.korot...@postgrespro.ru> wrote: > On Wed, May 31, 2017 at 6:53 PM, Tom Lane wrote: > >> Alexander Korotkov writes: >> > I've discovered that PostgreSQL is able to run following kind of >>

Re: [HACKERS] ALTER INDEX .. SET STATISTICS ... behaviour

2017-05-31 Thread Alexander Korotkov
On Wed, May 31, 2017 at 6:53 PM, Tom Lane wrote: > Alexander Korotkov writes: > > I've discovered that PostgreSQL is able to run following kind of queries > in > > order to change statistic-gathering target for an indexed expression. > > > ALTER

Re: [HACKERS] ALTER INDEX .. SET STATISTICS ... behaviour

2017-05-31 Thread Tom Lane
Alexander Korotkov writes: > I've discovered that PostgreSQL is able to run following kind of queries in > order to change statistic-gathering target for an indexed expression. > ALTER INDEX index_name ALTER COLUMN expr SET STATISTICS stat_target; > It's been

[HACKERS] ALTER INDEX .. SET STATISTICS ... behaviour

2017-05-31 Thread Alexander Korotkov
Hackers, I've discovered that PostgreSQL is able to run following kind of queries in order to change statistic-gathering target for an indexed expression. ALTER INDEX index_name ALTER COLUMN expr SET STATISTICS stat_target; It's been previously discussed in [1]. I think this should be fixed