Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean,

2007-04-02 Thread Bruce Momjian
Added to TODO: o Allow PL/Python to return boolean rather than 1/0 http://archives.postgresql.org/pgsql-patches/2007-01/msg00596$ --- Guido Goldstein wrote: Peter Eisentraut wrote: Guido Goldstein

Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean,

2007-02-19 Thread Bruce Momjian
I am still waiting for a plpython patch that has Python version checking. --- Guido Goldstein wrote: Peter Eisentraut wrote: Guido Goldstein wrote: Is it possible to tell me which python versions you want to support?

Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean,

2007-01-31 Thread Hannu Krosing
Ühel kenal päeval, T, 2007-01-30 kell 14:52, kirjutas Guido Goldstein: I've checked the patch with postgres 8.1.3 and 8.2.1 with python 2.4 and 2.5 on intel 32 bit and amd 64 bit systems; all systems running linux. *And* it's not a feature patch but a bug-fixing one! Python is a language

Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean,

2007-01-31 Thread Bruce Momjian
Hannu Krosing wrote: Officially by who ? 2.3 was the first version to introduce bool as a subtype of int, in 2.2.3 True and False were introduced as two variables pointing to integers 1 and 0. So to make your patch ok on all python versions, just make it conditional on python version

Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean,

2007-01-31 Thread Alvaro Herrera
Bruce Momjian wrote: Hannu Krosing wrote: Officially by who ? 2.3 was the first version to introduce bool as a subtype of int, in 2.2.3 True and False were introduced as two variables pointing to integers 1 and 0. So to make your patch ok on all python versions, just make it

Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean,

2007-01-31 Thread Tino Wildenhain
Bruce Momjian schrieb: Hannu Krosing wrote: Officially by who ? 2.3 was the first version to introduce bool as a subtype of int, in 2.2.3 True and False were introduced as two variables pointing to integers 1 and 0. So to make your patch ok on all python versions, just make it conditional on

Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean,

2007-01-31 Thread Bruce Momjian
Tino Wildenhain wrote: Bruce Momjian schrieb: Hannu Krosing wrote: Officially by who ? 2.3 was the first version to introduce bool as a subtype of int, in 2.2.3 True and False were introduced as two variables pointing to integers 1 and 0. So to make your patch ok on all python

Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean,

2007-01-31 Thread Tom Lane
Tino Wildenhain [EMAIL PROTECTED] writes: Bruce Momjian schrieb: I thought about suggesting that, but do we want plpython to have different result behavior based on the version of python used? I didn't think so. Why not? Indeed --- the underlying language changed, so I should think that

Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean,

2007-01-30 Thread Guido Goldstein
Hi! Sorry for the late reply. On Thu, 25 Jan 2007 01:52:32 -0500 Tom Lane [EMAIL PROTECTED] wrote: [EMAIL PROTECTED] (Bruce Momjian) writes: Fix for plpython functions; return true/false for boolean, This patch has broken a majority of the buildfarm. Is it possible to tell me which

Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean,

2007-01-30 Thread Peter Eisentraut
Guido Goldstein wrote: Is it possible to tell me which python versions you want to support? The issue isn't so much which versions we want to support. There is certainly some flexibility with that. But when a patch breaks the buildfarm a) unannounced and b) without any apparent feature

Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean,

2007-01-30 Thread Andrew Dunstan
Guido Goldstein wrote: Is it possible to tell me which python versions you want to support? There are still products shipping with 2.3 (e.g. RHEL4). I'd be surprised if we need to go back before that. cheers andrew ---(end of

Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean,

2007-01-30 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: Guido Goldstein wrote: Is it possible to tell me which python versions you want to support? There are still products shipping with 2.3 (e.g. RHEL4). I'd be surprised if we need to go back before that. As far as Red Hat is concerned, we won't be

Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean,

2007-01-30 Thread J. Andrew Rogers
On Jan 30, 2007, at 2:43 AM, Guido Goldstein wrote: Is it possible to tell me which python versions you want to support? Just as a hint: 2.5 is the current stable version. I support a lot of python on several platforms. For broad compatibility with pre-installed Python versions on recent

Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean,

2007-01-30 Thread Guido Goldstein
Peter Eisentraut wrote: Guido Goldstein wrote: Is it possible to tell me which python versions you want to support? The issue isn't so much which versions we want to support. There is certainly some flexibility with that. But when a patch breaks the buildfarm a) unannounced and b) without