On 10 December 2013 12:25, Dmitry Stogov dmi...@zend.com wrote:
What exactly are you fixing with this patch?
fast_add_function() is used only by VM and opcode operands can't alias (it's
guaranteed by compiler).
It's also used by array_sum(), but it also can't create aliases between
results
Le 10/12/2013 14:25, Ard Biesheuvel a écrit :
On 10 December 2013 13:17, Dmitry Stogov dmi...@zend.com wrote:
Sorry, I just read patch improperly. It's fine.
Thanks for perseverance.
No problem.
BTW I guess nobody runs 'make test' on Windows anymore, because the
same issue should have
Sorry, I just read patch improperly. It's fine.
Thanks for perseverance.
Dmitry.
On Tue, Dec 10, 2013 at 4:06 PM, Ard Biesheuvel
ard.biesheu...@linaro.orgwrote:
On 10 December 2013 12:57, Dmitry Stogov dmi...@zend.com wrote:
You missed the second introduced addition:
+
On 10 December 2013 12:57, Dmitry Stogov dmi...@zend.com wrote:
You missed the second introduced addition:
+ Z_LVAL_P(result) = Z_LVAL_P(op1) +
Z_LVAL_P(op2);
So for each $a + $b PHP is going to execute two add instructions instead
of one (plus memory reads
Commit:60d2e70c062e436a6c6cd3c8a17469a083a38b46
Author:Ard Biesheuvel ard.biesheu...@linaro.org Tue, 10 Dec 2013
12:07:46 +0100
Parents: 5a87b7ff39bbf427807c46d1e51e2654259ad394
Branches: PHP-5.6 master
Link:
