RE: [PHP] POLL: To add the final ? or not...

2010-01-27 Thread Daevid Vincent
I think someone has been having fun with the Poll... ;-) It used to be like 10::20 and now it's 71::31... Hmmm -- PHP General Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP] POLL: To add the final ? or not...

2010-01-14 Thread Kim Madsen
Hey Haven't had the time to read up on the maillist, but here's my input. Mattias Thorslund wrote on 09/01/2010 02:26: To my eyes, ? means look there is more content coming, which seems kind of silly when there isn't. To mine it means, no more PHP code for now. I don't wanna make it

Re: [PHP] POLL: To add the final ? or not...

2010-01-14 Thread Kim Madsen
John Corry wrote on 12/01/2010 17:04: I leave ? out. I'm pretty careful about my code formatting and whitespace. It's my opinion that if I can eliminate a potential problem by not including an optional closing tag...there's really no reason why I shouldn't. What is the difference between: ?

Re: [PHP] POLL: To add the final ? or not...

2010-01-14 Thread Ashley Sheridan
On Thu, 2010-01-14 at 23:30 +0100, Kim Madsen wrote: John Corry wrote on 12/01/2010 17:04: I leave ? out. I'm pretty careful about my code formatting and whitespace. It's my opinion that if I can eliminate a potential problem by not including an optional closing tag...there's

Re: [PHP] POLL: To add the final ? or not...

2010-01-14 Thread Kim Madsen
Ashley Sheridan wrote on 14/01/2010 23:30: What is the difference between: ? print hello PHPeople; ?WHITESPACE and ? print hello PHPeople; WHITESPACE Same shit when I look at it, a sloppy developer is what it is :-) -- Kind regards Kim Emax - masterminds.dk Plenty of differences, if you

Re: [PHP] POLL: To add the final ? or not...

2010-01-14 Thread Ashley Sheridan
On Thu, 2010-01-14 at 23:37 +0100, Kim Madsen wrote: Ashley Sheridan wrote on 14/01/2010 23:30: What is the difference between: ? print hello PHPeople; ?WHITESPACE and ? print hello PHPeople; WHITESPACE Same shit when I look at it, a sloppy developer is what it is :-)

Re: [PHP] POLL: To add the final ? or not...

2010-01-14 Thread Kim Madsen
Ashley Sheridan wrote on 14/01/2010 23:36: What has been said on this thread a few times is it is not always a developer error, but a bug with the editor, which is not something that will be picked up until it occurs. Once again I love my VIm :-) (with whitespace highlight if needed) --

Re: [PHP] POLL: To add the final ? or not...

2010-01-14 Thread Ashley Sheridan
On Fri, 2010-01-15 at 00:04 +0100, Kim Madsen wrote: Ashley Sheridan wrote on 14/01/2010 23:36: What has been said on this thread a few times is it is not always a developer error, but a bug with the editor, which is not something that will be picked up until it occurs. Once again I

Re: [PHP] POLL: To add the final ? or not...

2010-01-14 Thread Bipper Goes!
Wait, Kim, whats your last name? On Thu, Jan 14, 2010 at 5:04 PM, Kim Madsen php@emax.dk wrote: Ashley Sheridan wrote on 14/01/2010 23:36: What has been said on this thread a few times is it is not always a developer error, but a bug with the editor, which is not something that will

Re: [PHP] POLL: To add the final ? or not...

2010-01-14 Thread Mattias Thorslund
Kim Madsen wrote: Mattias Thorslund wrote on 09/01/2010 02:26: A neat thing with pairing every ?php with a ? when mixed in HTML is that these are valid XML processing instructions. If your HTML satisfies XML well-formedness, your PHP document will also be valid XML. Not that I've ever had any

Re: [PHP] POLL: To add the final ? or not...

2010-01-14 Thread Jochem Maas
Op 1/14/10 11:37 PM, Kim Madsen schreef: Ashley Sheridan wrote on 14/01/2010 23:30: What is the difference between: ? print hello PHPeople; ?WHITESPACE and ? print hello PHPeople; WHITESPACE Same shit when I look at it, a sloppy developer is what it is :-) -- Kind regards Kim

Re: [PHP] POLL: To add the final ? or not...

2010-01-13 Thread Bipper Goes!
You could also sit on the egg. On Tue, Jan 12, 2010 at 3:41 PM, tedd tedd.sperl...@gmail.com wrote: At 3:49 PM -0500 1/12/10, Robert Cummings wrote: tedd wrote: At 5:24 PM + 1/12/10, Ashley Sheridan wrote: On Tue, 2010-01-12 at 12:22 -0500, Robert Cummings wrote: -- egg snip-its

Re: [PHP] POLL: To add the final ? or not...

2010-01-12 Thread John Corry
I leave ? out. I'm pretty careful about my code formatting and whitespace. It's my opinion that if I can eliminate a potential problem by not including an optional closing tag...there's really no reason why I shouldn't. -- John Corry PHP developer - 3by400, Inc http://www.3by400.com

Re: [PHP] POLL: To add the final ? or not...

2010-01-12 Thread LinuxManMikeC
On Fri, Jan 8, 2010 at 1:24 PM, Daevid Vincent dae...@daevid.com wrote: I'm having a debate with a co-worker about adding the final ? on a PHP page... So everybody, when do we get to the real discussion? Which end of an egg do we break? -- PHP General Mailing List (http://www.php.net/) To

Re: [PHP] POLL: To add the final ? or not...

2010-01-12 Thread Michael A. Peters
LinuxManMikeC wrote: On Fri, Jan 8, 2010 at 1:24 PM, Daevid Vincent dae...@daevid.com wrote: I'm having a debate with a co-worker about adding the final ? on a PHP page... So everybody, when do we get to the real discussion? Which end of an egg do we break? Depends upon how far away the

Re: [PHP] POLL: To add the final ? or not...

2010-01-12 Thread Robert Cummings
Michael A. Peters wrote: LinuxManMikeC wrote: On Fri, Jan 8, 2010 at 1:24 PM, Daevid Vincent dae...@daevid.com wrote: I'm having a debate with a co-worker about adding the final ? on a PHP page... So everybody, when do we get to the real discussion? Which end of an egg do we break?

Re: [PHP] POLL: To add the final ? or not...

2010-01-12 Thread Ashley Sheridan
On Tue, 2010-01-12 at 12:22 -0500, Robert Cummings wrote: Michael A. Peters wrote: LinuxManMikeC wrote: On Fri, Jan 8, 2010 at 1:24 PM, Daevid Vincent dae...@daevid.com wrote: I'm having a debate with a co-worker about adding the final ? on a PHP page... So everybody, when do we get

Re: [PHP] POLL: To add the final ? or not...

2010-01-12 Thread tedd
At 5:24 PM + 1/12/10, Ashley Sheridan wrote: On Tue, 2010-01-12 at 12:22 -0500, Robert Cummings wrote: -- egg snip-its While on the subject of eggs and other non-php topics, here's a life trick. If you don't know if an egg is hard-boiled, or not, try spinning it. A hard-boiled egg will

Re: [PHP] POLL: To add the final ? or not...

2010-01-12 Thread Ashley Sheridan
On Tue, 2010-01-12 at 12:52 -0500, tedd wrote: At 5:24 PM + 1/12/10, Ashley Sheridan wrote: On Tue, 2010-01-12 at 12:22 -0500, Robert Cummings wrote: -- egg snip-its While on the subject of eggs and other non-php topics, here's a life trick. If you don't know if an egg is

Re: [PHP] POLL: To add the final ? or not...

2010-01-12 Thread Paul M Foster
On Tue, Jan 12, 2010 at 05:24:06PM +, Ashley Sheridan wrote: On Tue, 2010-01-12 at 12:22 -0500, Robert Cummings wrote: Michael A. Peters wrote: LinuxManMikeC wrote: On Fri, Jan 8, 2010 at 1:24 PM, Daevid Vincent dae...@daevid.com wrote: I'm having a debate with a co-worker

Re: [PHP] POLL: To add the final ? or not...

2010-01-12 Thread Ashley Sheridan
On Tue, 2010-01-12 at 13:10 -0500, Paul M Foster wrote: On Tue, Jan 12, 2010 at 05:24:06PM +, Ashley Sheridan wrote: On Tue, 2010-01-12 at 12:22 -0500, Robert Cummings wrote: Michael A. Peters wrote: LinuxManMikeC wrote: On Fri, Jan 8, 2010 at 1:24 PM, Daevid Vincent

Re: [PHP] POLL: To add the final ? or not...

2010-01-12 Thread Paul M Foster
On Tue, Jan 12, 2010 at 06:08:59PM +, Ashley Sheridan wrote: On Tue, 2010-01-12 at 13:10 -0500, Paul M Foster wrote: On Tue, Jan 12, 2010 at 05:24:06PM +, Ashley Sheridan wrote: snip There's always a chance that if thrown, the egg won't contact end-on.

Re: [PHP] POLL: To add the final ? or not...

2010-01-12 Thread Rolf Brejner
- Original Message - From: Paul M Foster pa...@quillandmouse.com To: Ashley Sheridan a...@ashleysheridan.co.uk Cc: php-general@lists.php.net Sent: Tuesday, January 12, 2010 7:25 PM Subject: Re: [PHP] POLL: To add the final ? or not... On Tue, Jan 12, 2010 at 06:08:59PM +, Ashley

Re: [PHP] POLL: To add the final ? or not...

2010-01-12 Thread Robert Cummings
tedd wrote: At 5:24 PM + 1/12/10, Ashley Sheridan wrote: On Tue, 2010-01-12 at 12:22 -0500, Robert Cummings wrote: -- egg snip-its While on the subject of eggs and other non-php topics, here's a life trick. If you don't know if an egg is hard-boiled, or not, try spinning it. A

Re: [PHP] POLL: To add the final ? or not...

2010-01-12 Thread tedd
At 3:49 PM -0500 1/12/10, Robert Cummings wrote: tedd wrote: At 5:24 PM + 1/12/10, Ashley Sheridan wrote: On Tue, 2010-01-12 at 12:22 -0500, Robert Cummings wrote: -- egg snip-its While on the subject of eggs and other non-php topics, here's a life trick. If you don't know if an egg is

Re: [PHP] POLL: To add the final ? or not...

2010-01-11 Thread Olav
Paul M Foster wrote: I leave it off. I don't want to have to worry about which editor I'm using or whether I accidentally left some whitespace where it shouldn't be. I also use different editors in different situations, both terminal based and GUI. For instance I find Midnight Commander's

Re: [PHP] POLL: To add the final ? or not...

2010-01-11 Thread Bipper Goes!
Ever write a string replace function on a closing ? //somecomment here like end junk I have written some systems and gone back two to three years later and found myself having to do such. Sloppy, sure. Minimize cost to the client? Oh yeah. I keep em, and comment 'em as I feel I should. On

Re: [PHP] POLL: To add the final ? or not...

2010-01-10 Thread Michael A. Peters
Daevid Vincent wrote: What do you guys all do? I keep it there, and just make sure not to have white space where it should not be. -- PHP General Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP] POLL: To add the final ? or not...

2010-01-10 Thread Michael A. Peters
Stuart Dallas wrote: That's a massive assumption. There are a number of editors that automatically add a blank line to the end of source files. I stand by taking the option that requires the least conscious thought from your developers - they have enough important stuff to occupy their brain

Re: [PHP] POLL: To add the final ? or not...

2010-01-10 Thread Stuart Dallas
On 10 Jan 2010, at 14:44, Michael A. Peters wrote: Stuart Dallas wrote: That's a massive assumption. There are a number of editors that automatically add a blank line to the end of source files. I stand by taking the option that requires the least conscious thought from your developers -

Re: [PHP] POLL: To add the final ? or not...

2010-01-10 Thread Michael A. Peters
Stuart Dallas wrote: On 10 Jan 2010, at 14:44, Michael A. Peters wrote: Stuart Dallas wrote: That's a massive assumption. There are a number of editors that automatically add a blank line to the end of source files. I stand by taking the option that requires the least conscious thought from

Re: [PHP] POLL: To add the final ? or not...

2010-01-10 Thread Jim Lucas
Stuart Dallas wrote: That's a massive assumption. There are a number of editors that automatically add a blank line to the end of source files. A single \n after the final ? doesn't matter anyways. Even if the following example was two different files where the second included the first,

Re: [PHP] POLL: To add the final ? or not...

2010-01-10 Thread Ashley Sheridan
On Sun, 2010-01-10 at 08:52 -0800, Jim Lucas wrote: Stuart Dallas wrote: That's a massive assumption. There are a number of editors that automatically add a blank line to the end of source files. A single \n after the final ? doesn't matter anyways. Even if the following example

Re: [PHP] POLL: To add the final ? or not...

2010-01-10 Thread Paul M Foster
On Sun, Jan 10, 2010 at 06:41:19AM -0800, Michael A. Peters wrote: Daevid Vincent wrote: What do you guys all do? I leave it off. I don't want to have to worry about which editor I'm using or whether I accidentally left some whitespace where it shouldn't be. Paul -- Paul M. Foster --

[PHP] POLL: To add the final ? or not...

2010-01-08 Thread Daevid Vincent
I'm having a debate with a co-worker about adding the final ? on a PHP page... To be honest, I am the lead, and I could pull rank and be done with the discussion, however I don't like to be that way. I would rather do the right thing. If my way of thinking is old-school (I've been coding since

Re: [PHP] POLL: To add the final ? or not...

2010-01-08 Thread Ashley Sheridan
On Fri, 2010-01-08 at 12:24 -0800, Daevid Vincent wrote: I'm having a debate with a co-worker about adding the final ? on a PHP page... To be honest, I am the lead, and I could pull rank and be done with the discussion, however I don't like to be that way. I would rather do the right

Re: [PHP] POLL: To add the final ? or not...

2010-01-08 Thread LinuxManMikeC
http://framework.zend.com/manual/en/coding-standard.html#coding-standard.overview.scope This document provides guidelines for code formatting and documentation to individuals and teams contributing to Zend Framework. So as far as anything other than code being contributed to Zend Framework, its

Re: [PHP] POLL: To add the final ? or not...

2010-01-08 Thread Ryan Sun
if you use the newest PDT, you will find that a new php file has no final ? I vote for your co-worker [?] On Fri, Jan 8, 2010 at 3:49 PM, LinuxManMikeC linuxmanmi...@gmail.comwrote: http://framework.zend.com/manual/en/coding-standard.html#coding-standard.overview.scope This document provides

Re: [PHP] POLL: To add the final ? or not...

2010-01-08 Thread Stuart Dallas
On 8 Jan 2010, at 20:49, LinuxManMikeC wrote: http://framework.zend.com/manual/en/coding-standard.html#coding-standard.overview.scope This document provides guidelines for code formatting and documentation to individuals and teams contributing to Zend Framework. So as far as anything other

Re: [PHP] POLL: To add the final ? or not...

2010-01-08 Thread Ashley Sheridan
On Fri, 2010-01-08 at 21:30 +, Stuart Dallas wrote: On 8 Jan 2010, at 20:49, LinuxManMikeC wrote: http://framework.zend.com/manual/en/coding-standard.html#coding-standard.overview.scope This document provides guidelines for code formatting and documentation to individuals and teams

Re: [PHP] POLL: To add the final ? or not...

2010-01-08 Thread Stuart Dallas
On 8 Jan 2010, at 21:38, Ashley Sheridan wrote: On Fri, 2010-01-08 at 21:30 +, Stuart Dallas wrote: On 8 Jan 2010, at 20:49, LinuxManMikeC wrote: http://framework.zend.com/manual/en/coding-standard.html#coding-standard.overview.scope This document provides guidelines for code

Re: [PHP] POLL: To add the final ? or not...

2010-01-08 Thread tedd
At 12:24 PM -0800 1/8/10, Daevid Vincent wrote: What do you guys all do? I always close my code. I have never had a problem in doing so. I shall continue to close my code until it trips me up. At such time, I'll figure out what the problem is and fix it. Then I'll probably still close my

Re: [PHP] POLL: To add the final ? or not...

2010-01-08 Thread Mattias Thorslund
Hadn't paid much attention to the issue until reading a previous discussion on the topic, here on this list. After that, I decided to be consistent and leave the closing ? out in all include files. To my eyes, ? means look there is more content coming, which seems kind of silly when there

Re: [PHP] POLL: To add the final ? or not...

2010-01-08 Thread German Geek
I would leave this to personal preference, whether there is a closing ? or not wouldn't bother me. I could argue both ways: Pro: You should put a final ? for neatness and XML compatibility. Con: It makes the script fractionally slower because 2 more characters have to be processed and there might

Re: [PHP] POLL: To add the final ? or not...

2010-01-08 Thread Robert Cummings
Mattias Thorslund wrote: Hadn't paid much attention to the issue until reading a previous discussion on the topic, here on this list. After that, I decided to be consistent and leave the closing ? out in all include files. To my eyes, ? means look there is more content coming, which seems

Re: [PHP] POLL: To add the final ? or not...

2010-01-08 Thread Per Jessen
tedd wrote: At 12:24 PM -0800 1/8/10, Daevid Vincent wrote: What do you guys all do? I always close my code. I have never had a problem in doing so. I shall continue to close my code until it trips me up. At such time, I'll figure out what the problem is and fix it. Then I'll probably