Re: [Piglit] [PATCH] depth_texture_mode_and_swizzle: request alpha channel

Jose Fonseca jfons...@vmware.com writes: Reviewed-by: Jose Fonseca jfons...@vmware.com I assume that PIGLIT_GL_VISUAL_RGBA came from GLUT_RGBA, but given that it is a misleading alias for PIGLIT_GL_VISUAL_RGB and there is no need to be bug compatible with glut, I believe that in a follow on

Re: [Piglit] [PATCH] depth_texture_mode_and_swizzle: request alpha channel

- Original Message - Jose Fonseca jfons...@vmware.com writes: Reviewed-by: Jose Fonseca jfons...@vmware.com I assume that PIGLIT_GL_VISUAL_RGBA came from GLUT_RGBA, but given that it is a misleading alias for PIGLIT_GL_VISUAL_RGB and there is no need to be bug compatible

Re: [Piglit] [PATCH] ext_framebuffer_multisample: check for GL_EXT_framebuffer_multisample

Reviewed-by: Jose Fonseca jfons...@vmware.com - Original Message - Part of the fix for http://bugs.freedesktop.org/show_bug.cgi?id=59873 --- .../ext_framebuffer_multisample/interpolation.cpp |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git

Re: [Piglit] [PATCH] glx-swap-pixmap: Expect alpha = 1.0 if there is no alpha in the pixmap

On 01/28/2013 05:39 PM, Ian Romanick wrote: From: Ian Romanickian.d.roman...@intel.com Signed-off-by: Ian Romanickian.d.roman...@intel.com Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=59833 --- tests/glx/glx-swap-pixmap.c | 16 ++-- 1 file changed, 14 insertions(+), 2

Re: [Piglit] [PATCH] glsl-uniform-out-of-bounds-2: work with or without [0] after array names

On 01/28/2013 05:18 PM, Frank Henigman wrote: Ignore this. Ian sent a better patch at the same time. Should I count that as a Reviewed-by for my patch? :) On Mon, Jan 28, 2013 at 4:18 PM, Frank Henigman fjhenig...@google.com mailto:fjhenig...@google.com wrote: Make

Re: [Piglit] [PATCH] Test varying structs in GLSL ES 3.00.

On 01/21/2013 03:01 PM, Paul Berry wrote: diff --git a/tests/spec/glsl-es-3.00/execution/varying-struct-arrays.shader_test b/tests/spec/glsl-es-3.00/execution/varying-struct-arrays.shader_test Seems like a good mean test...I'd hate to debug it, but worth having. I didn't review the

Re: [Piglit] Fwd: [PATCH 1/1] RFC: add ability to report gl api supported by tests

Tom Gall tom.g...@linaro.org writes: No feedback? I think what's missing is the explanation of why do we want the tests to be able to print what apis they support? pgp0uTJqXMx6p.pgp Description: PGP signature ___ Piglit mailing list

Re: [Piglit] [PATCH V3] KHR image from texture test

Abdiel Janulgue abdiel.janul...@linux.intel.com writes: +#define TEXTURE_SIZE 64 + +PIGLIT_GL_TEST_CONFIG_BEGIN + + config.supports_gl_es_version = 20; + + config.window_width = 448; + config.window_height = 448; + config.window_visual = PIGLIT_GL_VISUAL_RGB |

[Piglit] etc1: Fix basic API test

Fixes https://bugs.freedesktop.org/show_bug.cgi?id=55147 ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH 1/3] etc1: Fix glTexImage2D call in basic API test

On mesa-1559994 with Intel Sandybridge, this test failed due to two unexpected GL errors. This patch fixes the first. The test wanted glTexImage2D(format=GL_RGB, internalformat=GL_ETC1_RGB8_OES) to emit GL_INVALID_VALUE. However, implementations are allowed to emit GL_INVALID_VALUE or

[Piglit] [PATCH 2/3] etc1: Fix glTexSubImage2D call in basic API test

On mesa-1559994 with Intel Sandybridge, this test failed due to an unexpected GL error. The test wanted glTexSubImage2D(width=8, height=8, size=4096) to emit GL_INVALID_OPERATION. However, Mesa emitted GL_INVALID_VALUE because the size was incorrect. From page 79 of the OpenGL ES 1.1 spec:

[Piglit] [PATCH 3/3] etc1: Document expected errors in basic API test

Document why we expect GL_INVALID_OPERATION from gl*TexSubImage2D calls. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- .../oes_compressed_etc1_rgb8_texture-basic.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

[Piglit] [PATCH] Test bad interaction with optimizer and array accesses to vector elements

From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com Cc: Chris Wolfe cwo...@chromium.org Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=53256 --- .../shaders/glsl-vs-channel-overwrite.shader_test | 42 ++ 1 file changed, 42

[Piglit] [PATCH] arb_framebuffer_srgb/blit: check requested samples against GL_MAX_SAMPLES

We can't run some of tests if we don't support multisampling. Just skip those tests. Fixes http://bugs.freedesktop.org/show_bug.cgi?id=60044 --- tests/spec/arb_framebuffer_srgb/blit.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git

Re: [Piglit] [PATCH] glean/tdepthstencil: Print what error was expected

Matt Turner matts...@gmail.com writes: Thy all seem to already print what error was expected, though not what was generated. glDrawPixels(1, 1, GL_DEPTH_COMPONENT, GL_UNSIGNED_INT_24_8_EXT, p); - if (glGetError() != GL_INVALID_OPERATION) { - sprintf(errorMsg, -

[Piglit] [PATCH v2] Test bad interaction with optimizer and array accesses to vector elements

From: Ian Romanick ian.d.roman...@intel.com v2: Add several other, similar test cases that tickle other related bugs in the same optimization passes. Signed-off-by: Ian Romanick ian.d.roman...@intel.com Cc: Chris Wolfe cwo...@chromium.org Bugzilla:

Re: [Piglit] [PATCH] glean/tdepthstencil: Print what error was expected

On Tue, Jan 29, 2013 at 6:41 PM, Eric Anholt e...@anholt.net wrote: Matt Turner matts...@gmail.com writes: Thy all seem to already print what error was expected, though not what was generated. glDrawPixels(1, 1, GL_DEPTH_COMPONENT, GL_UNSIGNED_INT_24_8_EXT, p); - if (glGetError()