Bug#845606: The Bytecode Should Not Be Targeting Java 1.2

2017-01-18 Thread Miguel Landaeta
On Wed, Jan 18, 2017 at 11:43:04AM +0100, Emmanuel Bourg wrote: > > I got another look and I think the root issue is the change I made in > asm/5.1-1 when I replaced asm-all.jar by a symlink to asm-debug-all.jar. > I assumed that asm-all was simply a version of the jar stripped from its > debug

Bug#845606: The Bytecode Should Not Be Targeting Java 1.2

2017-01-18 Thread Emmanuel Bourg
Le 15/01/2017 à 16:26, Miguel Landaeta a écrit : > It's probably too late to object this change since it's about to enter > testing but I suspect this change could trigger FTBFS in libasm-java > reverse dependencies. We still have two weeks before the final freeze to examine this actually. I

Bug#845606: The Bytecode Should Not Be Targeting Java 1.2

2017-01-18 Thread Emmanuel Bourg
On Mon, 5 Dec 2016 05:44:46 -0800 tony mancill wrote: > I do note that the JAR files produced by > the "unshrunk" package are much larger (~4x) than what is being > distributed by Maven Central. > > I'll have a look - there could be another cause. I noticed that too, the

Bug#845606: The Bytecode Should Not Be Targeting Java 1.2

2017-01-15 Thread Miguel Landaeta
On Sun, Dec 04, 2016 at 09:07:12PM -0800, tony mancill wrote: > On Sun, Dec 04, 2016 at 07:47:31PM +0800, 殷啟聰 wrote: > > FYI, I forwarded the bug to ASM's upstream issue tracker [1]. > > > > I propose the follwing patch to fix the bug: > > > > override_dh_auto_build: > > - dh_auto_build

Bug#845606: The Bytecode Should Not Be Targeting Java 1.2

2016-12-05 Thread 殷啟聰
In version 1.3~b8 that I have been packaging, Jack uses ASM 5.0.4 [1]. The upstream Jack is not affected by this particular problem because the source of Jack includes the source of all external dependencies which are compiled using Ant and javac and are included into `jack.jar` when Jack is

Bug#845606: The Bytecode Should Not Be Targeting Java 1.2

2016-12-05 Thread 殷啟聰
I tried building Jack using the asm-all.jar from jcenter and it failed with the same error. And when I checked the classes in this JAR it gave me "Java 1.2" as well. So looks like the same problem applies to the upstream as well. __ This is the maintainer address of Debian's Java team

Bug#845606: The Bytecode Should Not Be Targeting Java 1.2

2016-12-05 Thread Emmanuel Bourg
Le 5/12/2016 à 16:53, 殷啟聰 a écrit : > I tried building Jack using the asm-all.jar from jcenter and it failed > with the same error. And when I checked the classes in this JAR it > gave me "Java 1.2" as well. > > So looks like the same problem applies to the upstream as well. Good, at least our

Bug#845606: The Bytecode Should Not Be Targeting Java 1.2

2016-12-05 Thread tony mancill
On Mon, Dec 05, 2016 at 10:09:07AM +0100, Emmanuel Bourg wrote: > Le 5/12/2016 à 06:07, tony mancill a écrit : > > > Looks good to me. I have applied the patch and will upload this week if > > there are no objections. > > There is just one thing unclear to me, does Java Android Compiler Kit >

Bug#845606: The Bytecode Should Not Be Targeting Java 1.2

2016-12-05 Thread Emmanuel Bourg
Le 5/12/2016 à 06:07, tony mancill a écrit : > Looks good to me. I have applied the patch and will upload this week if > there are no objections. There is just one thing unclear to me, does Java Android Compiler Kit build fine with the ASM jar from Maven Central? Because if we use the same

Bug#845606: The Bytecode Should Not Be Targeting Java 1.2

2016-12-04 Thread tony mancill
On Sun, Dec 04, 2016 at 07:47:31PM +0800, 殷啟聰 wrote: > FYI, I forwarded the bug to ASM's upstream issue tracker [1]. > > I propose the follwing patch to fix the bug: > > override_dh_auto_build: > - dh_auto_build -- jar jdoc examples > + dh_auto_build -- -Dproduct.noshrink=true jar

Bug#845606: The Bytecode Should Not Be Targeting Java 1.2

2016-12-04 Thread 殷啟聰
FYI, I forwarded the bug to ASM's upstream issue tracker [1]. I propose the follwing patch to fix the bug: ``` diff --git a/debian/rules b/debian/rules index 734f78c..ed59b80 100755 --- a/debian/rules +++ b/debian/rules @@ -6,7 +6,7 @@ VERSION ?= $(shell dpkg-parsechangelog | sed -rne

Bug#845606: The Bytecode Should Not Be Targeting Java 1.2

2016-11-24 Thread 殷啟聰
Package: libasm-java Version: 5.1-1 Severity: important The current package of libasm-java contains classes that targets the ancient Java 1.2 where generics is not supported. When I was building a package for Jack (Java Android Compiler Kit) which uses the generics code in ASM, it yielded the