Your message dated Sun, 13 Aug 2017 15:19:03 +0000
with message-id <e1dgufp-00006v...@fasolo.debian.org>
and subject line Bug#871924: fixed in libjlha-java 0.0.20050504-10
has caused the Debian Bug report #871924,
regarding jlha does not support Amiga LhA files
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
871924: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=871924
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: libjlha-java
Version: 0.0.20050504-9

Amiga LhA is a variant of MS-DOS LHA which tweaks the file format to store filenotes. jlha does not support them. I've attached a patch to add support.

AmigaDOS allows files to have a "filenote", free-form ISO-8859-1 text up to 80 characters. Amiga LhA archives this by appending it to the stored file path, separated from the path by a null byte.

For example, if you download the archive at https://www.exotica.org.uk/wiki/The_Wall you'll find two files in the archive, the first archive file has path "The_Wall\\mod.days of fury\0Martin de Agger | The Wall | 1990 | Kefrens" (note the null byte). The intended filename is "The Wall/mod.days of fury"

00000000: 5b562d6c 68352d0b 0101005e a5010073  [V-lh5-....^...s
00000010: 52792d00 00455468 655f5761 6c6c5c6d  Ry-..EThe_Wall\m
00000020: 6f642e64 61797320 6f662066 75727900  od.days of fury.
00000030: 4d617274 696e2064 65204167 67657220  Martin de Agger
00000040: 7c205468 65205761 6c6c207c 20313939  | The Wall | 199
00000050: 30207c20 4b656672 656e7350 7c25e885  0 | KefrensP|%..

jlha doesn't know about this trick, so it doesn't support it:

$ jlha v The_Wall.lha
PERMSSN UID GID PACKED SIZE RATIO METHOD CRC STAMP NAME ---------- ----------- ------- ------- ------ ---------- ------------ ------------- [generic] 65803 107870 61.0% -lh5- 7c50 Nov 25 2002 The_Wall/mod.days of furyMartin de Agger | The Wall | 1990 | Kefrens [generic] 66429 95176 69.7% -lh5- 5101 Nov 25 2002 The_Wall/mod.thunder-wallMartin de Agger | The Wall | 1990 | Kefrens ---------- ----------- ------- ------- ------ ---------- ------------ -------------
 Total         2 files  132232  203046  65.1%            Aug 12 13:14

$ jlha x The_Wall.lha
The_Wall/mod.days of furyMartin de Agger | The Wall | 1990 | Kefrens - Melted : Aug 12, 2017 3:50:34 PM org.jlhafrontend.JLHAFrontEnd extract SEVERE: open OutputStream error java.io.FileNotFoundException: Invalid file path
Aug 12, 2017 3:50:34 PM org.jlhafrontend.JLHAFrontEnd extract
SEVERE: open OutputStream error java.io.FileNotFoundException: Invalid file path The_Wall/mod.thunder-wallMartin de Agger | The Wall | 1990 | Kefrens - Melted : Aug 12, 2017 3:50:34 PM org.jlhafrontend.JLHAFrontEnd extract SEVERE: open OutputStream error java.io.FileNotFoundException: Invalid file path
Aug 12, 2017 3:50:34 PM org.jlhafrontend.JLHAFrontEnd extract
SEVERE: open OutputStream error java.io.FileNotFoundException: Invalid file path

I've attached a patch to fix this. Once applied, jlha handles the archives correctly.

$ lha v The_Wall.lha
PERMSSN UID GID PACKED SIZE RATIO METHOD CRC STAMP NAME ---------- ----------- ------- ------- ------ ---------- ------------ ------------- [generic] 65803 107870 61.0% -lh5- 7c50 Nov 25 2002 The_Wall/mod.days of fury [generic] 66429 95176 69.7% -lh5- 5101 Nov 25 2002 The_Wall/mod.thunder-wall ---------- ----------- ------- ------- ------ ---------- ------------ -------------
 Total         2 files  132232  203046  65.1%            Aug 12 13:14

$ lha x The_Wall.lha
The_Wall/mod.days of fury    - Melted   :  oooooooooooooo
The_Wall/mod.thunder-wall    - Melted   :  oooooooooooo

From 24eac22c434aedfbe953db4aba001b5ec4e59445 Mon Sep 17 00:00:00 2001
From: Stuart Caie <ky...@kyzer.me.uk>
Date: Sat, 12 Aug 2017 15:25:09 +0100
Subject: [PATCH] Support Amiga LhA files

---
 debian/patches/04_AmigaLhA.patch | 10 ++++++++++
 debian/patches/series            |  1 +
 2 files changed, 11 insertions(+)
 create mode 100644 debian/patches/04_AmigaLhA.patch

diff --git a/debian/patches/04_AmigaLhA.patch b/debian/patches/04_AmigaLhA.patch
new file mode 100644
index 0000000..4162001
--- /dev/null
+++ b/debian/patches/04_AmigaLhA.patch
@@ -0,0 +1,10 @@
+--- jp/gr/java_conf/dangan/util/lha/LhaHeader.java	2005-05-03 08:50:30.000000000 +0100
++++ jp/gr/java_conf/dangan/util/lha/LhaHeader.java	2017-08-12 15:14:05.465109915 +0100
+@@ -919,6 +919,7 @@
+         this.HeaderLevel    = HeaderData[ HeaderLevelIndex ] & 0xFF;
+         this.Path           = new String( HeaderData, PathIndex, PathLength, encode );    //After Java 1.1 throw IndexOutOfBoundsException
+         this.Path           = this.Path.replace( '\\', File.separatorChar );
++        this.Path           = this.Path.split("\0")[0]; // Amiga LhA adds filenote to path after a null byte
+ 
+         if( CRCIndex + 2 <= HeaderSize ){
+             this.CRC = LittleEndian.readShort( HeaderData, CRCIndex );          //throw ArrayIndexOutOfBoundsException
diff --git a/debian/patches/series b/debian/patches/series
index 6503cc2..0eb42a5 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,3 +1,4 @@
 01_AntBuildfiles.patch
 02_AccessingClassField.patch
 03_DateDeprecation.patch
+04_AmigaLhA.patch
-- 
2.7.4


--- End Message ---
--- Begin Message ---
Source: libjlha-java
Source-Version: 0.0.20050504-10

We believe that the bug you reported is fixed in the latest version of
libjlha-java, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 871...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
tony mancill <tmanc...@debian.org> (supplier of updated libjlha-java package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 13 Aug 2017 07:43:50 -0700
Source: libjlha-java
Binary: libjlha-java libjlha-java-doc-ja
Architecture: source all
Version: 0.0.20050504-10
Distribution: unstable
Urgency: medium
Maintainer: Debian Java Maintainers 
<pkg-java-maintainers@lists.alioth.debian.org>
Changed-By: tony mancill <tmanc...@debian.org>
Description:
 libjlha-java - LHA compress/decompress library for Java
 libjlha-java-doc-ja - Japanese documentation for libjlha-java, the LHA library 
for Java
Closes: 871924
Changes:
 libjlha-java (0.0.20050504-10) unstable; urgency=medium
 .
   [ tony mancill ]
   * Team upload.
   * Add AmigaLhA patch.  (Closes: #871924)
     Thank you to Stuart Caie for the patch.
   * Use debhelper and compat level 10
   * Add myself to Uploaders
   * Bump Standards-Version to 4.0.1
   * Update Homepage in debian/control
Checksums-Sha1:
 178e9d687f2acb565ba4c0444b66accc4f28d870 2217 libjlha-java_0.0.20050504-10.dsc
 e9f6191432fe6ddecfcc44cecd0bd2a15b3dde74 7592 
libjlha-java_0.0.20050504-10.debian.tar.xz
 402b7d4537f1294873451b02bb3283d40be74be2 90880 
libjlha-java-doc-ja_0.0.20050504-10_all.deb
 fd38116f0667536cbfeeef5623903d89681a8a35 99138 
libjlha-java_0.0.20050504-10_all.deb
 8706f0c1b1fb5d2e88f8c670a3ae608e5c5ef2d2 10314 
libjlha-java_0.0.20050504-10_amd64.buildinfo
Checksums-Sha256:
 e31550ba56347a957267370cfbd1aaa570c4d2c2527d89d217a1595ddd8f0b28 2217 
libjlha-java_0.0.20050504-10.dsc
 4b4fa1f64847fa13842b908ef7e9364ee5adaa62d4b330f1f4cef2984324e1ef 7592 
libjlha-java_0.0.20050504-10.debian.tar.xz
 df912832ad850c99e12ed2e5fc357e70f170608a2fb08d744c0d7524f2179085 90880 
libjlha-java-doc-ja_0.0.20050504-10_all.deb
 546efb626f8844c12ead217af4c70c8e8de03ecd2a925b47c47501577616d0ae 99138 
libjlha-java_0.0.20050504-10_all.deb
 bdfa5a69720cfe874bd56aea65a8e9dff4ce5a3d9b277fb0ff33c521c5554b59 10314 
libjlha-java_0.0.20050504-10_amd64.buildinfo
Files:
 76a223bcad6f2b926446164271dc0f5a 2217 java optional 
libjlha-java_0.0.20050504-10.dsc
 ee9942b60b57af820e2441e2478f11c1 7592 java optional 
libjlha-java_0.0.20050504-10.debian.tar.xz
 b864829993aed663e29130b0a5443159 90880 doc optional 
libjlha-java-doc-ja_0.0.20050504-10_all.deb
 358ca7b98e2536a6c1b13b24230a1a8c 99138 java optional 
libjlha-java_0.0.20050504-10_all.deb
 6a0f5b4ace0fe6f7180aa54cbb2c6df9 10314 java optional 
libjlha-java_0.0.20050504-10_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJIBAEBCgAyFiEE5Qr9Va3SequXFjqLIdIFiZdLPpYFAlmQZ6cUHHRtYW5jaWxs
QGRlYmlhbi5vcmcACgkQIdIFiZdLPpb5BxAArHLnjuY4cON2H1U5Fdoeyvb5FWwZ
zBJDpaeHgufmpD3tr/I4VfTdjV5c4AADmq+AiGXWctzoUURH+NEmI3TIKySPvy6d
S1MkxZ7lgtjOPUNx+Y6e/kjKwmEQ7c4rThgtCobGjplKPG4wqxNa86tBvnKUHiEC
PUqy60hLtNFNsp3yhJJEmr6/ZmPiPY4CcA7PI5JPJPaG5kdRJuGKAWc4nTQJpEvY
2DW60rHqKpEWD3Sywqu/wdGccUgzQdv130xQoriXuvVd9XJcsy5fZsEaZQ3egGc/
0es4iuK9qtHbje444uAOdwOt6ds9PP2iHrfD9C8Eueq4T3Z2ydwRgIS/mh8oM/LR
9D/mGl513pirG5muZjdbkaflOgDqqwXP6UgI1ZvMUfsr+UrOLg+4y7NAXqyW5pRr
UT5B4WkuGbqb5VLzaOxGy9D5QQJFaW2Tqun5APYz6wCym6ffj/XAxJySSbJKSLRj
/esuL5smsZNxCs+al87CFIG1Dchdh+yIXR011qvZS3zE+2IxXUDOr5kRE/W30QQ8
RbDMzpoZ00KatuMOqBCdHLYCK6XVAbmJPCxhGLv0oPyqwYfYaokWRUS0B8pUwf36
tU/5pRz9HWUZkYuLQlZe9yiD3iMGaei3jAYlniKylGRoqyerXQLv0e1jLmY8u1y7
OkeR4AFoSXCbY+I=
=qCZO
-----END PGP SIGNATURE-----

--- End Message ---
__
This is the maintainer address of Debian's Java team
<http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-java-maintainers>. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Reply via email to