Your message dated Sat, 04 Nov 2017 22:20:53 +0000
with message-id <e1eb6o9-0000uk...@fasolo.debian.org>
and subject line Bug#880746: fixed in libmetadata-extractor-java 2.10.1-3
has caused the Debian Bug report #880746,
regarding libmetadata-extractor-java: Manifest references xmpcore-debian.jar, 
but libxmpcore-java does not provide this file.
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
880746: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=880746
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: libmetadata-extractor-java
Version: 2.10.1-2
Severity: important
Control: affects -1 src:gpsprune

Dear Maintainer,

As reported in the upstream GpsPrune issue [0], loading JPG files using
libmetadata-extractor-java causes NoClassDefFoundError exceptions:

 Link: com/adobe/xmp/XMPException
 java.lang.NoClassDefFoundError: com/adobe/xmp/XMPException
 at com.drew.imaging.jpeg.JpegMetadataReader.(JpegMetadataReader.java:57)
 at 
com.drew.imaging.ImageMetadataReader.readMetadata(ImageMetadataReader.java:111)
 at 
com.drew.imaging.ImageMetadataReader.readMetadata(ImageMetadataReader.java:161)
 at tim.prune.jpeg.ExternalExifLibrary.getJpegData(ExternalExifLibrary.java:36)
 at tim.prune.jpeg.ExifGateway.getJpegData(ExifGateway.java:46)
 at tim.prune.load.JpegLoader.createPhoto(JpegLoader.java:227)
 at tim.prune.load.JpegLoader.processFile(JpegLoader.java:204)
 at tim.prune.load.JpegLoader.processFileList(JpegLoader.java:172)
 at tim.prune.load.JpegLoader.run(JpegLoader.java:127)
 at java.lang.Thread.run(Thread.java:748)
 Caused by: java.lang.ClassNotFoundException: com.adobe.xmp.XMPException
 at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
 at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
 at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:335)
 at java.lang.ClassLoader.loadClass(ClassLoader.java:357)

The GpsPrune upstream developer traced this issue down to an incorrect
jar being referenced in the manifest of libmetdata-extractor-java:

"
 I had a look at the jars, and the manifest of GpsPrune's jar correctly
 references the metadata-extractor.jar. However, the manifest of the
 metadata-extractor.jar refers to a file called "xmpcore-debian.jar"
 instead of "xmpcore.jar" as I would expect.
"

The xmpcore-debian.jar file is not provided by the libxmpcore-java
package, only xmpcore.jar & xmpcore-5.1.2.jar.

The attached patch uses jh_classpath from javahelper to fix the
Class-Path in metadata-extractor.jar.

Please consider applying this patch, or fix this issue in a different
way.

[0] https://github.com/activityworkshop/GpsPrune/issues/15

Kind Regards,

Bas
>From 70f18e987b094e2f562b68bb459aa7aca94f9b0c Mon Sep 17 00:00:00 2001
From: Bas Couwenberg <sebas...@xs4all.nl>
Date: Sat, 4 Nov 2017 17:48:37 +0100
Subject: Use javahelper to fix the Class-Path for xmpcore.jar.

---
 debian/changelog                            | 7 +++++++
 debian/control                              | 1 +
 debian/libmetadata-extractor-java.classpath | 1 +
 debian/rules                                | 4 ++++
 4 files changed, 13 insertions(+)
 create mode 100644 debian/libmetadata-extractor-java.classpath

diff --git a/debian/changelog b/debian/changelog
index 4cd2d38..a87850d 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+libmetadata-extractor-java (2.10.1-2.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Use javahelper to fix the Class-Path for xmpcore.jar.
+
+ -- Bas Couwenberg <sebas...@debian.org>  Sat, 04 Nov 2017 17:48:01 +0100
+
 libmetadata-extractor-java (2.10.1-2) unstable; urgency=medium
 
   * Team upload.
diff --git a/debian/control b/debian/control
index 06c4607..7dad3d2 100644
--- a/debian/control
+++ b/debian/control
@@ -6,6 +6,7 @@ Uploaders: Emmanuel Bourg <ebo...@apache.org>
 Build-Depends: debhelper (>= 10),
                default-jdk,
                default-jdk-doc,
+               javahelper,
                junit4,
                libxmpcore-java,
                libmaven-javadoc-plugin-java,
diff --git a/debian/libmetadata-extractor-java.classpath 
b/debian/libmetadata-extractor-java.classpath
new file mode 100644
index 0000000..10ba889
--- /dev/null
+++ b/debian/libmetadata-extractor-java.classpath
@@ -0,0 +1 @@
+usr/share/java/metadata-extractor.jar /usr/share/java/xmpcore.jar
diff --git a/debian/rules b/debian/rules
index fa23c8f..194f12c 100755
--- a/debian/rules
+++ b/debian/rules
@@ -3,5 +3,9 @@
 %:
        dh $@ --buildsystem=maven
 
+override_dh_install:
+       dh_install
+       jh_classpath -v
+
 get-orig-source::
        uscan --force-download --download-current-version
-- 
2.11.0


--- End Message ---
--- Begin Message ---
Source: libmetadata-extractor-java
Source-Version: 2.10.1-3

We believe that the bug you reported is fixed in the latest version of
libmetadata-extractor-java, which is due to be installed in the Debian FTP 
archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 880...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Markus Koschany <a...@debian.org> (supplier of updated 
libmetadata-extractor-java package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 04 Nov 2017 22:44:19 +0100
Source: libmetadata-extractor-java
Binary: libmetadata-extractor-java libmetadata-extractor-java-doc
Architecture: source
Version: 2.10.1-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Java Maintainers 
<pkg-java-maintainers@lists.alioth.debian.org>
Changed-By: Markus Koschany <a...@debian.org>
Description:
 libmetadata-extractor-java - JPEG metadata extraction framework
 libmetadata-extractor-java-doc - Documentation for the JPEG metadata 
extraction framework
Closes: 880746
Changes:
 libmetadata-extractor-java (2.10.1-3) unstable; urgency=medium
 .
   * Team upload.
   * Use javahelper to fix the Class-Path attribute for xmpcore.jar.
     Thanks to Bas Couwenberg for the report and patch. (Closes: #880746)
   * Declare compliance with Debian Policy 4.1.1.
Checksums-Sha1:
 0107cc7474063be465d288e9c7f20e4c20c412ed 2487 
libmetadata-extractor-java_2.10.1-3.dsc
 73e0d8191dafd4e2d45620745211fabde83e27a2 5100 
libmetadata-extractor-java_2.10.1-3.debian.tar.xz
 b8ffdf20eac357ab11ea88ca1f653b60b933f251 16452 
libmetadata-extractor-java_2.10.1-3_amd64.buildinfo
Checksums-Sha256:
 51a957c76b76eb4ad2f08a538f3e405e4bb3b16b529aeefad9d85911c6acfcd8 2487 
libmetadata-extractor-java_2.10.1-3.dsc
 05dbb9d88552dd6613495fdaab16a7b08a29a985bc39c0a862f80e4db7f38f6a 5100 
libmetadata-extractor-java_2.10.1-3.debian.tar.xz
 4afd99ecdb158bee3f145a1290d4eba1a059d8ac4e1e07d098127b2cd758976d 16452 
libmetadata-extractor-java_2.10.1-3_amd64.buildinfo
Files:
 5c841f8b094737e481bbbdcdbc125910 2487 java optional 
libmetadata-extractor-java_2.10.1-3.dsc
 c550a73c0ab109fbb8e61a0ed01ba0e7 5100 java optional 
libmetadata-extractor-java_2.10.1-3.debian.tar.xz
 0e5c99e3818e7bf103c07383d70fd5fb 16452 java optional 
libmetadata-extractor-java_2.10.1-3_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQKjBAEBCgCNFiEErPPQiO8y7e9qGoNf2a0UuVE7UeQFAln+OfxfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEFD
RjNEMDg4RUYzMkVERUY2QTFBODM1RkQ5QUQxNEI5NTEzQjUxRTQPHGFwb0BkZWJp
YW4ub3JnAAoJENmtFLlRO1HkHA8QAKVgwY/6E6MFp4NbCx7HnVB0gKnxSRl5evxw
eWZaFYeB9ia5B8Tf1Z7OmvBeTSajsV30f24L8oTcnXjTE9vhuJ909HpD9NQRsVgB
89+jeXpP70sThSnc1gW2qbC6lgxYgp8H/SyE+BNuNTgUeZORWVRmJUlhPJi7nvyR
RCEzfMg0Y092hfres3QlrI5NeDpDhDzx8aiDN5PuBxJ0KtsLLYuASMmYMrWm+9h9
ArjUjWKYMtV8AZc5/ps0MlM098NjUo7dZYEkfAlydwFu3+ELoXd3EOFQNJx/4EKN
TRvKFOyh15DMV151C7D/iYk3M0n+2QvVXdfR25qsaO/tkV92m57AYEhqz+iBSWQB
ENUyH/3wI/of3t7ct6W1cMh182H+CtNNcvyanhMNE4dyr6k2KIHtTAh85cNBlA8+
0KqCrJQdN8GY7Pc/WexnLnAGCWufEKiFJ0ECs0FUKMLLeITAVBVxD6DOpAUgC04Y
fDcuG36eSfNXJIu6TY+5mlyQQAK6psjdYaYKpH47rijDPH2rMHR3VHJLtF2f2xX+
1G2hzLyU1VDx/P23nPDj4OraOA72ctHEBwn4p/+0GyGFt7eSdmy74wDcxhzrTFHL
+kE7ACVtXrUA8cFK/hbYaJ+0SRqi2o0qKURtbyShYa1I3kB+lvW5bjpB+Y/Glq49
NqIT1sRc
=1af2
-----END PGP SIGNATURE-----

--- End Message ---
__
This is the maintainer address of Debian's Java team
<http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-java-maintainers>. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Reply via email to