Re: [maven] 03/03: Upgrade to 3.5.2

2018-02-22 Thread Stephen Kitt
On Thu, 22 Feb 2018 22:49:21 +0100, Emmanuel Bourg  wrote:
> Le 22/02/2018 à 18:53, Stephen Kitt a écrit :
> > Done, thanks! If you think this is ready to go, I can take care of
> > uploading the package...  
> 
> I tested quickly, the package builds fine and can rebuild itself
> afterward. This update doesn't seem to break Gradle this time, so it
> looks good to me. Enjoy your first Maven upload :)

Uploaded, thanks ;-). I changed the package to install NOTICE too, to
appease Lintian — I’m not convinced it’s necessary in this instance, but
I reckoned it wasn’t especially onerous and the safest long-term option.

Regards,

Stephen


pgpD2oHiEWIsx.pgp
Description: OpenPGP digital signature
__
This is the maintainer address of Debian's Java team
. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Re: [maven] 03/03: Upgrade to 3.5.2

2018-02-22 Thread Emmanuel Bourg
Le 22/02/2018 à 23:25, Stephen Kitt a écrit :

> Uploaded, thanks ;-). I changed the package to install NOTICE too, to
> appease Lintian — I’m not convinced it’s necessary in this instance, but
> I reckoned it wasn’t especially onerous and the safest long-term option.

Thank you! I'm not convinced we have to put the NOTICE files in the
binary packages either since we already have the debian/copyright files
and the Apache-2.0 license allows putting the attribution notices in
another documentation file, but I'm not going to argue over this.

Emmanuel Bourg

__
This is the maintainer address of Debian's Java team
. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Re: [maven] 03/03: Upgrade to 3.5.2

2018-02-22 Thread Emmanuel Bourg
Le 22/02/2018 à 18:53, Stephen Kitt a écrit :

> Done, thanks! If you think this is ready to go, I can take care of uploading
> the package...

I tested quickly, the package builds fine and can rebuild itself
afterward. This update doesn't seem to break Gradle this time, so it
looks good to me. Enjoy your first Maven upload :)

Emmanuel Bourg

__
This is the maintainer address of Debian's Java team
. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Re: [maven] 03/03: Upgrade to 3.5.2

2018-02-22 Thread Stephen Kitt
On Thu, 22 Feb 2018 15:46:34 +0100, Emmanuel Bourg  wrote:
> Le 22/02/2018 à 14:54, Stephen Kitt a écrit :
> > diff --git a/debian/control b/debian/control
> > index 346a6f9..9b8c36f 100644
> > --- a/debian/control
> > +++ b/debian/control
> > @@ -10,6 +10,7 @@ Build-Depends-Indep: junit4,
> >   libcommons-lang3-java (>= 3.4-2~),
> >   libcommons-logging-java,
> >   libeasymock-java,
> > + libgeronimo-annotation-1.3-spec-java,
> >   libguice-java (>= 4.0),
> >   liblogback-java,
> >   libmaven-parent-java (>= 27),  
> 
> You also need a symlink for this dependency in debian/maven.links.
> When I attempted the Maven 3.5.1 upgrade I added this:
[...]

Done, thanks! If you think this is ready to go, I can take care of uploading
the package...

Regards,

Stephen


pgp5go829dESV.pgp
Description: OpenPGP digital signature
__
This is the maintainer address of Debian's Java team
. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Re: [maven] 03/03: Upgrade to 3.5.2

2018-02-22 Thread Emmanuel Bourg
Le 22/02/2018 à 14:54, Stephen Kitt a écrit :

> diff --git a/debian/control b/debian/control
> index 346a6f9..9b8c36f 100644
> --- a/debian/control
> +++ b/debian/control
> @@ -10,6 +10,7 @@ Build-Depends-Indep: junit4,
>   libcommons-lang3-java (>= 3.4-2~),
>   libcommons-logging-java,
>   libeasymock-java,
> + libgeronimo-annotation-1.3-spec-java,
>   libguice-java (>= 4.0),
>   liblogback-java,
>   libmaven-parent-java (>= 27),

You also need a symlink for this dependency in debian/maven.links.
When I attempted the Maven 3.5.1 upgrade I added this:

--- a/debian/maven.links
+++ b/debian/maven.links
@@ -12,6 +12,7 @@
 /usr/share/java/jansi.jar
/usr/share/maven/lib/jansi.jar
 /usr/share/java/atinject-jsr330-api-1.0.jar  
/usr/share/maven/lib/javax.inject.jar
 /usr/share/java/jcl-over-slf4j.jar   
/usr/share/maven/lib/jcl-over-slf4j.jar
+/usr/share/java/geronimo-annotation-1.3-spec.jar 
/usr/share/maven/lib/jsr250-api.jar
 /usr/share/java/maven-resolver-api.jar   
/usr/share/maven/lib/maven-resolver-api.jar
 /usr/share/java/maven-resolver-connector-basic.jar   
/usr/share/maven/lib/maven-resolver-connector-basic.jar
 /usr/share/java/maven-resolver-impl.jar  
/usr/share/maven/lib/maven-resolver-impl.jar

__
This is the maintainer address of Debian's Java team
. 
Please use
debian-j...@lists.debian.org for discussions and questions.