Your message dated Sat, 31 Mar 2018 16:20:37 +0000
with message-id <e1f2jf7-000bkq...@fasolo.debian.org>
and subject line Bug#886105: fixed in klystrack 0.20171212-3
has caused the Debian Bug report #886105,
regarding klystrack: please make the build reproducible with respect to
timestamps
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
886105: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=886105
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: klystrack
Version: 0.20171212-1
Severity: wishlist
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org
Hi,
Whilst working on the Reproducible Builds effort [0], we noticed
that klystrack could not be built reproducibly.
Patch attached, although the resource files are still not reproducible
as they iterate over the filesystem in a non-determistic order. This
will require a match to makebundle.c.
[0] https://reproducible-builds.org/
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` la...@debian.org / chris-lamb.co.uk
`-
--- a/debian/patches/reproducible-build.patch 1970-01-01 01:00:00.000000000
+0100
--- b/debian/patches/reproducible-build.patch 2018-01-02 10:18:43.133544155
+0000
@@ -0,0 +1,58 @@
+Description: Make the build reproducible
+Author: Chris Lamb <la...@debian.org>
+Last-Update: 2018-01-02
+
+--- klystrack-0.20171212.orig/klystron/Makefile
++++ klystrack-0.20171212/klystron/Makefile
+@@ -28,6 +28,13 @@ lib_OBJ = $(patsubst %.c, objs.$(CFG)/li
+ CC = gcc -shared -std=gnu99 --no-strict-aliasing
+ CDEP = gcc -E -std=gnu99
+
++DATE_FMT = %Y%m%d
++ifdef SOURCE_DATE_EPOCH
++ KLYSTRON_REVISION ?= $(shell date -u -d "@$(SOURCE_DATE_EPOCH)"
"+$(DATE_FMT)" 2>/dev/null || date -u -r "$(SOURCE_DATE_EPOCH)" "+$(DATE_FMT)"
2>/dev/null || date -u "+$(DATE_FMT)")
++else
++ KLYSTRON_REVISION ?= $(shell date "+$(DATE_FMT)")
++endif
++
+ ifndef CFLAGS
+ CFLAGS = $(MACHINE) -ftree-vectorize
+ endif
+@@ -73,9 +80,7 @@ LDFLAGS =
+ build: Makefile
+ @echo '#ifndef KLYSTRON_VERSION_H' > ./src/version.h
+ @echo '#define KLYSTRON_VERSION_H' >> ./src/version.h
+- @echo -n '#define KLYSTRON_REVISION "' >> ./src/version.h
+- @date +"%Y%m%d" | tr -d '\n' >> ./src/version.h
+- @echo '"' >> ./src/version.h
++ @echo '#define KLYSTRON_REVISION "$(KLYSTRON_REVISION)"' >>
./src/version.h
+ @echo '#define KLYSTRON_VERSION_STRING "klystron " KLYSTRON_REVISION'
>> ./src/version.h
+ @echo '#endif' >> ./src/version.h
+ make all CFG=$(CFG)
+--- klystrack-0.20171212.orig/klystrack/Makefile
++++ klystrack-0.20171212/klystrack/Makefile
+@@ -21,6 +21,13 @@ REV := cp -f
+
+ CFLAGS := $(MACHINE) -ftree-vectorize -std=gnu99 --no-strict-aliasing
+
++DATE_FMT = %Y%m%d
++ifdef SOURCE_DATE_EPOCH
++ REVISION ?= $(shell date -u -d "@$(SOURCE_DATE_EPOCH)" "+$(DATE_FMT)"
2>/dev/null || date -u -r "$(SOURCE_DATE_EPOCH)" "+$(DATE_FMT)" 2>/dev/null ||
date -u "+$(DATE_FMT)")
++else
++ REVISION ?= $(shell date "+$(DATE_FMT)")
++endif
++
+ ifdef COMSPEC
+ TARGET := $(TARGET).exe
+ ARCHIVE := $(ARCHIVE).zip
+@@ -133,9 +140,7 @@ src/version.h: src/version
+ @echo '#ifndef VERSION_H' > ./src/version.h
+ @echo '#define VERSION_H' >> ./src/version.h
+ @echo '#include "version_number.h"' >> ./src/version.h
+- @echo -n '#define REVISION "' >> ./src/version.h
+- @date +"%Y%m%d" | tr -d '\n' >> ./src/version.h
+- @echo '"' >> ./src/version.h
++ @echo '#define REVISION "$(REVISION)"' >> ./src/version.h
+ @echo '#define VERSION_STRING "klystrack " VERSION " " REVISION' >>
./src/version.h
+ @echo '#endif' >> ./src/version.h
+
--- a/debian/patches/series 1970-01-01 01:00:00.000000000 +0100
--- b/debian/patches/series 2018-01-02 09:50:15.745957164 +0000
@@ -0,0 +1 @@
+reproducible-build.patch
--- End Message ---
--- Begin Message ---
Source: klystrack
Source-Version: 0.20171212-3
We believe that the bug you reported is fixed in the latest version of
klystrack, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 886...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Gürkan Myczko <gur...@phys.ethz.ch> (supplier of updated klystrack package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Fri, 23 Mar 2018 13:28:11 +0100
Source: klystrack
Binary: klystrack
Architecture: source
Version: 0.20171212-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Packages Maintainers
<pkg-multimedia-maintainers@lists.alioth.debian.org>
Changed-By: Gürkan Myczko <gur...@phys.ethz.ch>
Description:
klystrack - Chiptune tracker
Closes: 886105
Changes:
klystrack (0.20171212-3) unstable; urgency=medium
.
* Apply patch to make it more reproducible, thanks Chris Lamb.
(Closes: #886105)
Checksums-Sha1:
06eb89e6354fad95b9d289c7d5f4aeebdb2b3acf 1894 klystrack_0.20171212-3.dsc
c3bb94b74943853b81cf32fbc68f87036134d83f 7928
klystrack_0.20171212-3.debian.tar.xz
d2a44222b3dcd0579d46059a6c16937039dec586 5389
klystrack_0.20171212-3_source.buildinfo
Checksums-Sha256:
8c8998313d50464c29449c5bff67212d5a599e7d2635297239c8345f32eecc07 1894
klystrack_0.20171212-3.dsc
3056e48144cf2c4d9bca031fcc061f60911ac9fbe8d47d4d5f3ae6050be78497 7928
klystrack_0.20171212-3.debian.tar.xz
1244495018378b1dfdbedd9754b60271199778b1b6e61713364f9b0326d9aab3 5389
klystrack_0.20171212-3_source.buildinfo
Files:
b996bf47e2acb3c6a5f78370c958db01 1894 sound optional klystrack_0.20171212-3.dsc
6aec877a382bc6d50217eeb9d9cfb87d 7928 sound optional
klystrack_0.20171212-3.debian.tar.xz
1e5556a363e762b4b1f4b7c0ded40548 5389 sound optional
klystrack_0.20171212-3_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEkjZVexcMh/iCHArDweDZLphvfH4FAlq/sCsACgkQweDZLphv
fH5Prg//c73o4efASNPtIyPNwMyj2Ul48b9qLEJNU7kCFv3+15P1fEofJVpYqlrQ
oJ0yqf/4mme+sBFDuruKxsU1bR+mrSZ9c71RqHa9E8RRIKvwOsozvEP6lEw8KnrT
Kf8b00CKvgpZfFcPRFtsCYXDtpV4UYgdPmL1d60+rjcRJPh5q307kSN5JA2DrzXH
TiiQam7Vksc5PgdTB8LLbDOjqTuS1Q+1mbC0oxpR8JQnN1rNyo5lSFnamCCXBmLZ
rJHM0gn/qiZIcdhYkXfIZUhpYGNCUXY08Mzk9MluieCREadni9r+ScRViKQ2IyO1
p5idV1OjjFtPquvgHTWWRC3ieXZG9lsvI5pvdWoq4X2LiqmfNEZUj7Jm05y2MXNK
E8rUqlGN+c3ovwZzuQr9px5TmalJEPVK1SYa0hICAJBff/TCLMZgzAXHXfsjbPrS
7FBIE1blZLmeDLXt94nG/PD6yNKdKz/IPL0DNw4QNXguo+c1X/pv4nXHLro2tg9Y
W7l3eMiD3zIvEV9qXuZF2bfY2NRGSgTrhtS18OmKwB44oZYmTBfdEYAOyxDbmFNU
V/3gN/LnCHlWiGI6IEyOsJ6t0hCrt1vBzwHws0Mw+UYPY9u60SL9QH+RDYU4j5L4
D+7ihQKPxt/rRWdN91TNYkY+VijTJyLl3zYEBdLHBpKmJjRL260=
=48HO
-----END PGP SIGNATURE-----
--- End Message ---
_______________________________________________
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
