Re: exporting/importing config keys? plus: Mandelbrot news

2010-03-16 Thread Benoit Jacob
2010/3/15 Aaron J. Seigo ase...@kde.org: On March 13, 2010, Benoit Jacob wrote:     contextualActions().append(m_exportImageAction);     contextualActions().append(m_exportConfigAction);     contextualActions().append(m_importConfigAction); the append() is being called on a copy

Re: exporting/importing config keys? plus: Mandelbrot news

2010-03-14 Thread Benoit Jacob
Thanks to Ossi on IRC, this is now fixed. Benoit 2010/3/13 Benoit Jacob jacob.benoi...@gmail.com: ok, finally a hopefully not too stupid question. Here's my code: void Mandelbrot::exportConfig() {    KUrl url = KFileDialog::getSaveUrl(                   KUrl(),                   *.txt

exporting/importing config keys? plus: Mandelbrot news

2010-03-13 Thread Benoit Jacob
Hi, I've just made a bunch of Mandelbrot improvements in trunk, plus 1 bugfix backported to 4.4, see below. I would like to honor this feature request: http://forum.kde.org/brainstorm.php#idea55395_page1 Basically I want to create a right-click desktop menu entry that allows to export/import

Re: exporting/importing config keys? plus: Mandelbrot news

2010-03-13 Thread Benoit Jacob
2010/3/13 Marco Martin notm...@gmail.com: On Saturday 13 March 2010, Benoit Jacob wrote: Hi, I've just made a bunch of Mandelbrot improvements in trunk, plus 1 bugfix backported to 4.4, see below. great :) I would like to honor this feature request: http://forum.kde.org/brainstorm.php

Re: exporting/importing config keys? plus: Mandelbrot news

2010-03-13 Thread Benoit Jacob
2010/3/13 Marco Martin notm...@gmail.com: On Saturday 13 March 2010, Benoit Jacob wrote: Hi, I've just made a bunch of Mandelbrot improvements in trunk, plus 1 bugfix backported to 4.4, see below. great :) I would like to honor this feature request: http://forum.kde.org/brainstorm.php

Re: exporting/importing config keys? plus: Mandelbrot news

2010-03-13 Thread Benoit Jacob
2010/3/13 Benoit Jacob jacob.benoi...@gmail.com: 2010/3/13 Marco Martin notm...@gmail.com: On Saturday 13 March 2010, Benoit Jacob wrote: Hi, I've just made a bunch of Mandelbrot improvements in trunk, plus 1 bugfix backported to 4.4, see below. great :) I would like to honor

Re: exporting/importing config keys? plus: Mandelbrot news

2010-03-13 Thread Benoit Jacob
2010/3/13 Benoit Jacob jacob.benoi...@gmail.com: 2010/3/13 Benoit Jacob jacob.benoi...@gmail.com: 2010/3/13 Marco Martin notm...@gmail.com: On Saturday 13 March 2010, Benoit Jacob wrote: Hi, I've just made a bunch of Mandelbrot improvements in trunk, plus 1 bugfix backported to 4.4, see

Re: exporting/importing config keys? plus: Mandelbrot news

2010-03-13 Thread Benoit Jacob
2010/3/13 Benoit Jacob jacob.benoi...@gmail.com: 2010/3/13 Benoit Jacob jacob.benoi...@gmail.com: 2010/3/13 Benoit Jacob jacob.benoi...@gmail.com: 2010/3/13 Marco Martin notm...@gmail.com: On Saturday 13 March 2010, Benoit Jacob wrote: Hi, I've just made a bunch of Mandelbrot improvements

wheel events no longer passed to the wallpaper?

2009-12-29 Thread Benoit Jacob
Hi, I just tried 4.4 beta2 and noted that mouse wheel events are no longer passed to the wallpaper. Is this intentional or a bug? Notice that this breaks the Mandelbrot wallpaper, as it makes the zooming functionality much harder to discover (have to use MMB DD). Happy holidays! Benoit

Re: wheel events no longer passed to the wallpaper?

2009-12-29 Thread Benoit Jacob
2009/12/29 Chani chan...@gmail.com: On December 29, 2009 14:39:05 Benoit Jacob wrote: Hi, I just tried 4.4 beta2 and noted that mouse wheel events are no longer passed to the wallpaper. Is this intentional or a bug? Notice that this breaks the Mandelbrot wallpaper, as it makes the zooming

Re: kdereview review day

2009-04-30 Thread Benoit Jacob
You're welcome and thanks for reporting the bug! Benoit 2009/4/30 Anne-Marie Mahfouf annemarie.mahf...@free.fr: Hi Benoit, My system froze (I think there's something fishy in Desktop effects as X froze after I disable compositing). I checked Mandelbrot again with debugfull and it's OK now!

Re: how to use the cache-to-disk feature in Wallpaper

2009-04-13 Thread Benoit Jacob
exists: bja...@kiwi:~/.kde/cache-kiwi/plasma-wallpapers ls home mandelbrot-157422800.png mandelbrot-72259600.png usr Cheers, Benoit 2009/4/13 Benoit Jacob jacob.benoi...@gmail.com: I have a problem, I wonder if I'm hitting a bug. It seems as if insertIntoCache(key, QImage()) does not do

Re: how to use the cache-to-disk feature in Wallpaper

2009-04-13 Thread Benoit Jacob
By the way the committed code does this from save(), not from the destructor, so this wasn't where to look for an explanation. Cheers, Benoit 2009/4/13 Benoit Jacob jacob.benoi...@gmail.com: this is now committed, as a testcase... Example of console output: plasma-desktop(7077) Mandelbrot

Re: how to use the cache-to-disk feature in Wallpaper

2009-04-13 Thread Benoit Jacob
oops, sent too fast. sorry for the spam. It remains that my way of triggering save() was kquitapp plasma. So in every case, my problem arises when Mandelbrot is about to be destroyed. 2009/4/13 Benoit Jacob jacob.benoi...@gmail.com: By the way the committed code does this from save(), not from

Re: how to use the cache-to-disk feature in Wallpaper

2009-04-13 Thread Benoit Jacob
2009/4/13 Aaron J. Seigo ase...@kde.org: On Monday 13 April 2009, Benoit Jacob wrote: // remove old image from cache kDebug() remove m_cacheKey; insertIntoCache(m_cacheKey, QImage()); fixed in svn; what was happening was that a kio job was being created while the app was being destroyed

KDEReview for Mandelbrot Wallpaper Plugin

2009-04-13 Thread Benoit Jacob
Hi, The Mandelbrot wallpaper plugin is now in KDEReview, at this address: /trunk/kdereview/plasma/wallpapers/mandelbrot/ * Basic facts: * 844 lines of code (according to sloccount) Stripped executable size: 68 kB. Nontrivial dependencies: Eigen = 2.0 (in kdesupport). Should be

Re: how to use the cache-to-disk feature in Wallpaper

2009-04-12 Thread Benoit Jacob
2009/4/10 Aaron J. Seigo ase...@kde.org: papers (maybe i should add that bookkeeping into Wallpaper itself? H.. yes, probably... let me get back to you on that one, he says, again.) ok: caching is now implemented in Mandelbrot (r952792). Here's again a somewhat lengthy email but you can

Re: how to use the cache-to-disk feature in Wallpaper

2009-04-12 Thread Benoit Jacob
2009/4/12 Aaron J. Seigo ase...@kde.org: if you have 3 containments with the same image as the wallpaper, it shouldn't create three cache files on disk. so there is no real mapping from cache file to containment; there is a mapping of sorts between wallpaper plugins and the cache file they are

Re: how to use the cache-to-disk feature in Wallpaper

2009-04-12 Thread Benoit Jacob
, Benoit 2009/4/12 Benoit Jacob jacob.benoi...@gmail.com: 2009/4/12 Aaron J. Seigo ase...@kde.org: if you have 3 containments with the same image as the wallpaper, it shouldn't create three cache files on disk. so there is no real mapping from cache file to containment; there is a mapping of sorts

Re: Mandelbrot progress, need Qt GUI help!

2009-04-10 Thread Benoit Jacob
2009/4/10 Aaron J. Seigo ase...@kde.org: it's because you didn't put a layout in the widget itself. to do so in designer: * click on the background * select a layout from the toolbar this is equivalent to: QWidget *topLevelWidget  = new QWidget(this); QGridLayout *layout = new

Re: Usability questions for Mandelbrot

2009-04-10 Thread Benoit Jacob
2009/4/10 Aaron J. Seigo ase...@kde.org: On Thursday 09 April 2009, Benoit Jacob wrote: 2009/4/9 Aaron J. Seigo ase...@kde.org: QCursor::setCursor? ah, thanks! i wonder if the hoverOut events are accurate enough for that though.. hm.. i can't seem to find any hoverEvents

how to use the cache-to-disk feature in Wallpaper

2009-04-10 Thread Benoit Jacob
Hi, I think Mandelbrot is a good candidate for cache-to-disk, however, how do i enable this feature? I did setUsingDiskCache(true); in the constructor, and I emit renderCompleted once my image has finished rendering, but that doesn't make any difference. Thanks, Benoit

Re: Usability questions for Mandelbrot

2009-04-10 Thread Benoit Jacob
2009/4/10 Aaron J. Seigo ase...@kde.org: On Friday 10 April 2009, Benoit Jacob wrote: 2) There are no hoverEnterEvent and hoverLeaveEvent methods in Wallpaper. So I tried reimplementing QObject::event() but it doesn't seem to ever get called: the following gives nothing, not even the mouse

Re: Mandelbrot progress, need Qt GUI help!

2009-04-10 Thread Benoit Jacob
2009/4/10 Aaron J. Seigo ase...@kde.org: On Friday 10 April 2009, Benoit Jacob wrote: I allowed myself to remove the horiz spacer to the right of the KComboBox, letting it be horizontally expanded. Indeed (also to answer Andrew's question) my motivation was that the last items in this combo

Re: how to use the cache-to-disk feature in Wallpaper

2009-04-10 Thread Benoit Jacob
2009/4/10 Aaron J. Seigo ase...@kde.org: On Friday 10 April 2009, Benoit Jacob wrote: I did setUsingDiskCache(true); in the constructor, and I emit when you are ready to cache the image, you can now call: insertIntoCache(const QString key, const QImage image); and if you want to see

Re: Mandelbrot progress, need Qt GUI help!

2009-04-09 Thread Benoit Jacob
Hi, one more GUI question please! When I resize the Desktop Settings dialog horizontally, I'd expect the Mandelbrot controls to resize automatically to use the extra space. That's what happens with the Pattern wallpaper's controls. But I can't seem to obtain this behavior. I tried to mimic

Re: Usability questions for Mandelbrot

2009-04-09 Thread Benoit Jacob
2009/4/9 Sebastian Kügler se...@kde.org: Make the mouse pointer a hand only when the left button is pressed, this way you get visual feedback without the distraction of the always hand. OK, the next question is: how do you change the mouse cursor from a Plasma wallpaper? Normally i'd call

Mandelbrot, continued (and plasma bug reports)

2009-04-08 Thread Benoit Jacob
Hi, First of all, many thanks to Aaron and Andrew for your help. SVN now has an updated version taking it into account. Finally, I found that what I really need is to be able to distinguish between the main instance of the wallpaper, that is the one that is actually used as desktop background,

Usability questions for Mandelbrot

2009-04-08 Thread Benoit Jacob
Hi, I have a couple usability questions. The Mandelbrot wallpaper has 2 modes: locked and unlocked. In locked mode, it behaves like an ordinary wallpaper. In unlocked mode, the view can be moved by mouse dd and mouse wheel. Question 1. In locked mode, should mouse wheel do nothing? Or should it

Re: Usability questions for Mandelbrot

2009-04-08 Thread Benoit Jacob
2009/4/8 Aaron J. Seigo ase...@kde.org: On Wednesday 08 April 2009, Benoit Jacob wrote: In locked mode, should mouse wheel do nothing? Or should it have the default effect which is, cycle through virtual desktops? if the mouse event is not used by the wallpaper, you should not call accepted

Re: Mandelbrot, continued (and plasma bug reports)

2009-04-08 Thread Benoit Jacob
2009/4/8 Aaron J. Seigo ase...@kde.org: On Wednesday 08 April 2009, Benoit Jacob wrote: (**) Ideally, the main Mandelbrot instance should save its config before the Desktop Settings embedded instance reads the config. Is that possible? this is now done in svn .. the wallpaper

Re: Usability questions for Mandelbrot

2009-04-08 Thread Benoit Jacob
2009/4/9 Sebastian Kügler se...@kde.org: Make the mouse pointer a hand only when the left button is pressed, this way you get visual feedback without the distraction of the always hand. good idea! Benoit ___ Plasma-devel mailing list

Mandelbrot ready for review, config bugs

2009-04-07 Thread Benoit Jacob
Hi, Mandelbrot (playground/base/plasma/wallpapers/mandelbrot) is ready for review! However before moving it to kdereview let's discuss the following bug as I don't know if it is in my code or in libplasma. The bug is that the config isn't saved when it should, so is often lost: 1) when changing

Re: Mandelbrot progress, need Qt GUI help!

2009-04-07 Thread Benoit Jacob
2009/4/8 Andrew Stromme astro...@chatonka.com: It would be nice to have more descriptive names than Color 1, Color 2 etc.. for the color selection. Maybe something like Inside Color, Outline Color, Fringe Color or Main Color, Secondary Color, etc... would be more self-explanatory? Good idea.

Mandelbrot progress, need Qt GUI help!

2009-04-06 Thread Benoit Jacob
Hi, The mandelbrot wallpaper plugin is almost ready (in playground/base/plasma/wallpapers/mandelbrot). However I am a complete GUI n00b and I need some very basic help so I hope that someone here can help me. Initially, the configuration GUI had only one KColorButton. Now I want 3

Re: playground plasmoid redux

2008-10-03 Thread Benoit Jacob
2008/10/3, Aaron J. Seigo [EMAIL PROTECTED]: hrm; not to my knowledge but i could be wrong. what's the crash you get? Attached is the backtrace. It occurs only on plasma startup i.e. if you select Mandelbrot it works fine for the duration of your session but on next login it crashes. I assume

Re: playground plasmoid redux

2008-10-03 Thread Benoit Jacob
Another possibility: is it illegal to wait for a QThread that was just constructed but not yet started? I.e. thread = new MyThreadClass(); wait(thread); OK, i don't distract this thread (no pun intended) more with offtopic questions. Cheers, Benoit 2008/10/3, Benoit Jacob [EMAIL PROTECTED

Re: playground plasmoid redux

2008-10-03 Thread Benoit Jacob
Yes sure that's what I mean :) OK, I forget about this documentation bit, thank you. Cheers, Benoit 2008/10/3, Jason Stubbs [EMAIL PROTECTED]: wait(thread)? wait()'s parameter is an integer timeout... If you mean thread-wait(), the documentation says it returns true if the thread has not

Re : Re : New Mandelbrot wallpaper in playground, triggers some bugs

2008-09-08 Thread Benoit Jacob
I definitely plan to do so for 4.2 but there are a couple more things that I want to sort out before. Cheers, Benoit 2008/9/8, Aaron J. Seigo [EMAIL PROTECTED]: On Monday 08 September 2008, Benoit Jacob wrote: letting you know that the embargo on screenshots is lifted :) ;) even more

Re: New Mandelbrot wallpaper in playground, triggers some bugs

2008-09-06 Thread Benoit Jacob
just one more note: i'm going to implement the smooth gradient algo, so please nobody blog about this wallpaper until i've done it, currently it doesn't look too good. 2008/9/6 Benoit Jacob [EMAIL PROTECTED]: ok should be fixed in 857678. Cheers, Benoit PS. Now using intel graphics (yes i

Re: New Mandelbrot wallpaper in playground, triggers some bugs

2008-09-05 Thread Benoit Jacob
Thanks for looking into it, but now when i change the color and apply or ok the change is not applied, the old color is still used. I did svn up in trunk/kdebase/workspace, anything else I should do ? Benoit 2008/9/5 Aaron J. Seigo [EMAIL PROTECTED]: On Friday 05 September 2008, Benoit Jacob

Re: New Mandelbrot wallpaper in playground, triggers some bugs

2008-09-05 Thread Benoit Jacob
16:32:02 Benoit Jacob wrote: Here are the steps to reproduce: -set mandelbrot as your wallpaper -minimize all windows, close plasma toolboxes (e.g. the panel toolbox) -navigate through the wallpaper (e.g. mouse wheel) I still have the glitches with latest trunk; also, if i enable desktop

Re: New Mandelbrot wallpaper in playground, triggers some bugs

2008-09-05 Thread Benoit Jacob
Indeed, i can reproduce that. How do I get a backtrace? The kcrash dialog just disappears when i ask for the backtrace, and when i run plasma in gdb, after the crash it just says no stack. 2008/9/6 Aaron J. Seigo [EMAIL PROTECTED]: On Friday 05 September 2008, Benoit Jacob wrote: I updated

Re: New Mandelbrot wallpaper in playground, triggers some bugs

2008-09-05 Thread Benoit Jacob
. Cheers, Benoit 2008/9/6 Benoit Jacob [EMAIL PROTECTED]: Indeed, i can reproduce that. How do I get a backtrace? The kcrash dialog just disappears when i ask for the backtrace, and when i run plasma in gdb, after the crash it just says no stack. 2008/9/6 Aaron J. Seigo [EMAIL PROTECTED

[PATCH] pass mouse wheel events to the wallpaper

2008-09-04 Thread Benoit Jacob
Hi, The attached patch makes Containment forward mouse wheel events first to the wallpaper, if the event screenPos() indicates that the mouse cursor was on the wallpaper. I adapted this code from what you were already doing with mouseMoveEvent(). If the wallpaper doesn't accept the wheel event,

Re: [PATCH] pass mouse wheel events to the wallpaper

2008-09-04 Thread Benoit Jacob
OK, committed in 857101. Benoit 2008/9/4 Aaron J. Seigo [EMAIL PROTECTED]: On Thursday 04 September 2008, Benoit Jacob wrote: Hi, The attached patch makes Containment forward mouse wheel events first to the wallpaper, if the event screenPos() indicates that the mouse cursor

New Mandelbrot wallpaper in playground, triggers some bugs

2008-09-04 Thread Benoit Jacob
Hi, I just committed an initial version of my Mandelbrot wallpaper plugin (only 360 LOC) there: /trunk/playground/base/plasma/wallpapers/ commit message: http://websvn.kde.org/trunk/playground/base/plasma/wallpapers/?view=logpathrev=857241 You'll need a recent checkout of

Re: New Mandelbrot wallpaper in playground, triggers some bugs

2008-09-04 Thread Benoit Jacob
2008/9/5 Aaron J. Seigo [EMAIL PROTECTED]: woo hoo! the best part of this is that you manage to find all the annoying little bugs that hadn't been rooted out yet. thanks for that alone! You're welcome... thanks for making this framework in the first place :) 2) In the desktop settings dialog,

Plasma wallpaper painting inconsistency

2008-09-02 Thread Benoit Jacob
Hi, I noticed an inconsistency in the way plasma wallpapers are painted, between when it is painted as background of the screen and when it is painted in the little preview in the Desktop Settings dialog. Here is my paint() function. Mandelbrot is a subclass of Wallpaper. void

Re: Plasma wallpaper painting inconsistency

2008-09-02 Thread Benoit Jacob
these when i'll have committed. Cheers, Benoit 2008/9/3 Aaron J. Seigo [EMAIL PROTECTED] On Tuesday 02 September 2008, Aaron J. Seigo wrote: On Tuesday 02 September 2008, Benoit Jacob wrote: See, the paint() function is always called with exposedRect equal to the whole screed, regardless