Re: [REVIEW] integration of kuiserver applet into the systemtray

2008-11-17 Thread Jason Stubbs
at least get any necessary strings in. -- Jason Stubbs ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Prevent excessive painting of non-ARGB fdo system tray icons

2008-11-08 Thread Jason Stubbs
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/264/ --- (Updated 2008-11-08 04:00:45.525789) Review request for Plasma. Summary

Re: Review Request: Prevent excessive painting of non-ARGB fdo system tray icons

2008-11-08 Thread Jason Stubbs
Jason Stubbs wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/264/ --- (Updated 2008-11-08 04:00:45.525789) Hmm.. nothing

Re: Review Request: Prevent excessive painting of non-ARGB fdo system tray icons

2008-11-08 Thread Jason Stubbs
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/264/ --- (Updated 2008-11-08 19:40:17.960183) Review request for Plasma. Summary

Re: Review Request: Prevent excessive painting of non-ARGB fdo system tray icons

2008-11-08 Thread Jason Stubbs
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/264/ --- (Updated 2008-11-08 19:40:24.687531) Review request for Plasma. Summary

Re: Review Request: Some improments to the system tray notifications.

2008-11-05 Thread Jason Stubbs
, with/without a timeout and with/without being detached. -- Jason Stubbs ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: always paint background in the system tray

2008-10-31 Thread Jason Stubbs
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/247/#review239 --- Ship it! Looks fine to me. - Jason On 2008-10-31 06:42:16,

Re: bad panel rendering on NetBSD

2008-10-22 Thread Jason Stubbs
was probably a different systray container =) the new one went in early tuesday morning-ish UTC iirc? anyways .. what version of Qt are you using? It could have something to do with it, but I hope not. ;) The screenshot reminds me of https://bugs.kde.org/show_bug.cgi?id=170283. -- Jason Stubbs

playground/base/plasma/applets/systray-refactor

2008-10-05 Thread Jason Stubbs
SVN commit 868140 by jstubbs: Overriding the default hoverEnterEvent and hoverLeaveEvent handlers as they call update(), which is not required. There is still a pointless update when the mouse cursor enters the panel, though. It appears to be coming from Plasma::Containment and is causing

Re: playground plasmoid redux

2008-10-03 Thread Jason Stubbs
it returns true if the thread has not been started yet. ie, it doesn't wait at all. -- Jason Stubbs ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: playground applets

2008-09-30 Thread Jason Stubbs
notifications don't close. (What to do about this?) * Notifications aren't grouped by application. (Not critical but preferred) * Misbehavior of certain applets within the plasmoid protocol or vice-versa. (Still needs investigating) -- Jason Stubbs

Re: playground applets

2008-09-30 Thread Jason Stubbs
2008/10/1 Aaron J. Seigo [EMAIL PROTECTED] On Tuesday 30 September 2008, Jason Stubbs wrote: * The correct icon isn't being set on notifications (internal API issue) internal to the systray-refactor widget .. or? Yep. It's a TODO. * Detached notifications don't close. (What to do about

Re: playground applets

2008-09-30 Thread Jason Stubbs
, I'd like to add: * Sizing is wrong (again) when in the panel. -- Jason Stubbs ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: playground/base/plasma/applets/systray-refactor/protocols/plasmoid

2008-09-22 Thread Jason Stubbs
? If horizontal, should it still be horizontal on displays that have a larger height than width? -- Jason Stubbs ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: AppletScript configAccepted

2008-09-15 Thread Jason Stubbs
Petri Damstén wrote: If we are looking root of that package (It's equal to path() but needed in dashboard to set root to this) then basepath is /some/path/ and canonical is /some/path and startsWith does not match. Is it ok to add '/' to canonicalPath? What you probably want is

Re: plasma/kdelibs coding style and pointers

2008-09-01 Thread Jason Stubbs
Jason Stubbs wrote: The kdelibs coding style on techbase[1] only says For pointers or references, use a single space before '*' or '', but not after. When looking through applet.h and applet.cpp, I see this rule being broken in some circumstances. Am I right to believe that the first

plasma/kdelibs coding style and pointers

2008-08-31 Thread Jason Stubbs
are all correct, is it correct to put the asterisk next to the variable (but not function) name when one is present and next to the class/struct name otherwise? [1] http://techbase.kde.org/Policies/Kdelibs_Coding_Style -- Jason Stubbs ___ Plasma-devel

Re: Review Request: Transparent system tray icons

2008-08-21 Thread Jason Stubbs
more obvious. :) -- Jason Stubbs ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Transparent system tray icons

2008-08-17 Thread Jason Stubbs
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/137/ --- Review request for Plasma. Summary --- Adds transparency to system

Re: Review Request: Transparent system tray icons

2008-08-17 Thread Jason Stubbs
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/137/ --- (Updated 2008-08-17 08:43:00.845896) Review request for Plasma. Summary

Re: Review Request: Transparent system tray icons

2008-08-17 Thread Jason Stubbs
Jason Stubbs wrote: Diff: http://reviewboard.vidsolbach.de/r/137/diff It seems I screwed up the base diff path so, for those that tried to access it earlier and only got a python traceback, the above URL now works correctly. -- Jason Stubbs

playground/base/plasma/applets/systray-refactor/core/fdo

2008-08-16 Thread Jason Stubbs
SVN commit 848034 by jstubbs: This code doesn't serve it's purpose, but I'd like others to have a look at it so I'm throwing it into subversion for the time being. The purpose is to do ParentRelative background-pixmap manually. No X errors are mentioned on the console and there's no crashes but