Hi list,
The port audio/abcde has a small bug which is easy to fix. When
generating a playlist for ogg files, there is a problem in the abcde
shell script (line 767) with '[ -n $variable ]' which evaluates to
true even though $variable is empty. The solution is to use '[ -n
"$variable" ]'. This seems to be an one-off omission, all other test
using '-n' already uses double quotes around the variable name.
A patch is included (this is against the installed script).
Regards,
Andreas
--
Andreas Kahari
Somewhere in the general Cambridge area, UK
--- /usr/local/bin/abcde Sat Jun 3 21:07:42 2006
+++ /tmp/abcde Sun Jun 4 10:01:53 2006
@@ -764,7 +764,7 @@
ARTISTFILE=$(mungefilename "$TRACKARTIST")
# If we want to start the tracks with a given
number, we need to modify the
# TRACKNUM value before evaluation
- if [ -n $STARTTRACKNUMBER ] ; then
+ if [ -n "$STARTTRACKNUMBER" ]; then
# Get the trackpadding from the current
track
CURRENTTRACKPADDING=$(echo -n
$UTRACKNUM | wc -c)
TRACKNUM=$( printf
%0.${CURRENTTRACKPADDING}d $(expr ${UTRACKNUM} + ${STARTTRACKNUMBER} - 1 ))
