[pve-devel] applied: [PATCH pve-esxi-import-tools/storage v2] improve error handling/logging

2024-06-07 Thread Wolfgang Bumiller
applied both patches, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied-series: [PATCH many v3 0/8] notifications: move template strings to template files

2024-06-04 Thread Wolfgang Bumiller
applied series & bumped packages, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH storage 1/2] don't bail on whitespaces in backing devices

2024-04-30 Thread Wolfgang Bumiller
On Tue, Apr 30, 2024 at 11:13:02AM +0200, Fiona Ebner wrote: > Am 30.04.24 um 10:38 schrieb Wolfgang Bumiller: > > On Tue, Apr 30, 2024 at 10:14:13AM +0200, Fiona Ebner wrote: > >> > >> So the returned $parent will now just be undef if it contains > >> whites

Re: [pve-devel] [PATCH storage 1/2] don't bail on whitespaces in backing devices

2024-04-30 Thread Wolfgang Bumiller
On Tue, Apr 30, 2024 at 10:14:13AM +0200, Fiona Ebner wrote: > Am 30.04.24 um 09:53 schrieb Wolfgang Bumiller: > > This prevents importing from vmdks with whitespaces in file names. > > Further, some operations that include file sizes (like listing disks) > > would pote

[pve-devel] [PATCH storage 1/2] don't bail on whitespaces in backing devices

2024-04-30 Thread Wolfgang Bumiller
-machines.144023/page-16#post-658697 Signed-off-by: Wolfgang Bumiller --- src/PVE/Storage/Plugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm index 22a9729..683190b 100644 --- a/src/PVE/Storage/Plugin.pm +++ b/src/PVE/Storage

[pve-devel] [PATCH storage 2/2] fixup error messages in file_size_info

2024-04-30 Thread Wolfgang Bumiller
The assignment happens before the 'die', so the error message would always contain 'undef'. Signed-off-by: Wolfgang Bumiller --- src/PVE/Storage/Plugin.pm | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm index

[pve-devel] [PATCH common] interfaces: support stanzas without types/methods

2024-04-23 Thread Wolfgang Bumiller
This is allowed in ifupdown2 and previously interfaces named 'vmbr\d+' were recognized as bridges even if they used this mode. With commit e68ebda4f109 this is no longer the case. Fixes: e68ebda4f109 ("fix #545: interfaces: allow arbitrary bridge names in network config") Signed-off-by

Re: [pve-devel] [PATCH container 7/7] update: handle pool limits

2024-04-11 Thread Wolfgang Bumiller
On Thu, Apr 11, 2024 at 09:23:53AM +0200, Fabian Grünbichler wrote: > On April 10, 2024 3:13 pm, Fabian Grünbichler wrote: > > Signed-off-by: Fabian Grünbichler > > --- > > src/PVE/API2/LXC/Config.pm | 21 + > > 1 file changed, 21 insertions(+) > > > > diff --git

[pve-devel] applied: [PATCH] d/postinst: don't treat reload/restart failure as fatal

2024-04-11 Thread Wolfgang Bumiller
applied, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager 2/4] pvestatd: collect and broadcast pool usage

2024-04-11 Thread Wolfgang Bumiller
On Wed, Apr 10, 2024 at 03:13:08PM +0200, Fabian Grünbichler wrote: > so that other nodes can query it and both block changes that would violate the > limits, and mark pools which are violating it currently accordingly. > > Signed-off-by: Fabian Grünbichler > --- > PVE/Service/pvestatd.pm | 59

Re: [pve-devel] [PATCH container 2/7] status: add pool usage fields

2024-04-11 Thread Wolfgang Bumiller
On Wed, Apr 10, 2024 at 03:13:00PM +0200, Fabian Grünbichler wrote: > these are similar to existing ones, but with slightly different semantics. > > Signed-off-by: Fabian Grünbichler > --- > src/PVE/LXC.pm | 29 + > 1 file changed, 29 insertions(+) > > diff --git

Re: [pve-devel] [PATCH manager 1/4] api: pools: add limits management

2024-04-11 Thread Wolfgang Bumiller
On Wed, Apr 10, 2024 at 03:13:07PM +0200, Fabian Grünbichler wrote: > allow to set/update limits, and return them when querying individual pools. > > Signed-off-by: Fabian Grünbichler > --- > > Notes: > requires bumped pve-access-control > > PVE/API2/Pool.pm | 36

Re: [pve-devel] [PATCH guest-common 1/1] helpers: add pool limit/usage helpers

2024-04-11 Thread Wolfgang Bumiller
On Wed, Apr 10, 2024 at 03:13:06PM +0200, Fabian Grünbichler wrote: > one for combining the per-node broadcasted values, one for checking a pool's > limit, and one specific helper for checking guest-related actions such as > starting a VM. > > Signed-off-by: Fabian Grünbichler > --- >

[pve-devel] [PATCH kernel] add apparmor patch to fix recvmsg returning EINVAL

2024-04-10 Thread Wolfgang Bumiller
rly. Signed-off-by: Wolfgang Bumiller --- ...pect-msg_namelen-0-for-recvmsg-calls.patch | 31 +++ 1 file changed, 31 insertions(+) create mode 100644 patches/kernel/0012-apparmor-expect-msg_namelen-0-for-recvmsg-calls.patch diff --git a/patches/kernel/0012-apparmor-expect-msg_name

Re: [pve-devel] [PATCH qemu v2 07/21] PVE backup: add fleecing option

2024-04-10 Thread Wolfgang Bumiller
On Wed, Apr 10, 2024 at 11:30:59AM +0200, Fiona Ebner wrote: > Am 08.04.24 um 14:45 schrieb Wolfgang Bumiller: > > On Fri, Mar 15, 2024 at 11:24:48AM +0100, Fiona Ebner wrote: > >> @@ -581,6 +682,14 @@ static void create_backup_jobs_bh(void *opaque) { > >> aio_c

Re: [pve-devel] [PATCH manager v2 13/21] api: backup/vzdump: add permission check for fleecing storage

2024-04-10 Thread Wolfgang Bumiller
On Wed, Apr 10, 2024 at 11:57:37AM +0200, Fiona Ebner wrote: > Am 08.04.24 um 10:47 schrieb Wolfgang Bumiller: > > On Fri, Mar 15, 2024 at 11:24:54AM +0100, Fiona Ebner wrote: > >> @@ -52,6 +52,12 @@ sub assert_param_permission_common { > >> if (grep { defined

[pve-devel] applied: [PATCH pve-storage] esxi: add mapping for windows server 2016/2019

2024-04-09 Thread Wolfgang Bumiller
applied, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied-series: [PATCH v3 container 0/2] fix #5160: fix move_mount regression for mount point hotplug

2024-04-09 Thread Wolfgang Bumiller
applied both patches, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH backup-qemu] make capi_types module public

2024-04-09 Thread Wolfgang Bumiller
applied, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH v2 container 1/2] fix #5160: fix move_mount regression for mount point hotplug

2024-04-09 Thread Wolfgang Bumiller
looks mostly good, just the ExecStartPre= lines in the service files should be dropped On Mon, Mar 25, 2024 at 06:28:28PM +0100, Filip Schauer wrote: > Set up an Apparmor profile to allow moving mounts for mount point > hotplug. > > This fixes a regression caused by > kernel commit 157a3537d6

Re: [pve-devel] [PATCH qemu v2 07/21] PVE backup: add fleecing option

2024-04-08 Thread Wolfgang Bumiller
On Fri, Mar 15, 2024 at 11:24:48AM +0100, Fiona Ebner wrote: > When a fleecing option is given, it is expected that each device has > a corresponding "-fleecing" block device already attached, except for > EFI disk and TPM state, where fleecing is never used. > > The following graph was adapted

Re: [pve-devel] [PATCH manager v2 13/21] api: backup/vzdump: add permission check for fleecing storage

2024-04-08 Thread Wolfgang Bumiller
On Fri, Mar 15, 2024 at 11:24:54AM +0100, Fiona Ebner wrote: > Similar to how Datastore.AllocateSpace is required for the backup > storage, it should also be required for the fleecing storage. > > Removing a fleecing storage from a job does not require more > permissions than for modifying the

Re: [pve-devel] GET /access/users/{userid} has parameter 'tokens' with 'additionalProperties' containing object definition

2024-04-02 Thread Wolfgang Bumiller
On Tue, Apr 02, 2024 at 09:27:57AM +0200, Fabian Grünbichler wrote: > > > Jona Draaijer via pve-devel hat am 01.04.2024 > > 22:00 CEST geschrieben: > > Hi, > > > > As per the title, that endpoint has an additionalProperties value that is > > not a bool, but rather an object definition. (It's

[pve-devel] applied-series: [PATCH v2 pve-esxi-import-tools 0/7] Improve listvms.py

2024-03-27 Thread Wolfgang Bumiller
applied series, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH v1 pve-esxi-import-tools 4/5] listvms: add arg parser, context manager for connections, fetch helper

2024-03-20 Thread Wolfgang Bumiller
On Tue, Mar 19, 2024 at 04:32:49PM +0100, Max Carrara wrote: > +@contextmanager > +def connect_to_esxi_host(args: EsxiConnectonArgs) -> vim.ServiceInstance: > +"""Opens a connection to an ESXi host with the given username and > password > +contained in the password file. > +""" > +

Re: [pve-devel] [PATCH storage 1/1] storage/plugins: pass scfg to parse_volname

2024-03-13 Thread Wolfgang Bumiller
On Tue, Mar 05, 2024 at 12:13:05PM +0100, Thomas Lamprecht wrote: > Am 23/02/2024 um 10:24 schrieb Roland Kammerer: > > This passes the well known $scfg to parse_volname and bumps the API > > versions accordingly. This allows plugins to access their configuration > > if necessary. > > We

[pve-devel] applied: [PATCH proxmox] proxmox-acme: add api-types feature

2024-03-07 Thread Wolfgang Bumiller
applied, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH proxmox] proxmox-acme: derive PartialEq for API types

2024-03-07 Thread Wolfgang Bumiller
applied, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH pve-common] ticket: remove fallback for SHA1-base64 CSRF prevention tokens

2024-03-06 Thread Wolfgang Bumiller
applied, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH container] fix #5194: delete environment variables set by pve

2024-01-26 Thread Wolfgang Bumiller
On Fri, Jan 26, 2024 at 12:39:17PM +0100, Folke Gleumes wrote: > On Tue, 2024-01-23 at 10:51 +0100, Fabian Grünbichler wrote: > > On January 22, 2024 11:12 am, Folke Gleumes wrote: > > > proxmox-perl-rs set's SSL_CERT_{DIR,FILE}, which can break ssl in > > > containers if their certificate store

[pve-devel] applied: [PATCH v2 proxmox 01/22] notify: include 'hostname' metadata field for forwarded mails

2024-01-10 Thread Wolfgang Bumiller
applied all 3 proxmox-notify patches, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied-series: [PATCH proxmox v2 1/2] notify: smtp: forward original message instead nesting

2024-01-10 Thread Wolfgang Bumiller
applied both patches, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied-series: [PATCH proxmox v2 1/2] notify: api: allow resetting built-in targets if used by a matcher

2024-01-10 Thread Wolfgang Bumiller
applied both patches, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH proxmox 1/2] notify: smtp: forward original message instead nesting

2024-01-09 Thread Wolfgang Bumiller
On Wed, Dec 13, 2023 at 05:42:00PM +0100, Lukas Wagner wrote: > For mails forwarded by `proxmox-mail-forward` to an SMTP target, the > original message was nested as a 'message/rfc822' message part. > Originally this approach was chosen to avoid having to rewrite > message headers. > Good

Re: [pve-devel] [PATCH proxmox 1/2] notify: api: allow resetting built-in targets when they are referenced

2024-01-09 Thread Wolfgang Bumiller
On Thu, Dec 14, 2023 at 01:42:07PM +0100, Lukas Wagner wrote: > by a matcher. ^ this line should be part of the subject > > In the 'delete'-handler targets, we check if a > target is still referenced by a matcher - if it is, we return an > error. For built-in targets, this is actually not

[pve-devel] applied-series: [PATCH proxmox v2 0/5] sys: email: always format 'Date' header with C locale

2024-01-08 Thread Wolfgang Bumiller
applied series, thanks not 100% sure about the `C` const - might be nice to instead have a static Lazy C to get via `Locale::c()` but that can happen later... ___ pve-devel mailing list pve-devel@lists.proxmox.com

Re: [pve-devel] [PATCH access-control] fix #5136: ldap: Decode non-ASCII characters in attributes

2024-01-08 Thread Wolfgang Bumiller
On Wed, Dec 20, 2023 at 03:37:03PM +0100, Filip Schauer wrote: > Decode non-ASCII character when syncing user attributes, since those decode *how*? > will be encoded later on. Without this fix the attributes where encoded > twice, resulting in cases such as 'ü' turning into 'ü'. > >

[pve-devel] applied: [PATCH common 0/4] fix #5141: fix parsing of explicit vlan devices

2024-01-03 Thread Wolfgang Bumiller
applied series, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH docs] qm-cloud-init: make install inside VM more obvious

2024-01-03 Thread Wolfgang Bumiller
applied, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH pve-manager 1/1] report: add packet counter to iptables output

2024-01-03 Thread Wolfgang Bumiller
applied, thanks On Wed, Jan 03, 2024 at 09:53:30AM +0100, Hannes Duerr wrote: > Signed-off-by: Hannes Duerr > --- > > The additional information can help with debugging firewall rules, as > one can see how many times a specified rule got hit > > PVE/Report.pm | 2 +- > 1 file changed, 1

[pve-devel] applied: [PATCH v2 qemu-server] fix #4501: TCP migration: start vm: move port reservation and usage closer together

2024-01-03 Thread Wolfgang Bumiller
applied, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH pve-network] sdn: allow deletion of empty subnet with gateway

2023-11-22 Thread Wolfgang Bumiller
applied, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH pve-network] subnets: only delete macs.db entries if mac is available

2023-11-22 Thread Wolfgang Bumiller
applied, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH network 5/7] api: handle delete parameter when updating ipams

2023-11-22 Thread Wolfgang Bumiller
this is for completeness, currently no plugin has optional properties... Signed-off-by: Wolfgang Bumiller --- src/PVE/API2/Network/SDN/Ipams.pm | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/PVE/API2/Network/SDN/Ipams.pm b/src/PVE/API2/Network/SDN/Ipams.pm index d6e0bc8

[pve-devel] [PATCH network 6/7] api: handle delete parameter when updating dns entries

2023-11-22 Thread Wolfgang Bumiller
Signed-off-by: Wolfgang Bumiller --- src/PVE/API2/Network/SDN/Dns.pm | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/PVE/API2/Network/SDN/Dns.pm b/src/PVE/API2/Network/SDN/Dns.pm index 3d08552..826d111 100644 --- a/src/PVE/API2/Network/SDN/Dns.pm +++ b/src/PVE/API2/Network/SDN

[pve-devel] [PATCH network 1/7] Revert "sdn: require ipam in simple plugin for dhcp"

2023-11-22 Thread Wolfgang Bumiller
This reverts commit 53ab1495621f46c8af4dc560905f7e501bee75a7. This also affects the updateSchema which is not intentional, since the update API calls are supposed to take changes, not full replacements. Signed-off-by: Wolfgang Bumiller --- src/PVE/Network/SDN/Zones/SimplePlugin.pm | 1 - 1

[pve-devel] [PATCH network 3/7] api: take partial configs for PUT /cluster/sdn/vnets/

2023-11-22 Thread Wolfgang Bumiller
Handle 'delete' parameter and partial updates. See previous commit for explanation. Cc: Alexandre Derumier Signed-off-by: Wolfgang Bumiller --- src/PVE/API2/Network/SDN/Vnets.pm | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/src/PVE/API2/Network

[pve-devel] applied-series: [PATCH network 0/7] PUT API endpoint changes

2023-11-22 Thread Wolfgang Bumiller
in this series: - /cluster/sdn/ipams/ - /cluster/sdn/dns/ - /cluster/sdn/controllers/ Wolfgang Bumiller (7): Revert "sdn: require ipam in simple plugin for dhcp" api: take partial configs for PUT /cluster/sdn/zones/ api: take partial configs for PUT /cluster/sdn/vnets/ api: take parti

[pve-devel] [PATCH network 7/7] api: handle delete parameter when updating controllers

2023-11-22 Thread Wolfgang Bumiller
Signed-off-by: Wolfgang Bumiller --- src/PVE/API2/Network/SDN/Controllers.pm | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/PVE/API2/Network/SDN/Controllers.pm b/src/PVE/API2/Network/SDN/Controllers.pm index d8f18ab..0540a65 100644 --- a/src/PVE/API2/Network/SDN/Controllers.pm

[pve-devel] [PATCH network 4/7] api: take partial configs for PUT /cluster/sdn/vnets//subnets/

2023-11-22 Thread Wolfgang Bumiller
Handle 'delete' parameter and partial updates. See 2 commits earlier for explanation. Cc: Alexandre Derumier Signed-off-by: Wolfgang Bumiller --- src/PVE/API2/Network/SDN/Subnets.pm | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/PVE/API2/Network/SDN

[pve-devel] [PATCH network 2/7] api: take partial configs for PUT /cluster/sdn/zones/

2023-11-22 Thread Wolfgang Bumiller
for automation tools (the web UI already passed the full config each time). Cc: Alexandre Derumier Signed-off-by: Wolfgang Bumiller --- src/PVE/API2/Network/SDN/Zones.pm | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/src/PVE/API2/Network/SDN/Zones.pm b/src

[pve-devel] applied-series: [PATCH v4 qemu-server 21/33] vmnic add|remove : add|del ip in ipam

2023-11-21 Thread Wolfgang Bumiller
applied qemu-server series (also with a small $have_sdn guard fixup ;-) ) thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH pve-network] dhcp: fix allocating IP for every defined dhcp-range

2023-11-21 Thread Wolfgang Bumiller
applied, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied-series: [PATCH v4 pve-container 27/33] nic hotplug : add|del ips in ipam

2023-11-21 Thread Wolfgang Bumiller
applied container series with a small `$have_sdn` guard fixup ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied-series: [PATCH pve-network 1/2] sdn: require ipam in simple plugin for dhcp

2023-11-21 Thread Wolfgang Bumiller
applied both, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH v6 container] Add device passthrough

2023-11-20 Thread Wolfgang Bumiller
applied, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied-series: [PATCH access-control/manager 0/4] fix #1148: nested pools

2023-11-20 Thread Wolfgang Bumiller
applied series, bumped access control and manager's dep on it On Mon, Nov 20, 2023 at 08:22:38AM +0100, Fabian Grünbichler wrote: > this series extends the poolname to allow (for now) two '/' inside the > name to nest pools like this: > > parent/child/grandchild > > since '/' is a bad character

[pve-devel] applied: [PATCH container v2] setup: fix architecture detection for NixOS containers

2023-11-17 Thread Wolfgang Bumiller
applied, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager 2/2] ui: fw: allow selecting network interface for rules using combogrid

2023-11-17 Thread Wolfgang Bumiller
just some thoughts from my side: On Thu, May 11, 2023 at 11:46:20AM +0200, Christoph Heiss wrote: > For nodes, VMs and CTs we can show the user a list of available network > interfaces (as that information is available) when creating a new > firewall rule, much like it is already done in similar

Re: [pve-devel] [RFC qemu-server 3/4] fix #4474: qemu api: add overrule-shutdown parameter to stop endpoint

2023-11-17 Thread Wolfgang Bumiller
; > Passing `overrule-shutdown=1` is forbidden for HA resources. > > Signed-off-by: Friedrich Weber Acked-by: Wolfgang Bumiller > --- > PVE/API2/Qemu.pm | 16 +++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qem

Re: [pve-devel] [RFC container 2/4] fix #4474: lxc api: add overrule-shutdown parameter to stop endpoint

2023-11-17 Thread Wolfgang Bumiller
On Thu, Jan 26, 2023 at 09:32:12AM +0100, Friedrich Weber wrote: > The new `overrule-shutdown` parameter is boolean and defaults to 0. If > it is 1, all active `vzshutdown` tasks by the current user for the same > CT are aborted before attempting to stop the CT. > > Passing `overrule-shutdown=1`

Re: [pve-devel] [RFC guest-common 4/4] guest helpers: add helper to overrule active tasks of a specific type

2023-11-17 Thread Wolfgang Bumiller
Patch itself LGTM, just a note on sending patch series in general: If you number patches throughout a whole series rather than the individual repositories (as in, this one is labeled 4/4 instead of 1/1), it would be nice if the order also helps determine dependencies. Since the sub introduced

Re: [pve-devel] [RFC manager/container/qemu-server/guest-common 0/4] fix #4474: stop tasks may overrule shutdown tasks

2023-11-17 Thread Wolfgang Bumiller
On Wed, Sep 27, 2023 at 11:04:26AM +0200, Friedrich Weber wrote: > Lost track of this a bit, reviving due to user interest [1]. > > As the series does not apply anymore, I'll send a new version in any > case, but wanted to ask for feedback before I do. > > My questions from the cover letter

Re: [pve-devel] [PATCH manager 1/2] api: pools: support nested pools

2023-11-17 Thread Wolfgang Bumiller
minor issue On Fri, Nov 17, 2023 at 08:09:10AM +0100, Fabian Grünbichler wrote: > since poolid can now contain `/`, it's not possible to use it (properly) as > path parameter anymore. > > accordingly: > - merge `read_pool` (`GET /pools/{poolid}`) into 'index' (`GET > /pools/?poolid={poolid}`)

Re: [pve-devel] [PATCH access-control 2/2] pools: record parent/subpool information

2023-11-17 Thread Wolfgang Bumiller
On Thu, Nov 16, 2023 at 04:31:26PM +0100, Fabian Grünbichler wrote: > and ensure a missing intermediate pool exists at all times. > > Signed-off-by: Fabian Grünbichler > --- > > Notes: > a "missing link" should never happen when modifying via the API (both > deletion > with children

Re: [pve-devel] [PATCH access-control 1/2] allow up to three levels of pool nesting

2023-11-17 Thread Wolfgang Bumiller
On Thu, Nov 16, 2023 at 04:31:25PM +0100, Fabian Grünbichler wrote: > with ACLs being inherited along the pool hierarchy. > > Signed-off-by: Fabian Grünbichler > --- > src/PVE/AccessControl.pm | 10 -- > src/test/perm-test6.pl | 16 > src/test/test6.cfg | 5

Re: [pve-devel] [PATCH dnsmasq 0/1] purge previous ip/mac lease of dhcp reply

2023-11-17 Thread Wolfgang Bumiller
On Fri, Nov 17, 2023 at 06:49:27AM +, DERUMIER, Alexandre wrote: > Message initial > De: "DERUMIER, Alexandre" > À: pve-devel@lists.proxmox.com , > aderum...@odiso.com , s.hanre...@proxmox.com > > Objet: Re: [pve-devel] [PATCH dnsmasq 0/1] purge previous ip/mac lease > of

Re: [pve-devel] [PATCH v5 container] Add device passthrough

2023-11-16 Thread Wolfgang Bumiller
On Thu, Nov 16, 2023 at 12:50:44PM +0100, Filip Schauer wrote: > Add a dev[n] argument to the container config to pass devices through to > a container. A device can be passed by its path. Additionally the access > mode, uid and gid can be specified through their respective properties. > >

Re: [pve-devel] [PATCH v4 container 1/1] Add device passthrough

2023-11-16 Thread Wolfgang Bumiller
On Wed, Nov 15, 2023 at 03:14:50PM +0100, Thomas Lamprecht wrote: > concept wise this looks pretty much OK, but a few (mostly code-style) > comments in line > > Am 13/11/2023 um 11:30 schrieb Filip Schauer: > > diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm > > index 56e1f10..9f325f2

Re: [pve-devel] [RFC qemu-server 1/1] partially fix #4501: migration: start vm: move port reservation and usage closer together

2023-11-15 Thread Wolfgang Bumiller
On Wed, Nov 15, 2023 at 11:22:46AM +0100, Fiona Ebner wrote: > Am 15.11.23 um 11:12 schrieb Wolfgang Bumiller: > > > > What about adding an option to `next_migrate_port()` to actually return > > the open socket to keep the reservation? > > > > Also, did we con

Re: [pve-devel] [RFC qemu-server 1/1] partially fix #4501: migration: start vm: move port reservation and usage closer together

2023-11-15 Thread Wolfgang Bumiller
On Wed, Nov 15, 2023 at 09:55:22AM +0100, Fabian Grünbichler wrote: > On November 14, 2023 3:02 pm, Fiona Ebner wrote: > > Currently, volume activation, PCI reservation and resetting systemd > > scope happen in between and the 5 second expiretime used for port > > reservation might not be enough.

Re: [pve-devel] [PATCH common 4/4] section config: add tests for separated property lists

2023-11-15 Thread Wolfgang Bumiller
On Tue, Nov 14, 2023 at 11:33:39AM +0100, Dominik Csapak wrote: > more or less a copy from the normal section config test, but now with > properties defined multiple times as well as conflicting options > > Signed-off-by: Dominik Csapak > --- > test/Makefile | 1 + >

Re: [pve-devel] [PATCH common 3/4] section config: allow separated property lists for plugins

2023-11-15 Thread Wolfgang Bumiller
On Tue, Nov 14, 2023 at 11:33:38AM +0100, Dominik Csapak wrote: > when using 'init(1)'. This saves the property lists per type instead of > a big one, and using create/updateSchema creates a new schema with the > options as 'oneOf' and/or 'instance-types' (depending if the schemas > match). > >

Re: [pve-devel] [PATCH common 2/4] json schema: implement 'oneOf' schema

2023-11-14 Thread Wolfgang Bumiller
mostly LGTM, just minor things On Tue, Nov 14, 2023 at 11:33:37AM +0100, Dominik Csapak wrote: > a schema can now have the 'oneOf' property which is an array of regular > schemas. In the default case any of that has to match. If the > 'type-property'/'instance-types' are given, only the schema

Re: [pve-devel] applied: [PATCH v4 common 2/2] tools: Add mount flag constants

2023-11-14 Thread Wolfgang Bumiller
On Mon, Nov 13, 2023 at 03:14:47PM +0100, Thomas Lamprecht wrote: > Am 13/11/2023 um 11:30 schrieb Filip Schauer: > > Signed-off-by: Filip Schauer > > --- > > src/PVE/Tools.pm | 31 +++ > > 1 file changed, 31 insertions(+) > > > > > > applied this one already too,

Re: [pve-devel] [PATCH v3 container 1/1] Add device passthrough

2023-11-10 Thread Wolfgang Bumiller
On Tue, Nov 07, 2023 at 02:46:42PM +0100, Filip Schauer wrote: > Add a dev[n] argument to the container config to pass devices through to > a container. A device can be passed by its path. Additionally the access > mode, uid and gid can be specified through their respective properties. > >

Re: [pve-devel] [PATCH v2 container 1/1] Add device passthrough

2023-11-03 Thread Wolfgang Bumiller
On Thu, Nov 02, 2023 at 03:28:22PM +0100, Filip Schauer wrote: > > On 30/10/2023 14:34, Wolfgang Bumiller wrote: > > On Tue, Oct 24, 2023 at 02:55:53PM +0200, Filip Schauer wrote: > > > Add a dev[n] argument to the container config to pass devices through to > >

Re: [pve-devel] [PATCH pve-network] Fix #4917: evpn: forbid vlan-aware bridge

2023-10-31 Thread Wolfgang Bumiller
On Fri, Oct 27, 2023 at 01:53:28PM +0200, Alexandre Derumier wrote: > Do it on vnet update instead throwing a warning at config generation. > > Signed-off-by: Alexandre Derumier > --- > src/PVE/Network/SDN/Zones/EvpnPlugin.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [pve-devel] [PATCH qemu-server] fix #4957: add vendor and product information passthrough for SCSI-Disks

2023-10-31 Thread Wolfgang Bumiller
On Mon, Oct 30, 2023 at 05:30:15PM +0100, Thomas Lamprecht wrote: > I mean, the properties are relatively straight forward, but some commit > message would be still nice to have – e.g., how did you check if the values > propagate into the guest, can this > > On 25/10/2023 14:37, Hannes Duerr

Re: [pve-devel] [PATCH v2 container 1/1] Add device passthrough

2023-10-30 Thread Wolfgang Bumiller
On Tue, Oct 24, 2023 at 02:55:53PM +0200, Filip Schauer wrote: > Add a dev[n] argument to the container config to pass devices through to > a container. A device can be passed by its path. Alternatively a mapped > USB device can be passed through with usbmapping=. > > Signed-off-by: Filip Schauer

Re: [pve-devel] [PATCH v2 guest-common 1/1] Add foreach_passthrough_device

2023-10-30 Thread Wolfgang Bumiller
On Tue, Oct 24, 2023 at 02:55:54PM +0200, Filip Schauer wrote: > Add a function to iterate over passthrough devices of a provided > container config. As container specific code this should be in pve-container. > > Signed-off-by: Filip Schauer > --- > src/PVE/AbstractConfig.pm | 44

Re: [pve-devel] [PATCH RFC container] Add device passthrough

2023-10-20 Thread Wolfgang Bumiller
On Thu, Oct 19, 2023 at 02:18:56PM +0200, Filip Schauer wrote: > Signed-off-by: Filip Schauer > --- > Is it reasonable to add a "dev[n]" argument to the pct.conf, given that > device mount points only allow passing through block devices? Why would they only allow block devices? Also, Dominik

Re: [pve-devel] [PATCH manager v2] fix #4631: ceph: osd: create: add osds-per-device

2023-08-23 Thread Wolfgang Bumiller
On Mon, Aug 21, 2023 at 01:45:54PM +0200, Aaron Lauterer wrote: > Allows to automatically create multiple OSDs per physical device. The > main use case are fast NVME drives that would be bottlenecked by a > single OSD service. > > By using the 'ceph-volume lvm batch' command instead of the

[pve-devel] applied: [PATCH installer] tui: fix search domain parsing from runtime environment info

2023-08-23 Thread Wolfgang Bumiller
applied, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied-series: [PATCH installer 0/2] add stricter checks w.r.t. BIOS boot on 4Kn disks

2023-08-23 Thread Wolfgang Bumiller
applied both patches, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH installer 5/6] sys: block: fix possible use of `undef`-value when detecting disk sizes

2023-08-23 Thread Wolfgang Bumiller
On Wed, Aug 09, 2023 at 03:44:24PM +0200, Christoph Heiss wrote: > `$size` and `$logical_bsize` might get unset if there invalid, but then > are unconditionally converted to an int - which throws an error. > This was reported on the forum by a user [0]. > > Fix it by changing the check a bit to

[pve-devel] applied-series: [PATCH installer 0/6] some small, assorted fixes & cleanups

2023-08-23 Thread Wolfgang Bumiller
applied series ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH proxmox-widget-toolkit] utils: Remove outdated url in comment

2023-08-23 Thread Wolfgang Bumiller
applied, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH pve-docs] website: update external links to www.proxmox.com

2023-08-23 Thread Wolfgang Bumiller
applied, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH dab-pve-appliances] dab.conf: update external links to www.proxmox.com

2023-08-23 Thread Wolfgang Bumiller
applied, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH pve-manager] website: update external links to www.proxmox.com

2023-08-23 Thread Wolfgang Bumiller
applied, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH storage v6 1/1] fix #4849: download-url: allow download and decompression of compressed ISOs

2023-08-23 Thread Wolfgang Bumiller
this one's applied ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [RFC proxmox 4/7] cache: add new crate 'proxmox-cache'

2023-08-22 Thread Wolfgang Bumiller
On Tue, Aug 22, 2023 at 01:33:44PM +0200, Lukas Wagner wrote: (...) > > ... can be replaced as follows, in order to make it similar to > > std::collections::{HashMap, BTreeMap}: > > > > impl> for SharedCache { > > // Returns old value on successful insert, if given > > fn insert(, k: K,

Re: [pve-devel] [RFC proxmox 4/7] cache: add new crate 'proxmox-cache'

2023-08-22 Thread Wolfgang Bumiller
On Tue, Aug 22, 2023 at 12:08:38PM +0200, Max Carrara wrote: > On 8/21/23 15:44, Lukas Wagner wrote: > > For now, it contains a file-backed cache with expiration logic. > > The cache should be safe to be accessed from multiple processes at > > once. > > > > This seems pretty neat! The cache

Re: [pve-devel] [RFC storage/proxmox{, -perl-rs} 0/7] cache storage plugin status for pvestatd/API status update calls

2023-08-22 Thread Wolfgang Bumiller
On Tue, Aug 22, 2023 at 11:17:14AM +0200, Fiona Ebner wrote: > Am 21.08.23 um 15:44 schrieb Lukas Wagner: > > Open questions: > > - not sure what a good expiration time for cached entries is. For > > now I picked 30s, but there was not much thought behind that value. > > > > If operations

Re: [pve-devel] [RFC proxmox 2/7] sys: add make_tmp_dir

2023-08-22 Thread Wolfgang Bumiller
On Mon, Aug 21, 2023 at 03:44:39PM +0200, Lukas Wagner wrote: > Under the hood, this function calls `mkdtemp` from libc. Unfortunatly > the nix crate did not provide bindings for this function, so we have > to call into libc directly. > > Signed-off-by: Lukas Wagner > --- >

[pve-devel] applied: [PATCH pve-kernel] d/rules: disable CONFIG_GDS_FORCE_MITIGATION

2023-08-18 Thread Wolfgang Bumiller
applied, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH pve-kernel] update sources to Ubuntu-5.15.0-82.91

2023-08-18 Thread Wolfgang Bumiller
applied, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH pve-kernel 0/2] cherry-picks and config-options for downfall

2023-08-17 Thread Wolfgang Bumiller
applied, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH kernel] add patch for igc tx timeout issue

2023-08-17 Thread Wolfgang Bumiller
applied yesterday, forgot to reply ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

  1   2   3   4   5   6   >