Gregory P. Smith g...@krypto.org added the comment:
Thanks for the test! I'll take a look and likely commit this later.
--
assignee: - gregory.p.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6610
Changes by Lars Gustäbel l...@gustaebel.de:
--
assignee: - lars.gustaebel
nosy: +lars.gustaebel
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8701
___
Martin v. Löwis mar...@v.loewis.de added the comment:
haypo: what's the relationship?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8678
___
Daniel Urban urban.dani...@gmail.com added the comment:
Sorry, I realized I made a stupid mistake. (I didn't use PyList_Sort to sort
the list in partial_hash.)
Here is the corrected patch.
--
Added file: http://bugs.python.org/file17315/partial_eq_hash_2.diff
Lars Gustäbel l...@gustaebel.de added the comment:
Unfortunately, I cannot reproduce your problem and ask you to please provide
more information. Would it be possible to attach the output or a screenshot
depicting the problem? Which operating system/distribution do you use? Have you
Ronald Oussoren ronaldousso...@mac.com added the comment:
The issue is indeed gone in HEAD. I've also verified the other 3 active
branches.
--
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
___
Python tracker
Ronald Oussoren ronaldousso...@mac.com added the comment:
The attached version should fix the issue found by Stefan. I'm going to do
builds on OSX as well as Linux before committing though.
--
Added file: http://bugs.python.org/file17316/issue7724-v3.patch
Ronald Oussoren ronaldousso...@mac.com added the comment:
I've verified that HEAD for both 3.1 and 3.2 build fine now, hence this issue
can be closed.
--
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
___
Python
New submission from anatoly techtonik techto...@gmail.com:
If source/target file for unified format diff context doesn't end with new
line, the diff should contain this marker:
\ No newline at end of file
Or else there is information loss when such patch is applied.
Changes by Ronald Oussoren ronaldousso...@mac.com:
--
assignee: - ronaldoussoren
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8455
___
___
New submission from Daniel Urban urban.dani...@gmail.com:
The Py3k documentation of PyList_Type [1] contains the sentence:
This is the same object as list and types.ListType in the Python layer.
But there is no types.ListType object in py3k.
[1]
Changes by R. David Murray rdmur...@bitdance.com:
--
keywords: +easy
type: - behavior
versions: -Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8702
___
Florent Xicluna florent.xicl...@gmail.com added the comment:
afaict, it needs backport to 2.7.
--
components: +Tests
nosy: +flox
stage: - commit review
status: closed - open
type: - crash
versions: +Python 2.7 -Python 3.2
___
Python tracker
Changes by Stefan Krah stefan-use...@bytereef.org:
--
status: pending - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1481
___
___
Changes by Stefan Krah stefan-use...@bytereef.org:
--
nosy: +skrah
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6419
___
___
Python-bugs-list
New submission from Daniel Stutzbach dan...@stutzbachenterprises.com:
If the CGI script crashes before finishing the headers, cgitb will emit invalid
HTTP headers before showing the error message. Below are HTTP headers I
received, captured with a packet sniffer. Note the --: spam.
HTTP/1.1
Changes by Daniel Stutzbach dan...@stutzbachenterprises.com:
--
keywords: +easy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8704
___
___
Mark Dickinson dicki...@gmail.com added the comment:
I think difflib is behaving as intended here; changing to feature request.
Could you please clarify about the information loss? I'm not seeing it. As
far as I can tell, the fact that unified_diff produces a list rather than a
single
Mark Dickinson dicki...@gmail.com added the comment:
It turns out that this problem was already reported in issue 2142 (which has a
patch); closing as a duplicate.
--
resolution: - duplicate
status: open - closed
superseder: - naive use of ''.join(difflib.unified_diff(...)) results
Mark Dickinson dicki...@gmail.com added the comment:
Closed 8702 as a duplicate of this one. Combining nosy lists.
--
nosy: +mark.dickinson, techtonik
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2142
Changes by Mark Dickinson dicki...@gmail.com:
--
versions: +Python 2.7, Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2142
___
___
Stefan Krah stefan-use...@bytereef.org added the comment:
Victor, I think one more skip is required in test_socketserver.
--
nosy: +skrah
resolution: fixed -
status: closed - open
Added file:
http://bugs.python.org/file17317/nothreads-socketserver-shutdown.patch
anatoly techtonik techto...@gmail.com added the comment:
You mean that this patch sits in here for 2 years already? This suxx.
And nobody added the tag 'easy', because people haven't explicitly requested
tracker privileges? That suxx.
And it won't be in 2.7 because of that.. I am
anatoly techtonik techto...@gmail.com added the comment:
Trent, the \ New line... seems to be feature specific to unified format only.
http://en.wikipedia.org/wiki/Diff#Unified_format
--
___
Python tracker rep...@bugs.python.org
anatoly techtonik techto...@gmail.com added the comment:
Another 'easy' patch hangs for ages. =/
tag:easy
tag:difflib
--
nosy: +techtonik
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4898
anatoly techtonik techto...@gmail.com added the comment:
tag:difflib
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7585
___
___
STINNER Victor victor.stin...@haypocalc.com added the comment:
afaict, it needs backport to 2.7.
Right: r81135 (and r81137).
Blocked on 2.6 (it doesn't have the non-ASCII path test): r81139.
--
status: open - closed
___
Python tracker
anatoly techtonik techto...@gmail.com added the comment:
Thanks for the patch. This was fixed as part of issue 7585.
Please add issue 7585 as superceder and close this.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4898
Florent Xicluna florent.xicl...@gmail.com added the comment:
It fails on x86 Tiger trunk buildbot, too.
(the PPC Tiger buildbot is happy)
--
keywords: +buildbot
nosy: +flox
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8084
Daniel Urban urban.dani...@gmail.com added the comment:
On python-dev Yaniv Aknin pointed out that the keywords dictionary of a partial
object is mutable [1]. This causes problems with hashing and equality. The
new patch replaces the keywords dictionary with a read-only proxy of that
New submission from Dan Koch koc...@ornl.gov:
The following sequence raises an exception, but nonetheless removes all files
from the Desktop under Windows Vista.
import os, shutil, user
desktop_dir = os.path.join(user.home, 'Desktop')
os.chdir(desktop_dir)
shutil.rmtree('')
This does not
Mark Dickinson dicki...@gmail.com added the comment:
Hmm. Not in my version of diff: it seems to use '\ No newline at end of file'
for both unified and 'normal' diffs.
$ diff --version
diff (GNU diffutils) 2.8.1
Copyright (C) 2002 Free Software Foundation, Inc.
...
$ diff 1.txt 2.txt
2c2
Changes by Florent Xicluna florent.xicl...@gmail.com:
--
assignee: - ronaldoussoren
components: +Macintosh, Tests
nosy: +flox, mark.dickinson, michael.foord, ned.deily, ronaldoussoren
stage: - needs patch
type: - behavior
versions: +Python 2.7
___
Florent Xicluna florent.xicl...@gmail.com added the comment:
Some diagnosis information ...
- happens for 2 tests inside test_pep277: test_listdir and test_normalize
- happens only for 4 weird filenames (added with #8180)
- happens only on x86 Tiger buildbot (PPC Tiger does not report this
Poor Yorick pooryor...@users.sourceforge.net added the comment:
I can't reproduce it now, either.
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8701
___
Jeffrey Yasskin jyass...@gmail.com added the comment:
Fixed in r81142.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3605
Ronald Oussoren ronaldousso...@mac.com added the comment:
It prefer if it were clear why these tests fail (but don't have time to look
into this at the moment). That is, I don't mind if the tests get disabled on
darwin, but only if there is a documented reason for it because otherwise
New submission from Gregory P. Smith g...@krypto.org:
C Python has a real wart in that standard types and library functions that are
implemented in C do not always accept keyword arguments:
'xx'.find('xx', 4)
4
'xx'.find('xx', start=4)
Traceback (most recent call last):
File stdin,
Daniel Stutzbach dan...@stutzbachenterprises.com added the comment:
After experimenting with changing the order of the multiplications and not
having much luck, I went back and looked for other differences in Alexander's
Python functions that might cause the speed difference. I believe
Marcin Bachry hegel...@gmail.com added the comment:
I wrote a Perl script testing this issue and it fails too, so it's most
probably a bug in sqlite itself. I think the bug is already reported under id
26ff0c82d1 in sqlite bug tracker: http://www.sqlite.org/src/rptview?rn=2
--
nosy:
Alexander Belopolsky belopol...@users.sourceforge.net added the comment:
Daniel,
Your variant does not seem to work:
def partial_product3(j, i):
... a = [l 1 | 1 for l in range(j, i + 1)]
... n = len(a)
... while 1:
... if n == 1:
... return a[0]
...
STINNER Victor victor.stin...@haypocalc.com added the comment:
Support of characters outside the Unicode BMP (code 0x) is not complete
in narrow build (sizeof(Py_UNICODE) == 2) for Python2:
$ ./python
Python 2.7b2+ (trunk:81139M, May 13 2010, 18:45:37)
x=u'\U0001'
x[0], x[1]
Daniel Stutzbach dan...@stutzbachenterprises.com added the comment:
Isn't it amazing how fast one can make incorrect code? ;-)
Here is a fixed version of my partial_product3, but now it is no faster than
partial_product.
def partial_product3(j, i):
a = [l 1 | 1 for l in range(j, i + 1)]
Benjamin Peterson benja...@python.org added the comment:
Fixed in r81145. Thanks.
--
nosy: +benjamin.peterson
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8703
Michele Orrù maker...@gmail.com added the comment:
Unit tests added; tested both on python2.6 and python2.7.
--
nosy: +maker
versions: +Python 2.6
Added file: http://bugs.python.org/file17319/issue1100562.patch
___
Python tracker
Mark Dickinson dicki...@gmail.com added the comment:
Does anyone feel like doing a speed comparison between Daniel's C patch and a
version with a direct no-frills iterative version of factorial_part_product
(i.e., just a simple 'for (i = n; i = m; i += 2) { multiply running product
by i }?
Mark Dickinson dicki...@gmail.com added the comment:
It prefer if it were clear why these tests fail
I agree. There's little point having tests if we're just going to disable them
when they fail without understanding why they're failing first.
At that point a green buildbot just means Hey,
Alexander Belopolsky belopol...@users.sourceforge.net added the comment:
On Thu, May 13, 2010 at 5:31 PM, Mark Dickinson rep...@bugs.python.org wrote:
And why are we trying to speed up the pure Python factorial code here?
I would expect that for large factorials the performance will be
Mark Dickinson dicki...@gmail.com added the comment:
I would expect that for large factorials the performance will be
determined by the number of long multiplications and the size of
multiplicands.
Okay, but I don't think we should care about the performance of *really* large
factorials for
Daniel Stutzbach dan...@stutzbachenterprises.com added the comment:
Speaking of getting side-tracked, I didn't see an answer to a question I asked
earlier. I'd like to get some feedback before I proceed with revising the
patch.
For the find-last-set-bit (to replace log2) and count-set-bits
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
components: +Library (Lib) -None
nosy: +ezio.melotti
stage: unit test needed - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1100562
New submission from INADA Naoki songofaca...@gmail.com:
http://docs.python.org/dev/library/telnetlib.html#telnetlib.Telnet
The part number can be passed to the constructor... is duplicated.
--
assignee: d...@python
components: Documentation
messages: 105667
nosy: d...@python, naoki
Alexander Belopolsky belopol...@users.sourceforge.net added the comment:
On Wed, May 12, 2010 at 3:47 PM, Mark Dickinson rep...@bugs.python.org wrote:
...
Realistically though, I don't see an iterative version of
factorial_part_product as
an option for the C patch, without a significant
Florent Xicluna florent.xicl...@gmail.com added the comment:
The gory details...
import os, unicodedata
tempdir = u'temp_pep277'
name = u'\u0385\u03d3\u03d4'
os.mkdir(tempdir)
with open(os.path.join(tempdir, name), 'w') as f:
... f.write('foo')
unicodedata.normalize('NFD', name)
STINNER Victor victor.stin...@haypocalc.com added the comment:
Patch for Python3:
- Fix PyUnicode_AsWideChar() to support surrogates (Py_UNICODE: 2 bytes,
wchar_t: 4 bytes)
- u_set() of _ctypes uses PyUnicode_AsWideChar()
- add a test (skipped if sizeof(wchar_t) is smaller than 4 bytes)
Brian Curtin cur...@acm.org added the comment:
Value and copy come from multiprocessing.sharedctypes, not from ctypes. Changed
the import and also the test skipping based on this.
(done during a presentation with the Chicago Python Users Group)
--
keywords: +patch
nosy: +brian.curtin
Changes by Brian Curtin cur...@acm.org:
--
keywords: +needs review
stage: needs patch - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8584
___
New submission from Jack Diederich jackd...@gmail.com:
I tried logging into the tracker using my gmail login and accidentally
created a new user. Could someone either wipe out the OpenID for
jackd...@gmail.com (but NOT the jackdied login with email addy of
jackd...@gmail.com) or combine the
Changes by Jack Diederich jackd...@gmail.com:
--
assignee: d...@python - jackdied
nosy: +jackdied
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8707
___
Jack Diederich jackd...@gmail.com added the comment:
Woops, didn't know that email would create a new bug.
--
nosy: +jackdied
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8708
___
STINNER Victor victor.stin...@haypocalc.com added the comment:
Reference about OSX decomposition:
http://developer.apple.com/mac/library/qa/qa2001/qa1173.html
Mac OS X source code:
http://www.opensource.apple.com/source/xnu/xnu-1504.3.12/bsd/vfs/vfs_utfconv.c?txt
--
STINNER Victor victor.stin...@haypocalc.com added the comment:
I fixed the typo in pythonrun.c: r81156. I don't use Windows, so I cannot
review the other fixes.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4653
STINNER Victor victor.stin...@haypocalc.com added the comment:
Here is a patch catching the _PyUnicode_AsString() error.
input() uses sys.stdout.encoding to encode the prompt to a byte string, but
PyOS_StdioReadline() writes the prompt to stderr (it should use sys_stdout).
I don't know which
Brett Cannon br...@python.org added the comment:
OK, my patch is committed:
2.6 81158
2.7 81154
3.1 81159
3.2 81155
I didn't apply your test, Gabriel, as it passed without the fixes. Thanks to
the work you did on it, though.
--
resolution: - fixed
status: open - closed
Changes by Dan Buch daniel.b...@gmail.com:
--
nosy: +meatballhat
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8698
___
___
Python-bugs-list
Changes by Dan Buch daniel.b...@gmail.com:
--
nosy: +meatballhat
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2142
___
___
Python-bugs-list
Changes by Dan Buch daniel.b...@gmail.com:
--
nosy: +meatballhat
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8704
___
___
Python-bugs-list
Changes by Dan Buch daniel.b...@gmail.com:
--
nosy: +meatballhat
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8706
___
___
Python-bugs-list
Alexander Belopolsky belopol...@users.sourceforge.net added the comment:
On Thu, May 13, 2010 at 5:58 PM, Mark Dickinson rep...@bugs.python.org wrote:
 Optimizations that speed up, say, factorial(n) for n = 1000 would seem more
valuable.
I am attaching a variant of my patch which precomputes
Daniel Stutzbach dan...@stutzbachenterprises.com added the comment:
That's a clever idea. Do you have a Python script that generates the
precomputed values?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8692
Daniel Stutzbach dan...@stutzbachenterprises.com added the comment:
It's a little too clever though. It gives the wrong answer for 29!.
I'll have a revised version of my patch done sometime tomorrow.
--
___
Python tracker rep...@bugs.python.org
Alexander Belopolsky belopol...@users.sourceforge.net added the comment:
Oh, my!
How did that last term get into precomputed list?!
It should have been
precomputed[] = {3, 15, 5, 35, 315, 63, 693, 9009, 1287, 19305, 328185, 36465,
692835,
14549535, 1322685, 30421755,
Daniel Stutzbach dan...@stutzbachenterprises.com added the comment:
Attached is a patch to improve the unit tests for the factorial function.
To compute the check value, it keeps a running total instead of recomputing the
factorial from scratch inside the loop. It checks up to range(999) and
Changes by Alexander Belopolsky belopol...@users.sourceforge.net:
Added file: http://bugs.python.org/file17327/factorial-precompute-partials.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8692
Changes by Alexander Belopolsky belopol...@users.sourceforge.net:
Removed file:
http://bugs.python.org/file17327/factorial-precompute-partials.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8692
Changes by Alexander Belopolsky belopol...@users.sourceforge.net:
Removed file:
http://bugs.python.org/file17325/factorial-precompute-partials.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8692
Changes by Alexander Belopolsky belopol...@users.sourceforge.net:
Added file: http://bugs.python.org/file17328/factorial-precompute-partials.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8692
Daniel Stutzbach dan...@stutzbachenterprises.com added the comment:
Attached is a simple bash script to run math.factorial(n) through timeit for
several values of n. It makes comparing the speed of different builds MUCH
easier.
--
Added file:
Alexander Belopolsky belopol...@users.sourceforge.net added the comment:
Mark Does anyone feel like doing a speed comparison between Daniel's C patch
and a version with a direct no-frills iterative version of
factorial_part_product (i.e., just a simple 'for (i = n; i = m; i += 2) {
multiply
Changes by R. David Murray rdmur...@bitdance.com:
--
resolution: - fixed
stage: - committed/rejected
status: open - closed
superseder: - difflib should separate filename from timestamp with tab
___
Python tracker rep...@bugs.python.org
Martin v. Löwis mar...@v.loewis.de added the comment:
I have retired the user Jack.Diederich.
In the future, please use the meta tracker to discuss issues with this tracker.
--
nosy: +loewis -Jack.Diederich
___
Python tracker rep...@bugs.python.org
81 matches
Mail list logo
