Nick Coghlan ncogh...@gmail.com added the comment:
(just reviewing the idea here, not the current patch)
The problem of stale code (i.e. what was executed doesn't match what is
displayed in the traceback) is a tricky and subtle one. There are a few
different cases:
1. Source displayed does
Carl Robben carl.rob...@gmail.com added the comment:
Here's a patch for test_bdist_rpm.py and to check the contents of
dist.dist_files
--
Added file: http://bugs.python.org/file23363/test_bdist_rpm.patch
___
Python tracker rep...@bugs.python.org
Carl Robben carl.rob...@gmail.com added the comment:
Adding a patch for 2.7
--
Added file: http://bugs.python.org/file23364/bdist_rpm-2.7.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2945
Changes by Ezio Melotti ezio.melo...@gmail.com:
Removed file: http://bugs.python.org/file23355/issue12753-4.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12753
___
Changes by Ezio Melotti ezio.melo...@gmail.com:
Added file: http://bugs.python.org/file23365/issue12753-4.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12753
___
Changes by Guandalino guandal...@gmail.com:
--
nosy: +guandalino
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11776
___
___
Python-bugs-list
Changes by Eric V. Smith e...@trueblade.com:
--
nosy: +eric.smith, jason.coombs
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13143
___
___
Ezio Melotti ezio.melo...@gmail.com added the comment:
Attached an updated patch that addresses the comments of Éric in the review and
adds an entry to the whatsnew.
--
assignee: orsenthil - ezio.melotti
keywords: +needs review
nosy: -BreamoreBoy
stage: patch review - commit review
New submission from Graeme Glass graemegl...@gmail.com:
On my machine (Ubuntu 11.04) the link to Python Module Index from the index
page is incorrect in the Indices and tables section (it links to
modindex.html instead of py-modindex.html).
It links to the correct place in the navigation
Nick Coghlan ncogh...@gmail.com added the comment:
No, the naming problem had occurred to me as well. Given the 'vars' builtin,
perhaps 'getclosurevars' would do as the name?
--
___
Python tracker rep...@bugs.python.org
New submission from Sven Marnach s...@marnach.net:
The documentation of PyNumber_ToBase() [1] states
When base is not 2, 8, 10, or 16, the format is 'x#num'
where x is the base.
In reality, the function does not accept any bases different
from 2, 8, 10, or 16, as can be seen in the
Senthil Kumaran sent...@uthcode.com added the comment:
Hi Ezio, I had probably overlooked this one. But It's a very interesting one
for me. Do you mind if I commit it ?
On Oct 10, 2011 7:20 PM, Ezio Melotti rep...@bugs.python.org wrote:
Ezio Melotti ezio.melo...@gmail.com added the comment:
Jason R. Coombs jar...@jaraco.com added the comment:
Thanks Garen for the detailed analysis and writeup. The short answer to your
question is supported by the Python runtime. Allow me to provide a bit of
history.
Symlink awareness under Windows was added to Python in Python 3.2, so the
Meador Inge mead...@gmail.com added the comment:
perhaps 'getclosurevars' would do as the name?
I like vars. Updated patch attached.
--
Added file: http://bugs.python.org/file23368/issue13062-3.patch
___
Python tracker rep...@bugs.python.org
Ezio Melotti ezio.melo...@gmail.com added the comment:
Symlink awareness under Windows was added to Python in Python 3.2
If they are not available on Windows with 2.7, the doc should get an
availability: unix or something similar (depending on where they are actually
supported), or mention
Éric Araujo mer...@netwok.org added the comment:
I made some more comments.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1673007
___
___
Changes by Éric Araujo mer...@netwok.org:
--
keywords: +easy
versions: +Python 2.7, Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11776
___
Éric Araujo mer...@netwok.org added the comment:
You did not reply to my first question on apiref.rst, and you did not rewrap
your lines to 80 chars :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3902
Éric Araujo mer...@netwok.org added the comment:
The bug was encountered while trying to install a package. As it turns
out, a dependency was incorrectly installed, resulting in a null
version being passed around which quickly caused a crash in setup.py.
While this is definitely not a normal
Éric Araujo mer...@netwok.org added the comment:
Looks good. Do you have rpm on your machine? If yes, have you run the tests
successfully?
--
stage: needs patch - patch review
___
Python tracker rep...@bugs.python.org
Éric Araujo mer...@netwok.org added the comment:
Thanks, I will take all contributions and suggestions and propose one patch.
--
assignee: docs@python - eric.araujo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12436
Éric Araujo mer...@netwok.org added the comment:
For new doc editors, it would be nicer if the filename (directory name,
actually)
had been changed to 'py_setup' or even 'py_usage'.
py_setup would conflict with pysetup, the installer part of
distutils2/packaging. py_ seems redundant to me,
Nick Coghlan ncogh...@gmail.com added the comment:
In reviewing Meador's patch (which otherwise looks pretty good), I had a
thought about the functionality and signature of getclosurevars().
Currently, it equates closure to nonlocal scope, which isn't really true -
the function's closure is
Vinay Sajip vinay_sa...@yahoo.co.uk added the comment:
Can you add tests?
https://bitbucket.org/vinay.sajip/pythonv/changeset/f7c5098e3c3b
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12393
M. Zilmer mzdkm...@gmail.com added the comment:
Just to make it clear: I have not observed any problems on the Windows terminal
(cmd) with \n newline, but at least Notepad does not break lines correctly if
only \n is used.
--
___
Python tracker
Mike Hoy mho...@gmail.com added the comment:
Responded to first question in apiref and uploaded a new patch that wraps lines
at 80 characters.
--
Added file: http://bugs.python.org/file23369/apiref-setupscript-v3.diff
___
Python tracker
Changes by Eric Snow ericsnowcurren...@gmail.com:
--
nosy: +eric.snow
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8087
___
___
Python-bugs-list
Terry J. Reedy tjre...@udel.edu added the comment:
I was not necessary suggesting that the filename actually be changed, just that
the mapping between docs and filenames is not always obvious. I will somedays
look at the dev docs doc page and see if I have any further suggestions to help.
Add
New submission from Antoine Pitrou pit...@free.fr:
One of the buildbots recently showed the following failure:
==
ERROR: test_rapid_restart
(test.test_multiprocessing.WithProcessesTestManagerRestart)
Francisco Martín Brugué franci...@email.de added the comment:
The patch is updated. Let me know if I've understood your review.
Thanks !
--
Added file: http://bugs.python.org/file23370/issue12659_v3.patch
___
Python tracker rep...@bugs.python.org
Changes by Ron Adam ron3...@gmail.com:
--
nosy: +ron_adam
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13062
___
___
Python-bugs-list mailing
Ben Gamari bgam...@gmail.com added the comment:
Sorry, no log is available.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13055
___
___
New submission from Jakub Gedeon kazagis...@gmail.com:
Multiprocessing Pool.map_async() does not have an error_callback paramter as
described here
http://docs.python.org/library/multiprocessing.html#multiprocessing.pool.multiprocessing.Pool.map_async
I assume this is an old configuration that
Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
*Very* good news for lzma on windows: The precompiled static library liblzma.a
works very well with MSVC (tested with VS2008 on Windows XP, 32bit). This was
a surprise for me...
Here is a patch for the win32 build files, to be
Nick Coghlan ncogh...@gmail.com added the comment:
Don't feel bad about not recognising the context - this stuff wasn't documented
at all for a long time, and it wasn't until Georg pointed me to the usage docs
that I realised adding it there would be the right place. I should have
remembered
New submission from Maxim Yanchenko maxim.yanche...@gs.com:
The condition contradicts the exception text:
if (offset = st.st_size) {
PyErr_SetString(PyExc_ValueError,
mmap offset is greater than file size);
return NULL;
Garrett Cooper yaneg...@gmail.com added the comment:
As a note for future reference, FreeBSD/NetBSD/OpenBSD doesn't use the term
bug, but instead uses the term problem report (the NetBSD website says
bug though BTW).
The PR system for NetBSD can be accessed here:
Antoine Pitrou pit...@free.fr added the comment:
Well, you have to understand what this code does: it tries to prevent
non-meaningful offsets. If the offset is equal to the file size, mapping from
that offset would not map anything in the file (and the system call may
actually fail).
New submission from Antoine Pitrou pit...@free.fr:
io.StringIO is quite slower than ''.append() when used for mass concatenation
(around 5x slower). This patch brings it to similar performance by deferring
construction of the internal buffer until needed.
The problem is that it's very easy to
Maxim Yanchenko maxim.yanche...@gs.com added the comment:
First of all, it doesn't fail (at least on Linux), I tested it before posting.
And the latest, it's not like I'm just stalking around and reading Python
sources for fun. It's a real and pretty valid case, I hit it while upgrading
our
Antoine Pitrou pit...@free.fr added the comment:
I don't think it makes sense to accept mmap'ing empty contents when at offset
n but not at offset n + 1. Either we remove the check entirely and let
people deal with the consequences, or we keep the check as-is.
--
nosy: +neologix
Maxim Yanchenko maxim.yanche...@gs.com added the comment:
Well, n+1 is clearly outside the file, wile n is within and therefore valid.
Also, if your position is to forbid zero-size mmapping completely, then the
checks inside if (map_size == 0) { don't make any sense, especially as they
may or
Changes by Ezio Melotti ezio.melo...@gmail.com:
Removed file: http://bugs.python.org/file23365/issue12753-4.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12753
___
Changes by Ezio Melotti ezio.melo...@gmail.com:
Added file: http://bugs.python.org/file23374/issue12753-4.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12753
___
Antoine Pitrou pit...@free.fr added the comment:
Here is a patch for import.c.
--
keywords: +patch
Added file: http://bugs.python.org/file23375/importrename.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13146
Ezio Melotti ezio.melo...@gmail.com added the comment:
(I had to re-upload the patch a couple of time to get the review button to
work. Apparently if there are some conflicts rietveld fails to apply the
patch, whereas hg is able to merge files without problems here. Sorry for the
noise.)
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
assignee: ezio.melotti - orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1673007
___
New submission from Antoine Pitrou pit...@free.fr:
sysconfig is imported and used by site.py.
$ time ./python -S -c ''
real0m0.019s
user0m0.013s
sys 0m0.005s
$ time ./python -S -c 'import sysconfig'
real0m0.047s
user0m0.046s
sys 0m0.002s
$ time ./python -S -c 'import
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
nosy: +ezio.melotti
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13150
___
___
Ezio Melotti ezio.melo...@gmail.com added the comment:
We have discussed the API a bit on IRC and these are the outcomes:
1) should method always have priority or should 'POST' always be used whenever
data is passed?
2) if the method is e.g. 'GET' and data is passed, should an error be raised?
Terry J. Reedy tjre...@udel.edu added the comment:
That was the page I said I would look at. My suggest is that one or more of the
directory entries could have either a bit more information about the directory
or a More info link to a separate page. As a remember, files for modules were
named
Senthil Kumaran sent...@uthcode.com added the comment:
Our discussion stemmed from this point. If you look at the change proposed,
Request class is taking a new parameter by name 'method' and it is initialized
to None:
class Request:
def __init__(self, url, data=None, headers={},
-
52 matches
Mail list logo
