Georg Brandl added the comment:
And please don't commit cosmetic/cleanup changes to bugfix branches in the
future.
--
nosy: +georg.brandl
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16793
Roundup Robot added the comment:
New changeset c0266ba8e4c6 by Serhiy Storchaka in branch '2.7':
Issue #16761: Raise TypeError when int() or long() called with base argument
only.
http://hg.python.org/cpython/rev/c0266ba8e4c6
New changeset e4ea38a92c4d by Serhiy Storchaka in branch '3.2':
Serhiy Storchaka added the comment:
When this patch is updated because of the commit for issue 16790, in 3.x can
the edited test cases be moved to the top of the test class per the following
comment (as appropriate)?
I will do this in issue16784. In any case I am going to move a large part
Raymond Hettinger added the comment:
Why did you backport this change after being advised not to do it?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16761
___
Ned Deily added the comment:
Andrew, comments to closed issues are usually ignored. I suggest you open a
new issue about this. A quick glance suggests that the code for this feature
is not in Python 3. It may be that it was lost when, during the 2.7
development cycle, it was decided to not
Mark Dickinson added the comment:
I'd suggest leaving 3.2 and 3.3 as they are: the bug is fairly benign, but
fixing it could break existing code unnecessarily. That's something that we
should try hard not to do in a bugfix release.
As to PyNumber_AsSsize_t() used instead
Mark Dickinson added the comment:
The only difference with previous code is that now OverflowError raised for
large bases instead of ValueError.
Serhiy: can you clarify this remark? Where do you see the OverflowError? The
current exception and message look fine to me, so maybe I'm
Mark Dickinson added the comment:
I actually think this issue can be closed as fixed:
Ah, whoops; I failed to understand Serhiy's comment about the still existing
if (!PyLong_Check(obase)), which does indeed mean that the code *still*
doesn't work for __index__-able types.
Here's a fix for
Changes by Mark Dickinson dicki...@gmail.com:
--
assignee: serhiy.storchaka - mark.dickinson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16772
___
Chris Jerdonek added the comment:
I actually think this issue can be closed as fixed: the current code looks
fine to me, and I don't think the fix should be backported.
How about backporting the tests? In addition to adding tests for the fix, Greg
added more comprehensive tests for the
Mark Dickinson added the comment:
Sure, I don't see any issue with backporting test_int_base_limits; that has
little to do with this issue, though, so shouldn't prevent closing this one.
I'll add a Misc/NEWS entry when I commit; not sure it's meaningful to add doc
changes, since I the 3.2
Mark Dickinson added the comment:
Patch including doc update.
--
Added file: http://bugs.python.org/file28466/issue16772_v2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16772
___
New submission from Larry Hastings:
The line declaring the function dbm.open looks like this:
def open(file, flag='r', mode=0o666):
The docstring for dbm.open looks like this:
open(file, flag='r', mode=438)
Obviously 438==0o666. But the author used the octal representation because
Larry Hastings added the comment:
(I was also considering proposing using annotations to tell the parser we want
the original representation in the docstring, but I suspect that's a bad idea.
That would instantly restrict the untamed frontier that is annotations.)
--
Mark Dickinson added the comment:
It's an interesting idea. This sounds like the wrong solution to me, though:
it's significant extra machinery to produce a solution that only fixes a small
handful of cases; IOW, the benefit / cost ratio seems to small to make this
worth it. E.g., apart
Antoine Pitrou added the comment:
What is the point of having heapq.heappush under a lock if heapq.heappop in
another method is not protected? The logic doesn't seem to make sense.
--
___
Python tracker rep...@bugs.python.org
Changes by Daniel Shahaf pyt...@danielsh.fastmail.net:
--
nosy: +danielsh
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16379
___
___
New submission from Richard Oudkerk:
The actual signature is
socket.socket(family=AF_INET, type=SOCK_STREAM, proto=0, fileno=None)
but the documented signature is
socket.socket([family[, type[, proto]]])
Should the fileno argument be documented or is it considered an implementation
Serhiy Storchaka added the comment:
Of course. Thanks for point. It's my editor made wrong whitespace changes after
block indent/unindent. hg diff shows this changes and I shouldn't miss this.
I will review every patch before commit one more time.
--
Charles-François Natali added the comment:
A couple of years ago I conducted similar tests and it turned out that 64k
was the best compromise:
http://code.google.com/p/pyftpdlib/issues/detail?id=94
Twisted uses 128k.
I'd be for using 64k and also change asynchat.async_chat.ac_*_buffer_size
R. David Murray added the comment:
If it is a feature, then is it documented in the language reference and is this
actually a bug in PyPy (it sounds like it is)?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16791
Serhiy Storchaka added the comment:
fout.close() here is intentional no-op. This is a check that fout was closed
properly (in contrary case close() should raise exception). Unfortunately there
is no other way to test that fout was closed.
--
___
R. David Murray added the comment:
I don't think you mean 'docstring'. A docstring is something a human writes in
the source code. I presume you are actually talking about introspection of the
signature here. Beyond that, I agree with Mark's comments.
--
nosy: +r.david.murray
Mark Dickinson added the comment:
It looks to me as though this has nothing to do with itertools In CPython 2.7:
Python 2.7.3 |EPD 7.3-1 (32-bit)| (default, Apr 12 2012, 11:28:34)
[GCC 4.0.1 (Apple Inc. build 5493)] on darwin
Type credits, demo or enthought for more information.
b = [1]
b
Mark Dickinson added the comment:
And here's a non-infinite example where CPython and PyPy differ.
Python 2.7.3 |EPD 7.3-1 (32-bit)| (default, Apr 12 2012, 11:28:34)
[GCC 4.0.1 (Apple Inc. build 5493)] on darwin
Type credits, demo or enthought for more information.
b = [1]
b += (x+1 for x in
Mark Dickinson added the comment:
Opened https://bugs.pypy.org/issue1355 for this.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16791
___
___
Giampaolo Rodola' added the comment:
IMO no. asyncore.dispatcher_with_send should not exist in the first place as it
basically is a castrated version of asynchat.async_chat with less capabilities.
I'd say it's there only for an historical reason.
Moving ac_*_buffer_size to asyncore.dispatcher
Mark Dickinson added the comment:
BTW, in case it saves anyone else some time, the current machinery is in
Lib/pydoc.py, in the `TextDoc.docroutine` method. It uses
inspect.getfullargspec to retrieve the information to format, though I guess
using inspect.Signature would be the modern way to
Mark Dickinson added the comment:
Bah. s/inspect.Signature/inspect.signature/
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16801
___
___
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16802
___
___
Serhiy Storchaka added the comment:
Good point. Here is updated patch.
--
Added file:
http://bugs.python.org/file28467/itertools_tee_nonrecursive_clear_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13454
Antoine Pitrou added the comment:
I agree that 64K seems better here (on Linux).
There is another problem with dispatcher_with_send: the buffering algorithm
(both when appending and popping) is quadratic. You can easily observe it with
your test script, when growing the DATA. async_chat looks
Serhiy Storchaka added the comment:
Sorry. I were understand that patches were approved by several core devs. This
issue was created for fixing regression from issue16045, but then I saw yet
some forgotten deprecated asserts. If you want, I will revert this additional
changes in 2.7 and 3.3.
Serhiy Storchaka added the comment:
Sorry, I have not noticed your advice before I did commit (it took me a lot of
time). Should I now revert my changes to 2.7, 3.2 and 3.3?
--
___
Python tracker rep...@bugs.python.org
Charles-François Natali added the comment:
Alright, here's a simple patch bumping the buffers to 64K for asyncore
and asynchat.
There is another problem with dispatcher_with_send: the buffering algorithm
(both when appending and popping) is quadratic. You can easily observe it
with your
Antoine Pitrou added the comment:
support.transient doesn't help here since no exception is raised
An exception can still be raised in do_handshake(), which is called when the
connection succeeds. But, yes, it's otherwise useless.
Note that I'm not sure that connect_ex returning None is
Serhiy Storchaka added the comment:
This heapq.heappop does applied to a copy of self._queue. Copying done under a
lock.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16640
___
Serhiy Storchaka added the comment:
Serhiy: can you clarify this remark? Where do you see the OverflowError?
The current exception and message look fine to me, so maybe I'm
misunderstanding what you're talking about:
Sorry, I have been confused (and confuse you) by the variety of PyLong_As*
Giampaolo Rodola' added the comment:
But even in asynchat, there's a lot of copying going on, length
computations performed twice in a row, etc.
What/where do you mean exactly?
I see little value in focusing efforts towards things such as
initiate_with_send which are not supposed to be used
Roundup Robot added the comment:
New changeset 3436769a7964 by Antoine Pitrou in branch '2.7':
Backport Python 3.2 fix for issue #12065, and add another test for
SSLSocket.connect_ex().
http://hg.python.org/cpython/rev/3436769a7964
--
___
Python
Changes by Tshepang Lekhonkhobe tshep...@gmail.com:
--
nosy: +tshepang
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16799
___
___
Antoine Pitrou added the comment:
Ah, ok. By the way, the queue property says it returns An ordered list, but
it seems to actually return an iterator.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16640
New submission from Brett Cannon:
Need to do some work on the importlib tests such that they get run using both
_frozen_importlib and importlib._bootstrap to prevent any drift between
importlib/_bootstrap.py and import.c (and to make it easier to develop).
--
components: Tests
Serhiy Storchaka added the comment:
Perhaps it was inherited from Python 2.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16640
___
___
Andrew Svetlov added the comment:
Good step!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15302
___
___
Python-bugs-list mailing list
Changes by Andrew Svetlov andrew.svet...@gmail.com:
--
nosy: +asvetlov
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16799
___
___
Charles-François Natali added the comment:
What/where do you mean exactly?
187 def push (self, data):
188 sabs = self.ac_out_buffer_size
189 if len(data) sabs:
190 for i in range(0, len(data), sabs):
191
Antoine Pitrou added the comment:
If PyPy gets away with a different behaviour, there's probably nobody relying
on it, so I'd say the backports are safe.
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16761
Giampaolo Rodola' added the comment:
memoryview is also great to avoid copies when sending/receiving to a socket.
That's interesting. How exactly? Would producer_fifo have to change from a
deque() to a memoryview() object? In that case we might have to take backward
compatibility into
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +chris.jerdonek
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16165
___
___
Serhiy Storchaka added the comment:
Sorry, Chris.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16645
___
___
Python-bugs-list mailing list
Serhiy Storchaka added the comment:
Sorry, Chris. I have opened too many browser tabs. ;)
--
nosy: -chris.jerdonek
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16165
___
Serhiy Storchaka added the comment:
What anyone can say about this doc changes?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16642
___
___
Changes by Brett Cannon br...@python.org:
--
nosy: +brett.cannon
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16795
___
___
Python-bugs-list
Ezio Melotti added the comment:
LGTM.
--
nosy: +ezio.melotti, rhettinger
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16642
___
___
Changes by Brett Cannon br...@python.org:
--
nosy: -brett.cannon
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7325
___
___
Python-bugs-list
Brett Cannon added the comment:
Making tests discoverable allows for the future possibility of dropping our
custom test runner code and using more of unittest code by having regrtest use
unittest's discovery code to find all tests.
--
___
Python
Brett Cannon added the comment:
Since http://bugs.python.org/issue10967 is the meta issue for updating regrtest
this can be closed.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
Giampaolo Rodola' added the comment:
New patch in attachment.
It always uses poll() and maintains and internal fd/Connection map.
I get one failure due to the returned list being sorted differently than when
using select() though.
vertograd phrokhladny added the comment:
Re:
2012/12/27 R. David Murray rep...@bugs.python.org
R. David Murray added the comment:
This is a duplicate of issue 10060, and as indicated there there really
isn't much Python can do about this. You should report the bug to Ubuntu,
but I'm
New submission from Antoine Pitrou:
$ python3.4 -S -m site
sys.path = [
'',
'/home/antoine/opt/lib/python34.zip',
'/home/antoine/opt/lib/python3.4/',
'/home/antoine/opt/lib/python3.4/plat-linux',
'/home/antoine/opt/lib/python3.4/lib-dynload',
]
Traceback (most recent call
Terry J. Reedy added the comment:
I should think that the first fix should be to the PEP. If I understand
msg177908, that would mean removing unittest.TestCase as a base for ExampleTest
and adding it as bases for AcceleratedExampleTest and PyExampleTest. Or have I
missed something?
Daniel Shahaf added the comment:
Attached patch that:
- Adds sqlite3.SQLITE_OK constants
- Adds sqlite3.errorcode dictionary
- Adds sqlite_errcode attribute to sqlite.Error instances
The patch does not add support for extended result codes
(http://www.sqlite.org/c3ref/c_abort_rollback.html).
Raymond Hettinger added the comment:
Should I now revert my changes to 2.7, 3.2 and 3.3?
Once committed, I would say leave it in as long as you're confident that no
currently working code will break as a result. In general, be very
conservative about backporting any behavioral change.
R. David Murray added the comment:
That sounds right to me.
Note that PEP 399 is following older conventions that were laid down in a time
when unittest did not *have* test discovery, so this is a new paradigm we'd
like to move to (for the reasons Brett mentioned), and it may take a while to
Daniel Shahaf added the comment:
I didn't compile-test the Doc/ part of the patch.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16379
___
___
Georg Brandl added the comment:
Like Raymond said in the other issue: it's not going to be a problem once
committed, but please be mindful of what you commit to bugfix branches in the
future.
--
___
Python tracker rep...@bugs.python.org
Ezio Melotti added the comment:
And please don't commit cosmetic/cleanup changes to bugfix branches in the
future.
Note that those methods are deprecated and thus raise deprecation warnings when
the tests are run. It's not just a simple cosmetic/cleanup change IMHO.
--
Antoine Pitrou added the comment:
The order of the results is probably unimportant.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10527
___
___
Jason Huntley added the comment:
Finally! I was able to get all building on mingw64, gcc 4.7.2, and python 3.3.
I had to take everybody's work here a little further, and I have produced a new
patch which will build python33 using the latest minw64 compiler in an msys
environment.
I cloned
Charles-François Natali added the comment:
memoryview is also great to avoid copies when sending/receiving to a socket.
That's interesting. How exactly? Would producer_fifo have to change from a
deque() to a memoryview() object? In that case we might have to take backward
compatibility
Chris Jerdonek added the comment:
Another task: backport the tests for current behavior added under issue 16772
(e.g. test_int_base_limits() tests).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16784
Antoine Pitrou added the comment:
Would producer_fifo have to change from a deque() to a memoryview()
object?
A memoryview is not a container, it's a view over an existing container.
In that case we might have to take backward compatibility into account
(producer_fifo already changed in
Georg Brandl added the comment:
That makes it more of a fix, true.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16793
___
___
Python-bugs-list
Terry J. Reedy added the comment:
Antoine: do you know anything about this message?
Fatal Python error: PyEval_RestoreThread: NULL tstate
Is there a serious possibility that it could indicate a CPython error, as
opposed to an extension author error? Could running Windows on Mac hardware
make a
Antoine Pitrou added the comment:
Well, the error message comes from a misuse of the PyEval_RestoreThread() (by
passing it a NULL argument), either directly or by using another API such as
Py_END_ALLOW_THREADS which calls that function. The problem is likely to be in
the Solidoodle extension.
Changes by Vinay Sajip vinay_sa...@yahoo.co.uk:
--
hgrepos: +166
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16778
___
___
Python-bugs-list
Changes by Vinay Sajip vinay_sa...@yahoo.co.uk:
--
keywords: +patch
Added file: http://bugs.python.org/file28472/8756372f0f5f.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16778
___
Chris Jerdonek added the comment:
Improvement of int/long tests should also be reflected in the Tests section of
Misc/NEWS. An entry wasn't added in issue 16045. For linking purposes, this
issue number would probably be the best to use for such an entry.
--
Terry J. Reedy added the comment:
This is at most a further doc clarification issue as the code is working as
documented. In a previous issue, I added the following sentence to all current
versions to try to clarify this type of behavior: If exec gets two separate
objects as globals and
New submission from Tshepang Lekhonkhobe:
I am running Debian 7, which has sphinx is1.1.3+dfsg-4.
When I run
$ python tools/sphinx-build.py -bhtml . build/
I get a whole bunch of errors:
Making output directory...
Running Sphinx v1.1.3
loading pickled environment... not yet created
building
New submission from Carsten Klein:
Given an input module such as
class klass(object):
multi line comment
continued on this line
single line comment
Another multi
line
comment
and implementing a custom ast.NodeVisitor such as
import as
class
Carsten Klein added the comment:
Please note that, regardless of the indent level, the col_offset for multi line
str expressions will always be -1.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16806
Leonardo DaVinci added the comment:
Terry,
I've tried installing on Mac at least 6 times and I still get error
messages. I'm dealing with Solidoodle with no success.
I have an appointment with a 3d Print Lab on Jan 3rd (50 miles away) to
help me resolve my issues.
Regards
Ciro
On Fri, Dec
Antoine Pitrou added the comment:
I've tried installing on Mac at least 6 times and I still get error
messages. I'm dealing with Solidoodle with no success.
I have an appointment with a 3d Print Lab on Jan 3rd (50 miles away) to
help me resolve my issues.
Ciro, it seems you should wait a
Sandro Tosi added the comment:
Hello Tshepang,
the documentation is not compatible with Sphinx versions different than the one
the Makefile will download (in this case it's 1.0.7 for all active branches).
I'd suggest to build the doc with just
$ make -C Doc html
and it will fetch the needed
Eugene Toder added the comment:
To recap, the issue is that pickle doesn't handle recursion via reduce
arguments (i.e. arguments to the constructor function as returned in 2nd
element of the tuple from __reduce__). This leads to 2 kind of effects:
class C:
def __init__(self, x=None):
Changes by Eugene Toder elto...@gmail.com:
--
versions: +Python 3.3, Python 3.4 -Python 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1062277
___
Andrew Svetlov added the comment:
I guess it is actually firewall.
--
nosy: +asvetlov
type: performance - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16758
___
Terry J. Reedy added the comment:
Opening a duplicate issue to rant against the developers is not responsible
behavior. Since you do not seem to understand Martin's 2.x solution, ask for
help on python-list or elsewhere (and read below). The proper fix for multiple
Unicode and text coding
Carsten Klein added the comment:
In addition, the reported lineno will be set to the last line of the multi line
string instead of the first line where parsing the parse began parsing the
string.
--
___
Python tracker rep...@bugs.python.org
Terry J. Reedy added the comment:
You should ask for usage tips on python-list or other forums.
2.6 and 3.1 only get security fixes.
2.7 and 3.2,3.3 only get bug fixes.
This looks like a request for a new feature (assuming that it is not available
now).
I am not familiar with the modules, but I
William D. Colburn added the comment:
I'm ranting against an improper bug closure and bad behavior from the
python sqlite3. Treating invalid data as sometimes valid and sometime
as invalid is a problem. Problems with a Python module are not
anuser-error, they are an implementation error.
Javier Domingo added the comment:
I am currently using a subprocess with a call to xmllint to make it create a
temporal file that gets created on execution for xmllint use.
I have seen about lxml, but I wondered if there is any place in the standard
python to put xml validation
--
R. David Murray added the comment:
It looks like you are correct Terry. The problem, I think, is that the
behavior of name spaces inside a class definition is probably the least
intuitive aspect of python scoping, so that sentence, while technically
complete, doesn't provide enough guidance.
Terry J. Reedy added the comment:
David is correct
dbm.open.__doc__
Open or create database at path given by *file*.\n\nOptional argument
*flag* can be 'r' (default) for read-only access, 'w'\nfor read-write
access of an existing database, 'c' for read-write access\nto a new or
Tshepang Lekhonkhobe added the comment:
It is my preference to be able to build all of CPython with the
already-installed distro packages, instead of pulling in foreign ones.
Any reason why not use later versions? Can't the docs be written such
that they can run on various versions of these
New submission from Dougal Sutherland:
If you wrap a mutually exclusive group inside an argument group in an
argparse.ArgumentParser, and then use parents= to inherit from that parser, the
non-exclusive argument group is forgotten in the help output, and the arguments
move to the default
Terry J. Reedy added the comment:
To me the doc strongly implies, but does not boldly and baldly say, that base
should be an int.
A base-n literal consists of the digits 0 to n-1, with a to z (or A to Z)
having values 10 to 35. The default base is 10. The allowed values are 0 and
2-36.
Chris Jerdonek added the comment:
Here is a patch to start using a Namespace object.
I also noticed that the usage() function I removed in 6e2e5adc0400 is still
used elsewhere in regrtest.main(), so this patch also fixes that.
--
keywords: +patch
Added file:
1 - 100 of 136 matches
Mail list logo
