Serhiy Storchaka added the comment:
I don't really understand your algorithm. Why do you need a stack?
Before resolving the symlink we mark the path as unresolved symlink for
detecting infinite symlink loops. Before resolving the symlink we mark the path
as resolved symlink (and cache the
New submission from Ramchandra Apte:
This bug is intended to contain all the patches for fixing PEP8 errors in
stdlib.
I am thinking of using a tool such as autopep8 to help fix the errors.
--
messages: 179921
nosy: ramchandra.apte
priority: normal
severity: normal
status: open
title:
Ramchandra Apte added the comment:
s/stdlib/everywhere
--
components: +None
title: Fix PEP8 errors in stdlib. - Fix PEP8 errors everywhere
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16960
Ezio Melotti added the comment:
Sorry, but we don't fix style issue unless we are already working on that code
for some other reasons.
--
nosy: +ezio.melotti
resolution: - rejected
stage: - committed/rejected
status: open - closed
type: - enhancement
Ramchandra Apte added the comment:
Why? This may be low priority.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16960
___
___
Python-bugs-list
Ezio Melotti added the comment:
Several reasons, e.g.:
* there's the risk of introducing new bugs;
* it makes merging more difficult;
* it takes time to produce and review the patches;
* it makes hg annotate harder to use;
--
___
Python tracker
Serhiy Storchaka added the comment:
Yes, this thing was doubted me too. I proceeded from the following
considerations.
1. Often system id is used for file operations and in this case you need to use
the file system encoding. Unfortunately Python 2 does not have
'surrogateescape' handler
STINNER Victor added the comment:
Might make sense to put this in atexit.atfork() to avoid small-module
inflation?
It sounds strange to mix at exit and at fork in the same module.
Both are very different.
2013/1/13 Arfrever Frehtes Taifersar Arahesis rep...@bugs.python.org:
Changes by
STINNER Victor added the comment:
is it correct that this bug no longer appears in Python 2.7.3?
Martin wrote that it cannot be fixed in Python 2: For 2.6, I don't think
fixing it is feasible.
The fix is to upgrade your application to Python 3.
--
Raymond Hettinger added the comment:
FWIW, I concur with Ezio's reasons for rejecting this.
--
nosy: +rhettinger
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16960
___
Ramchandra Apte added the comment:
It's a valid bug report however difficult or low priority it is.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16960
___
Changes by lekma lekma...@gmail.com:
--
nosy: +lekma
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15870
___
___
Python-bugs-list mailing list
gac added the comment:
Here's a second path I've done for the current/default branch, using a separate
print function for output, as recommended by Berker Peksag. I tried to add it
as a separate patch set using the code review tool but every time I did, I just
got a screen full of debug
Serhiy Storchaka added the comment:
Here is an alternative patch. It doesn't encode system id when it settled,
instead system id attribute can be bytes or an unicode and encoding/decoding
happened only a file opened.
--
Added file:
Changes by Serhiy Storchaka storch...@gmail.com:
--
stage: - needs patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16903
___
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: docs@python - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16954
___
R. David Murray added the comment:
It is valid, but it is not *useful* to have it in the bug tracker as an open
bug. All developers are aware that when they touch code for some other reason,
they can fix PEP8 errors at the same time. Having an open bug report for it
would just clutter the
New submission from Nick Coghlan:
Accessing an environment variable without Py_GETENV (or breaking
Py_IgnoreEnvironmentFlag configuration *cough*) may lead to environment
variables being accessed even if -E is passed on the command line.
As part of the PEP 432 implementation, I'm adding
R. David Murray added the comment:
Thanks for the suggestion and patch. I haven't reviewed it thoroughly yet, but
if you change _print_debug to be:
def _print_debug(*args):
then
print(datetime.datetime.now(), *args, file=stderr)
should do what you want for python3 (I don't think the
R. David Murray added the comment:
Er, that should have been (self, *args), but actually I'd recommend making it a
module function, not a method, in which case my signature would be correct :)
--
___
Python tracker rep...@bugs.python.org
New submission from Riku Voipio:
Getdents system call was superseded with with getdents64 in Linux 2.4 (January
2001). New architectures, such as 64-Bit ARM opt out not to support legacy
system calls, and getdents is one of them.
Since getdents64 has been supported for over a decade, I don't
New submission from sean:
NOTE: SAME AS Python 3.2.2, Python 3.3 from python.org/download
Python 3.2.2 Stackless 3.1b3 060516 (default, Feb 20 2012, 13:36:12) [MSC
v.1500 32 bit (Intel)] on win32
Type copyright, credits or license() for more information.
from html.parser import HTMLParser
Ezio Melotti added the comment:
It works for me on 3.2.3, 3.2.3+, 3.3.0+, 3.4.0a0
from html.parser import HTMLParser
class LooseParser(HTMLParser):
... def __init__(self, strict=False):
... HTMLParser.__init__(self, strict=strict)
... def handle_starttag(self, tag, attrs):
sean added the comment:
SAME AS
#issue13273
http://bugs.python.org/issue13273
--
resolution: - duplicate
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16963
___
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
stage: - committed/rejected
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16963
___
___
Ronald Oussoren added the comment:
The patch didn't work for me because I manually applied and missed a bit. The
patches fixes https://bitbucket.org/ronaldoussoren/py2app/issue/81 for me,
and the environ(7) manpage also indicates that the call to _NSEnvironment is
needed in shared libraries.
Serhiy Storchaka added the comment:
Patch updated. Fixed an error which Georg have found. Restored testing
XMLGenerator with StringIO as Antoine pointed. Now XMLGenerator tested for
StringIO, BytesIO and an user writer. Added tests for encoding.
--
keywords: -easy
Added file:
Changes by Serhiy Storchaka storch...@gmail.com:
--
stage: needs patch - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1470548
___
Amaury Forgeot d'Arc added the comment:
Added some comments on Rietveld.
The .fileno() method is missing. Can this cause a problem when the file is
passed to stdlib functions? subprocess for example?
--
___
Python tracker rep...@bugs.python.org
Antoine Pitrou added the comment:
What does this proposal bring exactly?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12939
___
___
Marc-Andre Lemburg added the comment:
On 13.01.2013 00:37, STINNER Victor wrote:
By the way, OpenSSL expects that its PRNG is reseed somehow (call RNG_add)
after a fork. I wrote a patch for OpenSSL, but I don't remember if I sent it
to OpenSSL.
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +gregory.p.smith
stage: - patch review
type: - behavior
versions: +Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16962
___
Antoine Pitrou added the comment:
Still, raising SkipTest from the toplevel is useful when some toplevel setup
code otherwise depends on the missing module.
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16935
Serhiy Storchaka added the comment:
I should add a symlink loop detecting to _rlistdir() as Antoine advised me on
IRC.
--
stage: patch review - needs patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13968
Antoine Pitrou added the comment:
How does this interact with pdb?
--
nosy: +georg.brandl, haypo, pitrou
stage: - patch review
type: - enhancement
versions: +Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16956
Antoine Pitrou added the comment:
It sounds strange to mix at exit and at fork in the same module.
Both are very different.
That's true. The sys module would probably be the right place for both
functionalities.
--
___
Python tracker
Andrew Svetlov added the comment:
Please email python-dev if you think LoadError should be directly specified.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16715
___
Eric V. Smith added the comment:
I think this issue should be closed, since we're doing as we're instructed by
the OS. If someone wants to open a new issue for the m format specifier type,
I'd support that.
--
nosy: +eric.smith
___
Python tracker
Zachary Ware added the comment:
I agree that raising SkipTest (or subclasses thereof, such as ResourceDenied)
at module level should be supported. That would mean no changes would be
needed in most of the should-be-skipped-but-fail-instead tests listed in issue
16748 to make test discovery
Stefan Krah added the comment:
I agree, we can't really do anything here.
--
resolution: - invalid
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16944
Zachary Ware added the comment:
Georg:
Note that Sphinx' make text output already should be suitable. We
already update the pydoc topics with that on every release, so we could
just as well do the same for the IDLE doc. No need for another
separate script.
I take it this would mean
New submission from Stefan Krah:
This issue proposes an additional 'm' format specifier that behaves like
'n', but uses mon_grouping, mon_decimal_point and mon_thousands_sep.
See #16944 for the rationale.
--
components: Interpreter Core
messages: 179955
nosy: Peter.Stahl, eric.smith,
Zachary Ware added the comment:
Chris:
There are lots of modules to change here. I wonder if some or most of
this couldn't be automated.
Possibly, but I don't mind going through individually if Ezio (or others) don't
mind committing individually. From what I've seen, the test suite is
Roundup Robot added the comment:
New changeset d1ef91025d70 by Andrew Svetlov in branch 'default':
Issue #5066: Update IDLE docs
http://hg.python.org/cpython/rev/d1ef91025d70
--
nosy: +python-dev
___
Python tracker rep...@bugs.python.org
Andrew Svetlov added the comment:
Pushed. Thanks.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5066
Changes by Andrew Svetlov andrew.svet...@gmail.com:
--
nosy: +asvetlov
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16932
___
___
Andrew Svetlov added the comment:
Regenerating idle.txt and committing it is fine to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16893
___
Georg Brandl added the comment:
I take it this would mean generating help.txt and then checking it in?
Otherwise, users who built their own Python would likely run into issues with
IDLE not finding its help file, or would be required to have sphinx available.
Yes, it will be checked in.
Zachary Ware added the comment:
I don't think we have to worry about it getting out of date quickly.
Fair point :)
Automatically generating the IDLE help at run time from a documentation
source file is not posssible anyway, since the doc sources are not
available in a standard location
Georg Brandl added the comment:
The unified diff is not very helpful; I think somebody has to put the files
side by side and merge.
The pydoc topics are built with a custom Sphinx builder implemented in
tools/sphinxext/pyspecific.py -- but if we just want the vanilla text builder
output it
Georg Brandl added the comment:
To make it actually work, replace library/idle by library/idle.rst.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16893
___
New submission from Barry A. Warsaw:
In this distribute bug I describe a problem when pip installing mimeparse,
which has a setup.py with a BOM. distribute uses execfile() which gets fixed
in Python 3 to use a combination of compile(open()) as the fixer.
Ned Deily added the comment:
Ronald: the patch?
--
nosy: -BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1602133
___
___
Changes by Ronald Oussoren ronaldousso...@mac.com:
Added file: http://bugs.python.org/file28726/1602133.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1602133
___
John Brearley added the comment:
Hi Rchard: Thanks very much. The wait() method works fine.
Regards, John Brearley
613-259-5622 (H)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16955
John Brearley added the comment:
Hi Richard: Thanks for pointers on other methods.
I am coming from a TCL background, and learning Python. I have gone through
regular sockets, select, asyncore, sockserv, threading and multiprocessing
modules. Only multiprocessing seems to be able to use more
New submission from John Brearley:
Hi Richard: I have published my multiprocessing server client scripts on the 2
web sites shown below in the hopes that they will help others learning this
module. I haven't seen anyplace on the python.org web site that might be
suitable for a copy. Are people
Serhiy Storchaka added the comment:
At the moment gzip can raise two errors on unexpected EOF: struct.error from
struct.unpack() or TypeError from ord(). Both bz2 and lzma raise EOFError in
such cases.
The proposed patch converts both truncated gzip errors to EOFError as for bz2
and lzma.
New submission from Kay Hayen:
Suprisingly, keyword only arguments become evaluated first:
def f(a=undefined1,*,b=undefined2):pass
...
Traceback (most recent call last):
File stdin, line 1, in module
NameError: name 'undefined2' is not defined
It should be undefined1.
I am sure, this is
Georg Brandl added the comment:
Looks like a bug to me, although it isn't likely to cause great harm.
--
nosy: +georg.brandl
title: Keyword keyword only default parameters are evaluated before po -
Keyword only argument default values are evaluated before other defaults
Chris Jerdonek added the comment:
Also, I'm of the opinion that we'll end up with a higher quality result doing
things by hand anyway.
Automation doesn't (and shouldn't) preclude careful review and modifications by
hand. My point was that it seems like it might be able to get you, say, 80%
Richard Oudkerk added the comment:
Added some comments on Rietveld.
The .fileno() method is missing. Can this cause a problem when the file
is passed to stdlib functions? subprocess for example?
Thanks. An older version of the patch had a fileno() method which returned the
handle -- but
R. David Murray added the comment:
Vis the discussion of x[:0] in the review. This kind of construct is only
unfamiliar because it is new in Python3, and there are not *that* many places
that you want to (and can) deal with both bytes and strings using the same
code. But when you can, it is
Richard Oudkerk added the comment:
What does this proposal bring exactly?
Unless we are willing to completely replace fds with handles on Windows,
perhaps not too much. (At one point I had assumed that that was the plan for
py3k.)
Although not advertised, openhandle() does have a
Jason R. Coombs added the comment:
For reference, I encountered an issue due to this change and didn't quite
understand what was going on. I distilled the problem down and posted a
question on stack overflow:
Changes by Marco Buccini marcu...@gmail.com:
--
nosy: -markon
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6975
___
___
Python-bugs-list mailing
Changes by Marco Buccini marcu...@gmail.com:
--
nosy: -markon
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6973
___
___
Python-bugs-list mailing
Changes by Marco Buccini marcu...@gmail.com:
--
nosy: -markon
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6074
___
___
Python-bugs-list mailing
Richard Oudkerk added the comment:
If you want to communicate between processes of the same progam, you are best
off calling multiprocessing.Pipe() or multiprocessing.Queue() in the main
process. Queues or connections can then be inherited by the child processes.
Usually all communication
Richard Oudkerk added the comment:
For the reasons I wrote in the other issue, I don't think this an approach to
encourage.
There was no need to create a new issue: if you post to a closed issue then
people on the nosy list will still see your message.
So I will close this issue.
(Maybe
Serhiy Storchaka added the comment:
In fact glob() is already protected against an endless recursion (in the same
way as Bash). The level of recursion is simply limited by the maximum length of
the path. So I did not change the implementation, I have just added a test for
symlink loop. I also
Zachary Ware added the comment:
For the conversion from test_main() to unittest.main(), I could certainly see
automation helping a lot; most cases are very simple. But really, that issue
is somewhat tangential to this one and in my last message I was thinking from
the perspective of just the
Ned Deily added the comment:
LGTM and I agree that it should be considered a bug fix.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1602133
___
Andrew Svetlov added the comment:
Is it fixed now?
--
nosy: +asvetlov
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15539
___
___
Python-bugs-list
Changes by Andrew Svetlov andrew.svet...@gmail.com:
--
nosy: +asvetlov
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16823
___
___
Changes by Andrew Svetlov andrew.svet...@gmail.com:
--
nosy: +asvetlov
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16887
___
___
Changes by Andrew Svetlov andrew.svet...@gmail.com:
--
nosy: +asvetlov
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16901
___
___
Changes by Andrew Svetlov andrew.svet...@gmail.com:
--
nosy: +asvetlov
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16921
___
___
Changes by Andrew Svetlov andrew.svet...@gmail.com:
--
nosy: +asvetlov
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16935
___
___
New submission from Zachary Ware:
Here's an incomplete patch to test_concurrent_futures.py that does not convert
from test_main() to unittest.main(); the decorator on test_main has me unsure
how to make the conversion. I've attempted moving various parts of the
decorator's functions to
Brett Cannon added the comment:
The way I would replace test_main() would be:
if __name__ == '__main__':
try:
test.support.reap_threads(unittest.main)()
finally:
test.support_reap_children()
--
___
Python tracker rep...@bugs.python.org
Zachary Ware added the comment:
That looks quite good, except for the fact that discovery (of the form `python
-m unittest discover Lib/test/ 'test_*.py'`) won't hit reap_threads or
reap_children. It does cover `python -m test.test_concurrent_futures` and
standard regrtest, though; is 2 out
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16967
___
Serhiy Storchaka added the comment:
Yes, it's fixed.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15539
___
___
Python-bugs-list mailing list
Roundup Robot added the comment:
New changeset ce869b05762c by Serhiy Storchaka in branch '2.7':
Issue #9720: zipfile now writes correct local headers for files larger than 4
GiB.
http://hg.python.org/cpython/rev/ce869b05762c
New changeset b93848ca7760 by Serhiy Storchaka in branch '3.2':
Serhiy Storchaka added the comment:
If no one objects, I'm going to commit this next week.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9290
___
Serhiy Storchaka added the comment:
Fixed. Thank you for report, Craig de Stigter.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9720
Éric Araujo added the comment:
Source code says:
# derives from OSError for backwards-compatibility with Python 2.4.0
class LoadError(OSError): pass
In 3.0, LoadError could have been made a direct subclass of Exception. Now
it’s too late, but a best practice IMO would still be to write
Roundup Robot added the comment:
New changeset 13e2e44db99d by Serhiy Storchaka in branch 'default':
Issue #15989: Fix several occurrences of integer overflow
http://hg.python.org/cpython/rev/13e2e44db99d
--
nosy: +python-dev
___
Python tracker
Changes by Serhiy Storchaka storch...@gmail.com:
--
stage: patch review - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15989
___
Brett Cannon added the comment:
Yes as even the current solution doesn't work with ``-m unittest discover``
anyway, right? And if you are running the tests independently then it is a
separate process and thus you don't need to worry about dangling threads or
processes.
--
Zachary Ware added the comment:
Ok then, I'll update the patch. Thanks, Brett!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16968
___
___
Roundup Robot added the comment:
New changeset da5e520a7ba5 by Richard Oudkerk in branch '2.7':
Issue #10527: Use poll() instead of select() for multiprocessing pipes
http://hg.python.org/cpython/rev/da5e520a7ba5
--
___
Python tracker
Roundup Robot added the comment:
New changeset abf111b9a464 by Richard Oudkerk in branch '3.2':
Issue #10527: Use poll() instead of select() for multiprocessing pipes
http://hg.python.org/cpython/rev/abf111b9a464
--
___
Python tracker
Chris Jerdonek added the comment:
Okay, well the title of this issue is Make CPython test package discoverable,
so as part of that we should be confirming that test discovery finds the same
tests that test_main() runs (and if not, to understand why and/or make them the
same).
--
Chris Jerdonek added the comment:
If you want to get the same cleanup logic working with unittest discovery, you
could try using the load_tests protocol, and wrapping the functions that
actually run the tests there (which may simply mean wrapping the tests passed
to load_tests, which I
Chris Jerdonek added the comment:
By the way, I think this process of using unittest (i.e. dog-fooding) is a good
exercise in part because it helps us understand better where unittest could use
improvement (e.g. the SkipTest during import issue, and the decorator issue
raised here).
Terry J. Reedy added the comment:
First, What's New explains the new features in Python. This issue is a
bugfix. AFAIK, object() has always been documented as having no parameters. The
fact that passing extra args should raise a TypeError is no secret.
Second, this *is* documented. The third
Terry J. Reedy added the comment:
We use 'crash' to mean a segfault (and core dump, on *nix) or the Windows
equivalent. We avoid those if at all possible. A Python traceback is not a
crash but a semi-graceful shutdown that has be planned for, given the
circumstances. What is annoying here is
Meador Inge added the comment:
I agree that it is better to cover both cases in one test irrespective of the
interpreter command line options. I will take a look at creating a subprocess.
Thanks for the review.
--
___
Python tracker
1 - 100 of 106 matches
Mail list logo
