Changes by Tshepang Lekhonkhobe tshep...@gmail.com:
--
nosy: -tshepang
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11874
___
___
Roundup Robot added the comment:
New changeset 9dddc95ef31e by Victor Stinner in branch '3.4':
Issue #22762: Fix _Py_DisplaySourceLine(), clear the exception if
https://hg.python.org/cpython/rev/9dddc95ef31e
New changeset f4f5b942e5e0 by Victor Stinner in branch 'default':
(Merge 3.4) Issue
STINNER Victor added the comment:
Thanks for the report and the patch. It was not easy to reproduce the issue,
but I reproduced the assertion error. I'm not sure that it's useful to add an
unit test.
--
resolution: - fixed
status: open - closed
Phil Elson added the comment:
FWIW - this doesn't appear to have been backported to v2.7.x. As a result, the
./Modules/ld_so_aix reference still exists in _sysconfigdata.py in v2.7.8 (and
therefore I was unable to build numpy). The workaround is easy enough, it is
just something that is worth
New submission from Robert Collins:
test_assertRaises_frames_survival
(unittest2.test.test_assertions.Test_Assertions
Depends on refcount behaviour to pass - adding a gc.collect() before the
weakref checks is sufficient to fix things on pypy.
test_no_exception_leak
Robert Collins added the comment:
Herewith a patch. Applied to unittest2 for backport to unbreak its tests on
pypy.
--
keywords: +patch
Added file: http://bugs.python.org/file37072/issue22764.patch
___
Python tracker rep...@bugs.python.org
Changes by Robert Collins robe...@robertcollins.net:
--
type: - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22764
___
___
Changes by Eldar Abusalimov eldar.abusali...@gmail.com:
--
nosy: +abusalimov
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20440
___
___
Antoine Pitrou added the comment:
I think the change in test_assertions is wrong: it doesn't test what the change
was meant to fix in the first place.
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22764
Antoine Pitrou added the comment:
You could instead mark the test as cpython-specific.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22764
___
Antoine Pitrou added the comment:
Le 30/10/2014 12:00, Robert Collins a écrit :
Ah, perhaps the test was flawed to start with, since no effort is
made
in it to capture the error and then process it. If we pass a result in,
the traceback will have a ref and gc.collect() can't possibly be
Robert Collins added the comment:
Hmm? I must have misunderstood the test. Here's my understanding: the test is
testing that a an object ref only held in the traceback object of the exception
is cleaned up such that it can be collected. In a refcount system that
collection is immediate, in a
Antoine Pitrou added the comment:
Here's my understanding: the test is testing that a an object ref only held
in the traceback object of the exception is cleaned up such that it can be
collected
The best way to check would be to revert the case.py changes in 6ab3193e890e.
My intuition is
New submission from Bohuslav Slavek Kabrda:
The attached patch fixes two test_gdb problems that can occur under some
circumstances:
- With new GDB (I think version = 7.4.0, but I'm not sure about the precise
version), GDB sometimes prints entry-values for variables, which can lead to
Amaury Forgeot d'Arc added the comment:
Looks good to me.
I checked that there are only 16 differences between cp1251 and kz1048,
and that the two standards define the same mapping.
--
nosy: +amaury.forgeotdarc
___
Python tracker
Claudiu Popa added the comment:
Looks good to me. You might want to sign the contributor agreement:
https://www.python.org/psf/contrib/contrib-form/. This is required for
non-trivial contributions. You'll get a * next to your name after signing it.
--
stage: patch review - commit
R. David Murray added the comment:
+1 on the refactoring. I think it makes more conceptual sense.
--
nosy: +r.david.murray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22763
___
Claudiu Popa added the comment:
I don't know why there's no review link for your patch. Anyway..
+self.assertTrue(c.complete(A.foo, 0) in ['A.foo(', 'A.foobar('])
+self.assertTrue(c.complete(A.foo, 1) in ['A.foo(', 'A.foobar('])
You can use self.assertIn for these.
+
Lorenz Quack added the comment:
Thanks for reviewing!
test now use assertIn and assertIsNone as suggested
PS: My Contributors Agreement is in progress. Just emailed the PSF with some
question (but I intend to sign it)
--
Added file:
New submission from Joshua Chin:
Currently, in-place operations on 'collections.Counter' with unsupported types
raises an 'AttributeError'.
Example:
import collections
counter = collections.Counter()
counter += 1
Traceback (most recent call last):
File stdin, line 1, in module
File
Changes by Ethan Furman et...@stoneleaf.us:
--
assignee: - rhettinger
nosy: +ethan.furman, rhettinger
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22766
___
Changes by Ethan Furman et...@stoneleaf.us:
--
versions: +Python 2.7, Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22766
___
___
R. David Murray added the comment:
That would prevent it from working with work alike (duck type) classes,
though.
--
nosy: +r.david.murray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22766
Ethan Furman added the comment:
As I noted in my review, the docstring specifically says other Counter.
If we want to relax that we could check for an 'items' attribute and 'return
NotImplemented' if it isn't there, but one or the other should definitely
happen.
--
New submission from Tom Christie:
This is one of those behavioural issues that is a borderline bug.
The seperators argument to `json.dumps()` behaves differently across python 2
and 3.
* In python 2 it should be provided as a bytestring, and can cause a
UnicodeDecodeError otherwise.
* In
Georg Brandl added the comment:
IMO the snowman should be a Unicode string in the second example for Python 2.7.
--
nosy: +georg.brandl
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22767
Georg Brandl added the comment:
in the second example
or even, in both examples.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22767
___
___
R. David Murray added the comment:
'counter' in the docstrings is in lower case, so that says nothing dispositive.
However, __add__ does an ininstance check, so it is hard to see why __iadd__
does not.
Personally I'd drop the isinstance checks and let the errors bubble up as they
may. Why
Ethan Furman added the comment:
Indeed -- we mostly discuss with each other to try and sway his opinion. :)
stdlib types should not let every error bubble up. Consider a dict:
-- d = {}
-- d += 2
Traceback (most recent call
R. David Murray added the comment:
And that works, including with the future import. I don't remember if this is
a bug we've fixed since 2.7.2, but I don't think so.
In Python3, json explicitly does not support bytes.
--
nosy: +r.david.murray
resolution: - not a bug
stage: -
Antoine Pitrou added the comment:
I also think returning NotImplemented would be the right thing here.
--
nosy: +pitrou
type: behavior - enhancement
versions: -Python 2.7, Python 3.4
___
Python tracker rep...@bugs.python.org
New submission from Mathieu Pasquet:
Currently, the only workaround is to use transport._sock.getpeercert(True) on
the Transport returned by loop.create_connection(), which is not something to
be encouraged. It is useful to get such information, for example to perform a
manual certificate
Antoine Pitrou added the comment:
Thanks for the patch!
other issues of
feature disparity might arise when more people try to switch to asyncio.
Exposing a proxy SSLSocket object for read-only functions might be
more beneficial.
I'm not sure that would make a difference. We still have to
Roundup Robot added the comment:
New changeset d94d8789e924 by Antoine Pitrou in branch '3.4':
Issue #8876: distutils now falls back to copying files when hard linking
doesn't work.
https://hg.python.org/cpython/rev/d94d8789e924
New changeset ce484e0840e3 by Antoine Pitrou in branch 'default':
Mathieu Pasquet added the comment:
I'm not sure that would make a difference. We still have to implement
the proxy SSLSocket, which is no easier than adding the extra info by
hand. Or did I misunderstand you?
The difference would be that exposing methods can be more future-proof, as some
Roundup Robot added the comment:
New changeset 263395345aa7 by Antoine Pitrou in branch '2.7':
Issue #8876: distutils now falls back to copying files when hard linking
doesn't work.
https://hg.python.org/cpython/rev/263395345aa7
--
___
Python
Antoine Pitrou added the comment:
This should now be fixed. Thanks for your patience :)
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8876
Antoine Pitrou added the comment:
some methods take parameters (like the offender getpeercert(bool), or
get_channel_binding() that takes an element of
ssl.CHANNEL_BINDING_TYPES, list that may grow in the future) that need
to be covered in the properties
That's a good point. I don't have
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +dmalcolm
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22765
___
___
Python-bugs-list mailing
Alex Gaynor added the comment:
Patch now makes more precise assertions about the type of error that's
occurring.
--
Added file: http://bugs.python.org/file37077/issue22417.diff
___
Python tracker rep...@bugs.python.org
Tom Christie added the comment:
Not too fussed if this is addressed or not, but I think this is closed a little
prematurely.
I don't think there's a problem under Python 3, that's entirely reasonable.
However under Python 2, `json.dumps()` will normally handle *either* bytes or
unicode
Éric Araujo added the comment:
Thanks for the patches folks!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8876
___
___
Python-bugs-list
R. David Murray added the comment:
But only if you use non-ascii in the binary input, in which case you get an
encoding error, which is a correct error.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22767
Antoine Pitrou added the comment:
ENAMETOOLONG: that doesn't mean the file doesn't exist. For example, it could
be accessed by changing the current directory and shortening the residual path
name.
ELOOP: unfortunately it doesn't guarantee that there is a real symlink loop,
just that the OS
Antoine Pitrou added the comment:
Here is a patch with tests.
--
stage: test needed - patch review
Added file: http://bugs.python.org/file37078/path_exists_enotdir.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22759
Hristo Venev added the comment:
Should I file bugs for is_dir, is_file, is_symlink, is_socket, is_fifo,
is_block_device and is_char_device?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22759
Antoine Pitrou added the comment:
Le 30/10/2014 20:36, Hristo Venev a écrit :
Hristo Venev added the comment:
Should I file bugs for is_dir, is_file, is_symlink, is_socket, is_fifo,
is_block_device and is_char_device?
Hmm... good catch. No, this issue will do.
--
Antoine Pitrou added the comment:
Updated patch for other querying function.
--
Added file: http://bugs.python.org/file37079/path_exists_enotdir2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22759
R. David Murray added the comment:
No, it is introducing the unicode that is the problem. Your first example is
entirely binary. It is only when you *mix* binary and unicode that you have
encoding problems (because python doesn't know the encoding of the binary
data...well, more precisely
R. David Murray added the comment:
Or, to put it another way, we agree with you that both cases should behave the
same: using binary data in a json dumps call should raise an error. And in
python3 they do. But in python2 there is a confusion as to what is text and
what is binary, and so
Tom Christie added the comment:
But only if you use non-ascii in the binary input, in which case you get an
encoding error, which is a correct error.
Kind of, except that this (python 2.7) works just fine:
data = {'snowman': '☃'}
json.dumps(data, ensure_ascii=False)
'{snowman:
Changes by Antoine Pitrou pit...@free.fr:
--
assignee: eric.araujo -
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16561
___
___
Python-bugs-list
Changes by Antoine Pitrou pit...@free.fr:
--
assignee: eric.araujo -
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13719
___
___
Python-bugs-list
Changes by Antoine Pitrou pit...@free.fr:
--
assignee: tarek -
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2943
___
___
Python-bugs-list
Tom Christie added the comment:
So, as soon as (but only as soon as) you mix unicode with your non-ascii
data, your program blows up.
Indeed. For context tho my example of running into this the unicode literals
used as seperators weren't even in the same package as the non-ASCII binary
R. David Murray added the comment:
Yes, that third party problem is a prime example of exactly why this needed to
be fixed, but it required python3 to fix it.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22767
Antoine Pitrou added the comment:
Patch looks good to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22410
___
___
Python-bugs-list mailing
Roundup Robot added the comment:
New changeset 40497cc445f4 by Antoine Pitrou in branch '3.4':
Issue #22759: Query methods on pathlib.Path() (exists(), is_dir(), etc.) now
return False when the underlying stat call raises NotADirectoryError.
https://hg.python.org/cpython/rev/40497cc445f4
New
Antoine Pitrou added the comment:
This is now fixed. Thanks for the report!
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22759
New submission from David Durrett:
Have only tried this on Python 2.7
To reproduce:
~
from Tkinter import *
import ttk
root = Tk()
tree = ttk.Treeview(root)
id = tree.insert('' , 'end', text='foo', tag='bar')
print tree.tag_has('bar', item=id)
# ^ this works..
print tree.tag_has('baz',
Roundup Robot added the comment:
New changeset 6d2788f9b20a by Serhiy Storchaka in branch '2.7':
Issue #22410: Module level functions in the re module now cache compiled
https://hg.python.org/cpython/rev/6d2788f9b20a
New changeset cbdc658b7797 by Serhiy Storchaka in branch '3.4':
Issue #22410:
New submission from Ned Deily:
The changes to tkinter tests introduced by the changes for Issue22236 (2.7
32fdaf401e50, 3.4 dd1dffe6f0d2, and default/3.5 014060738f7f) may cause Python
to crash due to a Tk segfault on OS X. The crash only shows up when using the
-j option to regrtest and is
Ned Deily added the comment:
See Issue22770 for details of a potential Tk crash that can occur on OS X when
running tests as a result of these changes and for a workaround.
--
nosy: +ned.deily
___
Python tracker rep...@bugs.python.org
Ned Deily added the comment:
For the record, a typical instance of this failure will look like this:
$ /usr/local/bin/python3.4 -m test -w -uall -j2
== CPython 3.4.2 (v3.4.2:ab2c023a9432, Oct 5 2014, 20:42:22) [GCC 4.2.1 (Apple
Inc. build 5666) (dot 3)]
== Darwin-14.0.0-x86_64-i386-64bit
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
stage: - needs patch
versions: +Python 3.4, Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22769
Roundup Robot added the comment:
New changeset d565dbf576f9 by Serhiy Storchaka in branch '2.7':
Fixed compile error in issue #22410. The _locale module is optional.
https://hg.python.org/cpython/rev/d565dbf576f9
New changeset 0c016fa378db by Serhiy Storchaka in branch '3.4':
Fixed compile
Robert Collins added the comment:
I've done some experimentation. Yes, the updated test passes when the
clear_frames call is removed in cPython 3.5
But the original test also passes when clear_frames is not called if one drops
into pdb and steps through, which still fits the symptoms of
Changes by Robert Collins robe...@robertcollins.net:
Added file: http://bugs.python.org/file37080/issue22764.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22764
___
Robert Collins added the comment:
I'll apply the patch monday if there are no further comments before then.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22153
___
Antoine Pitrou added the comment:
There's the cpython_only decorator in test.support. I think CPython is the only
popular refcounting implementation.
(of course I don't know which implementations may qualify as popular exactly
:-))
--
___
Python
Serhiy Storchaka added the comment:
Thank you for your review Antoine.
Committed patch has fixed only part of the problem. It doesn't fix the problem
of explicitly compiled patterns. Better solution requires changes to the _sre
module.
--
resolution: - fixed
stage: patch review -
Robert Collins added the comment:
(Pinging for reviews - I'm going to time out and land this early next week if I
can't get a review on it, since this is actually a fairly significant oversight
and I don't want unittest2 to run ahead of the stdlib - that way leads
unmaintainable madness).
STINNER Victor added the comment:
The issue is about the base if /dev/urandom is not present. How is
arc4random() PRNG/CPRNG initialized if /dev/urandom is *not* present?
Can we rely on it if it only uses a poor seed?
--
___
Python tracker
Alex Gaynor added the comment:
Updates to teh docs based on teh feedback from Antoine.
--
Added file: http://bugs.python.org/file37081/issue22417.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22417
Terry J. Reedy added the comment:
when -j 0 is used in an OS X framework build
Did you mean -j 1? I checked the buildbots and the x86 Tiger is run -j1 while
the AMD Snow Leopard is not running.
--
nosy: +terry.reedy
___
Python tracker
Guido van Rossum added the comment:
Maybe
transport.get_extra_info('socket').getpeercert(True)
would be okay, no patch needed?
On Thu, Oct 30, 2014 at 11:56 AM, Antoine Pitrou rep...@bugs.python.org
wrote:
Antoine Pitrou added the comment:
some methods take parameters (like the offender
Ned Deily added the comment:
Did you mean -j 1?
No.
I checked the buildbots and the x86 Tiger is run -j1 while the AMD Snow
Leopard is not running.
I'm not sure what you are referring to here. This crash would not be seen on
either of those buildbots because (1) they are not configured
77 matches
Mail list logo
