Terry J. Reedy added the comment:
I just added a generic entry to the 3.4 and 3.5 What's New docs pointing people
to idlelib/NEWS.txt.
+ idlelib and IDLE
+
+
+Since idlelib implements the IDLE shell and editor and is not intended for
+import by other programs, it gets
Mark Lawrence added the comment:
FTR I've now built everything successfully.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24268
___
___
Petr Viktorin added the comment:
Thank you, Steve.
A similar problem is on other platforms as well. This patch should fix it;
could someone look at it?
--
Added file: http://bugs.python.org/file39477/fix-dynload-init-name.patch
___
Python tracker
Serhiy Storchaka added the comment:
Thanks Raymond.
I tried to write an implementation with locking, but it would be too
complicated (much more complex than all proposed before patches), because
recursive locks are needed. In any case I think that GIL is enough here.
Locking in Python
Steve Dower added the comment:
That patch looks good to me. Totally didn't think to look for copy-paste
issues...
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24268
___
Larry Hastings added the comment:
If it makes sense, can you guys check it in soon, like in real-time here? I
tag 3.5 beta 1 in about an hour, and since this is a bug-fix it's legitimate
to go in.
--
___
Python tracker rep...@bugs.python.org
Changes by Paul Moore p.f.mo...@gmail.com:
--
nosy: +paul.moore
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2528
___
___
Python-bugs-list
Guido van Rossum added the comment:
I've opened a separate bug (http://bugs.python.org/issue24272) for docs.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23973
___
Steve Dower added the comment:
I think it's missing PyAPI_DATA, as it's probably supposed to be an external
reference than a declaration. If it builds fine now, I'll commit that, but
whoever made the change should confirm that's what it is supposed to be.
--
Steve Dower added the comment:
It also required updating PC/python3.def to put the new functions into the
stable API.
This is the reason we should auto-gen that file (+Zach), to make sure that
anything people can #include under the limited ABI can actually be used.
Just double checking all
Roundup Robot added the comment:
New changeset af167a62e2a3 by Steve Dower in branch 'default':
Issue #24268: Adds PyModuleDef_Init and PyModuleDef_Type to python3.def (stable
ABI)
https://hg.python.org/cpython/rev/af167a62e2a3
--
___
Python tracker
Roundup Robot added the comment:
New changeset 57776eee74f2 by Serhiy Storchaka in branch 'default':
Issue #14373: Added C implementation of functools.lru_cache(). Based on
https://hg.python.org/cpython/rev/57776eee74f2
--
nosy: +python-dev
___
Petr Viktorin added the comment:
Steve, could you please merge it?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24268
___
___
Python-bugs-list
Guido van Rossum added the comment:
This was committed (rev 3e96d7ca3f51). I'm keeping this open because there is
more to do (see https://github.com/ambv/typehinting/labels/bug).
--
priority: release blocker - normal
___
Python tracker
Changes by Guido van Rossum gu...@python.org:
--
stage: - needs patch
type: - enhancement
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24272
___
New submission from Guido van Rossum:
Would be nice if there were more docs for the typing module (PEP 484). Looking
for volunteers. (There's stuff in the PEP that can serve as a starting point.)
Note: support for isinstance() and issubclass() will be withdrawn in beta 2.
--
assignee:
Roundup Robot added the comment:
New changeset 7b5f5f8b26a6 by Steve Dower in branch 'default':
Issue #24268: Fix import naming when loading extension modules. Patch by Petr
Viktorin.
https://hg.python.org/cpython/rev/7b5f5f8b26a6
--
___
Python
Mark Lawrence added the comment:
error C2079: 'PyModuleDef_Type' uses undefined struct '_typeobject'
c:\cpython\include\moduleobject.h is occurring on both 32 and 64 bit release
builds on Windows 8.1 VS2015. I don't know what is causing it but figured I'd
better flag it up pronto, and as you
Nick Coghlan added the comment:
Thanks for getting the Windows side sorted out folks, and my apologies for
the breakage. The overlap between the current import system maintainers and
Windows developers is unfortunately the null set :(
--
___
Python
Steve Dower added the comment:
Since you're up, any chance you can help diagnose these test failures:
Traceback (most recent call last):
File
D:\buildarea\3.x.bolen-windows8\build\lib\test\test_importlib\extension\test_loader.py,
line 93, in setUp
assert self.spec
AssertionError
From
Steve Dower added the comment:
Actually, that probably means we're not building a new extension module on
Windows, right?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24268
___
Roundup Robot added the comment:
New changeset 42ec976f627e by Steve Dower in branch 'default':
Issue #24268: Adds PCBuild project to build _testmultiphase module.
https://hg.python.org/cpython/rev/42ec976f627e
--
___
Python tracker
Steve Dower added the comment:
Confirmed that when we build the module needed by the test, the test works fine
:)
Unfortunately, I think it missed the branch for b1, so people who install and
run the test suite will see failures there. I'll make sure it gets into the 3.5
branch once that
Matthew Barnett added the comment:
In odict_new, if _odict_initialize fails, will the dict pointed to by
od_inst_dict be deallocated?
In odictiter_new, there's Py_INCREF(od);. If di-di_result == NULL fails,
od isn't DECREFed.
--
___
Python tracker
Eric Snow added the comment:
Good catch. I've fixed odictiter_new in the feature branch. However, I'm not
sure there's anything to be fixed in odict_new. It follows the same pattern as
dict_new (over in Objects/dictobject.c).
--
___
Python
Changes by Eric Snow ericsnowcurren...@gmail.com:
--
hgrepos: +309
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16991
___
___
Python-bugs-list
Changes by Eric Snow ericsnowcurren...@gmail.com:
--
hgrepos: +310
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24254
___
___
Python-bugs-list
New submission from Jacob:
This looks very related to: http://bugs.python.org/issue13829
I have very simple test code that looks like this:
import requests
r = requests.get('http://www.google.com')
print('requests.get() succeeded')
The above code works fine. However, when:
Raymond Hettinger added the comment:
Thanks Serhiy. I'll work on the next steps after the beta.
--
assignee: serhiy.storchaka - rhettinger
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14373
eryksun added the comment:
In msg243815 you asked me to look over this patch. I hope this helps.
For GetFileSecurity you need to also request LABEL_SECURITY_INFORMATION. To
test this in Vista+, use a file in the root directory of the system drive. This
will inherit a high integrity level w/
Ram Rachum added the comment:
Raymond: Thank you. So the discussion is back on adding a recipe to the docs.
Brian: When I said possible issues, I followed that with a couple of issues
with the example I uploaded (filter_example.py).
--
___
Python
Martin Panter added the comment:
Thanks for the reviewing. Here is http-buffer.v3.patch:
* Merged with current code
* Better HTTPResponse(sock) compatibility suggested by Demian
* New HTTPConnection.request(close=True) feature also suggested by Demian. This
sends “Connection: close” in the
Petr Viktorin added the comment:
And here are all changes in a single patch.
--
keywords: +patch
Added file: http://bugs.python.org/file39471/pep0489.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24268
New submission from Petr Viktorin:
Here is the implementation for the recently accepted PEP 489.
Tested on Linux.
--
files: pep0489.patches
messages: 243893
nosy: encukou, eric.snow, ncoghlan
priority: normal
severity: normal
status: open
title: PEP 489 -- Multi-phase extension module
Nick Coghlan added the comment:
+1 from me.
--
nosy: +larry, rkuska
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23968
___
___
Python-bugs-list
Tim Golden added the comment:
Thanks for the very thorough review. This isn't going to make it into
3.5, but I'll rework it in the light of your comments and see if people
are happy with it in the optional argument variation.
--
___
Python tracker
Nick Coghlan added the comment:
There's two issues here:
1. The bundled pip should be upgraded to the recently released 7.0 (I believe
we can do that after beta 1, due to the different-from-normal guidelines set up
in PEP 453)
2. Neither the tests nor ensurepip itself should be touching the
Martin Panter added the comment:
Actually looks like I should have updated before I opened this bug. I just
updated and I suspect revision 29b95625a07c (“Merge 3.4 into default, upgrading
pip to 7.0.1”, a large binary change) fixed it for me.
But I did wonder why removing -unetwork didn’t
Nick Coghlan added the comment:
types.prepare_class() also needs to be updated to use OrderedDict() by default.
--
dependencies: +Add OrderedDict written in C
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24254
Ethan Furman added the comment:
It looks like we are pretty much neutral between the +1's and -1's.
Antoine seems to be opposed on general principles against bloat, while I am for
it on general principles of completeness.
The recipe could still go in the docs for people to use on previous
Changes by Ned Deily n...@acm.org:
--
nosy: +dstufft, ncoghlan
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24267
___
___
Python-bugs-list
Nick Coghlan added the comment:
I'll get this merged tonight so we make the beta1 deadline, but I expect the
initial docs to be fairly rudimentary and requiring further updates.
--
assignee: - ncoghlan
versions: +Python 3.5
___
Python tracker
Nick Coghlan added the comment:
I'd suggest also taking a look into whether or not the PEP 412 keysharing might
be causing problems.
--
nosy: +ncoghlan
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16991
Nick Coghlan added the comment:
Digging into the test_options failure suggests Christian is right (although I
think it has more to do with
https://fedoraproject.org/wiki/Changes/CryptoPolicy than it does with FIPS):
ctx = ssl.SSLContext(ssl.PROTOCOL_TLSv1)
bin(ctx.options)
Ned Deily added the comment:
If you want to recognize architecture specific sonames
For OS X we don't have a need to recognize architecture specific sonames
because we want to continue to defer to the operating system to make the
decisions about which, if any, architecture binary to load from
Raymond Hettinger added the comment:
I would like to tip the balance in favor of the -1. Antoine is right about
this one.
--
nosy: +rhettinger
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24195
Jörn Hees added the comment:
I'm closing this because the OP's original concern about wanting an in-place
operation was already solved
Was it? Are you referring to http://bugs.python.org/issue13121 ?
My main concern was that += is considerably slower than .update(), kind of
catching me
New submission from Martin Panter:
Recently when running the test suite on the code from the default Mercuiral
branch, I have been seeing following failure. This only started happening in
the last week or two.
$ ./python -bWall -m test -v test_venv
[. . .]
test_with_pip
Changes by Raymond Hettinger raymond.hettin...@gmail.com:
--
assignee: - docs@python
components: +Documentation -Library (Lib)
nosy: +docs@python
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24195
Nick Coghlan added the comment:
I've also come to agree with Raymond that the repr may not be the best place
for this additional information, and have updated the issue title accordingly.
For example, as one possible alternative, we might be able to put something in
the inspect module (e.g.
Stefan Krah added the comment:
Then pep-008 is wrong, too, since the implementation *does* allow
Evgeny's example.
The current implementation just checks if the same INDENT/DEDENT
tokens are generated for tab widths 1 and 8.
--
___
Python tracker
Changes by Martin Panter vadmium...@gmail.com:
--
nosy: +vadmium
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23237
___
___
Python-bugs-list
Nick Coghlan added the comment:
Regarding the extraneous whitespace changes in modsupport.h, those are courtesy
of running make patchcheck as part of preparing the commit.
--
___
Python tracker rep...@bugs.python.org
Donald Stufft added the comment:
Yea, I already upgraded pip. I did forget that we'll want to add
--disable-pip-version-check to the pip invocation inside of ensurepip.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24267
Stefan Krah added the comment:
I would go further and forbid tabs after spaces entirely. Tabs
used for indentation with spaces following for formatting are
okay (though unusual in Python).
--
nosy: +skrah
___
Python tracker rep...@bugs.python.org
New submission from Dmitry Kazakov:
collections.Counter: Formatted the code in the See also section.
collections.deque.remove: Removed the first occurrence of value. - Remove
...
collections.deque.index (a followup from issue23704):
Changed [, end] to [, stop] in the signature, because
Nick Coghlan added the comment:
Attached patch is the one I'm looking to commit, but -R 3:3 shows significant
reference leaks in test_importlib, and possible problems in other tests as well.
I'm about to revert it to see if there were any pre-existing refleak issues
before applying this.
New submission from Nick Coghlan:
Tracking issue for the PEP 485 math.isclose() implementation:
https://www.python.org/dev/peps/pep-0485/
Chris's implementation review request to python-dev:
https://mail.python.org/pipermail/python-dev/2015-May/140031.html
Working repo:
Mark Lawrence added the comment:
From https://www.python.org/dev/peps/pep-0008/
quote
Tabs or Spaces?
Spaces are the preferred indentation method.
Tabs should be used solely to remain consistent with code that is already
indented with tabs.
Python 3 disallows mixing the use of tabs and
Nick Coghlan added the comment:
Initial implementation checked in at
https://hg.python.org/cpython/rev/e729b946cc03
Larry, FYI regarding the refleak in test_importlib I just committed: as
described in the commit message, I'm pretty sure it's a real refleak in the
current PEP 489
Roundup Robot added the comment:
New changeset 7f2e6f236202 by Nick Coghlan in branch 'default':
Issue #24268: Address some PEP 489 refleaks
https://hg.python.org/cpython/rev/7f2e6f236202
--
nosy: +python-dev
___
Python tracker rep...@bugs.python.org
Petr Viktorin added the comment:
FWIW, the remaining refleak occurs when unloading an extension module object.
This is something that wasn't possible before PEP 489 -- extension modules were
never deleted.
--
___
Python tracker
Changes by Raymond Hettinger raymond.hettin...@gmail.com:
--
assignee: docs@python - rhettinger
nosy: +rhettinger
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24269
___
Raymond Hettinger added the comment:
Thanks for the patch. I've applied all of it except for the expansion of code
in the multiset example where I've keep the style of the itertools recipes.
--
___
Python tracker rep...@bugs.python.org
Changes by Raymond Hettinger raymond.hettin...@gmail.com:
--
resolution: - fixed
stage: - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24269
___
Roundup Robot added the comment:
New changeset 4d92ce08de6a by Raymond Hettinger in branch 'default':
Issue #24269: Minor doc fixups.
https://hg.python.org/cpython/rev/4d92ce08de6a
--
nosy: +python-dev
___
Python tracker rep...@bugs.python.org
Changes by Raymond Hettinger raymond.hettin...@gmail.com:
--
assignee: docs@python - rhettinger
resolution: - fixed
stage: patch review - resolved
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24204
Nick Coghlan added the comment:
Thanks, that reduces the refleaks shown for ./python -m test -R3:3
test_importlib from 102 to 50 for me.
However, I suspect there may still be a leak in the machinery, as I'm still
seeing the total number of objects growing when importing the array module and
New submission from Ram Rachum:
I was trying to read this page:
https://www.python.org/dev/peps/pep-0492/#acceptance
On my mobile. (Nexus 5, chrome.) But when scrolling down the page, the browser
sometimes scrolls up to the top of the page. This makes reading very annoying
because I have to
Roundup Robot added the comment:
New changeset 710cdba13323 by Benjamin Peterson in branch '3.2':
allow square brackets in cookie values (closes #22931)
https://hg.python.org/cpython/rev/710cdba13323
New changeset c7b3a50a2f01 by Benjamin Peterson in branch '3.3':
merge 3.2 (#22931)
Roundup Robot added the comment:
New changeset a811f5561c99 by Steve Dower in branch 'default':
Issue #24268: Fixes generation of init import name on Windows.
https://hg.python.org/cpython/rev/a811f5561c99
--
___
Python tracker rep...@bugs.python.org
Steve Dower added the comment:
For the sake of getting things running again, I went ahead and fixed the format
string in dynload_win.c. Feel free to change it again if that isn't what was
intended.
--
nosy: +steve.dower
___
Python tracker
Tom Tanner added the comment:
is this going to be fixed in 2.7.10?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21718
___
___
Python-bugs-list
Eric Snow added the comment:
Good point, Nick. I'd checked that earlier but did not see any relationship.
At this point it's worth checking again. :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16991
Petr Viktorin added the comment:
Fix some refleaks
- one in PyModule_FromDefAndSpec2 - this is my fault
- one in PyType_FromSpecWithBases - I guess this is
the first time PEP-384 built-in types are GC'd
- one in the new PEP 489 tests
There's still one more in the new testing module,
Ned Deily added the comment:
Problems with the python.org website are tracked at
https://github.com/python/pythondotorg/issues. This is a duplicate of
https://github.com/python/pythondotorg/issues/531.
--
nosy: +ned.deily
resolution: - third party
stage: - resolved
status: open -
Carol Willing added the comment:
Updated patch with Terry's suggested changes. Thanks Terry and Raymond for the
review of the initial patch.
--
Added file: http://bugs.python.org/file39476/iss24204b.patch
___
Python tracker rep...@bugs.python.org
Changes by Steve Dower steve.do...@microsoft.com:
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23970
___
Roundup Robot added the comment:
New changeset 367e3923532f by Raymond Hettinger in branch 'default':
Issue #24204: Elaborate of the str.strip() documentation.
https://hg.python.org/cpython/rev/367e3923532f
--
nosy: +python-dev
___
Python tracker
Changes by Raymond Hettinger raymond.hettin...@gmail.com:
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24204
___
___
Raymond Hettinger added the comment:
Serhiy, go ahead and apply your patch, lru_cache2.patch. I'll fix-up the
make_key() code after the beta1 (like the pure python version, it needs to
guarantee that hash is called no more than once per key).
--
assignee: rhettinger -
Nick Coghlan added the comment:
Once we sort these out, any that impact Python 3.4 (like the
PyType_FromSpecAndBases one) should be backported to the maintenance branch.
I wouldn't assume the one you found in PyType_FromSpecAndBases is the only one,
though - I believe the tests for this PEP
Petr Viktorin added the comment:
The array module is good if you *really* drop references:
$ ./python -X showrefcount
Python 3.5.0a4+ (default, May 23 2015, 16:44:38)
[GCC 4.9.2 20150212 (Red Hat 4.9.2-6)] on linux
Type help, copyright, credits or license for more information.
import sys, gc
Roundup Robot added the comment:
New changeset b2ee6206fa5e by Steve Dower in branch 'default':
Issue #23970: Adds distutils._msvccompiler for new Visual Studio versions.
https://hg.python.org/cpython/rev/b2ee6206fa5e
--
nosy: +python-dev
___
Python
Tom Tanner added the comment:
The patch is waiting for inclusion in 2.7.10 :/
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21114
___
___
Benjamin Peterson added the comment:
b2ee6206fa5e broke every non-Windows buildbot.
http://buildbot.python.org/all/builders/AMD64%20Snow%20Leop%203.x/builds/3229/steps/test/logs/stdio
--
nosy: +benjamin.peterson
resolution: fixed -
status: closed - open
Serhiy Storchaka added the comment:
The OrderedCounter recipe doesn't support well multiset operations, because the
result type is hardcoded to Counter. The order is already scrambled. update()
and substract() don't work well with overloaded __missing__().
Proposed implementations of __add__
Changes by Berker Peksag berker.pek...@gmail.com:
--
nosy: +berker.peksag
versions: -Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24209
___
Roundup Robot added the comment:
New changeset 32e6123f9f8c by Steve Dower in branch 'default':
Issue #23970: Fixes bdist_wininst not working on non-Windows platform.
https://hg.python.org/cpython/rev/32e6123f9f8c
--
___
Python tracker
Ned Deily added the comment:
One workaround should be to disable network proxy lookups by defining the
environment variable 'no_proxy' with value '*' in the Python process, for
example:
env no_proxy='*' python3.4 ...
--
___
Python tracker
Jim Jewett added the comment:
Eric, unless I'm misreading your debugging info, it is the other way around --
something is in the dict, but not in the list that you iterate over.
And since the list that you iterate over looks right, I have to wonder if it
was something
Jim Jewett added the comment:
(Just putting my review summary in the main ticket)
I'm going to echo the previous comment that maybe trying to emulate the
existing dict implementation too carefully just adds complexity.
The split-keys implementation shows that there is at least some
Serhiy Storchaka added the comment:
Unfortunately the patch caused a crash in test_ipaddress. Larry granted special
exclusion for adding this feature after feature freeze if it will be fixed
before beta 2.
--
___
Python tracker
New submission from Jim Jewett:
The specialized lookdict_* variants replace themselves with the generic
lookdict as soon as a non-unicode key is looked up.
They could reasonably leave the replacement to insertdict (line 819, currently
assert rather than a replacement), when a non-unicode
Jim Jewett added the comment:
Should dictobject.h get a bit more changes? In particular, should the
following be expanded?
#define PyDictKeys_Check(op) (Py_TYPE(op) == PyDictKeys_Type)
#define PyDictItems_Check(op) (Py_TYPE(op) == PyDictItems_Type)
#define PyDictValues_Check(op) (Py_TYPE(op)
New submission from Jim Jewett:
https://hg.python.org/cpython/file/2df7c958974e/Objects/dictobject.c#l451
The comments near lookdict suggest that specialized versions such as
lookdict_unicode and lookdict_unicode_nodummy cannot return NULL, as that would
indicate an Exception was raised
96 matches
Mail list logo
