[issue25406] OrderedDict.move_to_end may cause crash in python 3.5

Changes by Eric Snow : -- assignee: -> serhiy.storchaka ___ Python tracker ___

[issue25406] OrderedDict.move_to_end may cause crash in python 3.5

Eric Snow added the comment: @Serhiy, patch LGTM. Thanks for taking care of it. -- stage: patch review -> commit review ___ Python tracker ___

[issue25406] OrderedDict.move_to_end may cause crash in python 3.5

Changes by Serhiy Storchaka : -- nosy: +eric.snow ___ Python tracker ___ ___

[issue25406] OrderedDict.move_to_end may cause crash in python 3.5

Serhiy Storchaka added the comment: Here is a patch that fixes the issue. -- stage: needs patch -> patch review ___ Python tracker ___

[issue25406] OrderedDict.move_to_end may cause crash in python 3.5

Changes by Serhiy Storchaka : -- keywords: +patch Added file: http://bugs.python.org/file40783/move_to_end_issue25406.patch ___ Python tracker

[issue23857] Make default HTTPS certificate verification setting configurable

Barry A. Warsaw added the comment: On Oct 14, 2015, at 03:20 PM, Nick Coghlan wrote: >The rationale behind "platform_default" relates to what we put in the default >config file in the RPM. If enable/disable are the only options, then as soon >as the first version ships with "disable" as the

[issue25407] Update PEP 4 to keep modules in Python 3

New submission from Brett Cannon: In https://mail.python.org/pipermail/python-dev/2015-September/141499.html I asked if people thought it was okay to deprecate modules in Python 3 but to keep them around until Python 4. People agreed and so now I need to actually execute on that plan by

[issue25406] OrderedDict.move_to_end may cause crash in python 3.5

Changes by Snivy Pang : -- nosy: +Snivy Pang ___ Python tracker ___ ___

[issue23857] Make default HTTPS certificate verification setting configurable

Nick Coghlan added the comment: The rationale behind "platform_default" relates to what we put in the default config file in the RPM. If enable/disable are the only options, then as soon as the first version ships with "disable" as the default, affected systems will *never* switch to being

[issue25405] User install of 3.5 removes py.exe from C:\Windows

Steve Dower added the comment: Part of this will be the upgrade from RC, which will behave differently from the next upgrade to 3.5.1. But I have just made some fixes in how upgrading the launcher is handled, so there's a chance this is already fixed. But I'll test this scenario too. Do you

[issue25406] OrderedDict.move_to_end may cause crash in python 3.5

Changes by Serhiy Storchaka : -- nosy: +rhettinger, serhiy.storchaka priority: normal -> critical stage: -> needs patch versions: +Python 3.6 ___ Python tracker

[issue25395] SIGSEGV using json.tool

Serhiy Storchaka added the comment: Likely this issue is related to C implementation of OrderedDict. json.tool doesn't crash with --sort-keys and doesn't crash with Python implementation of OrderedDict. The patch for similar issue25406 doesn't fix this issue. -- nosy: +eric.snow,

[issue25099] test_compileall fails when run by unprivileged user on installed Python

Changes by Brett Cannon : -- status: open -> closed ___ Python tracker ___ ___

[issue21165] Optimize str.translate() for replacement with substrings and non-ASCII strings

STINNER Victor added the comment: This issue was more a reminder for myself, and I'm not more interested to implement this optimization. The method is already fast enough. -- resolution: -> out of date status: open -> closed ___ Python tracker

[issue25406] OrderedDict.move_to_end may cause crash in python 3.5

Roundup Robot added the comment: New changeset 88e6641c3dd3 by Serhiy Storchaka in branch '3.5': Issue #25406: Fixed a bug in C implementation of OrderedDict.move_to_end() https://hg.python.org/cpython/rev/88e6641c3dd3 New changeset 33d53a41daeb by Serhiy Storchaka in branch 'default': Issue

[issue25339] sys.stdout.errors is set to "surrogateescape"

STINNER Victor added the comment: Sorry, I don't understand the issue. Do you consider that using surrogateescape is a bug? Which behaviour do you expect? Python 3.5 now uses surrogateescape by default for stdout and stderr when the locale is POSIX. I guess that you got the POSIX locale

[issue25164] Windows default installation path is inconsistent between per-user and system-wide installation

Steve Dower added the comment: I don't think it will be a significant breaking change at this stage to update the default all-user install directory, since everyone *should* be resolving it through the registry keys or overriding it on installation. Upgrading from 3.5.0 will not change to the

[issue8952] Doc/c-api/arg.rst: fix documentation of number formats

STINNER Victor added the comment: This issue is now 5 years old and it doesn't contain much information. It's more a TODO item, and I'm not more interested to work on it. So I close the issue. If you want to work on the doc, please write a patch ;-) -- nosy: +haypo resolution: -> out

[issue25164] Windows default installation path is inconsistent between per-user and system-wide installation

Roundup Robot added the comment: New changeset be92f6ce1e80 by Steve Dower in branch '3.5': Issue #25164: Changes default all-users install directory to match per-user directory. https://hg.python.org/cpython/rev/be92f6ce1e80 -- nosy: +python-dev

[issue25400] robotparser doesn't return crawl delay for default entry

Peter Wirtz added the comment: On further inspection of the tests, it appears that the way in which the tests are written, a test case can only be tested for one useragent at a time. I will attempt to work on the tests so work correctly. Any advice would be much appreciated. --

[issue25339] sys.stdout.errors is set to "surrogateescape"

Serhiy Storchaka added the comment: I'm not sure this is a bug, but it looks at least unexpected, that surrogateescape is used with non-ASCII encoding. For example my last test for issue19058 fails on POSIX locale in 3.5+, and it is not so easy to make it working. May be change error handler

[issue23857] Make default HTTPS certificate verification setting configurable

Nick Coghlan added the comment: Yeah, it's the extra 5 years on RHEL 7 that makes me wary. For anything with a shorter life cycle, letting the legacy setting age out likely makes more sense. -- ___ Python tracker

[issue25210] Special-case NoneType() in do_richcompare()

STINNER Victor added the comment: > It looks like some of the example sessions in the documentation will become > out of date. Not sure if that is a problem. Ah yes, I updated them. Thanks for the review. -- resolution: -> fixed status: open -> closed

[issue25210] Special-case NoneType() in do_richcompare()

Roundup Robot added the comment: New changeset 0238eafb68da by Victor Stinner in branch 'default': Issue #25210: Change error message of do_richcompare() https://hg.python.org/cpython/rev/0238eafb68da -- nosy: +python-dev ___ Python tracker

[issue25406] OrderedDict.move_to_end may cause crash in python 3.5

Serhiy Storchaka added the comment: Thank you for your review Eric. -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker

[issue25400] robotparser doesn't return crawl delay for default entry

Berker Peksag added the comment: Thanks for the patch Peter(and welcome to Python and open source development). I have a WIP patch to rewrite test_robotparser in a less magic way. So we can ignore test failures for now. I'll take a closer look to your patch. -- stage: -> patch review

[issue25372] load_module() does not link submodule to parent package

Martin Panter added the comment: My use case is for Readline auto-completion, to list submodules of a package given by the user, without importing anything unnecessary. The original code is compatible with Python 2, but I am also writing a patch for 3.6 that wouldn't need that. The original

[issue24782] Merge 'configure extensions' into main IDLE config dialog

Terry J. Reedy added the comment: There is one issue. The window is wider now, I suspect because of the extension frame, which is wider than it need to be, at least for now. I will try adjusting it. -- ___ Python tracker

[issue25399] Optimize bytearray % args

STINNER Victor added the comment: Microbenchmark result below. Most operations are now between 2.5 and 5 times faster. %f is as-fast, probably because formatting a float is more expensive than copying bytes (raw estimation: 150 ns to format a single floating pointer number). Common platform:

[issue25400] robotparser doesn't return crawl delay for default entry

Changes by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker ___ ___

[issue25401] Optimize bytes.fromhex() and bytearray.fromhex()

New submission from STINNER Victor: Attached patch optimizes bytes.fromhex() and bytearray.fromhex(): * Fast-path working on a char* string for ASCII string * Slow-path for non-ASCII string * Replace slow hex_digit_to_int() function with a O(1) lookup in _PyLong_DigitValue precomputed table *

[issue25399] Optimize bytearray % args

Changes by STINNER Victor : -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue25401] Optimize bytes.fromhex() and bytearray.fromhex()

STINNER Victor added the comment: It's between 2 and 3.5x faster. It's 9% slower on short string (10 bytes for the output), but I consider that the speedup is more interesting than the slowdown on short strings. RMicrobenchmark: Common platform: Platform:

[issue25401] Optimize bytes.fromhex() and bytearray.fromhex()

Roundup Robot added the comment: New changeset 55d207a637ff by Victor Stinner in branch 'default': Optimize bytes.fromhex() and bytearray.fromhex() https://hg.python.org/cpython/rev/55d207a637ff -- nosy: +python-dev ___ Python tracker

[issue25399] Optimize bytearray % args

Roundup Robot added the comment: New changeset 03646293f1b3 by Victor Stinner in branch 'default': Fix long_format_binary() https://hg.python.org/cpython/rev/03646293f1b3 New changeset 6fe0050a2f52 by Victor Stinner in branch 'default': Add use_bytearray attribute to _PyBytesWriter

[issue25401] Optimize bytes.fromhex() and bytearray.fromhex()

Changes by STINNER Victor : -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue25339] sys.stdout.errors is set to "surrogateescape"

STINNER Victor added the comment: "it looks at least unexpected, that surrogateescape is used with non-ASCII encoding" What do you mean by non-ASCII encoding? surrogateescape is used by all encodings for all OS operations on Python 3, like os.listdir(), even for UTF-8. --

[issue25408] Consider dropping html5lib and spambayes from the default benchmark set

Changes by Brett Cannon : -- assignee: -> brett.cannon ___ Python tracker ___ ___

[issue25408] Consider dropping html5lib and spambayes from the default benchmark set

Antoine Pitrou added the comment: This all sounds good to me. -- ___ Python tracker ___ ___ Python-bugs-list

[issue25023] time.strftime('%a'), ValueError: embedded null byte, in ko locale

Steve Dower added the comment: I can confirm that this is fixed in an upcoming Windows update: Python 3.5.0 (v3.5.0:374f501f4567, Sep 13 2015, 02:27:37) [MSC v.1900 64 bit (AMD64)] on win32 Type "help", "copyright", "credits" or "license" for more information. >>> import locale, time >>>

[issue25370] Add support of pickling very large bytes and str objects with protocol < 4

Serhiy Storchaka added the comment: Changed tests and fixed bugs. Could anyone please test the patch with bigmem pickle tests? Tests need at least 32GB of memory, I have no such much memory. -- Added file: http://bugs.python.org/file40781/pickle_large_strings_2.patch

[issue25370] Add support of pickling very large bytes and str objects with protocol < 4

Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file40774/pickle_large_strings.patch ___ Python tracker ___

[issue25338] urllib bypasses all hosts if proxyoverride includes an empty element

Jung-chih Wei added the comment: I believe IE ignores the empty element because I must access the internet through proxy. And please refer to http://mxr.mozilla.org/mozilla-central/source/toolkit/system/windowsproxy/nsWindowsSystemProxySettings.cpp#177, Firefox also ignores the empty element.

[issue25403] urllib.parse.urljoin is broken in python 3.5

New submission from Pavel Ivanov: urllib.parse.urljoin does not conform the RFC 1808 in case of joining relative URL’s containing ‘..’ path components anymore. Examples: Python 3.4: >>> urllib.parse.urljoin('http://a.com', '..') 'http://a.com/..' Python 3.5: >>>

[issue25404] ssl.SSLcontext.load_dh_params() does not handle unicode filenames properly

STINNER Victor added the comment: Right. The workaround is to encode manually the filename: filename = filename.encode(sys.getfilesystemencoding()) -- ___ Python tracker

[issue25404] ssl.SSLcontext.load_dh_params() does not handle unicode filenames properly

Changes by STINNER Victor : -- components: +Unicode, Windows nosy: +ezio.melotti, haypo, paul.moore, steve.dower, tim.golden, zach.ware ___ Python tracker

[issue25402] Accurater estimation of the number of digits in int to decimal string conversion

New submission from Serhiy Storchaka: Int to decimal string conversion (function long_to_decimal_string_internal() at Objects/longobject.c:1583) has a limitation. On 32-bit platform you can't convert integers larger than 2**2**31 (10**646456993). Proposed patch removes this limitation [*].

[issue25404] ssl.SSLcontext.load_dh_params() does not handle unicode filenames properly

New submission from Michael Schlenker: The load_dh_params() method of SSLContext does not properly handle unicode filenames on Windows (like load_verify_location() does). It should convert any passed unicode path to the filesystem encoding. This is already fixed in the 3.x head revision, by

[issue25404] ssl.SSLcontext.load_dh_params() does not handle unicode filenames properly

Michael Schlenker added the comment: Yes, the workaround works. Would be nice if this could be fixed in a 2.7.11... -- ___ Python tracker ___

[issue25384] Use _PyBytesWriter in the binascii module

Roundup Robot added the comment: New changeset 32b17c3b3cf3 by Victor Stinner in branch 'default': Issue #25384: Fix binascii.rledecode_hqx() https://hg.python.org/cpython/rev/32b17c3b3cf3 -- ___ Python tracker

[issue23857] Make default HTTPS certificate verification setting configurable

Barry A. Warsaw added the comment: Re: platform_default - I'm not sure that's a good idea. It hides what's actually happening in some hard to discover place (the code). Probably EIBTI and just go with 'enable' and 'disable'. -- ___ Python tracker

[issue25401] Optimize bytes.fromhex() and bytearray.fromhex()

Roundup Robot added the comment: New changeset 09e0533f3694 by Victor Stinner in branch 'default': Issue #25401: Remove now unused hex_digit_to_int() function https://hg.python.org/cpython/rev/09e0533f3694 -- ___ Python tracker

[issue19058] test_sys.test_ioencoding_nonascii() fails with ASCII locale encoding

STINNER Victor added the comment: > What could you say about the recent patch Victor? I'm not sure that it works in all cases. io.TextIOWrapper doesn't care to normalize the encoding name. You should use something like: encoding = codecs.lookup(encoding).name Otherwise, the test can fail

[issue25408] Consider dropping html5lib and spambayes from the default benchmark set

New submission from Brett Cannon: The spambayes and html5lib benchmarks are not compatible with Python 3, so I think we should remove them from the default set (they can obviously stay in the benchmark suite). And while I'm thinking about it, maybe pull etree since we already have the JSON

[issue25400] robotparser doesn't return crawl delay for default entry

Peter Wirtz added the comment: Ok, for the mean time, I reworked the test so it appears to test correctly and tests passes. There does seem to be some magic, so I do hope I did not overlook anything. Here is the new patch. -- Added file:

[issue25406] OrderedDict.move_to_end may cause crash in python 3.5

New submission from Cruise Liu: Following code will crash python. Tested on linux and windows. Python 3.5.0 (default, Sep 20 2015, 11:28:25) [GCC 5.2.0] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import collections >>> x = collections.OrderedDict([

[issue25372] load_module() does not link submodule to parent package

R. David Murray added the comment: Well, once you've loaded the module and added it to the namespace of the parent package, you've imported it. Since import_module is available in 2.7, it sounds like that satisfies your use case. -- ___ Python

[issue25405] User install of 3.5 removes py.exe from C:\Windows

New submission from Paul Moore: I have had a user install of Python 3.5rc3 for some time on one of my PCs. It also had plenty of other versions on there - 3.4, 3.3, 2.7 and 2.6. The 3.5rc3 install was a user install. I have my Python 3.4 install set up on PATH, and I've configured py.ini to

[issue21475] Support the Sitemap extension in robotparser

Peter Wirtz added the comment: I would like to tackle this issue. Should I wait for issue25400 to be resolved first? -- nosy: +pwirtz ___ Python tracker

[issue16113] SHA-3 (Keccak) support may need to be removed before 3.4

STINNER Victor added the comment: I agree with Larry. If this feature is super useful, we can consider adding it to stable versions later. -- ___ Python tracker

[issue16113] SHA-3 (Keccak) support may need to be removed before 3.4

Larry Hastings added the comment: I should clarify, I don't speak for 2.7. The rules there are a little different and it's up to Benjamin to decide. But please don't add new features to 3.4 and 3.5. -- ___ Python tracker