[issue25814] Propagate all errors from ElementTree.iterparse

2015-12-06 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: Some memory errors raised in handlers during XML parsing are explicitly or implicitly propagated to the caller of XMLParser methods feed(), close(), and _parse_whole(). But others are silenced with PyErr_Clear() with added comments "FIXME: propagate

[issue25701] Document that tp_setattro and tp_setattr are used for deleting attributes

2015-12-06 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I think the conclusion of Python_Dev discussion is that it is not worth to deprecate this behavior in the code. Current behavior of PyObject_SetAttr and PySequence_SetItem should be documented with a deprecation notice. --

[issue25717] tempfile.TemporaryFile fails when dir option set to directory residing on host OS mount

2015-12-06 Thread STINNER Victor
STINNER Victor added the comment: Thank you. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue1322] Deprecate platform.dist() and platform.linux_distribution() functions

2015-12-06 Thread Nir Cohen
Nir Cohen added the comment: I have a premliminary implementation of it: https://github.com/nir0s/ld Would love some help. It tries to use adhere to the standards (os-release first, lsb-release later, then, distro-specific release files). It also returns more types of values then there were

[issue25810] Python 3 documentation for eval is incorrect

2015-12-06 Thread R. David Murray
R. David Murray added the comment: As I recall it, in the python2 docs we used the [... notation, sometimes even when the actual arguments were or accepted keywords. In the python3 docs we converted to always using keyword notation...and then realized that that also caused confusion, in the

[issue1322] Deprecate platform.dist() and platform.linux_distribution() functions

2015-12-06 Thread Matthias Klose
Matthias Klose added the comment: this is not "fixable". and now when parsing os-release you get different values then you got before, e.g. changing "Ubuntu" to "ubuntu". -- ___ Python tracker

[issue25638] Verify the etree_parse and etree_iterparse benchmarks are working appropriately

2015-12-06 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you for your review Brett. First than apply this optimization I want to fix errors propagating issue (issue25814). The patch for it is mainly the simplified part of the patch for this issue. -- dependencies: +Propagate all errors from

[issue1322] Deprecate platform.dist() and platform.linux_distribution() functions

2015-12-06 Thread Nir Cohen
Nir Cohen added the comment: I didn't mean to say that it was. Still, it's important to have some implementation of identifying linux distributions and their properties.. -- ___ Python tracker

[issue24682] Add Quick Start: Communications section to devguide

2015-12-06 Thread R. David Murray
R. David Murray added the comment: Carol: as part of requesting a commit you can set the stage to 'commit review' (I've done that for this one) and that may lead to at least a couple of us noticing it where we wouldn't otherwise :) -- nosy: +r.david.murray stage: patch review ->

[issue25495] binascii documentation incorrect

2015-12-06 Thread R. David Murray
R. David Murray added the comment: See also Issue 1753718. I will try to review both of these issues soon. -- ___ Python tracker ___

[issue1753718] base64 "legacy" functions violate RFC 3548

2015-12-06 Thread R. David Murray
R. David Murray added the comment: See also the discussion in issue 25495. I will try to review both of these issues soon. -- nosy: +r.david.murray versions: +Python 3.4, Python 3.5, Python 3.6 -Python 3.1, Python 3.2 ___ Python tracker

[issue25717] tempfile.TemporaryFile fails when dir option set to directory residing on host OS mount

2015-12-06 Thread STINNER Victor
STINNER Victor added the comment: Martin, please add a comment to explain the rationale on ignoring errors other than EBADF. At least, mention this issue number. -- ___ Python tracker

[issue14285] Traceback wrong on ImportError while executing a package

2015-12-06 Thread Nick Coghlan
Nick Coghlan added the comment: Ah, I think I understand the problem you're getting at now: * if the parent package is missing entirely, we still want to suppress the traceback by throwing the runpy specific exception * if the parent package is present, but one of the modules *that* tries to

[issue22742] IDLE shows traceback when printing non-BMP character

2015-12-06 Thread irdb
Changes by irdb : -- nosy: +irdb ___ Python tracker ___ ___ Python-bugs-list mailing

[issue21084] IDLE can't deal with characters above the range (U+0000-U+FFFF)

2015-12-06 Thread irdb
Changes by irdb : -- nosy: +irdb ___ Python tracker ___ ___ Python-bugs-list mailing

[issue13153] IDLE crashes when pasting non-BMP unicode char on Py3

2015-12-06 Thread irdb
Changes by irdb : -- nosy: +irdb ___ Python tracker ___ ___ Python-bugs-list mailing

[issue25813] co_flags section of inspect module docs out of date

2015-12-06 Thread Mark Lawrence
Mark Lawrence added the comment: None of these constants are documented either:- inspect.CO_COROUTINE inspect.CO_GENERATOR inspect.CO_ITERABLE_COROUTINE inspect.CO_NESTED inspect.CO_NEWLOCALS inspect.CO_NOFREE inspect.CO_OPTIMIZED inspect.CO_VARARGS inspect.CO_VARKEYWORDS --

[issue25717] tempfile.TemporaryFile fails when dir option set to directory residing on host OS mount

2015-12-06 Thread Martin Panter
Martin Panter added the comment: Okay will do -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue25717] tempfile.TemporaryFile fails when dir option set to directory residing on host OS mount

2015-12-06 Thread Roundup Robot
Roundup Robot added the comment: New changeset e9bf5803b716 by Martin Panter in branch '3.5': Issue #25717: Add comment explaining why errors are ignored https://hg.python.org/cpython/rev/e9bf5803b716 New changeset 8bf69413ec01 by Martin Panter in branch 'default': Issue #25717: Merge comment

[issue6395] Infinite Recursion during Unpickling a codecs Object

2015-12-06 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: There is also a problem with deepcopying: >>> class MemReader: ... def __init__(self, data): ... self.buf = memoryview(data).cast('B') ... def read(self, size=-1): ... if size < 0: ... size = len(self.buf) ... res =

[issue25638] Verify the etree_parse and etree_iterparse benchmarks are working appropriately

2015-12-06 Thread Roundup Robot
Roundup Robot added the comment: New changeset dd67c8c53aea by Serhiy Storchaka in branch 'default': Issue #25638: Optimized ElementTree.iterparse(); it is now 2x faster. https://hg.python.org/cpython/rev/dd67c8c53aea -- nosy: +python-dev ___ Python

[issue25701] Document that tp_setattro and tp_setattr are used for deleting attributes

2015-12-06 Thread Martin Panter
Martin Panter added the comment: setattr.3.patch changes to documenting setting as the main purpose, but mentions deleting also works but is deprecated in favour of the main deletion functions. I also clarified that the slots have to support deleting via NULL. -- Added file:

[issue25194] Opt-in motivations & affiliations page for core contributors

2015-12-06 Thread Jesús Cea Avión
Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing

[issue25815] Improper subprocess output of arguments with braces in them on windows

2015-12-06 Thread Eryk Sun
Eryk Sun added the comment: Using the cmd shell's "echo" command requires shell=True. You must have an "echo.exe" somewhere in your PATH. Check "where echo" in cmd. -- nosy: +eryksun ___ Python tracker

[issue25815] Improper subprocess output of arguments with braces in them on windows

2015-12-06 Thread Anthony Sottile
Anthony Sottile added the comment: It *is* in my path (otherwise it wouldn't produce any output at all). I'm not trying to use the shell builtin, I'm trying to use the executable. -- resolution: not a bug -> status: closed -> open ___ Python

[issue24682] Add Quick Start: Communications section to devguide

2015-12-06 Thread Carol Willing
Carol Willing added the comment: R. David Murray wrote: > > R. David Murray added the comment: > > Carol: as part of requesting a commit you can set the stage to 'commit > review' (I've done that for this one) and that may lead to at least a > couple of us noticing it where we wouldn't

[issue25761] Improve unpickling errors handling

2015-12-06 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: When pickle stream is unexpectedly ended, different exceptions can be raised. EOFError("Ran out of input") is raised when the stream is unexpectedly ended without the STOP opcode. But it can be raised also when the data for the opcode is incomplete. Other

[issue18967] Find a less conflict prone approach to Misc/NEWS

2015-12-06 Thread Jesús Cea Avión
Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing

[issue25809] "Invalid" tests on locales

2015-12-06 Thread Martin Panter
Martin Panter added the comment: Some history: 1. Issue 23474 (Feb 2015): Testing fr_FR thousands_sep = ASCII space 2. Issue 24299 (Jun 2015): Changed to fr_FR.UTF-8 because Solaris uses the non-breaking space if it can be encoded as a single byte (i.e Latin-1) So I tend to agree with Serhiy

[issue10351] Add autocompletion for keys in dictionaries

2015-12-06 Thread Martin Panter
Martin Panter added the comment: Some thoughts and observations from trying this patch out: * It supports single and double quotes, but triple-quoted strings get trashed * It supports Python 2’s u". . ." syntax, but not r". . .", b". . .", etc * It supports integer keys, but not indexes of

[issue25815] Improper subprocess output of arguments with braces in them on windows

2015-12-06 Thread Anthony Sottile
Anthony Sottile added the comment: To clarify further, the echo.exe on my path reacts correctly: ``` Anthony@AnthonysDesktop MINGW64 ~/Desktop/git/pre-commit (allow_curly_braces_in_args) $ /usr/bin/echo hi{1} hi{1} Anthony@AnthonysDesktop MINGW64 ~/Desktop/git/pre-commit

[issue14285] Traceback wrong on ImportError while executing a package

2015-12-06 Thread Martin Panter
Martin Panter added the comment: The test suite does check run_module() with some relative names; see test_invalid_names() in test_runpy. But there does not appear to be a test for “python -m .relative”. Changes in init-ancestor.3.patch: * Added a comment explaining the exception handling *

[issue25610] Add typing.Awaitable

2015-12-06 Thread Guido van Rossum
Guido van Rossum added the comment: Fixed by e9aeae1b2ea9 in 3.5, ad855c779bf3 in 3.6.] -- versions: +Python 3.5 ___ Python tracker ___

[issue25815] Improper subprocess output of arguments with braces in them on windows

2015-12-06 Thread Anthony Sottile
New submission from Anthony Sottile: First some expected output: ``` # from cmd.exe C:\Users\Anthony>echo hi{1} hi{1} # from MINGW $ echo hi{1} hi{1} ``` ``` # On ubuntu $ echo 'hi{1}' hi{1} $ python3.5 -c "import subprocess; print(subprocess.check_output(('echo', 'hi{1}')))" b'hi{1}\n' ```

[issue25814] Propagate all errors from ElementTree.iterparse

2015-12-06 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue14285] Traceback wrong on ImportError while executing a package

2015-12-06 Thread Nick Coghlan
Nick Coghlan added the comment: +1, latest iteration looks good to me. -- ___ Python tracker ___ ___

[issue25815] Improper subprocess output of arguments with braces in them on windows

2015-12-06 Thread Emanuel Barry
Changes by Emanuel Barry : -- resolution: -> not a bug status: open -> closed ___ Python tracker ___

[issue25529] Provide access to the validated certificate chain in ssl module

2015-12-06 Thread R. David Murray
R. David Murray added the comment: If there's no reply, that would be a no :) So, pinging the issue after a month as you just did is appropriate, let's see if one of the openssl experts replies. On the other hand, how is this different from issue 24107, where Crys did reply? -- nosy:

[issue1322] Deprecate platform.dist() and platform.linux_distribution() functions

2015-12-06 Thread Nir Cohen
Nir Cohen added the comment: Apologies. This can be simply installed by running `pip install ld` (from https://pypi.python.org/pypi/ld). Some notes: * I've just now started writing tests * Haven't tested on versions other than 2.7.x and 2.6.x * There's some stray code there. This works.. but

[issue24682] Add Quick Start: Communications section to devguide

2015-12-06 Thread R. David Murray
R. David Murray added the comment: Looking over this...I'm -0. I really don't like the organization of the front page of the developers guide. The idea of a "quick start" section is fine, but is it appropriate? (I'm talking about the code quick start) The first pages of the document, to my

[issue24454] Improve the usability of the match object named group API

2015-12-06 Thread Eric V. Smith
Eric V. Smith added the comment: I've been playing around with this. My implementation is basically the naive: def __getitem__(self, value): return self.group(value) I have the following tests passing: def test_match_getitem(self): pat = re.compile('(?:(?Pa)|(?Pb))(?Pc)?')

[issue25814] Propagate all errors from ElementTree.iterparse

2015-12-06 Thread Martin Panter
Martin Panter added the comment: The patch looks good as far as I can tell. I left a question about an inconsistency with checking for a null pointer. -- nosy: +martin.panter ___ Python tracker

[issue25814] Propagate all errors from ElementTree.iterparse

2015-12-06 Thread Roundup Robot
Roundup Robot added the comment: New changeset 2df330606cd0 by Serhiy Storchaka in branch '3.4': Issue25814: Propagate all errors from custom XML parser handlers https://hg.python.org/cpython/rev/2df330606cd0 New changeset de9ef294a3ef by Serhiy Storchaka in branch '2.7': Issue25814: Propagate

[issue24682] Add Quick Start: Communications section to devguide

2015-12-06 Thread R. David Murray
R. David Murray added the comment: Well, you got agreement from Stephen :) But you are right, I had overlooked the fact that this was your patch. I also just gave Stephen Developer privs on the tracker so he can do it in the future on issues he thinks are ready. All that said, I don't think

[issue25761] Improve unpickling errors handling

2015-12-06 Thread Roundup Robot
Roundup Robot added the comment: New changeset 5c670af0100f by Serhiy Storchaka in branch 'default': Issue #25761: Improved detecting errors in broken pickle data. https://hg.python.org/cpython/rev/5c670af0100f -- ___ Python tracker

[issue25701] Document that tp_setattro and tp_setattr are used for deleting attributes

2015-12-06 Thread Martin Panter
Martin Panter added the comment: Okay, I will look at making it say deleting via SetAttr etc is possible but is not the main purpose, and using DelAttr etc is recommended instead. -- ___ Python tracker

[issue1322] Deprecate platform.dist() and platform.linux_distribution() functions

2015-12-06 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: > This deprecation and eventual removal, will result in a pypi module created > with such functionality anyway, that everyone will try to pull in or > falling that copying in. That's the plan, right. The stdlib is not the right place for things that

[issue24682] Add Quick Start: Communications section to devguide

2015-12-06 Thread Carol Willing
Carol Willing added the comment: David, I love the three paragraph intro. It captures the essence of the dev guide usage from newcomers to the project to experienced core devs. I really like the second paragraph and how it suggests focusing on the issue at hand. Thanks, and I will take these

[issue24682] Add Quick Start: Communications section to devguide

2015-12-06 Thread R. David Murray
Changes by R. David Murray : -- stage: commit review -> needs patch ___ Python tracker ___

[issue25709] Problem with string concatenation and utf-8 cache.

2015-12-06 Thread Roundup Robot
Roundup Robot added the comment: New changeset 376b100107ba by Serhiy Storchaka in branch '3.5': Issue #25709: Fixed problem with in-place string concatenation and utf-8 cache. https://hg.python.org/cpython/rev/376b100107ba -- ___ Python tracker

[issue25815] Improper subprocess output of arguments with braces in them on windows

2015-12-06 Thread Eryk Sun
Eryk Sun added the comment: AFAICT, there's no place where subprocess.Popen would be responsible for removing braces from the output. I think it's something unusual with the "echo.exe" program. In the cmd.exe shell -- i.e. no msys, bash, etc -- what do you get for the following?

[issue25815] Improper subprocess output of arguments with braces in them on windows

2015-12-06 Thread Anthony Sottile
Anthony Sottile added the comment: ``` C:\Users\Anthony> C:\Users\Anthony\AppData\Local\Programs\Git\usr\bin\echo.exe hi{1} hi1 ``` Must be the provider of echo.exe. I'll take it up with them Sorry for the trouble! -- resolution: -> not a bug status: open -> closed

[issue14771] Occasional failure in test_ioctl when run parallel with test_gdb

2015-12-06 Thread Martin Panter
Martin Panter added the comment: I found that if you redirect GDB’s stdin if fixes all the problems. I don’t fully understand what GDB is doing to change the terminal’s foreground process group. In my patch I set stdin to a pipe. It is like using DEVNULL, but should be compatible with Python

[issue25777] Misleading descriptions in docs about invoking descriptors.

2015-12-06 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- assignee: docs@python -> rhettinger nosy: +rhettinger ___ Python tracker ___

[issue24934] django_v2 benchmark not working in Python 3.6

2015-12-06 Thread Florin Papa
Florin Papa added the comment: No problem. Thank you for merging the patch! -- ___ Python tracker ___ ___

[issue25815] Improper subprocess output of arguments with braces in them on windows

2015-12-06 Thread Zachary Ware
Changes by Zachary Ware : -- stage: -> resolved ___ Python tracker ___ ___

[issue23788] test_urllib2_localnet.test_bad_address fails: OSError not raised by urlopen

2015-12-06 Thread Martin Panter
Martin Panter added the comment: Steve and/or Raniere: I suspect this is the same problem as mentioned in the giant comment, Issue 17564. In other words, it is probably your ISP or DNS which is broken, not Python. However, rather than expecting everyone to automatically read the giant wall of

[issue23788] test_urllib2_localnet.test_bad_address fails: OSError not raised by urlopen

2015-12-06 Thread Martin Panter
Martin Panter added the comment: Actually test_bad_address() in /test/test_urllib2_localnet.py looks redundant with the test of the same name in /test/test_urllibnet.py. That test already has a nice precondition to skip the test if DNS does not fail, originating in revision 7d69d04522e3. And