[issue26119] Windows Installer can sometimes silently fail pip stage

Paul Hammant added the comment: That's all the files in the %TEMP% dir beginning with Python* - right? -- ___ Python tracker ___

[issue26140] inspect.iscoroutinefunction raises TypeError when checks Mock of function or coroutinefunction

Hiroyuki Takagi added the comment: Thank you for review and comment. Honestly speaking, I couldn't find any other good place to fix it. One possible solution might be to use isinstance(mock, Mock) in iscoroutinefunction, but I don't think it's good for inspect module to add special check and

[issue26107] PEP 511: code.co_lnotab: use signed line number delta to support moving instructions in an optimizer

STINNER Victor added the comment: We have many unit test in the Python test suite which rely on exact line numbers. Examples: * test_sys_settrace * test_pdb * test_dis I know them because they were all broken when my fatoptimizer project had bugs related to line numbers :-) With my patch,

[issue6500] urllib2 maximum recursion depth exceeded

Roundup Robot added the comment: New changeset d34fdd1736f2 by Serhiy Storchaka in branch '2.7': Issue #6500: Fixed infinite recursion in urllib2.Request.__getattr__(). https://hg.python.org/cpython/rev/d34fdd1736f2 -- ___ Python tracker

[issue26121] Use C99 functions in math if available

Mark Dickinson added the comment: LGTM. What platform are the benchmarks on? Is there some way that this can be submitted to the buildbots *before* applying to the 3.6 branch, so that we can get a sense of how widespread (if at all) libm problems are? --

[issue26121] Use C99 functions in math if available

Serhiy Storchaka added the comment: The benchmarks were ran on 32-bit Linux with AMD processor. I'll try to run custom build on buildbots. -- ___ Python tracker

[issue26101] Lib/test/test_compileall.py fails when run directly

Roundup Robot added the comment: New changeset c6a0f424837a by Victor Stinner in branch 'default': Fix test_compilepath() of test_compileall https://hg.python.org/cpython/rev/c6a0f424837a -- nosy: +python-dev ___ Python tracker

[issue26107] PEP 511: code.co_lnotab: use signed line number delta to support moving instructions in an optimizer

STINNER Victor added the comment: Patch version 2 to take Serhiy's review in account: * complete Objects/lnotab_notes.txt update. Replace (300, 300) delta example with (300, 200) delta for better readability (300 is the bytecode offset delta, 200 is the line number delta) * fix added

[issue26145] PEP 511: Add sys.set_code_transformers()

STINNER Victor added the comment: Missing patch for test_sys testing the new sys.get/set_code_transformers() functions. -- Added file: http://bugs.python.org/file41644/test_sys.patch ___ Python tracker

[issue26100] PEP 511: Add test.support.optim_args_from_interpreter_flags()

Changes by STINNER Victor : -- title: Add test.support.optim_args_from_interpreter_flags() -> PEP 511: Add test.support.optim_args_from_interpreter_flags() ___ Python tracker

[issue6500] urllib2 maximum recursion depth exceeded

Serhiy Storchaka added the comment: Thank you for the review Senthil. -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker

[issue26100] Add test.support.optim_args_from_interpreter_flags()

STINNER Victor added the comment: Lib/distutils/util.py must also be modified: see attached distutils.patch. -- Added file: http://bugs.python.org/file41642/distutils.patch ___ Python tracker

[issue26107] PEP 511: code.co_lnotab: use signed line number delta to support moving instructions in an optimizer

STINNER Victor added the comment: Brett Cannon added the comment: > I just wanted to comment on "don't change importlib MAGIC: we only change it > between Python minor versions": that's actually not true. Feel free to up the > number whenever you make a change that affects eval.c or bytecode.

[issue25731] Assigning and deleting __new__ attr on the class does not allow to create instances of this class

Bohuslav "Slavek" Kabrda added the comment: Hi, I'm maintainer of flexmock [1] and some users of my library have started hitting this bug [2] - when one tries to mock __new__ and then revert this mock at the end of testcase to the original one (either by deleting the mock __new__ or replacing

[issue25843] lambdas on the same line may incorrectly share code objects

STINNER Victor added the comment: FYI this issue is linked to the issue #26146 which allows to emit constants from an AST optimizer (see also the PEP 511). -- ___ Python tracker

[issue26146] PEP 511: Add ast.Constant to allow AST optimizer to emit constants

STINNER Victor added the comment: To support emiting constants from ast.Constant, we will also need the fix for the issue #25843. Currently, the compile merges constants (0, 0) and (0.0, 0.0) because they are equal, but item types are different. --

[issue21847] Fix xmlrpc in unicodeless build

Roundup Robot added the comment: New changeset f602dfd35cd4 by Serhiy Storchaka in branch '2.7': Issue #21847: Fixed xmlrpclib and tests on Unicode-disabled builds. https://hg.python.org/cpython/rev/f602dfd35cd4 -- nosy: +python-dev ___ Python

[issue21847] Fix xmlrpc in unicodeless build

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka dependencies: -Fix unicodeless build of Python resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue9006] xml-rpc Server object does not propagate the encoding to Unmarshaller

Roundup Robot added the comment: New changeset 04e95f05aafe by Serhiy Storchaka in branch '2.7': Issue #9006: Added tests for XML RPC with non-UTF-8 encoding. https://hg.python.org/cpython/rev/04e95f05aafe New changeset 59cb8811286a by Serhiy Storchaka in branch '3.5': Issue #9006: Added tests

[issue26146] PEP 511: Add ast.Constant to allow AST optimizer to emit constants

Brett Cannon added the comment: Would it make sense to tag the type of the constant in the node somehow? We also make no backwards-compatibility guarantees about the AST, so if it simplifies things to switch entirely to Constant from Num, etc. then I said do it. --

[issue26146] PEP 511: Add ast.Constant to allow AST optimizer to emit constants

New submission from STINNER Victor: Currently, the Python parser emits ast.Tuple AST nodes which are compiled to multiple LOAD_xxx instructions followed a final BUILD_TUPLE instruction. The Python peephole optimizer detect LOAD_CONST x n + BUILD_TUPLE instructions to replace it directly with

[issue557704] netrc module can't handle all passwords

R. David Murray added the comment: If it is a matter of following "the normal rules" about quoting in a place where we currently don't do that, I think it would be sensible to add it, but IMO it should be the full set of "normal rules". Presumably shlex provides facilities to do that...I

[issue9006] xml-rpc Server object does not propagate the encoding to Unmarshaller

Changes by Serhiy Storchaka : -- resolution: -> rejected stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue26147] Encoding errors in xmlrpc

New submission from Serhiy Storchaka: Proposed patch fixes issue with sending non-encodable string via XML RPC. This issue caused raising an exception or even hanging. -- components: Library (Lib), XML files: xmlrpc_escape_nonencodable-3.x.patch keywords: patch messages: 258537 nosy:

[issue26147] Encoding errors in xmlrpc

Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file41649/xmlrpc_escape_nonencodable-2.7.patch ___ Python tracker ___

[issue25843] lambdas on the same line may incorrectly share code objects

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___

[issue26140] inspect.iscoroutinefunction raises TypeError when checks Mock of function or coroutinefunction

Yury Selivanov added the comment: It looks like this should be fixed in the mock module, as special casing it in inspect doesn't look right. Unfortunately, I can't review this patch, as I don't know the mock module internals and I don't think I understand all consequences of this patch.

[issue26145] PEP 511: Add sys.set_code_transformers()

Changes by Yury Selivanov : -- nosy: +yselivanov ___ Python tracker ___ ___

[issue26107] PEP 511: code.co_lnotab: use signed line number delta to support moving instructions in an optimizer

STINNER Victor added the comment: Patch version 3: * When I reviewed issue #16956 patch, I noticed that I forgot to extract my changes on codeobject.c :-/ (FAT Python became a giant patch, it's hard to browse it!) * Fix typo in dis.py (regression of patch 2) -- Added file:

[issue26139] libmpdec: disable /W4 warning (non-standard dllimport behavior)

Stefan Krah added the comment: This is *exactly* what I want. As the sole author of libmpdec I *know* that the broken dllimport behavior cannot affect anything in memory.c, since there are no function pointer comparisons. Please stop educating us. --

[issue26139] libmpdec: disable /W4 warning (non-standard dllimport behavior)

Alexander Riccio added the comment: > Please stop educating us. Sorry, not what was intended! Tone transmits poorly. -- ___ Python tracker ___

[issue26100] PEP 511: Add test.support.optim_args_from_interpreter_flags()

Changes by STINNER Victor : -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue26100] PEP 511: Add test.support.optim_args_from_interpreter_flags()

Roundup Robot added the comment: New changeset ac6d33317eda by Victor Stinner in branch 'default': subprocess._optim_args_from_interpreter_flags() https://hg.python.org/cpython/rev/ac6d33317eda -- nosy: +python-dev ___ Python tracker

[issue26101] Lib/test/test_compileall.py fails when run directly

Changes by STINNER Victor : -- components: +Tests resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue26107] PEP 511: code.co_lnotab: use signed line number delta to support moving instructions in an optimizer

STINNER Victor added the comment: > A patch was proposed in issue16956. And issue17611 is related. I don't see directly the link between this issue and the issue17611, but cool if it helps to implement new optimizations :-) I compared my patch with issue16956 patch: * my patch mentions also

[issue26129] Difference in behaviour with grp.getgrgid and pwd.getpwuid

Serhiy Storchaka added the comment: Thank you for your review Brett. -- assignee: -> serhiy.storchaka resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue26107] PEP 511: code.co_lnotab: use signed line number delta to support moving instructions in an optimizer

Brett Cannon added the comment: I just wanted to comment on "don't change importlib MAGIC: we only change it between Python minor versions": that's actually not true. Feel free to up the number whenever you make a change that affects eval.c or bytecode. Otherwise .pyc files won't be

[issue26129] Difference in behaviour with grp.getgrgid and pwd.getpwuid

Roundup Robot added the comment: New changeset 65e0e06b70b6 by Serhiy Storchaka in branch 'default': Issue #26129: Deprecated accepting non-integers in grp.getgrgid(). https://hg.python.org/cpython/rev/65e0e06b70b6 -- nosy: +python-dev ___ Python

[issue25958] Implicit ABCs have no means of "anti-registration"

Andrew Barnert added the comment: Style changes based on Martin's review -- Added file: http://bugs.python.org/file41650/patch5.diff ___ Python tracker

[issue25958] Implicit ABCs have no means of "anti-registration"

Changes by Andrew Barnert : Removed file: http://bugs.python.org/file41650/patch5.diff ___ Python tracker ___

[issue26013] Pickle protocol 2.0 not loading in python 3.5

Roundup Robot added the comment: New changeset 270add17f203 by Serhiy Storchaka in branch '3.5': Issue #26013: Added compatibility with broken protocol 2 pickles created https://hg.python.org/cpython/rev/270add17f203 New changeset 35ff0976b211 by Serhiy Storchaka in branch 'default': Issue

[issue20556] Use specific asserts in threading tests

Berker Peksag added the comment: test_threading_asserts_2.patch looks good to me. -- nosy: +berker.peksag stage: patch review -> commit review versions: -Python 3.4 ___ Python tracker

[issue24823] ctypes.create_string_buffer does not add NUL if len(init) == size

Terry J. Reedy added the comment: (Tracker notes: I added as nosy the people listed as active 'experts' for ctypes on https://docs.python.org/devguide/experts.html#experts. This was easily done by going to the end of the nosy list, typing a comma ',', typing 'ctypes', and then clicking the

[issue26145] PEP 511: Add sys.set_code_transformers()

STINNER Victor added the comment: main.c: +case 'o': +if (wcslen(_PyOS_optarg) == 0 + || wcschr(_PyOS_optarg, L'.') + || wcschr(_PyOS_optarg, L'-') ... '-' character must be valid for -o argument. --

[issue25366] test_venv fails with --without-threads

Berker Peksag added the comment: Fixed. Thanks for the report, Arfrever -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed type: -> behavior versions: -Python 3.4 ___ Python tracker

[issue25366] test_venv fails with --without-threads

Roundup Robot added the comment: New changeset 2a201272daed by Berker Peksag in branch '3.5': Issue #25366: Skip test_with_pip when threading module is not available https://hg.python.org/cpython/rev/2a201272daed New changeset 27d4f06c3720 by Berker Peksag in branch 'default': Issue #25366:

[issue25859] EOFError in test_nntplib.NetworkedNNTPTests.test_starttls()

Roundup Robot added the comment: New changeset a9fca95f119a by Martin Panter in branch '3.5': Issue #25859: Reimplement NNTP test_starttls() using local server https://hg.python.org/cpython/rev/a9fca95f119a New changeset c44bfa733526 by Martin Panter in branch 'default': Issue #25859: Merge

[issue13886] readline-related test_builtin failure

Martin Panter added the comment: Here is a possible patch which: * Runs the three test_input_tty() tests in a fresh child Python interpreter, for control over whether Readline is loaded. A pseudoterminal is used for stdin and stdout, and stderr is left untouched to easily see error messages.

[issue5626] misleading comment in socket.gethostname() documentation

Senthil Kumaran added the comment: Given that we have not received any more reports on users tripping up on this message, it seems to me that we could just ignore this report and close it. Thoughts? -- nosy: +orsenthil ___ Python tracker

[issue13886] readline-related test_builtin failure

Changes by Martin Panter : Added file: http://bugs.python.org/file41653/input-readline.patch ___ Python tracker ___

[issue23962] Incorrect TimeoutError referenced in concurrent.futures documentation

Senthil Kumaran added the comment: Thanks for the report and the patch. I have fixed that in 3.5 and 3.6 docs. I found it reasonable to include the full module path for TimeoutError makeing it consist with asyncio and multiprocessing TimeoutError. Also, Error exception is not exposed via

[issue1927] raw_input behavior incorrect if readline not enabled

Martin Panter added the comment: Tal: thanks for testing. This v3 patch changes the interactive interpreter to pass stderr as the sys_stdout parameter. This means we should maintain compatibility with the interpreter prompt going to stderr, but still fix input(). -- versions:

[issue25859] EOFError in test_nntplib.NetworkedNNTPTests.test_starttls()

Changes by Martin Panter : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue23962] Incorrect TimeoutError referenced in concurrent.futures documentation

Roundup Robot added the comment: New changeset 673d1ccea050 by Senthil Kumaran in branch '3.5': issue23962 - Reference the correct TimeoutError in concurrent.futures documentation. https://hg.python.org/cpython/rev/673d1ccea050 New changeset 2b0c7b67eca5 by Senthil Kumaran in branch 'default':

[issue26059] Integer Overflow in strop.replace()

Changes by Benjamin Peterson : -- resolution: wont fix -> not a bug status: open -> closed ___ Python tracker ___

[issue12869] PyOS_StdioReadline is printing the prompt on stderr

Martin Panter added the comment: Adam: My experiments were assuming that PyOS_Readline() only ever uses the basic implementation or the Readline library, in order to see if there was any consistency with how Python worked in common situations. There is actually a test that waits for the

[issue25731] Assigning and deleting __new__ attr on the class does not allow to create instances of this class

Roundup Robot added the comment: New changeset 3c9512d8ac0d by Benjamin Peterson in branch '3.5': set tp_new from the class in the hierarchy that actually owns the descriptor (closes #25731) https://hg.python.org/cpython/rev/3c9512d8ac0d New changeset e7062dd9085e by Benjamin Peterson in

[issue26145] PEP 511: Add sys.set_code_transformers()

STINNER Victor added the comment: sys_init_code_transformer: Py_DECREF(name); must be Py_XDECREF(name); at exit, it can NULL. An unit test on an invalid transformer (with no name) is missing? -- ___ Python tracker

[issue11816] Refactor the dis module to provide better building blocks for bytecode analysis

Roundup Robot added the comment: New changeset bf997b22df06 by Victor Stinner in branch '3.5': Fix BytecodeTestCase.assertNotInBytecode() https://hg.python.org/cpython/rev/bf997b22df06 -- ___ Python tracker

[issue26119] Windows Installer can sometimes silently fail pip stage

Steve Dower added the comment: Preferably just one group of them (created around the same time) for a failed installation. -- ___ Python tracker ___

[issue26013] Pickle protocol 2.0 not loading in python 3.5

Roundup Robot added the comment: New changeset 7215d13baa2d by Serhiy Storchaka in branch '3.5': Added exceptins for testing non-reversible import mapping for Issue #26013. https://hg.python.org/cpython/rev/7215d13baa2d New changeset 16cfc1652844 by Serhiy Storchaka in branch 'default': Added

[issue24922] assertWarnsRegex doesn't allow multiple warning messages

Rose Ames added the comment: Would this mean that we expect any one of the warnings to be raised, or all of them? If it's one, the example you give would be equivalent to: self.assertWarnsRegex(UserWarning, "^W100[01]") Matching all of the warnings seems more interesting, but I'm not

[issue26013] Pickle protocol 2.0 not loading in python 3.5

Serhiy Storchaka added the comment: Thank you Victor. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue26107] PEP 511: code.co_lnotab: use signed line number delta to support moving instructions in an optimizer

STINNER Victor added the comment: Patch version 4: * finish to update Objects/lnotab_notes.txt * update _PyCode_CheckLineNumber() in codeobject.c * set importlib MAGIC to 3361 I don't expect my patch to be complete nor perfect. IMHO it's fine to adjust the code later if needed. I would like

[issue21277] don't try to link _ctypes with a ffi_convenience library

Zachary Ware added the comment: It's not easy to find anything with a google search for 'ffi_convenience' that's not this issue. I did find doko's patch to GCC to not install libffi_convenience, which included a comment from the author of libffi saying he didn't recommend that GCC install

[issue26013] Pickle protocol 2.0 not loading in python 3.5

STINNER Victor added the comment: Buildbots are unhappy. http://buildbot.python.org/all/builders/PPC64%20Fedora%203.5/builds/344/steps/test/logs/stdio == FAIL: test_reverse_import_mapping (test.test_pickle.CompatPickleTests)

[issue26043] ON DELETE CASCADE does not work when using sqlite3 library

Changes by R. David Murray : -- nosy: +r.david.murray ___ Python tracker ___ ___

[issue26149] Suggest PyCharm Community as an editor for Unix platforms

New submission from John Hagen: The Python documentation recommends editors that can be used on Unix: https://docs.python.org/3.5/using/unix.html#editors If the intent is to advertise very excellent IDEs (as Geany and Komodo Edit are listed), I suggest that PyCharm Community Edition

[issue26124] shlex.quote and pipes.quote do not quote shell keywords

R. David Murray added the comment: Quote is for quoting shell special characters, not command names. It would be fairly straightforward to add that to the docs ("Return a version of the string s will with all shell special characters (including whitespace) escaped according to shell escaping

[issue26146] PEP 511: Add ast.Constant to allow AST optimizer to emit constants

STINNER Victor added the comment: Brett Cannon: "Would it make sense to tag the type of the constant in the node somehow?" It's easy to get the type of a constant: type(node.value). I like using isinstance(). Brett Cannon: "We also make no backwards-compatibility guarantees about the AST,

[issue26058] PEP 509: Add ma_version to PyDictObject

Changes by R. David Murray : -- nosy: +r.david.murray ___ Python tracker ___ ___

[issue26107] PEP 511: code.co_lnotab: use signed line number delta to support moving instructions in an optimizer

Serhiy Storchaka added the comment: But there is no need to increase it by 10. I suppose the gap is added to allow updating bytecode in maintained releases, but in process of developing next version we don't need this. -- ___ Python tracker

[issue26092] doctest should allow custom sys.displayhook

R. David Murray added the comment: What problem does replacing __displayhook__ provoke? What solution do you propose instead of 8048, which fixed a bug? -- nosy: +r.david.murray ___ Python tracker

[issue26107] PEP 511: code.co_lnotab: use signed line number delta to support moving instructions in an optimizer

Serhiy Storchaka added the comment: The launcher on Windows does a range check. -- ___ Python tracker ___ ___

[issue16907] Distutils fails to build extension in path with spaces

Zachary Ware added the comment: This isn't obviously a distutils bug, but sounds strikingly similar to #4508. Closing as a duplicate of #4508. -- assignee: eric.araujo -> nosy: +zach.ware resolution: -> duplicate stage: needs patch -> resolved status: open -> closed superseder: ->

[issue26149] Suggest PyCharm Community as an editor for Unix platforms

Berker Peksag added the comment: Thanks for the report. It would be better to refer to https://wiki.python.org/moin/PythonEditors and https://wiki.python.org/moin/IntegratedDevelopmentEnvironments instead of maintaining duplicate and outdated lists. -- keywords: +easy nosy:

[issue26036] Unnecessary arguments on smtpd.SMTPServer

Changes by R. David Murray : -- nosy: +r.david.murray ___ Python tracker ___ ___

[issue26107] PEP 511: code.co_lnotab: use signed line number delta to support moving instructions in an optimizer

Brett Cannon added the comment: There's technically no need to worry about ranged values as the magic number is purely an equality check to see if the interpreter matches what the .pyc was created with. I guess there might be third-party code that does a range check, but that's bad as