[issue10415] readline.insert_text documentation incomplete

2016-06-20 Thread Martin Panter
Martin Panter added the comment: In Issue 6953, I updated the documentation to indicate which underlying Readline functions etc are accessed. So perhaps that helps, so the reader knows what function to look up in the Readline documentation. Other than that, I’m not sure what else to do. It

[issue13376] readline: pre_input_hook not getting called

2016-06-20 Thread Martin Panter
Martin Panter added the comment: Surely this should be fixed in Editline, not Python? -- nosy: +martin.panter ___ Python tracker ___

[issue27359] OrderedDict pseudo-literals (WIP)

2016-06-20 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- assignee: rhettinger -> ___ Python tracker ___

[issue25259] readline macros can segfault Python

2016-06-20 Thread Martin Panter
Martin Panter added the comment: I think Victor may be on the right track. Since the macro contains two newlines, a single call to rl_callback_read_char() is going to produce two calls back to the rl_callback_handler_install() handler to receive each line. I can make the example from the

[issue27359] OrderedDict pseudo-literals (WIP)

2016-06-20 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: FYI the proposition about OrderedDict literals was raised on Python-Ideas or Python-Dev multiple times. http://comments.gmane.org/gmane.comp.python.ideas/4888 http://comments.gmane.org/gmane.comp.python.ideas/6569

[issue27358] BUILD_MAP_UNPACK_WITH_CALL is slow

2016-06-20 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The problem is that var-keyword argument can be not a dict, but general mapping. This optimization is applicable only if it is a dict. -- stage: -> patch review ___ Python tracker

[issue17507] To add history time format in readline

2016-06-20 Thread Martin Panter
Martin Panter added the comment: Is this related to Readline’s history_write_timestamps() feature, or is this a request for Python to make a custom history file? -- components: +Extension Modules -Library (Lib) nosy: +martin.panter ___ Python

[issue24727] Wrap rl_forced_update_display() and lock readline module while active

2016-06-20 Thread Martin Panter
Martin Panter added the comment: I wonder why you can’t add the locking around input() calls at a higher level, rather than needing to change the readline module itself. -- stage: -> patch review title: Expand readline module -> Wrap rl_forced_update_display() and lock readline

[issue27359] OrderedDict pseudo-literals (WIP)

2016-06-20 Thread Raymond Hettinger
Raymond Hettinger added the comment: No worries, it just seemed a little brash ;-) Go ahead and continue to post patch variants here. Once it's working, going to python-dev is the right thing to do (to see whether it meets a threshold of need and to endlessly debate what the syntax would

[issue27359] OrderedDict pseudo-literals (WIP)

2016-06-20 Thread Joe Jevnik
Joe Jevnik added the comment: Sorry about undoing the settings, that was unintentional. The UI around these settings is sort of unintuitive. I was waiting to propose this on python-dev until I got it working, but I wanted to push up what I did have as a work in progress so I could try to get

[issue23297] Clarify error when ‘tokenize.detect_encoding’ receives text

2016-06-20 Thread Martin Panter
Changes by Martin Panter : -- stage: -> needs patch title: ‘tokenize.detect_encoding’ is confused between text and bytes: no ‘startswith’ method on a byte string -> Clarify error when ‘tokenize.detect_encoding’ receives text type: crash -> behavior versions:

[issue12186] readline.replace_history_item still leaks memory

2016-06-20 Thread Martin Panter
Martin Panter added the comment: This seems like something that should be fixed in Readline, rather than Python. Judging by the rl_clear_history() documentation, it sounds like this is private data. Maybe we need a version of rl_free_undo_list() that works for old history items, or a Readline

[issue27359] OrderedDict pseudo-literals (WIP)

2016-06-20 Thread Raymond Hettinger
Raymond Hettinger added the comment: BTW, there's no way this particular syntax suggestion is going in without a discussion on python-dev. I think the square brackets will be a non-starter. -- assignee: -> rhettinger resolution: -> later status: open -> pending

[issue18300] script_helper._assert_python should set TERM='' by default.

2016-06-20 Thread Martin Panter
Martin Panter added the comment: More recently, Issue 19884 has worked around the problem where practical on non-Apple platforms, so perhaps this problem is not so important now. However it could still be present with older Gnu Readline versions, and slightly newer versions on Apple (pending

[issue1606233] readline on popen3 file returns empty string before end

2016-06-20 Thread Martin Panter
Changes by Martin Panter : -- versions: -Python 3.1, Python 3.2 ___ Python tracker ___

[issue10116] Sporadic failures in test_urllibnet

2016-06-20 Thread Martin Panter
Martin Panter added the comment: It looks like Antoine’s second failure (test_getcode) should be fixed now that transient_internet() is used (Issue 12138). Looking at Antoine’s first failure, it will always be possible for it to fail depending on the conditions of the buildbot, internet, and

[issue8538] Add FlagAction to argparse

2016-06-20 Thread paul j3
Changes by paul j3 : -- nosy: +paul.j3 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue27051] Create PIP gui

2016-06-20 Thread Terry J. Reedy
Terry J. Reedy added the comment: I seem to have anticipated some of your expansion, but I note this: while Raymond's first post could be interpreted as suggesting a new IDLE feature, with its own PIP menu with multiple options, I immediately said it should be a standalone module that IDLE

[issue24419] In argparse action append_const doesn't work for positional arguments

2016-06-20 Thread paul j3
Changes by paul j3 : -- status: open -> closed ___ Python tracker ___ ___

[issue27359] OrderedDict pseudo-literals (WIP)

2016-06-20 Thread Joe Jevnik
Joe Jevnik added the comment: Assuming all dicts are ordered, there will be no need for this (as long as the parser preserves order) so I am okay with dropping this. One of the main use cases I have for wanting nice literals is when I am working on tests. I find it very nice to be able to

[issue27359] OrderedDict pseudo-literals (WIP)

2016-06-20 Thread Raymond Hettinger
Raymond Hettinger added the comment: This needs to tabled pending the outcome of the python-dev discussion to make all dicts ordered dictionaries. If it does get revived, there need to be clear motivating use cases. In most of the use cases I've seen for ordered dicts, the key/value pairs

[issue27359] OrderedDict pseudo-literals (WIP)

2016-06-20 Thread Joe Jevnik
New submission from Joe Jevnik: This proposes the following syntax for creating OrderedDict literals: OrderedDict[k1: v1, k2: v2, ...] This is implemented by putting a metaclass on OrderedDict which has a getitem that turns the slices into a list of tuples (after validation). The idea is

[issue27051] Create PIP gui

2016-06-20 Thread Ned Deily
Ned Deily added the comment: One other possibility: decouple the gui from both Python and pip releases by packaging and, at least initially, releasing it through PyPI as an independent project. That is, after all, the preferred mechanism for adding new functionality to the standard library.

[issue12833] Document the need to pass the prompt to raw_input() with readline

2016-06-20 Thread Martin Panter
Changes by Martin Panter : -- stage: patch review -> needs patch title: raw_input misbehaves when readline is imported -> Document the need to pass the prompt to raw_input() with readline versions: -Python 3.4 ___ Python

[issue27051] Create PIP gui

2016-06-20 Thread Terry J. Reedy
Terry J. Reedy added the comment: Ned, my response was to your first message. I am just now reading the second. -- ___ Python tracker ___

[issue26894] Readline not aborting line edition on sigint

2016-06-20 Thread Martin Panter
Changes by Martin Panter : -- status: open -> pending ___ Python tracker ___ ___

[issue27358] BUILD_MAP_UNPACK_WITH_CALL is slow

2016-06-20 Thread Demur Rumed
Changes by Demur Rumed : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___

[issue27358] BUILD_MAP_UNPACK_WITH_CALL is slow

2016-06-20 Thread Demur Rumed
Changes by Demur Rumed : -- components: +Interpreter Core type: -> performance versions: +Python 3.6 ___ Python tracker ___

[issue27051] Create PIP gui

2016-06-20 Thread Terry J. Reedy
Terry J. Reedy added the comment: Ned, I agree with you in principle, and would have preferred that this had been handled by PPA/distutils/PIP folk. But see at least the first 4 messages on the original issue #23551, Feb 28 2015, where Donald Stufft says he would like to see it happen but

[issue27358] BUILD_MAP_UNPACK_WITH_CALL is slow

2016-06-20 Thread Demur Rumed
New submission from Demur Rumed: BUILD_MAP_UNPACK_WITH_CALL is _really_ slow, wasting much of its time asserting that keys are non overlapping. This patch optimizes a fast path for distinct dicts, especially useful for #27213 where BUILD_MAP_UNPACK_WITH_CALL is generated for a single **kw

[issue27051] Create PIP gui

2016-06-20 Thread Ned Deily
Ned Deily added the comment: Let me just expand on my concerns here. I apologize for not thinking about these earlier: I haven't been paying enough attention to this project. And I certainly do not intend this to be a criticism of anyone's work on this, especially your work, Upendra and

[issue27213] Rework CALL_FUNCTION* opcodes

2016-06-20 Thread Demur Rumed
Demur Rumed added the comment: callfunc2 fixes test_dis, addresses code review, currently implements a copy of _PyEval_EvalCodeWithName as _PyEval_EvalCodeWithName2 which changes a few lines to work with new keyword stack layout so that we can use fast_function with kwargs CALL_FUNCTION_EX

[issue27051] Create PIP gui

2016-06-20 Thread Ned Deily
Ned Deily added the comment: Terry et al: is anyone from the Python Packaging Authority (and or distutils-sig) involved in this project? After all, pip is developed and maintained by them, not by python-dev. I don't think we should be committing code to the Python Standard library for an

[issue27357] Enhancing the Windows installer

2016-06-20 Thread Ned Deily
Changes by Ned Deily : -- components: +Windows nosy: +paul.moore, steve.dower, tim.golden, zach.ware title: Enhancing the installer -> Enhancing the Windows installer ___ Python tracker

[issue27354] SSLContext.load_verify_locations cannot handle paths on Windows which cannot be encoded using mbcs

2016-06-20 Thread Ilya Kulakov
Ilya Kulakov added the comment: I checked the source code of OpenSSL, specifically the `bss_file.c:file_fopen` function (https://github.com/openssl/openssl/blob/OpenSSL_1_0_2h/crypto/bio/bss_file.c#L118-L167). As you can see it support UTF-8 encoded strings under Windows. Python must follow

[issue27354] SSLContext.load_verify_locations cannot handle paths on Windows which cannot be encoded using mbcs

2016-06-20 Thread Ilya Kulakov
Ilya Kulakov added the comment: Viktor, I also came across this thread but it is rather old (we're using OpenSSL 1.0.2h). And it would only explain if _neither_ of my methods had worked. But as you can see, the last one (passing UTF-8 encoded bytes) works. --

[issue25083] Python can sometimes create incorrect .pyc files

2016-06-20 Thread tzickel
tzickel added the comment: Sorry Brett of course I meant the upcoming 2.7.12 -- ___ Python tracker ___

[issue23908] Check path arguments of os functions for null character

2016-06-20 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Since the large part of code is Windows specific (and even is not compiled on Linux), the patch needs testing on Windows. -- ___ Python tracker

[issue23908] Check path arguments of os functions for null character

2016-06-20 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Proposed patch fixes this issue and issue13848 in 2.7. -- nosy: +benjamin.peterson stage: needs patch -> patch review Added file: http://bugs.python.org/file43492/unicode_converter_null_char-2.7.patch ___ Python

[issue27051] Create PIP gui

2016-06-20 Thread Terry J. Reedy
Terry J. Reedy added the comment: I should mention that the reason we have multiple alpha and beta releases for a new version is that new modules such as this are *typically* incomplete, a bit rough in the API, and even buggy, when first committed. We have had the most problems when modules

[issue27352] Bug in IMPORT_NAME

2016-06-20 Thread Brett Cannon
Brett Cannon added the comment: Then I say go ahead and commit it. -- ___ Python tracker ___ ___

[issue27352] Bug in IMPORT_NAME

2016-06-20 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thak you for the explanation Brett. Since current "import" without "from" is not broken, I suppose that the raised exception is cleared somewhere later. The patch doesn't have visible effect (unless may be using nonstandard loaders or __import__, don't

[issue22557] Local import is too slow

2016-06-20 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thanks Victor. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue22557] Local import is too slow

2016-06-20 Thread STINNER Victor
STINNER Victor added the comment: I rebased faster_import_4.patch on default. -- Added file: http://bugs.python.org/file43491/faster_import_4.patch ___ Python tracker

[issue22557] Local import is too slow

2016-06-20 Thread STINNER Victor
STINNER Victor added the comment: > Do you happen to know why you didn't get a review link for your patch, Serhiy? faster_import_4.patch is based on the revision d736c9490333 which is not part of the CPython repository. -- nosy: +haypo ___ Python

[issue27051] Create PIP gui

2016-06-20 Thread Terry J. Reedy
Terry J. Reedy added the comment: Upendra, Lorenzo is doing your midterm evaluation. 3.6.0a3 is scheduled for 7/11. A week before that, I would like to see a patch posted here that I could potentially commit. Work out the details of what to include with Lorenzo. The patch should include

[issue22557] Local import is too slow

2016-06-20 Thread Brett Cannon
Brett Cannon added the comment: Do you happen to know why you didn't get a review link for your patch, Serhiy? -- ___ Python tracker ___

[issue27353] Add nroot function to math

2016-06-20 Thread Tim Peters
Tim Peters added the comment: Note that the very popular TI graphics calculators have had a distinct nth-root function at least since the TI-83. It's a minor convenience there. I'm +0 on adding it to Python's math module, which means not enough to do any work ;-) Note that if it is added to

[issue27172] Add skip_bound_arg argument to inspect.Signature.from_callable()

2016-06-20 Thread Ryan Petrello
Ryan Petrello added the comment: Yury/Nick, Any word on this? I know it's minor, but I'd love to see this make it into Python3.6. -- ___ Python tracker

[issue27352] Bug in IMPORT_NAME

2016-06-20 Thread Brett Cannon
Brett Cannon added the comment: My suspicion is the -1 aspect is a hold-over from that being the default level value in Python 2.7 that no one removed. The patch LGTM. Do we need a test for this for some reason? -- assignee: -> serhiy.storchaka stage: patch review -> commit review

[issue26923] asyncio.gather drops cancellation

2016-06-20 Thread Yury Selivanov
Yury Selivanov added the comment: > @Yury, any comments? The fix looks fine to me. I've left a comment in code review. Other than that, the patch/approach looks good. -- ___ Python tracker

[issue27355] Strip out the last lingering vestiges of Windows CE support

2016-06-20 Thread Larry Hastings
Larry Hastings added the comment: Nosying two people who I know worked on the port originally, just in case they have an opinion about removing WinCE. (Remind me. Why is our private copy of libffi a divergent unmaintained fork? libffi still gets updates; last update was two years ago. Why

[issue26923] asyncio.gather drops cancellation

2016-06-20 Thread Guido van Rossum
Guido van Rossum added the comment: @Yury, any comments? The fix looks fine to me. -- ___ Python tracker ___

[issue27309] Visual Styles support to tk/tkinter file and message dialogs

2016-06-20 Thread Terry J. Reedy
Terry J. Reedy added the comment: Pat, thank you for the explanation, xml, and link. I was a bit confused by the overlapping yet different meanings of 'ttk theme' and 'Windows theme'. For 3.6, I am converting IDLE to use ttk widgets. From the example on the SO page, which links to

[issue26930] Upgrade installers to OpenSSL 1.0.2h

2016-06-20 Thread Steve Dower
Steve Dower added the comment: Test build went fine, was validated in another thread. -- ___ Python tracker ___

[issue27353] Add nroot function to math

2016-06-20 Thread Raymond Hettinger
Raymond Hettinger added the comment: If this ends up going forward (and I'm don't believe a good case has been made), I would prefer the function to be called "nth_root" which is unequivocal and readable (it is also close to what Matlab uses:

[issue26930] Upgrade installers to OpenSSL 1.0.2h

2016-06-20 Thread Steve Dower
Changes by Steve Dower : -- status: open -> closed ___ Python tracker ___ ___

[issue27355] Strip out the last lingering vestiges of Windows CE support

2016-06-20 Thread Zachary Ware
Zachary Ware added the comment: +1 Doesn't break anything in a x64 build for me. Modules/_ctypes/libffi_arm_wince/ should also be removed, though (it's a private, ancient copy of libffi that has never actually been used as far as I can tell). --

[issue27354] SSLContext.load_verify_locations cannot handle paths on Windows which cannot be encoded using mbcs

2016-06-20 Thread STINNER Victor
STINNER Victor added the comment: The Python ssl module is a wrapper to the OpenSSL library. For this issue, we are talking about the function SSL_CTX_load_verify_locations(): https://www.openssl.org/docs/manmaster/ssl/SSL_CTX_load_verify_locations.html OpenSSL expects a byte string for CAfile

[issue25083] Python can sometimes create incorrect .pyc files

2016-06-20 Thread Brett Cannon
Changes by Brett Cannon : -- nosy: -brett.cannon ___ Python tracker ___ ___

[issue25083] Python can sometimes create incorrect .pyc files

2016-06-20 Thread Brett Cannon
Brett Cannon added the comment: Python 2.6 is no longer supported. -- ___ Python tracker ___ ___

[issue25083] Python can sometimes create incorrect .pyc files

2016-06-20 Thread tzickel
tzickel added the comment: any chance for 2.6.12 ? 4 line patch. -- ___ Python tracker ___ ___

[issue20120] Percent-signs (%) in .pypirc should not be interpolated

2016-06-20 Thread Roundup Robot
Roundup Robot added the comment: New changeset 83d731f01dde by Berker Peksag in branch '3.5': Issue #20120: Add a test case to verify the % char can be used in .pypirc https://hg.python.org/cpython/rev/83d731f01dde New changeset 703d9066c459 by Berker Peksag in branch 'default': Issue #20120:

[issue26859] unittest fails with "Start directory is not importable" when trying to run sourceless tests

2016-06-20 Thread Xavier de Gaye
Xavier de Gaye added the comment: Thanks for the review Pamela, indeed self.vfs is not defined. The patched test_unittest runs without failure because the list_dir() nested function is never called. It is also never called in the un-patched version. Actually the un-patched

[issue27353] Add nroot function to math

2016-06-20 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: For general use I think it would be more useful to make pow() supporting fractions (using as_integer_ration()). >>> math.pow(1000, fractions.Fraction(2, 3)) 100.0 >>> math.pow(10, decimal.Decimal('0.4')) 100.0 --

[issue27353] Add nroot function to math

2016-06-20 Thread Steven D'Aprano
Steven D'Aprano added the comment: I suggested on python-ideas that the math module be given a pure-Python front end. Guido wasn't too keen on that idea, so I won't push for it. He did agree that having nroot in math was a reasonable idea. If I attach a pure Python implementation and tests,

[issue27199] TarFile expose copyfileobj bufsize to improve throughput

2016-06-20 Thread Łukasz Langa
Changes by Łukasz Langa : -- nosy: +lars.gustaebel ___ Python tracker ___ ___

[issue27351] Unexpected ConfigParser.read() behavior when passed fileobject

2016-06-20 Thread Rich Rauenzahn
Rich Rauenzahn added the comment: Thank you, lukasz. That's the answer I anticipated -- I can appreciate the backwards compatibility aspect very much. Regarding the docs, the docs say: "Attempt to read and parse a list of filenames, returning a list of filenames which were successfully

[issue27351] Unexpected ConfigParser.read() behavior when passed fileobject

2016-06-20 Thread Łukasz Langa
Łukasz Langa added the comment: Thanks for your report, Rich. configparser is one of the oldest libraries in the standard library. Its behavior might sometimes not be intuitive to newcomers but is burdened by years of backwards compatibility. Changing the behavior now to raise a type error

[issue27051] Create PIP gui

2016-06-20 Thread Upendra Kumar
Upendra Kumar added the comment: For blog posts related to this project, here is the blog link : https://scorython.wordpress.com For now, there are following posts : 1. Application Screenshots 2. Design Patterns: How to write reusable and tidy software? ( to be completed) 3. Menace of Global

[issue27354] SSLContext.load_verify_locations cannot handle paths on Windows which cannot be encoded using mbcs

2016-06-20 Thread Ilya Kulakov
Ilya Kulakov added the comment: I believe this is a bug, because path suitable for os.path (or pathlib), should be equally suitable for load_verify_locations. -- ___ Python tracker

[issue27353] Add nroot function to math

2016-06-20 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Looking at issue27181, nroot() wouldn't help too much to implement geometric mean (msg267990). -- nosy: +serhiy.storchaka ___ Python tracker

[issue27353] Add nroot function to math

2016-06-20 Thread Alexander Belopolsky
Changes by Alexander Belopolsky : -- nosy: +belopolsky ___ Python tracker ___

[issue27353] Add nroot function to math

2016-06-20 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- nosy: +mark.dickinson, tim.peters ___ Python tracker ___

[issue27357] Enhancing the installer

2016-06-20 Thread Sworddragon
Sworddragon added the comment: Edit: Forgot to say that the first point also applies to the options "Install launcher for all users (recommended)" and "for all users (requires elevation)" or "Install for all users" dependent on what the first one actually means. --

[issue27010] email library could "recover" from bad mime boundary like (some?) email clients do

2016-06-20 Thread R. David Murray
R. David Murray added the comment: Unfortunatley no, things were too busy. I'm hoping to have time to review email patches in the not too distant future, though. -- ___ Python tracker

[issue27357] Enhancing the installer

2016-06-20 Thread Sworddragon
New submission from Sworddragon: On installing Python 3.5.1 with the Windows installer I have noticed some things that could maybe be enhanced: - The launcher provides the option "Add Python 3.5 to PATH" on the first page. But if a custom installation is choosen the option appears again as

[issue27213] Rework CALL_FUNCTION* opcodes

2016-06-20 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you Demur. I left few comments on Rietveld (this is only the quick glance). Good news that this change allows to simplify BUILD_MAP_UNPACK_WITH_CALL. But using 15th bit means using EXTENDED_ARG. I think it would be simpler to just push an empty tuple

[issue27356] csv

2016-06-20 Thread Emanuel Barry
Emanuel Barry added the comment: (Berker beat me to it, but posting anyway since it is more detailed) Backslashes are escape characters, and "\b" is treated as "\x08". Invalid combinations (e.g. "\A", "\D"...) automatically escape the backslash, but you shouldn't rely on this behaviour - as

[issue27356] csv

2016-06-20 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report. \t is a tab character. You can use 'C:\\Users\\Anwender\\Desktop\\Test\\blub.txt' or r'C:\Users\Anwender\Desktop\Test\blub.txt' or 'C:/Users/Anwender/Desktop/Test/blub.txt' -- nosy: +berker.peksag resolution: ->

[issue27356] csv

2016-06-20 Thread Fabian
New submission from Fabian: Hi, I am running Canopy on Windows 7 64 bit. When I run the attached file, I get the following error: > 5 with open('C:\Users\Anwender\Desktop\Test\blub.txt') as csvfile: 6 dialekt = csv.Sniffer().sniff(csvfile.read(1024)) IOError: [Errno 22] invalid

[issue13592] repr(regex) doesn't include actual regex

2016-06-20 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This looks weird, but is not a bug. See issue26090. After implementing that feature truncating a pattern would look more explicit. -- ___ Python tracker

[issue24137] Force not using _default_root in IDLE

2016-06-20 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: And I thing changes to tests can be applied to all versions (especially since they become diverge), but NoDefaultRoot() should be called in IDLE only in 3.6. -- ___ Python tracker

[issue24137] Force not using _default_root in IDLE

2016-06-20 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I ran IDLE and tests and found yet few needed changes. NoDefaultRoot() should be called only if run IDLE with a subprocess support. -- Added file: http://bugs.python.org/file43489/nodefaultroot2.diff ___ Python

[issue8232] webbrowser.open incomplete on Windows

2016-06-20 Thread Carol Willing
Changes by Carol Willing : -- stage: needs patch -> patch review ___ Python tracker ___

[issue26292] Raw I/O writelines() broken for non-blocking I/O

2016-06-20 Thread Martin Panter
Martin Panter added the comment: Here is a patch documenting that RawIOBase.writelines() is undefined for partial writes and blocking errors, as mentioned in (1) above. The alternative of requiring write() to be retried would IMO be unfair to existing writelines() implementations. It also

[issue13592] repr(regex) doesn't include actual regex

2016-06-20 Thread Adam Bartoš
Adam Bartoš added the comment: Isn't the trucation of long patterns too rough? Currently, repr(re.compile("a" * 1000)) returns something like "re.compile('a)", i.e. no ending quote and no indication that something was truncated (besides the missing quote). It looked like a bug to

[issue27006] C implementation of Decimal.from_float() bypasses __new__ and __init__

2016-06-20 Thread Stefan Krah
Changes by Stefan Krah : -- status: open -> closed ___ Python tracker ___ ___

[issue27006] C implementation of Decimal.from_float() bypasses __new__ and __init__

2016-06-20 Thread Stefan Krah
Stefan Krah added the comment: > PyDec_CheckExact(type) always return 0. Should be PyDec_CheckExact(result). 'result' is always an exact decimal, because your enum example won't work otherwise. > And what about other calls of PyDecType_FromFloatExact()? Can they produce > broken instance of

[issue27309] Visual Styles support to tk/tkinter file and message dialogs

2016-06-20 Thread Pat Thoyts
Pat Thoyts added the comment: As explained in the SO answer, in Tk on Windows the messagebox, file open dialog, save as dialog and in 8.6 up the font dialog are all system standard dialogs. Tk gets Windows to show the common dialog or messagebox and just wraps the Win32 API calls. As a result

[issue27006] C implementation of Decimal.from_float() bypasses __new__ and __init__

2016-06-20 Thread Roundup Robot
Roundup Robot added the comment: New changeset 51a7a97c3ed4 by Stefan Krah in branch '3.5': Issue #27006: Do not use PyDec_CheckExact() on a type. https://hg.python.org/cpython/rev/51a7a97c3ed4 -- ___ Python tracker

[issue24364] Not all defects pass through email policy

2016-06-20 Thread Martin Panter
Martin Panter added the comment: Here is a patch to fix the two defects in Lib/email/feedparser.py. I also made some extra changes to the tests: * Remove some tests from Lib/test/test_email/test_email.py, because I think they were redundant with methods of the same name in

[issue12319] [http.client] HTTPConnection.request not support "chunked" Transfer-Encoding to send data

2016-06-20 Thread Rolf Krahl
Rolf Krahl added the comment: Martin, thank you for your review! I have to work through the list of comments and get back to you when I'm done. Please note that I didn't got your earlier reviews, so I don't know which comments are new and which are left over from earlier reviews. Of

[issue26923] asyncio.gather drops cancellation

2016-06-20 Thread Johannes Ebke
Johannes Ebke added the comment: Right, that's neater. Attached is a patch with your version and a test. I checked that it fails with the old version of cancel() and passes with the new one. Concerning possible other bugs, I've had a look in the standard library, but could not find another

[issue27006] C implementation of Decimal.from_float() bypasses __new__ and __init__

2016-06-20 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: PyDec_CheckExact(type) always return 0. Should be PyDec_CheckExact(result). And what about other calls of PyDecType_FromFloatExact()? Can they produce broken instance of Decimal subtype? -- status: closed -> open

[issue27309] Visual Styles support to tk/tkinter file and message dialogs

2016-06-20 Thread [HYBRID BEING]
[HYBRID BEING] added the comment: Ok, you sorta lost me. Would patthoyts's solution not work with Tk <8.5? As i understood (which i may did wrong), message box is returned by system (or is it actually Tk, and not system?), and it uses styled/non-styled controls based on calling process

[issue27006] C implementation of Decimal.from_float() bypasses __new__ and __init__

2016-06-20 Thread Stefan Krah
Stefan Krah added the comment: Thank you for the detailed summary! -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker

[issue27006] C implementation of Decimal.from_float() bypasses __new__ and __init__

2016-06-20 Thread Roundup Robot
Roundup Robot added the comment: New changeset dd3f48f1df86 by Stefan Krah in branch '3.5': Issue #27006: from_float(): call the subclass' __new__() and __init__(). https://hg.python.org/cpython/rev/dd3f48f1df86 -- nosy: +python-dev ___ Python

[issue27350] Compact and ordered dict

2016-06-20 Thread INADA Naoki
Changes by INADA Naoki : Added file: http://bugs.python.org/file43484/compact-dict.patch ___ Python tracker ___

[issue24137] Force not using _default_root in IDLE

2016-06-20 Thread Terry J. Reedy
Terry J. Reedy added the comment: Time to do it, at least for tests. I think patch is ready to push, with running without default root disabled until I do more testing. In particular, reread in Rietveld, do suggested actions when run through htest, and try all menu items. --

  1   2   >