[issue27558] SystemError with bare `raise` in threading or multiprocessing

2016-08-17 Thread Xiang Zhang
Xiang Zhang added the comment: Victor, upload a new patch, changing the test case to the approach you prefer. ;) -- Added file: http://bugs.python.org/file44137/issue27558_v3.patch ___ Python tracker

[issue27714] some test_idle tests are not re-runnable, producing false failures with regrtest -w option

2016-08-17 Thread Ned Deily
Ned Deily added the comment: "Could you try the comment out test of macosx call for test_autocomplete (around line 30 to 35) in 2.7 and 3.5?" Commenting out the mac.setupApp call in the test setup class did not appear to affect the running of the tests for either 2.7 or 3.5. --

[issue27598] Add SizedIterable to collections.abc and typing

2016-08-17 Thread Guido van Rossum
Guido van Rossum added the comment: Ping -- I'd really like to see this happening, with "Collection" as the name. -- ___ Python tracker ___

[issue27506] make bytes/bytearray delete a keyword argument

2016-08-17 Thread Martin Panter
Martin Panter added the comment: I can look at enhancing the tests at some stage, but it isn’t a high priority for me. Regarding translate() with no arguments, it makes sense if you see it as a kind of degenerate case of neither using a translation table, nor any set of bytes to delete:

[issue27789] test_asyncio Resource Warnings

2016-08-17 Thread Berker Peksag
Changes by Berker Peksag : -- stage: needs patch -> resolved status: open -> closed ___ Python tracker ___

[issue27749] multprocessing errors on Windows: WriteFile() argument 1 must be int, not None; OSError: handle is closed

2016-08-17 Thread wevsty
wevsty added the comment: A similar situation also occurs in the following Linux,A similar situation on stackoverflow http://stackoverflow.com/questions/29277150/python-3-4-multiprocessing-bug-on-lock-acquire-typeerror-integer-required -- ___

[issue26988] Add AutoNumberedEnum to stdlib

2016-08-17 Thread David Hagen
David Hagen added the comment: > Secondarily, the doesn't seem to be any use case that can't be readily > covered by the existing classes. The use case that doesn't have a clean interface in 3.5 at the moment is the most common use case of enums: just a collection of named objects of given

[issue27643] test_ctypes fails on AIX with xlc

2016-08-17 Thread Martin Panter
Changes by Martin Panter : -- stage: -> patch review ___ Python tracker ___ ___

[issue27643] test_ctypes fails on AIX with xlc

2016-08-17 Thread Martin Panter
Martin Panter added the comment: Michael, byref() is just a helper for passing an object’s address to a C function. Calling func(byref(b), ...) in Python is equivalent to the C code unpack_bitfields(, ...) I still think the root problem is in unpack_bitfields(). When compiled with XLC, your

[issue27787] Avoid test_main() in test_httplib; gc.collect() dangling threads

2016-08-17 Thread Martin Panter
Martin Panter added the comment: Yes I agree it would make sense to separate the test_httplib changes from the general change. I thought this task would be a very easy change, and noticed it wasn’t that simple the last minute. I would like to adjust the cleanup call to

[issue24773] Implement PEP 495 (Local Time Disambiguation)

2016-08-17 Thread Roundup Robot
Roundup Robot added the comment: New changeset 617104a6b759 by Alexander Belopolsky in branch 'default': Issue #24773: Include Tallinn 1999-10-31 transition in tests. https://hg.python.org/cpython/rev/617104a6b759 -- ___ Python tracker

[issue27791] test_threading: test_threads_join_2() failed with "Fatal Python error: Py_EndInterpreter: not the last thread"

2016-08-17 Thread Martin Panter
Martin Panter added the comment: I just happened to notice this failure on 3.5 as well: http://buildbot.python.org/all/builders/AMD64%20FreeBSD%2010.x%20Shared%203.5/builds/791/steps/test/logs/stdio -- nosy: +martin.panter versions: +Python 3.5 ___

[issue27784] Random failure of test_TCPServer() of test.test_socketserver.SocketServerTest and test_handle_accept() of test.test_asyncore.TestAPI_UseIPv6Select on FreeBSD buildbots

2016-08-17 Thread Martin Panter
Martin Panter added the comment: I think I have seen these kind of errors pop up randomly on various tests on Free BSD buildbots (at least in the last few months or so). Are the buildbots so overloaded that they drop localhost connections? Or are localhost TCP connections generally just that

[issue18295] Possible integer overflow in PyCode_New()

2016-08-17 Thread Mark Lawrence
Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___

[issue27780] memory leaks in pgen build step abort build with address sanitizer enabled

2016-08-17 Thread Ned Deily
Ned Deily added the comment: OK, that's not unreasonable and I see there have been earlier issues opened and addressed for similar problems (e.g. Issue18695). Perhaps someone will want to dive in. -- resolution: wont fix -> stage: resolved -> needs patch status: closed -> open

[issue27790] test_distutils spews linker messages on Windows

2016-08-17 Thread Steve Dower
Steve Dower added the comment: It certainly looks like more than we used to get... Ideally we'd capture the output from the build process and only write it out if the test failed. I'm not entirely sure why that isn't happening here. The warnings themselves are harmless (you get a nearly

[issue26750] Mock autospec does not work with subclasses of property()

2016-08-17 Thread Gregory P. Smith
Changes by Gregory P. Smith : -- stage: commit review -> resolved ___ Python tracker ___ ___

[issue27780] Memory leak during Python build (from git c3ff7e7) on Debian 8.5 x64

2016-08-17 Thread geeknik
geeknik added the comment: FYI, I was only able to build Python with ASAN by passing ASAN_OPTIONS=detect_leaks=0 along with the make command, otherwise ASAN wanted to stop the build process as soon as it detected this leak. -- ___ Python tracker

[issue26750] Mock autospec does not work with subclasses of property()

2016-08-17 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc added the comment: inspect.isdatadescriptor() is better indeed. (I was initially working on an old version of mock.py which does not import inspect, and I did not want to add the dependency there). - inspect uses hasattr(type(obj)) instead of hasatr(obj). This is better,

[issue27780] Memory leak during Python build (from git c3ff7e7) on Debian 8.5 x64

2016-08-17 Thread Ned Deily
Ned Deily added the comment: Thanks for the report but, AFAIK, pgen is only used during the build of Python and pgen is not installed (by "make install"). This doesn't seem like it is worth worrying about. Or am I missing something? Feel free to reopen if so or if someone comes up with a

[issue27791] test_threading: test_threads_join_2() failed with "Fatal Python error: Py_EndInterpreter: not the last thread"

2016-08-17 Thread STINNER Victor
New submission from STINNER Victor: http://buildbot.python.org/all/builders/AMD64%20FreeBSD%2010.x%20Shared%203.x/builds/4769/steps/test/logs/stdio 0:00:46 [ 41/402] test_threading crashed Fatal Python error: Py_EndInterpreter: not the last thread Current thread 0x000802006400 (most recent

[issue27594] Assertion failure when running "test_ast" tests with coverage.

2016-08-17 Thread Ivan Levkivskyi
Ivan Levkivskyi added the comment: Ned, thank you for applying the patch! I have discovered this same issue accidentally while playing with possible implementations of PEP 526. It appeared as a failure in test_sys_settrace in my fork. -- ___ Python

[issue27706] Random.seed, whose purpose is purportedly determinism, behaves non-deterministically with strings due to hash randomization

2016-08-17 Thread Glyph Lefkowitz
Glyph Lefkowitz added the comment: For what it's worth, I don't much care whether this is fixed or not; I ended up wanting to leak less information from the RNG output anyway so I wrote this: https://gist.github.com/glyph/ceca96100a3049fefea6f2035abbd9ea but I felt like it should be reported.

[issue27594] Assertion failure when running "test_ast" tests with coverage.

2016-08-17 Thread Ned Deily
Ned Deily added the comment: Thanks for the report. It looks the assert error is triggered by the new test case added in 59638baee25e for Issue13436. Since that test case was only added for 3.6, I've only applied Ivan's suggested fix for 3.6 as well, although you could trigger the same

[issue27790] test_distutils spews linker messages on Windows

2016-08-17 Thread Terry J. Reedy
New submission from Terry J. Reedy: 3.6, Win10, VS recently reinstalled to 'Update 3'. I believe these messages are somewhat new. 0:01:00 [111/402] test_distutils failed (env changed) xxmodule.c Creating library

[issue27746] ResourceWarnings in test_asyncio

2016-08-17 Thread STINNER Victor
STINNER Victor added the comment: I marked the issue #272989 as a duplicate of this one. Copy of the msg272986 by Terry J. Reedy: 3.6, Windows 10, debug build. The following appeared before and after pulling and rebuilding today. I am reporting as per Victor's request on pydev list. 0:00:22

[issue27789] test_asyncio Resource Warnings

2016-08-17 Thread STINNER Victor
STINNER Victor added the comment: Duplicate of issue #27746. -- resolution: -> duplicate superseder: -> ResourceWarnings in test_asyncio ___ Python tracker

[issue27706] Random.seed, whose purpose is purportedly determinism, behaves non-deterministically with strings due to hash randomization

2016-08-17 Thread STINNER Victor
STINNER Victor added the comment: > Changing the affected version to just 2.7. Oh. The request looks like an enhancement. The problem is that if you add a new feature in Python 2.7.n+1, it's not available on Python 2.7.n. Support 2.7.n as well, you have to backport the code in your

[issue27594] Assertion failure when running "test_ast" tests with coverage.

2016-08-17 Thread Roundup Robot
Roundup Robot added the comment: New changeset 1bf307f42a6b by Ned Deily in branch 'default': Issue #27594: Prevent assertion error when running test_ast with coverage https://hg.python.org/cpython/rev/1bf307f42a6b -- nosy: +python-dev ___ Python

[issue27789] test_asyncio Resource Warnings

2016-08-17 Thread Terry J. Reedy
New submission from Terry J. Reedy: 3.6, Windows 10, debug build. The following appeared before and after pulling and rebuilding today. I am reporting as per Victor's request on pydev list. 0:00:22 [ 52/402] test_asyncio passed F:\Python\dev\36\lib\asyncio\sslproto.py:329: ResourceWarning:

[issue27786] longobject.c: simplify x_sub(), inline _PyLong_Negate()

2016-08-17 Thread STINNER Victor
STINNER Victor added the comment: Serhiy Storchaka: "LGTM." Oh, you posted your comment while I was pushing the patch after Brett wrote LGTM on the review (not on the bug tracker). > Maybe use size_a instead of Py_SIZE(z)? > And look at "sign". Currently it takes values 1 and -1. Is it worth

[issue27788] platform module's version number doesn't match its docstring

2016-08-17 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: That must have been an oversight. __version__ should read '0.8.0'. -- ___ Python tracker ___

[issue27645] Supporting native backup facility of SQLite

2016-08-17 Thread Cédric Krier
Changes by Cédric Krier : -- nosy: +ced ___ Python tracker ___ ___ Python-bugs-list

[issue27574] Faster parsing keyword arguments

2016-08-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Yes, I came to conclusion than needed to push existing issues for separate files. I'm sure there are ready patches waiting for review. Now there is additional reason for converting to Argument Clinic. But some files contain only one

[issue18880] ssl.SSLSocket shutdown doesn't behave like socket.shutdown

2016-08-17 Thread Ned Deily
Changes by Ned Deily : -- nosy: +alex, dstufft, giampaolo.rodola, janssen versions: +Python 3.6 -Python 2.6, Python 3.1 ___ Python tracker

[issue26988] Add AutoNumberedEnum to stdlib

2016-08-17 Thread Raymond Hettinger
Raymond Hettinger added the comment: > you ran your test script with the -m "run module as script" flag Right, that was a mistest, so it looks like triple quotes do work. I did notice that there's also an issue if one line reads, "red='hello'". But really, the big issue is using a

[issue27574] Faster parsing keyword arguments

2016-08-17 Thread Brett Cannon
Brett Cannon added the comment: I think for converting uses to Argument Clinic it can be done in a more iterative process on a per-module basis. How many modules do we have left to convert? If it isn't ridiculously huge we could open individual issues to convert them each. --

[issue26200] SETREF adds unnecessary work in some cases

2016-08-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you Raymond and Victor. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker

[issue27574] Faster parsing keyword arguments

2016-08-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I left this issue open for three reasons. 1. I had ideas and almost finished patch for different optimization. Unfortunately my hope was not justified, new implementation is slower. If I fail to fix it in few days, I'll close the issue. 2. For bikeshedding

[issue27786] longobject.c: simplify x_sub(), inline _PyLong_Negate()

2016-08-17 Thread STINNER Victor
STINNER Victor added the comment: Thanks for the review Brett, I pushed my fix. -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue27782] Multi-phase extension module initialization, inconsistent exceptions and conflicts between code and PEP

2016-08-17 Thread Xiang Zhang
Xiang Zhang added the comment: Thanks Petr. I'd appreciate it if you are willing to review the patch. Upload a patch to fix this, along with tests and doc updating. But here is something different. In PEP489, it is explicitly stated that "Py_mod_create slot is not responsible for setting

[issue27786] longobject.c: simplify x_sub(), inline _PyLong_Negate()

2016-08-17 Thread Roundup Robot
Roundup Robot added the comment: New changeset be9dc240bf28 by Victor Stinner in branch 'default': Issue #27786: Simplify x_sub() https://hg.python.org/cpython/rev/be9dc240bf28 -- nosy: +python-dev ___ Python tracker

[issue27786] longobject.c: simplify x_sub(), inline _PyLong_Negate()

2016-08-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: LGTM. Maybe use size_a instead of Py_SIZE(z)? And look at "sign". Currently it takes values 1 and -1. Is it worth to replace it with boolean variable "negative"? Or Py_ssize_t variable size_z that takes values size_a and -size_a? --

[issue27755] Retire DynOptionMenu with a ttk Combobox

2016-08-17 Thread Mark Roseman
Mark Roseman added the comment: Justin, as you say, I think your patch is entirely reasonable as an interim step, as eventually doing a broader improvement on the preferences dialog as suggested in #24781 makes sense. My reworked version used Combobox in similar ways; I think we can safely

[issue27706] Random.seed, whose purpose is purportedly determinism, behaves non-deterministically with strings due to hash randomization

2016-08-17 Thread Glyph Lefkowitz
Glyph Lefkowitz added the comment: Changing the affected version to just 2.7. -- versions: -Python 3.5, Python 3.6 ___ Python tracker ___

[issue27706] Random.seed, whose purpose is purportedly determinism, behaves non-deterministically with strings due to hash randomization

2016-08-17 Thread Glyph Lefkowitz
Glyph Lefkowitz added the comment: It does seem to be stable on python 3, but on python 2.7 it's definitely a problem: $ python -Rc "import random; r=random.Random('abc'); print(''.join(map(str, (r.randrange(10) for x in range(10, hash('abc'))" ('9553343809', -1972659830997666042) $

[issue26988] Add AutoNumberedEnum to stdlib

2016-08-17 Thread Ethan Furman
Ethan Furman added the comment: Raymond, I appreciate your review and your poll. I am open to removing AutoEnum, but would like to give it a couple more weeks of review. (I'll post on py-dev.) The only point you made that I will firmly refute is the "unexpected breakage": you ran your test

[issue27181] Add geometric mean to `statistics` module

2016-08-17 Thread Mark Dickinson
Mark Dickinson added the comment: > self.assertEqual(self.nroot(x**12, 12), float(x)) > AssertionError: 1.1865 != 1.1868 That looks like a case where the test should simply be weakened to an `assertAlmostEqual` with a suitable tolerance; there's no strong reason to

[issue27786] longobject.c: simplify x_sub(), inline _PyLong_Negate()

2016-08-17 Thread STINNER Victor
STINNER Victor added the comment: Updated patch. -- Added file: http://bugs.python.org/file44135/x_sub-2.patch ___ Python tracker ___

[issue27785] Module platform: Versions of Windows

2016-08-17 Thread Steve Dower
Steve Dower added the comment: Platform module version 1.0.8 added support for Windows 8.1 and later. You actually downgraded to 1.0.7, which is why you lost functionality. -- resolution: -> not a bug status: open -> closed ___ Python tracker

[issue27786] longobject.c: simplify x_sub(), inline _PyLong_Negate()

2016-08-17 Thread Brett Cannon
Brett Cannon added the comment: That works too. :) -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue27786] longobject.c: simplify x_sub(), inline _PyLong_Negate()

2016-08-17 Thread STINNER Victor
STINNER Victor added the comment: > I would add a comment as to why the assertion is there, otherwise it seems > somewhat random that it exists. Hum. Maybe it's even better to remove the assertion :-) -- ___ Python tracker

[issue27786] longobject.c: simplify x_sub(), inline _PyLong_Negate()

2016-08-17 Thread Brett Cannon
Brett Cannon added the comment: I would add a comment as to why the assertion is there, otherwise it seems somewhat random that it exists. -- nosy: +brett.cannon ___ Python tracker

[issue27781] Change sys.getfilesystemencoding() on Windows to UTF-8

2016-08-17 Thread Brett Cannon
Changes by Brett Cannon : -- nosy: +brett.cannon ___ Python tracker ___ ___

[issue27785] Module platform: Versions of Windows

2016-08-17 Thread Brett Cannon
Changes by Brett Cannon : -- nosy: -brett.cannon ___ Python tracker ___ ___

[issue27785] Module platform: Versions of Windows

2016-08-17 Thread Brett Cannon
Changes by Brett Cannon : -- nosy: +brett.cannon ___ Python tracker ___ ___

[issue27788] platform module's version number doesn't match its docstring

2016-08-17 Thread Brett Cannon
New submission from Brett Cannon: Not sure if it's worth keeping the version number around, but ATM the module has __version__ set to 1.0.7 while the docstring mentions a 1.0.8. -- components: Library (Lib) messages: 272964 nosy: brett.cannon, lemburg priority: normal severity: normal

[issue27781] Change sys.getfilesystemencoding() on Windows to UTF-8

2016-08-17 Thread Steve Dower
Steve Dower added the comment: Ah I see, if we end up sticking with MBCS and offering a switch to enable UTF-8. In that case, we'll definitely ensure the flag is the same (but I'm hopeful we will just make the reliable behavior on Windows the default, so it won't matter). --

[issue27781] Change sys.getfilesystemencoding() on Windows to UTF-8

2016-08-17 Thread STINNER Victor
STINNER Victor added the comment: Steve Dower added the comment: > By portable, do you mean not using an environment variable? I mean that "python3 -X utf8" should force sys.getfilesystemencoding() to UTF-8 on UNIX/BSD, it would ignore the current locale setting. --

[issue27781] Change sys.getfilesystemencoding() on Windows to UTF-8

2016-08-17 Thread Steve Dower
Steve Dower added the comment: By portable, do you mean not using an environment variable? Command line parsing is potentially affected by this on Windows - I'd have to look deeper - as command lines are provided as UTF-16. But we may not ever expose them as bytes. I don't even know that

[issue27731] Opt-out of MAX_PATH on Windows 10

2016-08-17 Thread Steve Dower
Steve Dower added the comment: No, the flag that we add to the binary is backwards compatible. Earlier versions will just ignore it. -- ___ Python tracker

[issue9998] ctypes find_library should search LD_LIBRARY_PATH on Linux

2016-08-17 Thread Roundup Robot
Roundup Robot added the comment: New changeset 385181e809bc by Vinay Sajip in branch 'default': Closes #9998: Allowed find_library to search additional locations for libraries. https://hg.python.org/cpython/rev/385181e809bc -- nosy: +python-dev resolution: -> fixed stage: patch review

[issue23591] enum: Add Flags and IntFlags

2016-08-17 Thread STINNER Victor
STINNER Victor added the comment: > The repr is better -- which patch did you test? Sorry, I wasn't clear. I didn't test any patch :-) I expect (not expected) better repr when changes will be applied, it's just a remark... -- ___ Python tracker

[issue27782] Multi-phase extension module initialization, inconsistent exceptions and conflicts between code and PEP

2016-08-17 Thread Petr Viktorin
Petr Viktorin added the comment: Hi! I'm on a tight schedule this week, so I'm not looking into this in detail. But please let me know if you need any help and I'll raise the priority. -- ___ Python tracker

[issue23591] enum: Add Flags and IntFlags

2016-08-17 Thread Ethan Furman
Ethan Furman added the comment: The repr is better -- which patch did you test? -- ___ Python tracker ___ ___

[issue27787] Avoid test_main() in test_httplib; gc.collect() dangling threads

2016-08-17 Thread STINNER Victor
STINNER Victor added the comment: Your patch changes 3 different things. After the code review, I suggest to split it in two changes (fix test_httplib threading ripper, fix save_env, fix test_httplib main). -- nosy: +haypo ___ Python tracker

[issue27787] Avoid test_main() in test_httplib; gc.collect() dangling threads

2016-08-17 Thread Martin Panter
New submission from Martin Panter: In Issue 12319, there are many iterations of a patch that adds a new TestCase subclass to Lib/test/test_httplib.py. However it never got run by the main regrtest infrastructure, because nobody remembered to add the class to the list of test classes. So I

[issue24853] Py_Finalize doesn't clean up PyImport_Inittab

2016-08-17 Thread STINNER Victor
STINNER Victor added the comment: The issue was fixed by a previous change, maybe the issue #27736. -- resolution: -> fixed status: open -> closed ___ Python tracker

[issue26988] Add AutoNumberedEnum to stdlib

2016-08-17 Thread STINNER Victor
STINNER Victor added the comment: > Raymond, what are your thoughts about the version of AutoEnum that requires > that a bare tuple be used as the value. It has been in the Python docs since > 3.4 and was actually the original request of this issue: >

[issue26988] Add AutoNumberedEnum to stdlib

2016-08-17 Thread STINNER Victor
STINNER Victor added the comment: > It's not just C that has enums where you can define a unique group of names > and omit the values ... Yes, Python 3.4 too: Animal = Enum('Animal', 'ant bee cat dog') https://docs.python.org/dev/library/enum.html#functional-api --

[issue27781] Change sys.getfilesystemencoding() on Windows to UTF-8

2016-08-17 Thread STINNER Victor
STINNER Victor added the comment: > I suspect we'll have to go to Guido to get a ruling on the default, but I'll > add an environment variable to switch. If you go in this direction, I would like to follow you for the UNIX/BSD side to make the switch portable. I was thinking about "-X utf8"

[issue27781] Change sys.getfilesystemencoding() on Windows to UTF-8

2016-08-17 Thread STINNER Victor
STINNER Victor added the comment: > Is there a surrogatepass option? I'm talking about error handlers of Python codecs: text.encode('utf8', 'surrogatepass') -- ___ Python tracker

[issue27761] Private _nth_root function loses accuracy

2016-08-17 Thread STINNER Victor
STINNER Victor added the comment: > floor_nroot does arithmetic with integers of bit-length approximately 54*n. Oh, I see. But maybe the Decimal is fast enough for such giant numbers, since we can control the precision? -- ___ Python tracker

[issue24853] Py_Finalize doesn't clean up PyImport_Inittab

2016-08-17 Thread Xiang Zhang
Xiang Zhang added the comment: > initialize/run script/finalize will crash the second time I don't think so since we already get a test case in test_capi that does init/fini repeatedly. It does not crash. So I agree to close this one. -- ___

[issue27698] socketpair not in socket.__all__ on Windows

2016-08-17 Thread Roundup Robot
Roundup Robot added the comment: New changeset ac2bc921169c by Victor Stinner in branch '3.5': Issue #27698: Add socketpair to socket.__all__ on Windows https://hg.python.org/cpython/rev/ac2bc921169c -- nosy: +python-dev ___ Python tracker

[issue27698] socketpair not in socket.__all__ on Windows

2016-08-17 Thread STINNER Victor
STINNER Victor added the comment: The issue should now be fixed by my change. Thanks for the bug report! -- nosy: +haypo resolution: -> fixed status: open -> closed ___ Python tracker

[issue27725] Use Py_SIZE(x) instead of x->ob_size

2016-08-17 Thread STINNER Victor
STINNER Victor added the comment: > However, compiling ONLY the file Objects/longobject.c with -qalias=noansi did > fix the issue on AIX. That could be the same on Linux. Nobody asked to only set the compiler file to only this file. As we said, the issue is sprayed in all the C code base. The

[issue27558] SystemError with bare `raise` in threading or multiprocessing

2016-08-17 Thread Xiang Zhang
Xiang Zhang added the comment: Thanks for your review, Victor. :) Leave a reply. -- ___ Python tracker ___

[issue27725] Use Py_SIZE(x) instead of x->ob_size

2016-08-17 Thread REIX Tony
REIX Tony added the comment: OK. However, compiling ONLY the file Objects/longobject.c with -qalias=noansi did fix the issue on AIX. That could be the same on Linux. I haven't tried to use Py_SIZE() in all places where it should be used. Now trying to figure out why GCC behaves worst than

[issue26988] Add AutoNumberedEnum to stdlib

2016-08-17 Thread Emanuel Barry
Emanuel Barry added the comment: I tend to like all things magic, but the more I think about it, and the less I like it being a part of the standard library. I've had a use for this feature before, and when I did, I cooked my own 12-lines subclass of EnumMeta and _EnumDict. Raymond's points

[issue18880] ssl.SSLSocket shutdown doesn't behave like socket.shutdown

2016-08-17 Thread STINNER Victor
Changes by STINNER Victor : -- type: behavior -> security ___ Python tracker ___

[issue27682] wsgiref: Windows Error 10053, ConnectionAbortedError: [WinError 10053] An established connection was aborted by the software in your host machine

2016-08-17 Thread STINNER Victor
Changes by STINNER Victor : -- title: Windows Error 10053, ConnectionAbortedError: [WinError 10053] An established connection was aborted by the software in your host machine -> wsgiref: Windows Error 10053, ConnectionAbortedError: [WinError 10053] An

[issue27725] Use Py_SIZE(x) instead of x->ob_size

2016-08-17 Thread Stefan Krah
Stefan Krah added the comment: Agreed, the changes are too big for 2.7. -- resolution: -> wont fix stage: -> resolved status: open -> closed ___ Python tracker

[issue27731] Opt-out of MAX_PATH on Windows 10

2016-08-17 Thread STINNER Victor
STINNER Victor added the comment: Hum, but we use the same binary (.exe) for all Windows versions. Does it mean that we drop support for Windows < 10 in Python 3.6? -- nosy: +haypo ___ Python tracker

[issue27558] SystemError with bare `raise` in threading or multiprocessing

2016-08-17 Thread STINNER Victor
STINNER Victor added the comment: I reviewed issue27558_v2.patch, see my comments. -- ___ Python tracker ___

[issue27785] Module platform: Versions of Windows

2016-08-17 Thread R. David Murray
Changes by R. David Murray : -- components: +Windows nosy: +paul.moore, steve.dower, tim.golden, zach.ware ___ Python tracker ___

[issue27786] longobject.c: simplify x_sub(), inline _PyLong_Negate()

2016-08-17 Thread STINNER Victor
Changes by STINNER Victor : -- nosy: +Oren Milman ___ Python tracker ___ ___

[issue12319] [http.client] HTTPConnection.request not support "chunked" Transfer-Encoding to send data

2016-08-17 Thread Martin Panter
Martin Panter added the comment: Patch 12 has the following changes: * Change the chunked_encoding parameter to keyword-only * Drop most of the change regarding the UpdatingFile test (see code review) * Update the urlopen() TypeError to mention “data” may be a file object * Fix and update the

[issue27725] Use Py_SIZE(x) instead of x->ob_size

2016-08-17 Thread STINNER Victor
STINNER Victor added the comment: I mean that fixing ob->ob_size in Objects/longobject.c is not enough. You should also fix C structures and fix all other C files in the code base... It's too late for such major refactoring in Python 2. -- ___

[issue27781] Change sys.getfilesystemencoding() on Windows to UTF-8

2016-08-17 Thread Steve Dower
Steve Dower added the comment: Thanks for the regen. I don't think git format is the problem as most of my patches are fine, it's probably because it was in a patch queue and so the parent isn't actually a known commit. I haven't tested whether this works without my other console patches but

[issue27725] Use Py_SIZE(x) instead of x->ob_size

2016-08-17 Thread STINNER Victor
STINNER Victor added the comment: I suggest to close this issue. Aliasing issues are complex and simply cannot be fixed in Python 2. The root issue has been fixed in Python 3, it required to change the main C structures of Python objects. The fix for your issue to already known, use

[issue27786] longobject.c: simplify x_sub(), inline _PyLong_Negate()

2016-08-17 Thread STINNER Victor
New submission from STINNER Victor: When reading the issue #27725, I saw that x_sub() of Objects/longobject.c is too careful just to change the sign of the newly created number: z cannot be shared at the end of the function, before z is normalized. Attached patch simplifies the code. See

[issue27781] Change sys.getfilesystemencoding() on Windows to UTF-8

2016-08-17 Thread Chi Hsuan Yen
Changes by Chi Hsuan Yen : -- nosy: +Chi Hsuan Yen ___ Python tracker ___ ___

[issue26988] Add AutoNumberedEnum to stdlib

2016-08-17 Thread John Hagen
John Hagen added the comment: @Raymond, you raise valid concerns to be sure. Hoping we can work something out. @Ethan, what are your thoughts? It's not just C that has enums where you can define a unique group of names and omit the values for clarity when they are not significant: C++:

[issue26741] subprocess.Popen should emit a ResourceWarning in destructor if the process is still running

2016-08-17 Thread STINNER Victor
STINNER Victor added the comment: Oops, I forget to close the issue. -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue27765] Accept UTF-8 encoded bytes as input to json.loads()

2016-08-17 Thread Berker Peksag
Changes by Berker Peksag : -- stage: needs patch -> resolved ___ Python tracker ___

[issue27574] Faster parsing keyword arguments

2016-08-17 Thread STINNER Victor
STINNER Victor added the comment: The issue can now be closed no? -- ___ Python tracker ___ ___

[issue27761] Private _nth_root function loses accuracy

2016-08-17 Thread Mark Dickinson
Mark Dickinson added the comment: Victor: by "way too slow", I really *do* mean way too slow. :-) floor_nroot does arithmetic with integers of bit-length approximately 54*n. For small n, that's fine, but if someone tried to take the geometric mean of a list of 5 values (which it seems to

[issue27599] Buffer overrun in binascii

2016-08-17 Thread STINNER Victor
Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___

[issue10976] accept bytes in json.loads()

2016-08-17 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: -pitrou ___ Python tracker ___ ___ Python-bugs-list

  1   2   >