[issue27364] Deprecate invalid escape sequences in str/bytes

2016-09-07 Thread Emanuel Barry
Changes by Emanuel Barry : Added file: http://bugs.python.org/file44435/invalid_stdlib_escapes_4.patch ___ Python tracker ___

[issue27364] Deprecate invalid escape sequences in str/bytes

2016-09-07 Thread Emanuel Barry
Changes by Emanuel Barry : Removed file: http://bugs.python.org/file44433/invalid_stdlib_escapes_3_regen.patch ___ Python tracker ___

[issue27654] [Patch] Use arc4random_buf() on CloudABI

2016-09-07 Thread Ed Schouten
Ed Schouten added the comment: Sure thing! Attached is an updated patch. -- Added file: http://bugs.python.org/file44434/patch-arc4random ___ Python tracker

[issue27364] Deprecate invalid escape sequences in str/bytes

2016-09-07 Thread Emanuel Barry
Changes by Emanuel Barry : Added file: http://bugs.python.org/file44433/invalid_stdlib_escapes_3_regen.patch ___ Python tracker ___

[issue27364] Deprecate invalid escape sequences in str/bytes

2016-09-07 Thread Emanuel Barry
Emanuel Barry added the comment: Rebased patch after Victor's commit in #16334. Also regenerated invalid_stdlib_escapes_3 in the hopes that Rietveld picks it up. -- Added file: http://bugs.python.org/file44432/deprecate_invalid_escapes_both_4.patch

[issue27996] Python 3 ssl module can't use a fileno to create a SSLSocket

2016-09-07 Thread Berker Peksag
Berker Peksag added the comment: Great, closing this then. > And the next release will include this patch? Christian (one of our SSL module maintainers) just reviewed the patch so the next step is to address his review comments and upload a new patch. If you don't see any movement from

[issue27996] Python 3 ssl module can't use a fileno to create a SSLSocket

2016-09-07 Thread SenBin Yu
SenBin Yu added the comment: Yes, the giving code is what i desiere and shoud be supported. Sorry, i haven't see the patch file.And the next release will include this patch? -- ___ Python tracker

[issue27996] Python 3 ssl module can't use a fileno to create a SSLSocket

2016-09-07 Thread Berker Peksag
Berker Peksag added the comment: Did you look at the patch? It adds the following test case: +s = socket.socket() +sfd = s.fileno() +# Create secure socket from fileno +ss = ssl.SSLSocket(fileno=sfd) +self.assertTrue(ss.fileno() == sfd) Isn't that what

[issue27654] [Patch] Use arc4random_buf() on CloudABI

2016-09-07 Thread Christian Heimes
Christian Heimes added the comment: Thanks. The bare call to arc4random_buf() looks wrong at first. Please add a comment that arc4random_buf() cannot fail / does not report back errors. -- ___ Python tracker

[issue27996] Python 3 ssl module can't use a fileno to create a SSLSocket

2016-09-07 Thread SenBin Yu
SenBin Yu added the comment: The issue 27629 describe creating a SSLSocket only with server_hostname argument.But what i said is that we can't creating a SSLSocket with fileno argument from a existing socket.I'm strange about this code design that meaningless branch conditions exists.

[issue25856] The __module__ attribute of non-heap classes is not interned

2016-09-07 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file44431/intern_and_cache___module__2.patch ___ Python tracker ___

[issue25856] The __module__ attribute of non-heap classes is not interned

2016-09-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Could anyone please make a review? -- assignee: -> serhiy.storchaka ___ Python tracker ___

[issue27629] Cannot create ssl.SSLSocket without existing socket

2016-09-07 Thread Christian Heimes
Christian Heimes added the comment: The patch is incomplete. Please also check that type == SOCK_STREAM. The code can be simplified with a bitmask test: if sock is not None: type = sock.type if type & socket.SOCK_STREAM != socket.SOCK_STREAM: raise NotImplementedError --

[issue25776] More compact pickle of iterators etc

2016-09-07 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file44430/iterators_pickle_4.patch ___ Python tracker ___

[issue27996] Python 3 ssl module can't use a fileno to create a SSLSocket

2016-09-07 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report. This looks like a duplicate of issue 27629. Please provide a reproducer if it's different problem than issue 27629. -- nosy: +berker.peksag resolution: -> duplicate stage: -> resolved status: open -> closed superseder: ->

[issue16113] Add SHA-3 and SHAKE (Keccak) support

2016-09-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset ddc95a9bc2e0 by Christian Heimes in branch 'default': Issue #16113: one more C90 violation in big endian code. https://hg.python.org/cpython/rev/ddc95a9bc2e0 -- ___ Python tracker

[issue26032] Use scandir() to speed up pathlib globbing

2016-09-07 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue27938] PyUnicode_AsEncodedString, PyUnicode_Decode: add fast-path for "us-ascii" encoding

2016-09-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Maybe Windows buildbots failures are related: http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x/builds/8294/steps/test/logs/stdio == FAIL:

[issue25596] Use scandir() to speed up the glob module

2016-09-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: os.scandir() cannot handle bytes argument on Windows. If an argument is string, os.scandir() yields entries with string names, if an argument is bytes object, os.scandir() yields entries with bytes names. Opened issue27998 for adding support of bytes paths

[issue8800] add threading.RWLock

2016-09-07 Thread Kristján Valur Jónsson
Kristján Valur Jónsson added the comment: Seems to have fizzled out due to the intense amount of bikeshedding required. -- ___ Python tracker ___

[issue16113] Add SHA-3 and SHAKE (Keccak) support

2016-09-07 Thread Christian Heimes
Christian Heimes added the comment: A buildbot is complaining about strict aliasing: In file included from /buildbot/buildarea/3.x.ware-gentoo-x86.installed/build/Modules/_sha3/sha3module.c:113:0:

[issue16384] import.c doesn't handle EOFError from PyMarshal_Read*

2016-09-07 Thread Sye van der Veen
Sye van der Veen added the comment: I feel this patch (file44424) misses the mark. Any two Python processes that try to import a module, without a pyc, at the same time could suffer race conditions. The first process will start to write the pyc, get interrupted, and the second will fail with an

[issue16113] Add SHA-3 and SHAKE (Keccak) support

2016-09-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset 68df416e94ba by Christian Heimes in branch 'default': Issue #16113: take 2 on big endian machines. https://hg.python.org/cpython/rev/68df416e94ba -- ___ Python tracker

[issue16113] Add SHA-3 and SHAKE (Keccak) support

2016-09-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset e8884dcace9f by Christian Heimes in branch 'default': Issue #16113: compile the module on Windows, too. https://hg.python.org/cpython/rev/e8884dcace9f -- ___ Python tracker

[issue16113] Add SHA-3 and SHAKE (Keccak) support

2016-09-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset 4971ca2960c7 by Christian Heimes in branch 'default': Issue #16113: KeccakP-1600-opt64 does not support big endian platforms yet. https://hg.python.org/cpython/rev/4971ca2960c7 -- ___ Python tracker

[issue27928] Add hashlib.scrypt

2016-09-07 Thread Christian Heimes
Christian Heimes added the comment: Benjamin, what's your take on Alex's suggestion? gutworth: Alex_Gaynor has asked me if hashlib.scrypt() can go into 2.7, too. It's a password-based KDF like hashlib.pbkdf2() but more secure than PBKDF2. It requires OpenSSL 1.1.0. gutworth: I think it'd be

[issue16113] Add SHA-3 and SHAKE (Keccak) support

2016-09-07 Thread Christian Heimes
Changes by Christian Heimes : -- stage: patch review -> commit review ___ Python tracker ___

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

2016-09-07 Thread Erik Bray
Changes by Erik Bray : -- nosy: +erik.bray stage: -> patch review ___ Python tracker ___

[issue16113] Add SHA-3 and SHAKE (Keccak) support

2016-09-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset f8700ee4aef0 by Christian Heimes in branch 'default': Issue #16113: Add SHA-3 and SHAKE support to hashlib module. https://hg.python.org/cpython/rev/f8700ee4aef0 -- ___ Python tracker

[issue27989] incomplete signature with help function using typing

2016-09-07 Thread Spencer Brown
Spencer Brown added the comment: More precisely, the issue is with inspect.formatannotation(), which overrides/ignores the repr if the annotation is an instance of type. Perhaps that should be changed to also check that __repr__ is type's repr. -- nosy: +Spencer Brown

[issue11551] test_dummy_thread.py test coverage improvement

2016-09-07 Thread Senthil Kumaran
Senthil Kumaran added the comment: I've updated the patch to use unittest.mock, the removed the old style way of exercising it. -- nosy: +orsenthil Added file: http://bugs.python.org/file44429/issue11551.patch ___ Python tracker

[issue27984] singledispatch register should typecheck its argument

2016-09-07 Thread Xiang Zhang
Xiang Zhang added the comment: It's also better to add the typecheck to dispatch. Otherwise sometimes it can generate not obvious exception message. >>> from enum import IntEnum >>> from functools import singledispatch >>> IS = IntEnum("IS", "a, b") >>> @singledispatch ... def foo(x): ...

[issue25596] Use scandir() to speed up the glob module

2016-09-07 Thread Dima Tisnek
Dima Tisnek added the comment: @Serhiy please comment the implications / limitations of the fallback on Windows. Is it that scandir cannot handle bytes argument only? If argument is unicode, but response set contains bytes paths, will that work? --

[issue27998] Add support of bytes paths in os.scandir()

2016-09-07 Thread Eryk Sun
Eryk Sun added the comment: This is implemented in Steve's latest patch in issue 27781. For example: >>> sys.platform 'win32' >>> os.mkdir('test') >>> f = open('test/\U0001.txt', 'w') >>> next(os.scandir(b'test')).name b'\xf0\x90\x80\x80.txt' >>>

[issue26970] Replace OpenSSL's CPRNG with system entropy source

2016-09-07 Thread Christian Heimes
Christian Heimes added the comment: No, it won't make it into 3.6. My patch is far from ready. -- versions: +Python 3.7 -Python 3.6 ___ Python tracker

[issue16334] Faster unicode-escape and raw-unicode-escape codecs

2016-09-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thanks Victor! I benchmarked your patch. There is no regression in comparison with my patch. In few cases your patch is even faster! UnpatchedPatch v.4Patch v.5 148 (+76%) 235 (+11%) 260decode unicode-escape 'A'*1 197 (+30%) 257

[issue27998] Add support of bytes paths in os.scandir()

2016-09-07 Thread Paul Moore
Paul Moore added the comment: In the light of Steve Dower's work to "un-deprecate" bytes paths, I agree this should be added. -- ___ Python tracker ___

[issue27998] Add support of bytes paths in os.scandir()

2016-09-07 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- title: Add support of butes paths in os.scandir() -> Add support of bytes paths in os.scandir() ___ Python tracker

[issue27998] Add support of butes paths in os.scandir()

2016-09-07 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: Bytes paths are deprecated on Windows and their support was not added in os.scandir() for purpose. But this makes harder converting filesystem walking functions to use os.scandir(). We have to add a special case for bytes paths on Windows in every such

[issue7769] SimpleXMLRPCServer.SimpleXMLRPCServer.register_function as decorator

2016-09-07 Thread Xiang Zhang
Xiang Zhang added the comment: > Also one side effect that I can not eliminate is when it is used as a normal > function, the function instead of None is returned. I see the former patches > get this problem too. I think this does not matter after seeing functools.singledispatch. The

[issue27963] null poiter dereference in set_conversion_mode due uncheck _ctypes_conversion_errors

2016-09-07 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___

[issue26032] Use scandir() to speed up pathlib globbing

2016-09-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset 927665c4aaab by Serhiy Storchaka in branch 'default': Issue #26032: Optimized globbing in pathlib by using os.scandir(); it is now https://hg.python.org/cpython/rev/927665c4aaab -- nosy: +python-dev ___

[issue20842] pkgutil docs should reference glossary terms not PEP 302

2016-09-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset a4360b1b45a8 by Senthil Kumaran in branch 'default': issue20842 - null merge with 3.5 https://hg.python.org/cpython/rev/a4360b1b45a8 -- nosy: +python-dev ___ Python tracker

[issue26896] mix-up with the terms 'importer', 'finder', 'loader' in the import system and related code

2016-09-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7537ca1c2aaf by Senthil Kumaran in branch '3.5': [backport to 3.5] - issue26896 - Disambiguate uses of "importer" with "finder". https://hg.python.org/cpython/rev/7537ca1c2aaf -- ___ Python tracker

[issue26896] mix-up with the terms 'importer', 'finder', 'loader' in the import system and related code

2016-09-07 Thread Senthil Kumaran
Senthil Kumaran added the comment: Hi Brett, I backported only portions of the patch some this issue that were applicable to the issue that I was fixing. I will backport remain portions so that everything will be consistent now. -- Added file:

[issue27850] Remove 3DES from cipher list (sweet32 CVE-2016-2183)

2016-09-07 Thread Cory Benfield
Cory Benfield added the comment: > Future OpenSSLs don't affect Python 3.4, as Python 3.4 won't be upgraded to > them. Can I get a clarification on this, please, Larry? I just want to confirm I understand what your meaning is here. My reading of this is that for OpenSSL Python defines a

[issue27322] test_compile_path fails when python has been installed

2016-09-07 Thread Chris Angelico
Chris Angelico added the comment: Just ran into the same issue, but in a slightly different way, and with slightly different consequences. You can actually eliminate this failure by manually running compileall on the affected directory: sudo python3 -m compileall

[issue25596] Use scandir() to speed up the glob module

2016-09-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset 48e573e0a610 by Serhiy Storchaka in branch 'default': Issue #25596: Falls back to listdir in glob for bytes paths on Windows. https://hg.python.org/cpython/rev/48e573e0a610 -- ___ Python tracker

[issue27080] Implement the formatting part of PEP 515, '_' in numeric literals.

2016-09-07 Thread Chris Angelico
Chris Angelico added the comment: Another couple of tests, per comments. -- Added file: http://bugs.python.org/file44425/moar-tests.patch ___ Python tracker

[issue27137] Python implementation of `functools.partial` is not a class

2016-09-07 Thread Nick Coghlan
Nick Coghlan added the comment: Attempting to apply this, I found that the pure Python fallback fails the new recursive repr tests added in https://bugs.python.org/issue25455 The recursive pickling test is also failing, but I suspect that may be due to an error in my attempt to apply parts of

[issue27782] Multi-phase extension module initialization, inconsistent exceptions and conflicts between code and PEP

2016-09-07 Thread Xiang Zhang
Xiang Zhang added the comment: Thanks for your notice, Nick. :) Of course I am interested. I'll start following import-sig and reading Petr's good idea. -- ___ Python tracker

[issue15206] uuid module falls back to unsuitable RNG

2016-09-07 Thread STINNER Victor
STINNER Victor added the comment: > Given the introduction of the secrets module in 3.6, perhaps uuid could be > updated to fall back to that rather than to the random module and leave older > versions unmodified? issue15206.patch catchs exceptions on random.SystemRandom error, but the

[issue8800] add threading.RWLock

2016-09-07 Thread Ofek Lev
Ofek Lev added the comment: What is the status of the patch? -- nosy: +Ofekmeister ___ Python tracker ___ ___

<    1   2   3