[issue29335] subprocess module does not check WIFSTOPPED on SIGCHLD

Gregory P. Smith added the comment: thanks Ned, I was awaiting interesting buildbot results. :) fixed in 2.7 and 3.5 onwards. thanks for the report Zach. not closing until I also apply the fix to the subprocess32 backport. -- resolution: -> fixed stage: patch review -> commit review

[issue28999] Use Py_RETURN_NONE and like

Roundup Robot added the comment: New changeset df87db35833e by Serhiy Storchaka in branch 'default': Issue #28999: Use Py_RETURN_NONE, Py_RETURN_TRUE and Py_RETURN_FALSE wherever https://hg.python.org/cpython/rev/df87db35833e -- nosy: +python-dev ___

[issue28876] bool of large range raises OverflowError

INADA Naoki added the comment: LGTM, except 2-space indent. -- nosy: +inada.naoki ___ Python tracker ___ ___

[issue29348] this comment 'iff' should be 'if'?

INADA Naoki added the comment: "iff" is short form of "if and only if". -- nosy: +inada.naoki resolution: -> not a bug status: open -> closed ___ Python tracker

[issue29348] this comment 'iff' should be 'if'?

New submission from Tang Weizhi: I think this comment 'if' should be more clearly, or 'iff' is the abbreviation of 'if and only if'? -- assignee: docs@python components: Documentation messages: 286051 nosy: Tangwz, docs@python priority: normal pull_requests: 20 severity: normal status:

[issue29335] subprocess module does not check WIFSTOPPED on SIGCHLD

Roundup Robot added the comment: New changeset 8e3d412f8e89 by Gregory P. Smith in branch '2.7': Issue #29335: Fix subprocess.Popen.wait() when the child process has https://hg.python.org/cpython/rev/8e3d412f8e89 -- ___ Python tracker

[issue28999] Use Py_RETURN_NONE and like

INADA Naoki added the comment: Oh, I feel three LGTMs are positive signal. As I commented on ML, I think "ask forgiveness than permission" is realistic approach for patches like this. But it's up to you. -- ___ Python tracker

[issue28876] bool of large range raises OverflowError

Raymond Hettinger added the comment: This patch looks ready to go. I'll wait a bit to see it there are any other comments. If not, I'll apply it shortly. -- assignee: -> rhettinger ___ Python tracker

[issue28999] Use Py_RETURN_NONE and like

Raymond Hettinger added the comment: I believe this is a safe change. All of the replaced pairs on consecutive lines so there are no intervening operations. For Modules/xxsubtype.c, I think the code should remain as-is. It is intended to be the simplest possible example of how to make a

[issue29335] subprocess module does not check WIFSTOPPED on SIGCHLD

Ned Deily added the comment: Among other buildbot failures: http://buildbot.python.org/all/builders/x86%20Tiger%203.6/builds/142/steps/test/logs/stdio == ERROR: test_child_terminated_in_stopped_state

[issue28635] Update What's New for 3.6

Ned Deily added the comment: I don't see any reason to keep this open. Thanks so much, Elvis and Yury, for doing such a great job again! -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker

[issue29347] Python 2.7.8 is crashing while creating weakref for a given object.

Changes by Saida Dhanavath : -- type: -> crash ___ Python tracker ___ ___

[issue29347] Python 2.7.8 is crashing while creating weakref for a given object.

New submission from Saida Dhanavath: We are using python 2.7.8 on Ubuntu 14.04 to host our services. In one of the crashes python interpreter got segmentation fault while initializing weakref for a given object. Please find snip of backtraces as given below. #0 0x7f62aa86951a in

[issue29314] asyncio.async deprecation warning is missing stacklevel=2

Changes by INADA Naoki : -- stage: needs patch -> commit review ___ Python tracker ___

[issue29314] asyncio.async deprecation warning is missing stacklevel=2

INADA Naoki added the comment: LGTM. -- nosy: +inada.naoki ___ Python tracker ___ ___ Python-bugs-list

[issue28635] Update What's New for 3.6

Elvis Pranskevichus added the comment: I'm pretty sure we're done with What's New for 3.6.0, so, unless it's worth keeping this open for any 3.6.x edits, I'm for closing this. -- ___ Python tracker

[issue29212] Python 3.6 logging thread name regression with concurrent.future threads

Changes by Xiang Zhang : -- nosy: +gregory.p.smith ___ Python tracker ___ ___

[issue28635] Update What's New for 3.6

Guido van Rossum added the comment: Can this be closed (since 3.6 has been released)? Or is there still more you'd like to do specifically to complete this issue? -- nosy: +gvanrossum ___ Python tracker

[issue28556] typing.py upgrades

Roundup Robot added the comment: New changeset 4121755d by Guido van Rossum in branch '3.6': Issue #28556: various style fixes for typing.py (3.5->3.6) https://hg.python.org/cpython/rev/4121755d New changeset a7e69479ee22 by Guido van Rossum in branch 'default': Issue #28556: various

[issue28556] typing.py upgrades

Roundup Robot added the comment: New changeset f100619e7137 by Guido van Rossum in branch '3.5': Issue #28556: Allow defining methods in NamedTuple class syntax (#362) https://hg.python.org/cpython/rev/f100619e7137 -- ___ Python tracker

[issue28556] typing.py upgrades

Roundup Robot added the comment: New changeset 7bf6b4fe2c3c by Guido van Rossum in branch '3.5': Issue #28556: various style fixes for typing.py https://hg.python.org/cpython/rev/7bf6b4fe2c3c -- ___ Python tracker

[issue28879] smtplib send_message should add Date header if it is missing, per RFC5322

Eric Lafontaine added the comment: Hi, I've implemented the heuristic, but it's messy with the issue of this ticket. I'm going to do some clean-up and separate the issue from the heuristic and post them separated. Date issue ; Test Case Documentation Implementation Heuristic of Resent ;

[issue29335] subprocess module does not check WIFSTOPPED on SIGCHLD

Roundup Robot added the comment: New changeset 269296b2a047 by Gregory P. Smith in branch '3.5': Issue #29335: Fix subprocess.Popen.wait() when the child process has https://hg.python.org/cpython/rev/269296b2a047 New changeset ed5255a61648 by Gregory P. Smith in branch '3.6': Issue #29335: Fix

[issue29212] Python 3.6 logging thread name regression with concurrent.future threads

INADA Naoki added the comment: I don't think this is a regression, bug, bogos naming. I agree that "_0" is ugly. But the name describes what is the thread, than "Thread-1". How about giving default thread_name_prefix less ugly? e.g. "ThreadPoolExecutor-worker". -- nosy: +inada.naoki

[issue29346] datetime.utcfromtimestamp() returns strange result for very large values

Alexander Belopolsky added the comment: This looks like a duplicate of issue #29100 ("datetime.fromtimestamp() doesn't check min/max year anymore: regression of Python 3.6"). -- keywords: +3.6regression nosy: +haypo ___ Python tracker

[issue29212] Python 3.6 logging thread name regression with concurrent.future threads

Changes by Ned Deily : -- nosy: +bquinlan ___ Python tracker ___ ___ Python-bugs-list

[issue29212] Python 3.6 logging thread name regression with concurrent.future threads

desbma added the comment: Ping -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29136] Add OP_NO_TLSv1_3

Christian Heimes added the comment: memo to me: Update the TLS cipher list to include TLS 1.3 ciphers. TLS 1.3 uses a disjunct set of cipher suites. No member of the current cipher suite set is compatible with TLS 1.3. Handshake with TLS 1.3 enabled servers is going to fail. As of today

[issue29284] Include thread_name_prefix in the concurrent.futures.ThreadPoolExecutor example 17.4.2.1

Changes by Davin Potts : -- nosy: +davin ___ Python tracker ___ ___

[issue29335] subprocess module does not check WIFSTOPPED on SIGCHLD

Gregory P. Smith added the comment: test added. -- stage: test needed -> patch review type: -> behavior Added file: http://bugs.python.org/file46386/issue29335-gps02.diff ___ Python tracker

[issue29196] Remove old-deprecated plistlib features

Changes by Serhiy Storchaka : -- assignee: -> ronaldoussoren ___ Python tracker ___

[issue28769] Make PyUnicode_AsUTF8 returning "const char *" rather of "char *"

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue28769] Make PyUnicode_AsUTF8 returning "const char *" rather of "char *"

Roundup Robot added the comment: New changeset 0d89212941f4 by Serhiy Storchaka in branch 'default': Issue #28769: The result of PyUnicode_AsUTF8AndSize() and PyUnicode_AsUTF8() https://hg.python.org/cpython/rev/0d89212941f4 -- nosy: +python-dev ___

[issue28769] Make PyUnicode_AsUTF8 returning "const char *" rather of "char *"

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___

[issue28769] Make PyUnicode_AsUTF8 returning "const char *" rather of "char *"

Stefan Krah added the comment: For _decimal I'm happy with just the cast from the first patch -- you have a one line diff and it's easy to see the focus of the issue. -- ___ Python tracker

[issue17720] pickle.py's load_appends should call append() on objects other than lists

Serhiy Storchaka added the comment: >From PEP 7: listitemsOptional, and new in this PEP. If this is not None, it should be an iterator (not a sequence!) yielding successive list items. These list items will be pickled, and appended to

[issue28749] Fixed the documentation of the mapping codec APIs

Serhiy Storchaka added the comment: How can we move this issue forward? Marc-Andre, have I answered to your objections? -- ___ Python tracker ___

[issue28769] Make PyUnicode_AsUTF8 returning "const char *" rather of "char *"

Serhiy Storchaka added the comment: Stefan, what are your thoughts about this? The patch touches _decimal.c. -- nosy: +skrah ___ Python tracker ___

[issue29058] Mark new limited C API

Changes by Serhiy Storchaka : -- status: open -> closed ___ Python tracker ___

[issue29346] datetime.utcfromtimestamp() returns strange result for very large values

Marc-Andre Lemburg added the comment: According to the datetime.h file, the valid range for year is 1-, so it's a bit surprising that Python 3.6 allows dates outside this range. Internally, the year is represented using 2 bytes, so you could represent years outside the range and up to

[issue29058] Mark new limited C API

Steve Dower added the comment: I don't care enough to argue about it with you. Let's just fix the API as soon as we can and apologize to people who hit inconsistencies in earlier versions. -- ___ Python tracker

[issue29335] subprocess module does not check WIFSTOPPED on SIGCHLD

Gregory P. Smith added the comment: The attached patch should fix it. I want to incorporate a bug.py like regression test into test_subprocess.py. -- keywords: +patch stage: -> test needed Added file: http://bugs.python.org/file46385/issue29335-gps01.diff

[issue29346] datetime.utcfromtimestamp() returns strange result for very large values

Changes by Serhiy Storchaka : -- nosy: +belopolsky, lemburg ___ Python tracker ___

[issue29345] More lost updates with multiprocessing.Value and .Array

Eryk Sun added the comment: >if p.exitcode != 0: >print('Child failed with exit code:', p.exitcode) Interestingly the exit code is always 1 when running under pythonw.exe. I just inspected what's going on by setting sys.stderr to a file and discovered the following issue:

[issue29335] subprocess module does not check WIFSTOPPED on SIGCHLD

Changes by Gregory P. Smith : -- title: Python 2.7 subprocess module does not check WIFSTOPPED on SIGCHLD -> subprocess module does not check WIFSTOPPED on SIGCHLD ___ Python tracker

[issue29335] Python 2.7 subprocess module does not check WIFSTOPPED on SIGCHLD

Changes by Gregory P. Smith : -- assignee: -> gregory.p.smith ___ Python tracker ___ ___

[issue29335] Python 2.7 subprocess module does not check WIFSTOPPED on SIGCHLD

Changes by Gregory P. Smith : -- versions: +Python 3.5, Python 3.6 ___ Python tracker ___

[issue29346] datetime.utcfromtimestamp() returns strange result for very large values

New submission from Eli Collins: I've found an odd behavior when passing very large values to ``datetime.datetime.utcfromtimestamp()`` and ``.fromtimestamp()`` under python 3.6. Under python 3.5, ``utcfromtimestamp(1<<40)`` would throw a ValueError that the year was out of range. Under

[issue16270] urllib hangs when closing connection

Senthil Kumaran added the comment: The original problem here was retrieving files failed (hung) when it was tried via context-manager 1. For e.g after "reverting" the changes, if you use the original file without the context manager, it will succeed. fobj = urllib.request.urlopen( url )

[issue29345] More lost updates with multiprocessing.Value and .Array

Eryk Sun added the comment: Change the last print to test the exit code, as follows: if p.exitcode != 0: print('Child failed with exit code:', p.exitcode) else: print(num.value) print(arr[:]) Note that when you fail to limit creating a new process to just the

[issue29083] Readd PyArg_VaParse to the stable API

Serhiy Storchaka added the comment: There are also issues with PyArg_ValidateKeywordArguments(), PyArg_UnpackTuple() and Py_BuildValue(). Their declarations are not available if define PY_SSIZE_T_CLEAN and Py_LIMITED_API < 3.3. But they were available in Python 3.2. Proposed patch fixes

[issue29345] More lost updates with multiprocessing.Value and .Array

Davin Potts added the comment: I'm having difficulty watching your video attachment. Would it be possible to instead describe, preferably with example code that others can similarly try to reproduce the behavior, what you're experiencing? Please keep in mind what the documentation repeatedly

[issue29336] merge tuples in module

Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file46382/merge-constants.patch ___ Python tracker ___

[issue29336] merge tuples in module

Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file46371/merge-constants.patch ___ Python tracker ___

[issue27973] urllib.urlretrieve() fails on second ftp transfer

Senthil Kumaran added the comment: I spent time digging for a proper fix for this issue. I've come to a conclusion that this commit, https://hg.python.org/cpython/rev/44d02a5d59fb (10 May 2016) in 2.7.12, was a mistake and needs to be reverted. The reason this change was made was apparently,

[issue29345] More lost updates with multiprocessing.Value and .Array

New submission from Just a Person: Lately, I have been having trouble using the multiprocessing library's shared memory on Windows. Often, updating the .value property seems to fail for no reason. As shown in the attached video, changing ```if __name__ == '__main__':``` in the sample code

[issue29084] C API of OrderedDict

Serhiy Storchaka added the comment: Eric, what are your thoughts? -- ___ Python tracker ___ ___

[issue29058] Mark new limited C API

Serhiy Storchaka added the comment: Do you suggest to emit a warning when the user just defines Py_LIMITED_API without specifying concrete version? #define Py_LIMITED_API I think this would break too much code. And contradicts to the documentation. If you mean something different, could

[issue25658] PyThread assumes pthread_key_t is an integer, which is against POSIX

Masayuki Yamamoto added the comment: Above said, I updated minor changes to the version 2 patch. Several codes have kept the words "thread local" and "TLS" because they have pointed programming method or other meanings, not CPython TLS API itself. (e.g. _decimal module) -- Added

[issue29344] sock_recv not detected a coroutine

New submission from Jeremy Bustamante: Documemtation says sock_recv is a coroutine https://docs.python.org/3.6/library/asyncio-eventloop.html#low-level-socket-operations But following code says it isnt: import asyncio loop = asyncio.get_event_loop() asyncio.iscoroutinefunction(loop.sock_recv)

[issue29343] sock.close() raises OSError EBADF when socket's fd is closed

Martin Panter added the comment: I added this behaviour in 3.6 on purpose via Issue 26685. The change also impacted Yury (see the original bug thread), but if I understood correctly, he eventually decided that it highlighted a problem in asyncio or his code (though the resulting asyncio pull

[issue29343] sock.close() raises OSError EBADF when socket's fd is closed

Antoine Pitrou added the comment: Closing a socket whose fd has already been closed before is a bug waiting to happen. Indeed it feels harmless if you just get a EBADF, but if the given fd gets reused in the meantime for another file or socket, your close() method is going to close a

[issue28876] bool of large range raises OverflowError

Akira Li added the comment: Following the python-dev discussion [1] I've added a variant of the patch that uses c99 designated initializers [2] [1] https://mail.python.org/pipermail/python-dev/2017-January/147175.html [2] https://gcc.gnu.org/onlinedocs/gcc/Designated-Inits.html --

[issue28999] Use Py_RETURN_NONE and like

Serhiy Storchaka added the comment: That is why I haven't pushed the patch. Thanks you for your LGTMs Victor and Inada, but this is not enough. In general I think that it is better to use Py_RETURN_NONE than "Py_INCREF(Py_None); return Py_None;". Some replacements already was done in the

[issue29284] Include thread_name_prefix in the concurrent.futures.ThreadPoolExecutor example 17.4.2.1

John Taylor added the comment: I have updated the Python 3.6 example for 17.4.2.1. ThreadPoolExecutor Example. Please see the attachment. On my system this is the output: thread name: loader_0 thread name: loader_1 thread name: loader_2 thread name: loader_3 thread name: loader_4

[issue28999] Use Py_RETURN_NONE and like

INADA Naoki added the comment: While patch looks safe, some developer may dislike such a large patch without fixing real issue. Anyway, Coccinelle seems very interesting tool for refactoring. -- ___ Python tracker

[issue29343] sock.close() raises OSError EBADF when socket's fd is closed

New submission from Christian Heimes: In Python 3.6 the behavior of socket's close method has changed. In Python 2.7, 3.5 and earlier, socket.close() ignored EBADF. Starting with Python 3.6 socket.close() raises an OSError exception when its internal fd has been closed. Python 2.7.12

[issue29342] os.posix_fadvise misreports errors

Marian Beermann added the comment: Indeed, os.posix_fadvise tries to fetch the error from errno, via posix_error() static PyObject * os_posix_fadvise_impl(PyObject *module, int fd, Py_off_t offset, Py_off_t length, int advice) /*[clinic end generated code:

[issue29342] os.posix_fadvise misreports errors

New submission from Marian Beermann: It has been observed that posix_fadvise will not report the original error if the syscall fails. Eg. https://bugs.alpinelinux.org/issues/6592 >>> os.posix_fadvise(-1, 0, 0, os.POSIX_FADV_DONTNEED) Traceback (most recent call last): File "", line 1, in

[issue28180] sys.getfilesystemencoding() should default to utf-8

Xavier de Gaye added the comment: > On Android, setlocale(CATEGORY, "") does not look for the locale environment > variables (LANG, ...) but sets the 'C' locale instead FWIW the source code of setlocale() on bionic (Android libc) is at

[issue28663] Higher virtual memory usage on recent Linux versions

ProgVal added the comment: > On Linux 3.16? 4.7? What is difference between 3.16 and 4.7? On 4.8 (which has the same issue as 4.7). The difference is that on 4.7, the rlimit has to be set incredibly high for the child process not to hit the limit. > Again, I doubt Python's memory consumption

[issue28663] Higher virtual memory usage on recent Linux versions

INADA Naoki added the comment: On Linux 3.16? 4.7? What is difference between 3.16 and 4.7? Again, I doubt Python's memory consumption increased by Linux version. Isn't rlimit more strict for now? Even if memory usage is really grow, I don't think it's a Python's issue. Maybe, environment

[issue16899] Add support for C99 complex type (_Complex) as ctypes.c_complex

Mark Dickinson added the comment: Thanks, Tom. Re-opening. -- resolution: postponed -> status: closed -> open ___ Python tracker ___

[issue28663] Higher virtual memory usage on recent Linux versions

ProgVal added the comment: first command: (0, 0) 0.14user 0.01system 0:00.94elapsed 16%CPU (0avgtext+0avgdata 18484maxresident)k 560inputs+0outputs (0major+2702minor)pagefaults 0swaps second command: (6663744, 6732519) 0.18user 0.01system 0:00.96elapsed 20%CPU (0avgtext+0avgdata