date:20170331

Dominic Mayers added the comment: I am a bit ashamed that I missed that. Still, the intent in the current code, the name of the parameter, the examples, etc. is that we pass the handler class. This is more than its __init__ function and less than a generic factory method. An important

[issue29763] test_site failing on AppVeyor

2017-03-31 Thread Zachary Ware

Changes by Zachary Ware : -- pull_requests: +1123 ___ Python tracker ___ ___

[issue29957] unnecessary LBYL for key contained in defaultdict, lib2to3/btm_matcher

2017-03-31 Thread Mariatta Wijaya

Changes by Mariatta Wijaya : -- stage: -> patch review versions: +Python 3.7 ___ Python tracker ___

[issue29957] unnecessary LBYL for key contained in defaultdict, lib2to3/btm_matcher

2017-03-31 Thread Mariatta Wijaya

Mariatta Wijaya added the comment: Thanks for the PR Michael :) It may take one US business day for the CLA to be received. Then a core dev has to manually update the label in GitHub. -- ___ Python tracker

[issue29763] test_site failing on AppVeyor

2017-03-31 Thread Zachary Ware

Zachary Ware added the comment: New changeset b94d7fd4efa877d649cea9c8125c8869ffe0c32d by Zachary Ware in branch 'master': bpo-29763: Use unittest cleanup in test_site (GH-841) https://github.com/python/cpython/commit/b94d7fd4efa877d649cea9c8125c8869ffe0c32d --

[issue29957] unnecessary LBYL for key contained in defaultdict, lib2to3/btm_matcher

2017-03-31 Thread Michael Selik

Michael Selik added the comment: PR submitted. I also signed the contributor agreement, but the bot doesn't seem to have noticed. -- ___ Python tracker

[issue29957] unnecessary LBYL for key contained in defaultdict, lib2to3/btm_matcher

2017-03-31 Thread Roundup Robot

Changes by Roundup Robot : -- pull_requests: +1121 ___ Python tracker ___

[issue29955] logging decimal point should come from locale

2017-03-31 Thread Xiang Zhang

Xiang Zhang added the comment: Although I prefer period but such a change could break backwards compatibility so I don't know it's worth or not. Codes like `datetime.strptime('1993-04-21 08:03:00,123', '%Y-%m-%d %H:%M:%S,%f')` (usually for such a simple parse goal I like to use the builtin

[issue23033] Disallow support for a.example.net, a.example.net, and a*b.example.net in certificate wildcard handling.

2017-03-31 Thread Mandeep Singh

Changes by Mandeep Singh : -- pull_requests: +1120 ___ Python tracker ___ ___

[issue29957] unnecessary LBYL for key contained in defaultdict, lib2to3/btm_matcher

2017-03-31 Thread Michael Selik

Michael Selik added the comment: I'll submit a pull request momentarily. -- ___ Python tracker ___ ___

[issue29957] unnecessary LBYL for key contained in defaultdict, lib2to3/btm_matcher

2017-03-31 Thread Raymond Hettinger

Raymond Hettinger added the comment: Nice catch. You've got sharp eyes. Do you want to submit a pull request or have another dev work on it? -- nosy: +Mariatta, rhettinger ___ Python tracker

[issue29957] unnecessary LBYL for key contained in defaultdict, lib2to3/btm_matcher

2017-03-31 Thread Michael Selik

New submission from Michael Selik: Minor, but it looks like someone decided to use a defaultdict but forgot to remove the checks for whether a key exists. Creating a defaultdict(list):

[issue29955] logging decimal point should come from locale

2017-03-31 Thread Raymond Hettinger

Raymond Hettinger added the comment: +1 for changing this to a period. Every time I see the comma, it seems odd to me. It also is harder to parse back into a regular float. In addition, it is hazard when people use commas and delimiters between the fields in a log file. -- nosy:

[issue28629] Emit ResourceWarning when implicitly terminating a suspended frame?

2017-03-31 Thread Nathaniel Smith

Nathaniel Smith added the comment: It does make sense to skip emitting a warning if there's no try or with block active. Don't we already have the ability to check for this, though, without any extensions to the frame or code objects? That's what the public PyGen_NeedsFinalizing does, right?

[issue29947] In SocketServer, why not passing a factory instance for the RequestHandlerClass instead of the class itself?

2017-03-31 Thread R. David Murray

R. David Murray added the comment: I think I'm missing something here. What prevents one from passing a factory function as the RequestHandlerClass argument? In Python, a class name *is* a factory function for class instances. -- nosy: +r.david.murray

[issue29954] multiprocessing.Pool.exit() calls terminate() instead of close()

2017-03-31 Thread Josh Rosenberg

Josh Rosenberg added the comment: I suspect it's far too late to change this, given compatibility constraints. If you want it to close instead of terminate, contextlib.closing is always an option. -- nosy: +josh.r ___ Python tracker

[issue29952] "keys and values" preferred to "keys and elements" for dict constituent

2017-03-31 Thread Terry J. Reedy

Changes by Terry J. Reedy : -- title: "keys and values" is preferred to "keys and elements" for name of dict constituent -> "keys and values" preferred to "keys and elements" for dict constituent ___ Python tracker

[issue29944] Argumentless super() fails in classes constructed with type()

2017-03-31 Thread Terry J. Reedy

Changes by Terry J. Reedy : -- title: Argumentless super() calls do not work in classes constructed with type() -> Argumentless super() fails in classes constructed with type() ___ Python tracker

[issue28596] on Android _bootlocale on startup relies on too many library modules

2017-03-31 Thread admin

Changes by admin : -- pull_requests: -1113 ___ Python tracker ___

[issue28596] on Android _bootlocale on startup relies on too many library modules

2017-03-31 Thread Ezio Melotti

Changes by Ezio Melotti : -- pull_requests: +1113 ___ Python tracker ___ ___

[issue28157] Document time module constants (timezone, tzname, etc.) as deprecated.

2017-03-31 Thread STINNER Victor

STINNER Victor added the comment: IMHO it's worth it to have a dedicated section for CLOCK_xxx constants. It would allow to mention which functions use them. -- ___ Python tracker

[issue28596] on Android _bootlocale on startup relies on too many library modules

2017-03-31 Thread Ezio Melotti

Changes by Ezio Melotti : -- pull_requests: -1113 ___ Python tracker ___ ___

[issue29595] Expose max_queue_size in ThreadPoolExecutor

2017-03-31 Thread Raymond Hettinger

Raymond Hettinger added the comment: Prayslayer, please don't shove. Your PR request was responded to by Mariatta so it wasn't ignored. Making decisions about API expansions takes a while (making sure it fits the intended use, that it isn't a bug factory itself, that it is broadly useful,

[issue29949] sizeof set after set_merge() is doubled from 3.5

2017-03-31 Thread Cameron Simpson

Changes by Cameron Simpson : -- nosy: +cameron ___ Python tracker ___ ___ Python-bugs-list

[issue28596] on Android _bootlocale on startup relies on too many library modules

2017-03-31 Thread Ezio Melotti

Changes by Ezio Melotti : -- nosy: +ezio.melotti ___ Python tracker ___ ___

[issue29956] math.exp documentation is misleading

2017-03-31 Thread Raymond Hettinger

Raymond Hettinger added the comment: I suggest changing the main docs to match the existing docstring, "Return e raised to the power of x." The exp() function is a thin wrapper around the C math library and where it is documented as "compute e (the base of natural logarithms) raised to the

[issue28157] Document time module constants (timezone, tzname, etc.) as deprecated.

2017-03-31 Thread Alexander Belopolsky

Alexander Belopolsky added the comment: A question for Victor: Should we split the "Constants" section into "Clock ID constants" and "Timezone constants"? (See PR 928.) -- ___ Python tracker

[issue28157] Document time module constants (timezone, tzname, etc.) as deprecated.

2017-03-31 Thread Alexander Belopolsky

Alexander Belopolsky added the comment: The time and math modules are probably the oldest Python modules, but math have seen more development recently, so it should serve as a good model for how things should be organized. Yes, I believe re-listing module functions and constants in the

[issue25464] Tix HList header_exists should be "exist"

2017-03-31 Thread Terry J. Reedy

Changes by Terry J. Reedy : -- pull_requests: -833 ___ Python tracker ___ ___

[issue28157] Document time module constants (timezone, tzname, etc.) as deprecated.

2017-03-31 Thread Cheryl Sabella

Cheryl Sabella added the comment: We were discussing changing the docstring on the pull request and I had additional questions, so I am moving them here for discussion: I've been looking at pydoc math and pydoc time (and the the module.c source). Before I go down the wrong path, I'm not sure

[issue29595] Expose max_queue_size in ThreadPoolExecutor

2017-03-31 Thread Mariatta Wijaya

Changes by Mariatta Wijaya : -- stage: -> patch review ___ Python tracker ___ ___

[issue29955] logging decimal point should come from locale

2017-03-31 Thread Skip Montanaro

Skip Montanaro added the comment: One example demonstrating that the datetime module at least prefers a decimal point: >>> import dateutil.parser >>> t = '1993-04-21 08:03:00,123' >>> dateutil.parser.parse(t) datetime.datetime(1993, 4, 21, 8, 3, 0, 123000) >>>

[issue29725] sqlite3.Cursor doesn't properly document "arraysize"

2017-03-31 Thread Berker Peksag

Berker Peksag added the comment: > There is another attribute called row_factory in the cursor structure > that isn't in the docs. There is a row_factory defined in the docs, > but that one is for the connection structure. Should it be added under > cursor as well? Thank you for working on

[issue29955] logging decimal point should come from locale

2017-03-31 Thread Skip Montanaro

Skip Montanaro added the comment: It's Vinay's code, so what he wants should carry the most weight. I did this as much as an exercise in figuring out the whole pull request/bug report process as anything. -- ___ Python tracker

[issue29941] Confusion between asserts and Py_DEBUG

2017-03-31 Thread Thomas Wouters

Changes by Thomas Wouters : -- pull_requests: +1119 ___ Python tracker ___ ___

[issue29941] Confusion between asserts and Py_DEBUG

2017-03-31 Thread Thomas Wouters

Changes by Thomas Wouters : -- pull_requests: +1118 ___ Python tracker ___ ___

[issue29956] math.exp documentation is misleading

2017-03-31 Thread Serhiy Storchaka

Serhiy Storchaka added the comment: *e*:sup:`x` ? I like this idea. -- ___ Python tracker ___ ___

[issue29956] math.exp documentation is misleading

2017-03-31 Thread Alexander Belopolsky

Alexander Belopolsky added the comment: > This is because math.e is not the same as e. Right. That's why I think it would be nice to distinguish math.e and the base of the natural logarithm typographically in the docs. Can we use sphinx math mode? If not, I would use italic for the

[issue29956] math.exp documentation is misleading

2017-03-31 Thread Serhiy Storchaka

Serhiy Storchaka added the comment: This is because math.e is not the same as e. -- nosy: +mark.dickinson, rhettinger, serhiy.storchaka, stutzbach, tim.peters ___ Python tracker

[issue29953] Memory leak in the replace() method of datetime and time objects

2017-03-31 Thread Serhiy Storchaka

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue29953] Memory leak in the replace() method of datetime and time objects

2017-03-31 Thread Serhiy Storchaka

Serhiy Storchaka added the comment: New changeset 7d5d13d8d003ae5b62bb8c9ef1d1f310eaabc506 by Serhiy Storchaka in branch '3.6': bpo-29953: Fix memory leaks in the replace() method of datetime and t… (#933) https://github.com/python/cpython/commit/7d5d13d8d003ae5b62bb8c9ef1d1f310eaabc506

[issue29956] math.exp documentation is misleading

2017-03-31 Thread Alexander Belopolsky

New submission from Alexander Belopolsky: The math.exp(x) function is documented to "Return e**x" . This is misleading because even in the simplest case, math.exp(x) is not the same as math.e ** x: >>> import math >>> math.exp(2) - math.e

[issue29922] error message when aexit is not async

2017-03-31 Thread Ivan Levkivskyi

Changes by Ivan Levkivskyi : -- nosy: +levkivskyi ___ Python tracker ___ ___

[issue29953] Memory leak in the replace() method of datetime and time objects

2017-03-31 Thread Serhiy Storchaka

Changes by Serhiy Storchaka : -- pull_requests: +1117 ___ Python tracker ___ ___

[issue29953] Memory leak in the replace() method of datetime and time objects

2017-03-31 Thread Serhiy Storchaka

Serhiy Storchaka added the comment: New changeset 314d6fca36a4eaa0541218431d14804fadec6488 by Serhiy Storchaka in branch 'master': bpo-29953: Fix memory leaks in the replace() method of datetime and time (#927) https://github.com/python/cpython/commit/314d6fca36a4eaa0541218431d14804fadec6488

[issue8232] webbrowser.open incomplete on Windows

2017-03-31 Thread Boštjan Mejak

Boštjan Mejak added the comment: I have Windows 10, 64-bit, and Python 3.6.1, 64-bit, and the code still does not work! >>> import webbrowser >>> webbrowser.get("chrome") Traceback (most recent call last): File "", line 1, in File "C:\Program Files\Python 3.6\lib\webbrowser.py", line 51,

[issue29949] sizeof set after set_merge() is doubled from 3.5

2017-03-31 Thread Raymond Hettinger

Raymond Hettinger added the comment: Do you want to prepare a PR for me? I not yet set-up with the ways of Github. Please limit the PR to just unwinding the refactoring in the simplest possible way.. If in the future you want to chat about speed/space trade-offs, we can do that offline.

[issue29955] logging decimal point should come from locale

2017-03-31 Thread Vinay Sajip

Vinay Sajip added the comment: It's not exactly a decimal point, more a "decimal mark" as per ISO 8601. From the Wikipedia article for the standard at "https://en.wikipedia.org/wiki/ISO_8601#Times - "However, a fraction may only be added to the lowest order time element in the

[issue29941] Confusion between asserts and Py_DEBUG

2017-03-31 Thread Zachary Ware

Zachary Ware added the comment: Buildbots are happy, thanks! -- ___ Python tracker ___ ___ Python-bugs-list

[issue29955] logging decimal point should come from locale

2017-03-31 Thread Roundup Robot

Changes by Roundup Robot : -- pull_requests: +1116 ___ Python tracker ___

[issue29951] PyArg_ParseTupleAndKeywords exception messages containing "function"

2017-03-31 Thread R. David Murray

R. David Murray added the comment: If you want to be completely unambiguous, you could say "keyword argument names". "keyword argument" appears to mean different things in different contexts; sometimes it means the name and the value together, sometimes one or the other. Usually which one

[issue8232] webbrowser.open incomplete on Windows

2017-03-31 Thread Mariatta Wijaya

Mariatta Wijaya added the comment: Steve, would you like to create a PR based on your patch here? Also, what versions should this be targeted to now? Thanks. -- nosy: +Mariatta ___ Python tracker

[issue29941] Confusion between asserts and Py_DEBUG

2017-03-31 Thread Thomas Wouters

Thomas Wouters added the comment: FYI, buildbot issues should be fixed by PR #930. -- ___ Python tracker ___

[issue29941] Confusion between asserts and Py_DEBUG

2017-03-31 Thread Thomas Wouters

Changes by Thomas Wouters : -- pull_requests: +1115 ___ Python tracker ___ ___

[issue29949] sizeof set after set_merge() is doubled from 3.5

2017-03-31 Thread INADA Naoki

INADA Naoki added the comment: I agree. Before thinking about rebalance between size and speed, resolving regression is important. -- ___ Python tracker

[issue24452] Make webbrowser support Chrome on Mac OS X

2017-03-31 Thread Mariatta Wijaya

Mariatta Wijaya added the comment: Hi Boštjan Mejak, this ticket addresses the change for MacOS. The windows support is in http://bugs.python.org/issue8232. Please raise the issue there. Thanks. -- ___ Python tracker

[issue29955] logging decimal point should come from locale

2017-03-31 Thread Skip Montanaro

New submission from Skip Montanaro: The logging module hard codes the decimal point for timestamps to be ",". It should use locale.localeconv()["decimal_point"] instead. -- components: Library (Lib) messages: 290927 nosy: skip.montanaro priority: normal severity: normal status: open

[issue29534] _decimal difference with _pydecimal

2017-03-31 Thread Stefan Krah

Stefan Krah added the comment: Does anyone know how to disable the spurious pull requests that keep coming in? -- ___ Python tracker ___

[issue24452] Make webbrowser support Chrome on Mac OS X

2017-03-31 Thread Guido van Rossum

Changes by Guido van Rossum : -- nosy: -gvanrossum ___ Python tracker ___ ___

[issue24452] Make webbrowser support Chrome on Mac OS X

2017-03-31 Thread Boštjan Mejak

Boštjan Mejak added the comment: I have Windows 10, 64-bit, and Python 3.6.1, 64-bit, and the code still does not work! >>> import webbrowser >>> webbrowser.get("chrome") Traceback (most recent call last): File "", line 1, in File "C:\Program Files\Python 3.6\lib\webbrowser.py", line 51,