[issue29947] In SocketServer, why not passing a factory instance for the RequestHandlerClass instead of the class itself?

Martin Panter added the comment: By “factory instance”, I presume you just mean a function (or class or method) that returns an appropriate object when called. (I think these are normally called “factory functions”. Instances are objects, the things that class constructors and factories

[issue29961] More compact sets and frozensets created from sets

Serhiy Storchaka added the comment: Okay. I was going to provide patches for other set's weirdness (for example a set can increase its size after removing elements), but with your reaction I see that this doesn't make sense. I wash my hands from fixing set. --

[issue29446] Improve tkinter 'import *' situation

Changes by Serhiy Storchaka : -- keywords: +easy stage: test needed -> needs patch versions: +Python 2.7, Python 3.5, Python 3.6 ___ Python tracker

[issue29961] More compact sets and frozensets created from sets

INADA Naoki added the comment: OK, sorry about bothering you. -- ___ Python tracker ___ ___ Python-bugs-list

[issue29961] More compact sets and frozensets created from sets

Raymond Hettinger added the comment: You guys seem to have an enormous about of spare time and seem to feel to need to redesign every single thing you see. Please slow down and allow me to breathe a bit. I cannot keep up with a new "let's change x" every single day. This set object has

[issue29961] More compact sets and frozensets created from sets

INADA Naoki added the comment: I also feel set created from iterator is too large sometimes. Especially, frozenset is used for "unordered tuple" dict key sometimes. $ python -c 'N = 6000; from sys import getsizeof; s = [getsizeof(frozenset(range(n))) for n in range(N)]; print( [(n, s[n]) for n

[issue29941] Confusion between asserts and Py_DEBUG

Thomas Wouters added the comment: New changeset 553275d125478a6563dde7523f4f28c92f1861b4 by T. Wouters in branch '3.5': bpo-29941: Assert fixes (#886) (#956) https://github.com/python/cpython/commit/553275d125478a6563dde7523f4f28c92f1861b4 -- ___

[issue29751] PyLong_FromString documentation wrong on numbers with leading zero and base=0

Martin Panter added the comment: Underscores are only applicable to 3.6+, but the original concern about leading zeros applies to 3.5. On Git Hub I suggested dropping the details and just referring to the Lexical Analysis section

[issue29941] Confusion between asserts and Py_DEBUG

Thomas Wouters added the comment: New changeset 90e3518225bafaff01469ed48c472ae7db5686f0 by T. Wouters in branch '3.6': bpo-29941: Assert fixes (#886) (#955) https://github.com/python/cpython/commit/90e3518225bafaff01469ed48c472ae7db5686f0 -- ___

[issue26947] Hashable documentation improvement needed

Senthil Kumaran added the comment: I have to admit, I did not see some of the negative votes in this ticket before merging the patch. If your is opposition is strong, please comment and suggest a better improvement over the patch. thank you! --

[issue26947] Hashable documentation improvement needed

Senthil Kumaran added the comment: I reviewed in the pull request. I agree that the wording was slightly better than the original. -- ___ Python tracker

[issue5906] Risk of confusion in multiprocessing module - daemonic processes

Tim Peters added the comment: Again, I don't care about orphans. In the usual cases people are running code with no concern about what happens in case of forced termination. The only thing stopping it now is that the code goes out of its way to prevent it (or, alternatively, goes out of its

[issue26947] Hashable documentation improvement needed

Changes by Senthil Kumaran : -- resolution: -> fixed stage: -> resolved status: open -> closed type: -> behavior ___ Python tracker

[issue26947] Hashable documentation improvement needed

Senthil Kumaran added the comment: New changeset a71a3ad54d14483cfaebd8e0fb96c97c798d9e32 by Senthil Kumaran in branch '3.6': bpo-26947: DOC: clarify wording on hashable in glossary (#948) (#957) https://github.com/python/cpython/commit/a71a3ad54d14483cfaebd8e0fb96c97c798d9e32 --

[issue26947] Hashable documentation improvement needed

Senthil Kumaran added the comment: New changeset 51fc7e3d6a29de7b3142e51f8caf4d31f7ac72a0 by Senthil Kumaran in branch '3.5': bpo-26947: DOC: clarify wording on hashable in glossary (#948) (#958) https://github.com/python/cpython/commit/51fc7e3d6a29de7b3142e51f8caf4d31f7ac72a0 --

[issue26947] Hashable documentation improvement needed

Changes by Senthil Kumaran : -- pull_requests: +1140 ___ Python tracker ___ ___

[issue26947] Hashable documentation improvement needed

Changes by Senthil Kumaran : -- pull_requests: +1139 ___ Python tracker ___ ___

[issue26947] Hashable documentation improvement needed

Senthil Kumaran added the comment: New changeset 64c887ab3a400cf91bde4f0c5ef69eacc88bc5e1 by Senthil Kumaran (csabella) in branch 'master': bpo-26947: DOC: clarify wording on hashable in glossary (#948) https://github.com/python/cpython/commit/64c887ab3a400cf91bde4f0c5ef69eacc88bc5e1

[issue5906] Risk of confusion in multiprocessing module - daemonic processes

Eryk Sun added the comment: > e.g., a Pool worker dies with an assert(!) error if it tries to create > its own Pool for something A daemon process could create a child daemon when the OS can ensure that no orphans are left behind (e.g. call Linux prctl to set PR_SET_PDEATHSIG as SIGKILL).

[issue5906] Risk of confusion in multiprocessing module - daemonic processes

Tim Peters added the comment: @Eryk, not me ;-) I find the "daemonic or not?" distinction useless for processes - it just gets in the way at times (e.g., a Pool worker dies with an assert(!) error if it tries to create its own Pool for something). I don't care about orphans either. It's one

[issue5906] Risk of confusion in multiprocessing module - daemonic processes

Eryk Sun added the comment: > I've personally found this `multiprocessing` restriction (daemonic > processes can't have children) to be nothing but a pain in the ass To make that reliable on Windows you could create a silent-breakaway, kill-on-close Job object in each process for its daemon

[issue29941] Confusion between asserts and Py_DEBUG

Changes by Thomas Wouters : -- pull_requests: +1138 ___ Python tracker ___ ___

[issue29941] Confusion between asserts and Py_DEBUG

Changes by Thomas Wouters : -- pull_requests: +1137 ___ Python tracker ___ ___

[issue26947] Hashable documentation improvement needed

Martin Panter added the comment: The pull request currently suggests “All of Python’s immutable built-in objects are hashable; mutable containers (such as lists or dictionaries) are not.” This seems better wording than the original. FWIW, I would have tried “Python’s built-in immutable

[issue29947] In SocketServer, why not passing a factory instance for the RequestHandlerClass instead of the class itself?

Dominic Mayers added the comment: Oops, I did not realize that David was one of the developers. Well, may be this needs the attention of more than one developer. -- ___ Python tracker

[issue29947] In SocketServer, why not passing a factory instance for the RequestHandlerClass instead of the class itself?

Dominic Mayers added the comment: The reason why I feel we should not make it immediately a documentation issue is that I don't know how a person working on documentation could proceed ahead without a clear go ahead signal from developers. In that sense, having a documentation that says that

[issue29763] test_site failing on AppVeyor

Changes by Zachary Ware : -- pull_requests: +1136 ___ Python tracker ___ ___

[issue29960] _random.Random state corrupted on exception

Changes by Bryan G. Olson : -- pull_requests: +1135 ___ Python tracker ___ ___

[issue29947] In SocketServer, why not passing a factory instance for the RequestHandlerClass instead of the class itself?

R. David Murray added the comment: Given how old socket server is, and that it doesn't actually require that API, we should probably just reword the documentation so that it is clear that RequestHandlerClass is the default Handler implementation (and that you can work with setup/handle/finish

[issue29162] pyshell.py: name 'sys' is not defined

Terry J. Reedy added the comment: The follow-up tkinter import issue is #29446 -- ___ Python tracker ___ ___

[issue29947] In SocketServer, why not passing a factory instance for the RequestHandlerClass instead of the class itself?

R. David Murray added the comment: Well, we could document it as a factory argument, and explain that the argument name is an historical artifact. -- ___ Python tracker

[issue29339] Interactive: Move to same indentation level as previousline

Changes by Terry J. Reedy : -- resolution: -> rejected stage: needs patch -> resolved status: open -> closed ___ Python tracker ___

[issue28157] Document time module constants (timezone, tzname, etc.) as deprecated.

Changes by Cheryl Sabella : -- pull_requests: +1134 ___ Python tracker ___ ___

[issue5906] Risk of confusion in multiprocessing module - daemonic processes

Tim Peters added the comment: I'll take a crack at these ancient comments ;-) """ daemon The process’s daemon flag, a Boolean value. This must be set before start() is called. The initial value is inherited from the creating process. [1] When a process exits, it attempts to

[issue28157] Document time module constants (timezone, tzname, etc.) as deprecated.

Changes by Alexander Belopolsky : -- keywords: -3.2regression ___ Python tracker ___

[issue28157] Document time module constants (timezone, tzname, etc.) as deprecated.

Alexander Belopolsky added the comment: > The datetime module .. Yes, the datetime module documentation can be improved, but let's keep this issue focused on the time module. Please open a new issue for the datetime module improvements. -- ___

[issue28157] Document time module constants (timezone, tzname, etc.) as deprecated.

Alexander Belopolsky added the comment: Cheryl, There is no need to apologize. I assigned this issue to myself when I created it because I had a few ideas about refactoring the time module documentation and thought I would get to it soon. As often happens other priorities interfered.

[issue29957] unnecessary LBYL for key contained in defaultdict, lib2to3/btm_matcher

Michael Selik added the comment: Ok, I'll change the PR. -- ___ Python tracker ___ ___ Python-bugs-list

[issue29961] More compact sets and frozensets created from sets

Serhiy Storchaka added the comment: There is a program that uses 32 GB for sets. The patch could save up to 6 GB for it. I understood your arguments when you lowered the maximal fill ration from 2/3 to 60%. But in that case the fill ratio is between 15% and 30%! Isn't it too small?

[issue29947] In SocketServer, why not passing a factory instance for the RequestHandlerClass instead of the class itself?

Dominic Mayers added the comment: To sum up, David clarified that we can in fact easily pass an arbitrary factory method that creates and starts a request handler, instead of a request handler class with setup, handle and finish in its API. This could indeed be a valid reason to consider this

[issue29897] itertools.chain behaves strangly when copied with copy.copy

Raymond Hettinger added the comment: Serhiy, feel free to take this in whatever direction you think is best. -- assignee: -> serhiy.storchaka ___ Python tracker

[issue23033] Disallow support for a*.example.net, *a.example.net, and a*b.example.net in certificate wildcard handling.

Raymond Hettinger added the comment: +1 -- nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list

[issue29957] unnecessary LBYL for key contained in defaultdict, lib2to3/btm_matcher

Raymond Hettinger added the comment: Rather than removing the defaultdict, I think a cleaner fix is to just remove the unnecessary LBYL. That leaves the code a little more compact, faster, and nice looking. -- ___ Python tracker

[issue29961] More compact sets and frozensets created from sets

Raymond Hettinger added the comment: FWIW, I've long considered this to be a feature of set and dicts, it is the only way a user can affect sparseness. For lookup only sets, the extra sparseness is a virtue (fewer collisions). So, I would like to leave the current code in-place. With

[issue29960] _random.Random state corrupted on exception

Changes by Raymond Hettinger : -- assignee: -> rhettinger ___ Python tracker ___

[issue29962] Add math.remainder operation

Raymond Hettinger added the comment: > I'd prefer to keep the name that's consistent with both C and IEEE 754. +1 Also, the decimal module names are a poor guide. Its usability has been impaired by opaque naming (i.e. needing to use quantize() when you want to round to a fixed number of

[issue29962] Add math.remainder operation

Mark Dickinson added the comment: FTR, I don't have strong opinions on the name: I could be persuaded by any of `remainder`, `remainder_near` or `ieee_remainder`. I find `ieee_remainder` somewhat more informative than `remainder_near`. -- ___

[issue29962] Add math.remainder operation

Mark Dickinson added the comment: > In many cases the function that returns the nearest integer quotient is > useful. Agreed, but I'd like to keep the scope of this issue small for now: we're simply wrapping / implementing another C99 math.h function. --

[issue29962] Add math.remainder operation

Mark Dickinson added the comment: > Shouldn't the new function be named math.remainder_near? Not clear. :-) I'd prefer to keep the name that's consistent with both C and IEEE 754. (We already have plenty of naming differences between Decimal and math; attempting to reconcile them is likely

[issue29962] Add math.remainder operation

Serhiy Storchaka added the comment: See also Decimal.remainder_near and _PyLong_DivmodNear. Shouldn't the new function be named math.remainder_near? In many cases the function that returns the nearest integer quotient is useful. See Fraction.__round__, datetime._divide_and_round,

[issue29956] math.exp documentation is misleading

Mark Dickinson added the comment: PR made. New wording is: """ Return e raised to the power *x*, where e = 2.718281... is the base of natural logarithms. """ -- ___ Python tracker

[issue29956] math.exp documentation is misleading

Changes by Mark Dickinson : -- pull_requests: +1133 ___ Python tracker ___ ___

[issue29962] Add math.remainder operation

Changes by Mark Dickinson : -- pull_requests: +1132 ___ Python tracker ___ ___

[issue29962] Add math.remainder operation

New submission from Mark Dickinson: IEEE 754, the C99 standard, the Decimal IBM standard and Java all support/specify a 'remainder-near' operation. Apart from being standard, this has a number of useful applications: 1. Argument reduction in numerical algorithms: it's common to want to reduce

[issue29949] sizeof set after set_merge() is doubled from 3.5

INADA Naoki added the comment: New changeset efde51ad54c58353f25ff80c8d30dbee82ef33a3 by INADA Naoki in branch '3.6': bpo-29949: Fix set memory usage regression (GH-945) https://github.com/python/cpython/commit/efde51ad54c58353f25ff80c8d30dbee82ef33a3 --

[issue29692] contextlib.contextmanager may incorrectly unchain RuntimeError

Changes by svelankar : -- pull_requests: +1131 ___ Python tracker ___ ___

[issue26947] Documentation improvement needed

Changes by Cheryl Sabella : -- pull_requests: +1130 ___ Python tracker ___ ___

[issue28157] Document time module constants (timezone, tzname, etc.) as deprecated.

Cheryl Sabella added the comment: I think I may need to apologize. I'm new to this and was looking through the open docs issues and saw this one. Just now, I noticed that the 'assigned to' was filled in. I had only been looking at tickets that didn't have a pull request and not looking at

[issue29725] sqlite3.Cursor doesn't properly document "arraysize"

Cheryl Sabella added the comment: Thank you so much for being patient with me and explaining that. -- ___ Python tracker ___

[issue29725] sqlite3.Cursor doesn't properly document "arraysize"

Changes by Cheryl Sabella : -- pull_requests: +1129 ___ Python tracker ___ ___

[issue29751] PyLong_FromString documentation wrong on numbers with leading zero and base=0

Cheryl Sabella added the comment: Thank you. I've added that change. For the backporting, I think that would only be applicable to 3.6 and 3.7? -- ___ Python tracker

[issue29960] _random.Random state corrupted on exception

Changes by Serhiy Storchaka : -- nosy: +mark.dickinson, rhettinger stage: -> needs patch ___ Python tracker ___

[issue29961] More compact sets and frozensets created from sets

Changes by Serhiy Storchaka : -- pull_requests: +1128 ___ Python tracker ___ ___

[issue29949] sizeof set after set_merge() is doubled from 3.5

Changes by INADA Naoki : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___

[issue29961] More compact sets and frozensets created from sets

New submission from Serhiy Storchaka: For now new set and frozenset objects can allocate 2 times larger table than necessary when are created from set or dict. For example if the size n of the original set is the power of two, resulting set will allocate the table of 4*n rather that 2*n. Up

[issue29956] math.exp documentation is misleading

Mark Dickinson added the comment: > I suggest changing the main docs to match the existing docstring, "Return e > raised to the power of x." +1 for this description. -- ___ Python tracker

[issue29960] _random.Random state corrupted on exception

Bryan G. Olson added the comment: I'm going through https://docs.python.org/devguide/pullrequest.html and would like to be assigned this issue. -- ___ Python tracker

[issue29960] _random.Random state corrupted on exception

New submission from Bryan G. Olson: Demo: Run the Python library's test_random.py under the Python debugger and check the generator at the start of test_shuffle(): C:\bin\Python36>python -m pdb Lib\test\test_random.py > c:\bin\python36\lib\test\test_random.py(1)() -> import unittest (Pdb)

[issue29947] In SocketServer, why not passing a factory instance for the RequestHandlerClass instead of the class itself?

Dominic Mayers added the comment: Perhaps I should raise a separate issue, but it is related, because the current code "requires" that we define an handler class with `setup()`, `handle()` and `finish()` in its API. If you look at the actual code, there is no such requirement. We only have to

[issue28157] Document time module constants (timezone, tzname, etc.) as deprecated.

Cheryl Sabella added the comment: Also, back to the original title of saying timezone, altzone, etc are deprecated - there are examples in the datetime docs that use those constants. Should that be updated to tm_zone and tm_gmtoff? -- ___ Python

[issue28157] Document time module constants (timezone, tzname, etc.) as deprecated.

Cheryl Sabella added the comment: The datetime module has a separate section for strptime and strftime. Any interest in splitting those functions into their own section? -- ___ Python tracker

[issue29782] Use __builtin_clzl for bits_in_digit if available

Antoine Pitrou added the comment: I don't think a 3% improvement on a micro-benchmark is worth it (this will translate into 0% improvement on real-world workloads). Are there other uses of _Py_bit_length() that show bigger benefits? -- nosy: +pitrou

[issue29954] multiprocessing.Pool.__exit__() calls terminate() instead of close()

Antoine Pitrou added the comment: I agree it's far too late. Multiple existing libraries may rely on the current behaviour. -- nosy: +pitrou resolution: -> wont fix stage: -> resolved status: open -> closed ___ Python tracker

[issue29943] PySlice_GetIndicesEx change broke ABI in 3.5 and 3.6 branches

Changes by Miro Hrončok : -- nosy: +hroncok ___ Python tracker ___ ___ Python-bugs-list

[issue29955] logging decimal point should come from locale

Vinay Sajip added the comment: I would prefer to keep things as they are - which is conforming to the preferences expressed in ISO 8601, and preserving backwards compatibility. I agree that a period has some advantages, but I went with what the standard said as closely as I could. I'm not

[issue29949] sizeof set after set_merge() is doubled from 3.5

Changes by INADA Naoki : -- pull_requests: +1127 ___ Python tracker ___ ___

[issue29949] sizeof set after set_merge() is doubled from 3.5

INADA Naoki added the comment: New changeset e82cf8675bacd7a03de508ed11865fc2701dcef5 by INADA Naoki in branch 'master': bpo-29949: Fix set memory usage regression (GH-943) https://github.com/python/cpython/commit/e82cf8675bacd7a03de508ed11865fc2701dcef5 --

[issue29959] re.match failed to match left square brackets as the first char

Serhiy Storchaka added the comment: re.match() checks if the beginning of the string matches the regular expression pattern. Use re.search() if you want to find the match not at the beginning of the string. https://docs.python.org/3/library/re.html#re.match

[issue29959] re.match failed to match left square brackets as the first char

New submission from bo qu: if "[" is the first char in a string, then re.match can't match any pattern from the string, but re.findall works fine details as follows: [da@namenode log]$ python3 Python 3.4.3 (default, Jun 14 2015, 14:23:40) [GCC 4.4.7 20120313 (Red Hat 4.4.7-11)] on linux Type

[issue28115] Use argparse for the zipfile module

Serhiy Storchaka added the comment: Opened issue29958 for the latter patch. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue29958] Use add_mutually_exclusive_group(required=True) in zipfile and tarfile CLI

Changes by Serhiy Storchaka : -- pull_requests: +1126 ___ Python tracker ___ ___

[issue29949] sizeof set after set_merge() is doubled from 3.5

Changes by INADA Naoki : -- pull_requests: +1125 ___ Python tracker ___ ___

[issue29958] Use add_mutually_exclusive_group(required=True) in zipfile and tarfile CLI

New submission from Serhiy Storchaka: In the comment to the patch on issue28115 SilentGhost suggested to pass required=True to add_mutually_exclusive_group(). This makes the last "else" not needed. Proposed patch implements this idea for zipfile and tarfile. It also improves error handling

[issue29763] test_site failing on AppVeyor

Zachary Ware added the comment: New changeset cd815edf012dc6dd20dfeef91951270e96607616 by Zachary Ware in branch 'master': Revert "bpo-29763: Use unittest cleanup in test_site (GH-841)" (GH-942) https://github.com/python/cpython/commit/cd815edf012dc6dd20dfeef91951270e96607616 --

[issue27867] various issues due to misuse of PySlice_GetIndicesEx

Changes by Martin Panter : -- nosy: -martin.panter ___ Python tracker ___ ___

[issue28556] typing.py upgrades

Changes by Martin Panter : -- nosy: -martin.panter ___ Python tracker ___ ___

[issue27100] Attempting to use class with both __enter__ & __exit__ undefined yields __exit__ attribute error

Changes by Martin Panter : -- nosy: -martin.panter ___ Python tracker ___ ___

[issue29931] ipaddress.ip_interface __lt__ check seems to be broken

Serhiy Storchaka added the comment: New changeset 7bd8d3e794782582a4ad1c9749424fff86802c3e by Serhiy Storchaka (s-sanjay) in branch 'master': bpo-29931 fix __lt__ check in ipaddress.ip_interface for both v4 and v6. (#879)