[issue32002] test_c_locale_coercion fails when the default LC_CTYPE != "C"

Nick Coghlan added the comment: Note: I'm not entirely sold on my own argument though, as I believe at least Alpine Linux already interprets the empty locale as C.UTF-8, so it may make more sense to use your dynamic check with both the empty string and "POSIX", and only

[issue32002] test_c_locale_coercion fails when the default LC_CTYPE != "C"

Nick Coghlan added the comment: The essential problem in both this issue and issue 30672 is that the tests are currently incorporating some Linux-specific assumptions about ways to request the "C" locale. In https://github.com/python/cpython/pull/4369, I've taken the

[issue32002] test_c_locale_coercion fails when the default LC_CTYPE != "C"

Change by Nick Coghlan : -- pull_requests: +4322 ___ Python tracker ___ ___

[issue31996] `setuptools.setup` parameter `py_modules` is undocumented

Luther Thompson added the comment: Thanks, done: https://github.com/pypa/python-packaging-user-guide/issues/397 -- ___ Python tracker

[issue31356] Add context manager to temporarily disable GC

Nick Coghlan added the comment: Given the existing "gc.enable", "gc.disable" and "gc.isenabled" APIs, I'd suggest calling this one "gc.ensure_disabled": it ensures the GC is disabled in the with statement body, but only turns it back on at the end if it was previously

[issue32003] multiprocessing.Array("b", 1), multiprocessing.Array("c", 1 ) wrong value returned

Samuel Nwokenkwo added the comment: To clarify my expectation was something like this: arr = multiprocessing.Array('c', 3) # type char arr = "Fun" which is similar to c implementation: char arr[3] = "Fun" AND arr = multiprocessing.Array('b', 3) # type byte

[issue32003] multiprocessing.Array("b", 1), multiprocessing.Array("c", 1 ) wrong value returned

Samuel Nwokenkwo added the comment: I completely wrote the wrong code: So I'll copy and paste: Scenario 1 import multiprocessing br = multiprocessing.Array('c', 1) br[0] = 's' print(br[:]) Scenario 1 result = "TypeError: one character

[issue31975] Add a default filter for DeprecationWarning in __main__

Nick Coghlan added the comment: OK, I've had a couple of days to become not-annoyed about this, and given the discovery that pytest doesn't currently enable DeprecationWarning by default (even though the default DeprecationWarning behaviour changed more than 7 years ago),

[issue21149] logging._removeHandlerRef is not threadsafe during interpreter shutdown

Change by Gregory P. Smith : -- pull_requests: +4321 stage: resolved -> patch review ___ Python tracker ___

[issue32003] multiprocessing.Array("b", 1), multiprocessing.Array("c", 1 ) wrong value returned

Change by Eryk Sun : -- components: +Library (Lib) -asyncio type: -> behavior ___ Python tracker ___

[issue31356] Add context manager to temporarily disable GC

Pablo Galindo Salgado added the comment: Just to clarify the current situation: At this point, the contextmanager is referred as "disabled" in the C code but is exported as "Disabled" to the garbage collection module. The "gc_disabled" is the Python "equivalent" given by

[issue21149] logging._removeHandlerRef is not threadsafe during interpreter shutdown

Change by Gregory P. Smith : -- assignee: -> gregory.p.smith ___ Python tracker ___ ___

[issue31356] Add context manager to temporarily disable GC

Pablo Galindo Salgado added the comment: Sorry about that. The context manager is "gc.Disabled()", which I admit is probably a bad name. The documentation is an example of the "equivalent" Python code as stated by Raymond in the first comment but I see now that this will

[issue21149] logging._removeHandlerRef is not threadsafe during interpreter shutdown

Yilei Yang added the comment: Here is a minimal example: main.py: from pkg_a import lib_a pkg_a/__init__.py pkg_a/lib_a.py import logging import sys import pkg_a # This is important handler = logging.StreamHandler(sys.stderr) It does not happen in

[issue32006] multiprocessing.Array 'c' code is not documented

New submission from Steven D'Aprano : multiprocessing.Array is documented as taking the same character codes as array.array, but it also takes 'c' which is not documented. https://docs.python.org/3/library/multiprocessing.html#multiprocessing.Array

[issue31995] Set operations documentation error

Raymond Hettinger added the comment: I did understand your report. IMO your "declaration of incorrectness" is due to an overly strict misreading of what the docs are trying to say and it does not reflect an understanding of what the in-place operators do

[issue31995] Set operations documentation error

Change by Raymond Hettinger : -- assignee: -> rhettinger priority: normal -> low resolution: -> wont fix ___ Python tracker

[issue31995] Set operations documentation error

Change by Raymond Hettinger : -- status: open -> closed ___ Python tracker ___

[issue32005] multiprocessing.Array misleading error message in slice assignment

Change by Steven D'Aprano : -- title: mutliprocessing.Array misleading error message in slice assignment -> multiprocessing.Array misleading error message in slice assignment ___ Python tracker

[issue31995] Set operations documentation error

Alexander Mentis added the comment: I don't think you understood my bug. That the augmented assignment operators work differently for set and frozenset is not the issue. The issue is that the documentation says that the |=, &=, -=, ^= operators do not apply to immutable

[issue32005] mutliprocessing.Array misleading error message in slice assignment

New submission from Steven D'Aprano : multiprocessing.Array slice assignment claims to require a single character even if it requires more than one: py> arr = multiprocessing.Array('c', 3) py> arr[:] = b'xyz' # works py> arr[:] = 'xyz' Traceback (most recent call

[issue31526] Allow setting timestamp in gzip-compressed tarfiles

Martin Panter added the comment: Perhaps you can compress the tar file using the “gzip.GzipFile” class. It accepts a custom “mtime” parameter (see Issue 4272, added in 2.7 and 3.1+): >>> gztar = BytesIO() >>> tar = GzipFile(fileobj=gztar, mode="w", mtime=0) >>>

[issue32003] multiprocessing.Array("b", 1), multiprocessing.Array("c", 1 ) wrong value returned

Steven D'Aprano added the comment: I don't understand why you think they are the wrong values. What values were you expecting? You have a byte array, you set the value to the byte b's', which is 115, and you get 115. You have a (byte) character array, you set the

[issue32004] Allow specifying code packing order in audioop adpcm functions

New submission from MosesofEgypt : --- Issue --- audioop.adpcm2lin and audioop.lin2adpcm currently treat the high 4 bits of each byte as the first code and the low 4 as the second code. In practice this is often the opposite.

[issue31993] pickle.dump allocates unnecessary temporary bytes / str

Olivier Grisel added the comment: I have tried to implement the direct write bypass for the C version of the pickler but I get a segfault in a Py_INCREF on obj during the call to memo_put(self, obj) after the call to _Pickler_write_large_bytes. Here is the diff of

[issue32003] multiprocessing.Array("b", 1), multiprocessing.Array("c", 1 ) wrong value returned

Eryk Sun added the comment: The values are correct for the given type codes, which should be the same as the corresponding type codes for the array and struct modules. Except the array module doesn't support the "c" type. However, assigning b's' to an index of a "b" type

[issue31995] Set operations documentation error

Raymond Hettinger added the comment: This is an artifact of how in-place operators work (which is a topic covered in the Library Reference). It doesn't really have anything to do with frozensets specifically. For example, you see the same effect with tuples

[issue32001] @lru_cache needs to be called with ()

Raymond Hettinger added the comment: Marking this as rejected. We specifically added a test and error message for this particular misuse of lru_cache. -- resolution: -> rejected stage: -> resolved status: open -> closed

[issue28369] Raise RuntimeError when transport's FD is used with add_reader etc

Change by Berker Peksag : -- pull_requests: -1054 ___ Python tracker ___ ___

[issue31824] Missing default argument detail in documentation of StreamReaderWriter

Berker Peksag added the comment: Thank you, Peter and Pablo. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue31824] Missing default argument detail in documentation of StreamReaderWriter

Berker Peksag added the comment: New changeset 7abbddd88d4debe75b201145b6212afb7d93c457 by Berker Peksag (Miss Islington (bot)) in branch '3.6': bpo-31824: Document default value of 'errors' parameters (GH-4328)

[issue21149] logging._removeHandlerRef is not threadsafe during interpreter shutdown

Gregory P. Smith added the comment: We're still seeing this (in 2.7.12, but the code at 2.7 head hasn't changed). In this case the RLock being used within _acquireLock() still exists but is an incomplete object by the time we use it. -- resolution: fixed -> status:

[issue31824] Missing default argument detail in documentation of StreamReaderWriter

Change by Roundup Robot : -- pull_requests: +4320 ___ Python tracker ___

[issue31824] Missing default argument detail in documentation of StreamReaderWriter

Berker Peksag added the comment: New changeset e184cfd7bf8bcfd160e3b611d4351ca3ce52d9e2 by Berker Peksag (Pablo Galindo) in branch 'master': bpo-31824: Document default value of 'errors' parameters (GH-4328)

[issue31356] Add context manager to temporarily disable GC

Serhiy Storchaka added the comment: What is the name of the context manager? gc_disabled, disabled, or Disabled? I see different names in the PR and this confuses me. -- ___ Python tracker

[issue31356] Add context manager to temporarily disable GC

Pablo Galindo Salgado added the comment: I just realize that the link I provided is incorrect. This is the correct one (also is the one that appears in this issue anyway): https://github.com/python/cpython/pull/4224 -- ___

[issue31974] Cursor misbahavior with Tkinter 3.6.1/tk 8.5 Text on Mac Sierra

Terry J. Reedy added the comment: 3.7.0a2 is out now. There will be an .0a3, .0a4, then .0b1 in January. Ned is saying that at least the last of these will be compiled to work with 8.6. Once that occurs, I would switch as most of the remaining changes before the .0

[issue31824] Missing default argument detail in documentation of StreamReaderWriter

Pablo Galindo Salgado added the comment: I have updated the PR with the requested changes. -- ___ Python tracker ___

[issue15606] re.VERBOSE whitespace behavior not completely documented

Serhiy Storchaka added the comment: Steven's patch is outdated since 71a0b43854164b6ada0026d90f241c987b54d019. But that commit missed that spaces are not ignored within tokens. PR 4366 fixes this by using the wording from Ezio's comments. -- nosy:

[issue15606] re.VERBOSE whitespace behavior not completely documented

Change by Serhiy Storchaka : -- pull_requests: +4319 stage: needs patch -> patch review ___ Python tracker ___

[issue28369] Raise RuntimeError when transport's FD is used with add_reader etc

Change by Yury Selivanov : -- keywords: +patch pull_requests: +4318 ___ Python tracker ___

[issue28369] Raise RuntimeError when transport's FD is used with add_reader etc

Change by Yury Selivanov : -- nosy: +asvetlov ___ Python tracker ___ ___

[issue28369] Raise RuntimeError when transport's FD is used with add_reader etc

Change by Yury Selivanov : -- resolution: fixed -> stage: resolved -> patch review status: closed -> open ___ Python tracker ___

[issue31976] Segfault when closing BufferedWriter from a different thread

Change by Antoine Pitrou : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue31976] Segfault when closing BufferedWriter from a different thread

Antoine Pitrou added the comment: Thank you for posting this Benjamin. As I said on the PR, I don't think I want to backport this to 3.6, as it is always delicate to reason about subclassing and threads. -- versions: -Python 3.6

[issue31976] Segfault when closing BufferedWriter from a different thread

Antoine Pitrou added the comment: New changeset 9703f092abc0259926d88c7855afeae4a78afc7d by Antoine Pitrou (benfogle) in branch 'master': bpo-31976: Fix race condition when flushing a file is slow. (#4331)

[issue31974] Cursor misbahavior with Tkinter 3.6.1/tk 8.5 Text on Mac Sierra

Irv Kalb added the comment: Hi Ned, Thanks for your message. But I want to make sure I understand what you are saying here. I am using absolutely vanilla Python 3.6 from python.org , but have upgraded to version 8.5.18 if ActiveState tk. I was

[issue24641] Log type of unserializable value when raising JSON TypeError

Serhiy Storchaka added the comment: The idea about including a path to non-serializable object looks interesting (and it would be even more useful for pickling), but harder to implement. -- ___ Python tracker

[issue24641] Log type of unserializable value when raising JSON TypeError

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +4317 stage: -> patch review ___ Python tracker ___

[issue24641] Log type of unserializable value when raising JSON TypeError

Serhiy Storchaka added the comment: This issue was partially fixed in issue26623. The error message for unsupported types now is `"Object of type '%s' is not JSON serializable" % o.__class__.__name__`. But this change is not complete. The error message for

[issue31994] json encoder exception could be better

Serhiy Storchaka added the comment: Actually it was fixed in issue26623. -- superseder: Log type of unserializable value when raising JSON TypeError -> JSON encode: more informative error ___ Python tracker

[issue31994] json encoder exception could be better

Serhiy Storchaka added the comment: This is a duplicate of issue24641. -- nosy: +serhiy.storchaka resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> Log type of unserializable value when raising JSON TypeError

[issue31993] pickle.dump allocates unnecessary temporary bytes / str

Olivier Grisel added the comment: BTW, I am looking at the C implementation at the moment. I think I can do it. -- ___ Python tracker

[issue32001] @lru_cache needs to be called with ()

Serhiy Storchaka added the comment: One such decorator was added in 3.7: xmlrpc.server.register_function (see issue7769). I don't think lru_cache should follow this example. There are few cases in which such obscure decorators are more or less appropriate: 1.

[issue32001] @lru_cache needs to be called with ()

Éric Araujo added the comment: I remember seeing code needed to make a decorator that works with and without parens and finding it quite obscure and confusing for a long time. When you understand the distinction between, things become clear and simple again. I like that

[issue15606] re.VERBOSE whitespace behavior not completely documented

Kevin Shweh added the comment: It looks to me like there are more situations than the patch lists where whitespace still separates tokens. For example, *? is a reluctant quantifier and * ? is a syntax error, even in verbose mode. -- nosy: +Kevin Shweh

[issue31985] Deprecate openfp() in aifc, sunau and wave

Brian Curtin added the comment: New changeset 9f914a01affc55abe799afc521ce71612bb495a5 by Brian Curtin in branch 'master': bpo-31985: Deprecate openfp in aifc, sunau, and wave (#4344) https://github.com/python/cpython/commit/9f914a01affc55abe799afc521ce71612bb495a5

[issue32003] multiprocessing.Array("b", 1), multiprocessing.Array("c", 1 ) wrong value returned

New submission from Samuel Nwokenkwo : 1st sequence: arr = multiprocessing.Array("b", 1) # byte type arr[0] = 's'.encode() print(arr[:]) result is [115] 2nd sequence: arr = multiprocessing.Array("c", 1) # character type arr[0] = 's'.encode() print(arr[:])

[issue32002] test_c_locale_coercion fails when the default LC_CTYPE != "C"

Erik Bray added the comment: In my PR there's a behavior test for the default, so we don't have to hard-code that on a per-platform basis at least. The C != POSIX thing I'm not sure you can easily test for. -- ___ Python

[issue31993] pickle.dump allocates unnecessary temporary bytes / str

Serhiy Storchaka added the comment: Nice! I have got virtually the same code as your intermediate variant, but your final variant event better! -- ___ Python tracker

[issue31974] Cursor misbahavior with Tkinter 3.6.1/tk 8.5 Text on Mac Sierra

Ned Deily added the comment: Thanks for the very helpful video, Irv. It is definitely not a Python issue as I am able to reproduce the positioning problem using the current ActiveState Community Edition 8.6.6 and 8.5.18 macOS Wish shell text widget demos (as long as I use

[issue31993] pickle.dump allocates unnecessary temporary bytes / str

Olivier Grisel added the comment: Alright, the last version has now ~4% overhead for small bytes. -- ___ Python tracker ___

[issue31993] pickle.dump allocates unnecessary temporary bytes / str

Olivier Grisel added the comment: Actually, I think this can still be improved while keeping it readable. Let me try again :) -- ___ Python tracker

[issue31993] pickle.dump allocates unnecessary temporary bytes / str

Olivier Grisel added the comment: I have pushed a new version of the code that now has a 10% overhead for small bytes (instead of 40% previously). It could be possible to optimize further but I think that would render the code much less readable so I would be

[issue31992] Make iteration over dict_items yield namedtuples

R. David Murray added the comment: This is not something it is worth complicating the dict API or collections for. If you want the feature in your code, implement your subclass in your own utility library. If you disagree with this decision, please bring it up on the

[issue31993] pickle.dump allocates unnecessary temporary bytes / str

Serhiy Storchaka added the comment: This speeds up pickling large bytes objects. $ ./python -m timeit -s 'import pickle; a = [bytes([i%256])*100 for i in range(256)]' 'with open("/dev/null", "wb") as f: pickle._dump(a, f)' Unpatched: 10 loops, best of 5: 20.7

[issue31992] Make iteration over dict_items yield namedtuples

Richard Neumann added the comment: Maybe there is no need to sacrifice performance, if a new, optional keyword argument would be introduced to dict.items(): def items(self, named=False): if named: else: Currently I need to

[issue32002] test_c_locale_coercion fails when the default LC_CTYPE != "C"

Nick Coghlan added the comment: OK, I'd been meaning to get back to refactoring those tests anyway, so assigning this to myself. I'm thinking that the right way to go will be to give the test case a more explicit model of "expected platform behaviour" (initialised in

[issue31993] pickle.dump allocates unnecessary temporary bytes / str

Serhiy Storchaka added the comment: I'll try to write the C implementation. Maybe it will use other heuristic. -- ___ Python tracker

[issue31993] pickle.dump allocates unnecessary temporary bytes / str

Olivier Grisel added the comment: In my last comment, I also reported the user times (not spend in OS level disk access stuff): the code of the PR is on the order of 300-400ms while master is around 800ms or more. -- ___

[issue31993] pickle.dump allocates unnecessary temporary bytes / str

Serhiy Storchaka added the comment: Actually the time varies too much between runs. 1.641s ... 8.475s ... 12.645s -- ___ Python tracker

[issue32002] test_c_locale_coercion fails when the default LC_CTYPE != "C"

Erik Bray added the comment: Yes, I looked at some of the other issues pertaining to this, but it wasn't immediately apparent how to kill multiple birds with one stone, so here I just focused on this one assumption. -- ___

[issue31999] test_venv failed when the zlib module is not available

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue31530] Python 2.7 readahead feature of file objects is not thread safe

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue31530] Python 2.7 readahead feature of file objects is not thread safe

Serhiy Storchaka added the comment: New changeset 6401e5671781eb217ee1afb4603cc0d1b0367ae6 by Serhiy Storchaka in branch '2.7': [2.7] bpo-31530: Stop crashes when iterating over a file on multiple threads. (#3672)

[issue32002] test_c_locale_coercion fails when the default LC_CTYPE != "C"

Nick Coghlan added the comment: Issue 30672 is potentially related here - some of the test cases are already disabled on Mac OS X and other *BSD systems since the tests assume that C & POSIX are aliases of each other. I've also added Xavier to the nosy list, since the

[issue31999] test_venv failed when the zlib module is not available

Serhiy Storchaka added the comment: New changeset 7997fa2e2159cfce0cfbe985a953174ac86694a4 by Serhiy Storchaka (Miss Islington (bot)) in branch '3.6': bpo-31999: Fix test_venv in case the zlib module is not available. (GH-4359) (#4360)

[issue32002] test_c_locale_coercion fails when the default LC_CTYPE != "C"

Change by Erik Bray : -- keywords: +patch pull_requests: +4316 stage: -> patch review ___ Python tracker ___

[issue32002] test_c_locale_coercion fails when the default LC_CTYPE != "C"

New submission from Erik Bray : Several of the tests in test_c_locale_coercion (particularly LocaleCoercionTests._check_c_locale_coercion) tend to assume that the system default locale used when setting setlocale(category, "") and when all the relevant environment

[issue32001] @lru_cache needs to be called with ()

Serhiy Storchaka added the comment: I'm -1. The beginner can make use lru_cache incorrectly the first time, but nobody will make this mistake twice. It is not worth to complicate the code (by the way, your code contains a bug) for saving from at most one mistake

[issue31222] datetime.py implementation of .replace inconsistent with C implementation

STINNER Victor added the comment: Thanks Paul Ganssle for the bugfix! I merged your PR and backported it to Python 3.6. (Python 3.5 doesn't accept bugfixes anymore.) -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions:

[issue32001] @lru_cache needs to be called with ()

New submission from Tom Hale : This comes from a question I raised on StackOverflow: https://stackoverflow.com/q/47218313/5353461 I've copied the text below =

[issue31998] test_zipapp failed when the zlib module is not available

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 3.6 ___ Python tracker

[issue31998] test_zipapp failed when the zlib module is not available

Paul Moore added the comment: Good catch, thanks Serhiy! -- ___ Python tracker ___ ___

[issue31999] test_venv failed when the zlib module is not available

Change by Roundup Robot : -- pull_requests: +4315 ___ Python tracker ___

[issue31998] test_zipapp failed when the zlib module is not available

Serhiy Storchaka added the comment: New changeset a1718bc7e0455ec5019e800d4172947bb4a07962 by Serhiy Storchaka in branch 'master': bpo-31998: Fix test_zipapp in case the zlib module is not available. (#4358)

[issue31999] test_venv failed when the zlib module is not available

Serhiy Storchaka added the comment: New changeset 5e0df74b3bc6391e9a7eba0fd84531ed99a78ae9 by Serhiy Storchaka in branch 'master': bpo-31999: Fix test_venv in case the zlib module is not available. (#4359)

[issue31988] Saving bytearray to binary plist file doesn't work

Change by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___

[issue31380] test_undecodable_filename() in Lib/test/test_httpservers.py broken on APFS

Change by Serhiy Storchaka : -- components: +Tests type: crash -> behavior versions: -Python 3.3, Python 3.4, Python 3.5 ___ Python tracker

[issue32000] test_undecodable_filename in test_httpservers failed on Mac OS X

Serhiy Storchaka added the comment: Duplicate of issue31380. -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> test_undecodable_filename() in Lib/test/test_httpservers.py broken on APFS

[issue32000] test_undecodable_filename in test_httpservers failed on Mac OS X

New submission from Serhiy Storchaka : http://buildbot.python.org/all/#/builders/14/builds/160/steps/4/logs/stdio == ERROR: test_undecodable_filename (test.test_httpservers.SimpleHTTPServerTestCase)

[issue31999] test_venv failed when the zlib module is not available

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +4314 stage: needs patch -> patch review ___ Python tracker

[issue31998] test_zipapp failed when the zlib module is not available

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +4313 stage: needs patch -> patch review ___ Python tracker

[issue31999] test_venv failed when the zlib module is not available

New submission from Serhiy Storchaka : http://buildbot.python.org/all/#/builders/14/builds/160/steps/4/logs/stdio == FAIL: test_with_pip (test.test_venv.EnsurePipTest)

[issue31998] test_zipapp failed when the zlib module is not available

New submission from Serhiy Storchaka : http://buildbot.python.org/all/#/builders/14/builds/160/steps/4/logs/stdio == ERROR: test_create_archive_with_compression (test.test_zipapp.ZipAppTest)