[issue28009] core logic of uuid.getnode() is broken for AIX - all versions

2018-01-14 Thread Michael Felt
Michael Felt added the comment: On 14/01/2018 22:01, Antoine Pitrou wrote: > Antoine Pitrou added the comment: > > Is nohup required in the example you just posted or is that a red herring? > > -- > > ___ >

[issue15221] os.path.is*() may return False if path can't be accessed

2018-01-14 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: Thanks! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue15221] os.path.is*() may return False if path can't be accessed

2018-01-14 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: New changeset bb80645d06c16461b0b58d8983cd7fa6962ba3c6 by Mariatta (Miss Islington (bot)) in branch '3.6': bpo-15221: Update os.path.is*() documentation (GH-5185) (GH-5186)

[issue32553] venv says to use python3 which does not exist in 3.6.4

2018-01-14 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: People who has more than one Python versions installed will have python3. -- nosy: +Mariatta ___ Python tracker

[issue32551] 3.5.4 has a regression that was fixed in 3.6.1rc1

2018-01-14 Thread Larry Hastings
Larry Hastings added the comment: As a reminder: I'm currently scheduled to tag Python 3.5.5rc1 on January 21st, 2018, aka about six days from now. -- ___ Python tracker

[issue26330] shutil.disk_usage() on Windows can't properly handle unicode

2018-01-14 Thread Roundup Robot
Change by Roundup Robot : -- pull_requests: +5042 ___ Python tracker ___

[issue26330] shutil.disk_usage() on Windows can't properly handle unicode

2018-01-14 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: New changeset ee3b83547c6b0cac1da2cb44aaaea533a1d1bbc8 by Mariatta (Cheryl Sabella) in branch 'master': bpo-26330: Update shutil.disk_usage() documentation (GH-5184)

[issue26163] FAIL: test_hash_effectiveness (test.test_set.TestFrozenSet)

2018-01-14 Thread Raymond Hettinger
Change by Raymond Hettinger : -- pull_requests: +5041 stage: -> patch review ___ Python tracker ___

[issue15221] os.path.is*() may return False if path can't be accessed

2018-01-14 Thread Roundup Robot
Change by Roundup Robot : -- pull_requests: +5040 ___ Python tracker ___

[issue15221] os.path.is*() may return False if path can't be accessed

2018-01-14 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: New changeset b3dd18d4035803b50c65a434955966d1b3b1f363 by Mariatta (Cheryl Sabella) in branch 'master': bpo-15221: Update os.path.is*() documentation (GH-5185)

[issue26163] FAIL: test_hash_effectiveness (test.test_set.TestFrozenSet)

2018-01-14 Thread Raymond Hettinger
Raymond Hettinger added the comment: Bringing this tracker item back to life. I've had more time to look at the this and the underlying problem was the high bits were not being shuffled back to impact lower bits. By fixing this, all of the tests produce a

[issue32551] 3.5.4 has a regression that was fixed in 3.6.1rc1

2018-01-14 Thread Nick Coghlan
Nick Coghlan added the comment: Unfortunately, it looks like bpo-29319 was backported to the 3.5 branch, but not the follow-up fix from bpo-29723: https://github.com/python/cpython/commits/3.5/Modules/main.c (The metadata on bpo-29319 indicated that the original change

[issue32553] venv says to use python3 which does not exist in 3.6.4

2018-01-14 Thread Paul Watson
New submission from Paul Watson : The 3.6.4 documentation on venv specifies using 'python3', but no python3 executable is in the 3.6.4 kit. https://docs.python.org/3/library/venv.html?highlight=venv#module-venv -- assignee: docs@python components:

[issue32542] memory not freed, aka memory leak continues...

2018-01-14 Thread Michael Felt
Michael Felt added the comment: Thanks for the clarification. Being curious, is there a way to see what the size of the cache is? I want to believe, but i do not have the impression memory is being reallocated to later users. My gut feeling is that the code change

[issue26330] shutil.disk_usage() on Windows can't properly handle unicode

2018-01-14 Thread Eryk Sun
Eryk Sun added the comment: This is the high-level shutil module, so why not try to use the resolved parent directory? For example: def disk_usage(path): try: total, free = nt._getdiskusage(path) except NotADirectoryError: path =

[issue32552] Improve text for file arguments in argparse.ArgumentDefaultsHelpFormatter class

2018-01-14 Thread elypter
New submission from elypter : If you use formatter_class=argparse.ArgumentDefaultsHelpFormatter in the constructor then the defaults that you include in arguments get automatically added to the help text. this looks great for int and Strings but not for files. example:

[issue15221] os.path.is*() may return False if path can't be accessed

2018-01-14 Thread Cheryl Sabella
Cheryl Sabella added the comment: I created a PR for this by making the word 'existing' a link to 'os.path.exists' since Nick mentioned that that word already implied the definition. -- nosy: +csabella versions: +Python 3.7 -Python 2.7, Python 3.2, Python 3.3

[issue15221] os.path.is*() may return False if path can't be accessed

2018-01-14 Thread Cheryl Sabella
Change by Cheryl Sabella : -- keywords: +patch pull_requests: +5039 stage: -> patch review ___ Python tracker ___

[issue32516] Add a shared library mechanism for win32

2018-01-14 Thread Steve Dower
Steve Dower added the comment: The more details you reveal, the less I want it to be an officially supported pattern :) Perhaps you actually want an import hook? Brett can confirm, but I believe you can overwrite __loader__ in a package and change how submodules are

[issue15115] Duplicated Content-Transfer-Encoding header when applying email.encoders

2018-01-14 Thread Cheryl Sabella
Cheryl Sabella added the comment: Barry/David, Is this still a change you wanted to include in the documentation? Thanks! -- nosy: +csabella ___ Python tracker

[issue26330] shutil.disk_usage() on Windows can't properly handle unicode

2018-01-14 Thread Cheryl Sabella
Change by Cheryl Sabella : -- versions: +Python 3.7 -Python 3.3, Python 3.4, Python 3.5, Python 3.6 ___ Python tracker ___

[issue26330] shutil.disk_usage() on Windows can't properly handle unicode

2018-01-14 Thread Cheryl Sabella
Cheryl Sabella added the comment: I've submitted a PR for the documentation change. -- nosy: +csabella ___ Python tracker ___

[issue26330] shutil.disk_usage() on Windows can't properly handle unicode

2018-01-14 Thread Cheryl Sabella
Change by Cheryl Sabella : -- keywords: +patch pull_requests: +5038 stage: -> patch review ___ Python tracker ___

[issue28009] core logic of uuid.getnode() is broken for AIX - all versions

2018-01-14 Thread Antoine Pitrou
Antoine Pitrou added the comment: Is nohup required in the example you just posted or is that a red herring? -- ___ Python tracker ___

[issue28009] core logic of uuid.getnode() is broken for AIX - all versions

2018-01-14 Thread Michael Felt
Michael Felt added the comment: FYI: - On AIX, no uuid_create support: ./python -m unittest -v test.test_uuid ... Ran 48 tests in 0.261s OK (skipped=37) On AIX 6.1 (with ctypes, without _uuid) ./python -m unittest -v test.test_uuid ... Ran 48 tests in 0.274s OK

[issue28009] core logic of uuid.getnode() is broken for AIX - all versions

2018-01-14 Thread Michael Felt
Michael Felt added the comment: PR added, please review. -- ___ Python tracker ___

[issue28009] core logic of uuid.getnode() is broken for AIX - all versions

2018-01-14 Thread Michael Felt
Change by Michael Felt : -- keywords: +patch pull_requests: +5037 stage: -> patch review ___ Python tracker ___

[issue29476] Simplify set_add_entry()

2018-01-14 Thread Raymond Hettinger
Change by Raymond Hettinger : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue29476] Simplify set_add_entry()

2018-01-14 Thread Raymond Hettinger
Raymond Hettinger added the comment: New changeset 3329992e31bd0494a7d7312853f7ffd054737e27 by Raymond Hettinger in branch 'master': bpo-29476: Simplify set_add_entry() (#5175) https://github.com/python/cpython/commit/3329992e31bd0494a7d7312853f7ffd054737e27

[issue29708] support reproducible Python builds

2018-01-14 Thread Brett Cannon
Brett Cannon added the comment: As Eli's comments are coming off as negative to/at me, I feel like I have to defend myself here. If you look at the commit there was actually two places where the timestamp was checked; one did an equality comparison and one did a >= comparison.

[issue32550] STORE_ANNOTATION bytecode is unnecessary and can be removed.

2018-01-14 Thread Raymond Hettinger
Raymond Hettinger added the comment: I would like to see this patch go forward. Making __annotations__ special and subtly different just adds to language complexity. -- nosy: +rhettinger ___ Python tracker

[issue32534] Speed-up list.insert

2018-01-14 Thread Raymond Hettinger
Raymond Hettinger added the comment: The result likely varies quite a bit from compiler-to-compiler and processor-to-processor and os-to-os. It is may also be affected by data size and caching. -- nosy: +rhettinger

[issue32526] Closing async generator while it is running does not raise an exception

2018-01-14 Thread Joongi Kim
Change by Joongi Kim : -- keywords: +patch pull_requests: +5035 stage: -> patch review ___ Python tracker ___

[issue32226] Implement PEP 560: Core support for typing module and generic types

2018-01-14 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Sorry, I know very small about this module to writing the documentation. -- ___ Python tracker

[issue32551] 3.5.4 has a regression that was fixed in 3.6.1rc1

2018-01-14 Thread Ned Deily
Change by Ned Deily : -- dependencies: +3.6.1rc1 adds the current directory to sys.path when running a subdirectory's __main__.py; previous versions did not nosy: +larry, ncoghlan ___ Python tracker

[issue32551] 3.5.4 has a regression that was fixed in 3.6.1rc1

2018-01-14 Thread Ned Batchelder
Ned Batchelder added the comment: (For clarity) The problem is that 3.5.4 adds the current directory to sys.path when running a subdirectory's __main__.py. No other version of Python does this. -- ___ Python tracker

[issue32551] 3.5.4 has a regression that was fixed in 3.6.1rc1

2018-01-14 Thread Ned Batchelder
New submission from Ned Batchelder : The issue that I reported in https://bugs.python.org/issue29723 is now affecting 3.5.4: ``` $ pwd /Users/ned/foo $ tree syspathmain syspathmain └── __main__.py 0 directories, 1 file $ cat syspathmain/__main__.py import sys

[issue32550] STORE_ANNOTATION bytecode is unnecessary and can be removed.

2018-01-14 Thread Mark Shannon
Mark Shannon added the comment: Works as expected: >>> class C: ... exec('x: int') ... >>> C.__annotations__ {'x': } >>> __annotations__ {} -- ___ Python tracker

[issue32550] STORE_ANNOTATION bytecode is unnecessary and can be removed.

2018-01-14 Thread Ivan Levkivskyi
Ivan Levkivskyi added the comment: There is also another corner case to consider: class C: exec('x: int') assert C.__annotations__ == {'x': int} assert __annotations__ == {} I am not sure this one will be covered correctly. But the main argument here is speed I

[issue32550] STORE_ANNOTATION bytecode is unnecessary and can be removed.

2018-01-14 Thread Mark Shannon
Mark Shannon added the comment: > 3. It doesn't add a name constant. Instead it uses a name from the names list > (which already has to contain this name). This PR moves the constant for the name from `co_names` to `co_consts`. There is no duplication. >>> def f(): ...

[issue32550] STORE_ANNOTATION bytecode is unnecessary and can be removed.

2018-01-14 Thread Mark Shannon
Mark Shannon added the comment: PEP 526 explicitly states "as with all dunder attributes, any undocummented use of __annotations__ is subject to breakage without warning" I consider deleting __annotations__ to be undocumented use. Do you really think that an obscure

[issue32550] STORE_ANNOTATION bytecode is unnecessary and can be removed.

2018-01-14 Thread Ivan Levkivskyi
Ivan Levkivskyi added the comment: There are several corner cases. For example consider this code: >>> class C: ... del __annotations__ ... x: int Currently this correctly raises NameError, with your replacement it will instead stick {'x': int} in the module

[issue32550] STORE_ANNOTATION bytecode is unnecessary and can be removed.

2018-01-14 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: There some subtle differences. 1. Unlike to LOAD_NAME, STORE_ANNOTATION doesn't fall back to globals if '__annotations__' is not found in locals. The behavior difference is shown by the following example: x: int class

[issue32550] STORE_ANNOTATION bytecode is unnecessary and can be removed.

2018-01-14 Thread Mark Shannon
Change by Mark Shannon : -- keywords: +patch pull_requests: +5034 stage: needs patch -> patch review ___ Python tracker ___

[issue32550] STORE_ANNOTATION bytecode is unnecessary and can be removed.

2018-01-14 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- nosy: +gvanrossum, levkivskyi, yselivanov ___ Python tracker ___

[issue32550] STORE_ANNOTATION bytecode is unnecessary and can be removed.

2018-01-14 Thread Mark Shannon
New submission from Mark Shannon : The STORE_ANNOTATION bytecode is used to implement annotations. The code name : ann is equivalent to __annotations__['name'] = ann Consequently, STORE_ANNOTATION name can be trivially replaced with LOAD_NAME

[issue32534] Speed-up list.insert

2018-01-14 Thread Jeethu Rao
Jeethu Rao added the comment: I managed to tune an i7700k desktop running Ubuntu 17.10 per this doc[1], and ran the pyperformance benchmarks[2]. I also tried various threshold with this benchmark and 16 still seems to be the sweet spot. The geometric mean of the relative

[issue32549] Travis: Test with OpenSSL 1.1.0

2018-01-14 Thread Christian Heimes
Change by Christian Heimes : -- keywords: +patch pull_requests: +5033 ___ Python tracker ___

[issue32549] Travis: Test with OpenSSL 1.1.0

2018-01-14 Thread Christian Heimes
New submission from Christian Heimes : For several planned features and security improvements, at least OpenSSL 1.0.2 is required. OpenSSL 1.1.0 is preferred to test all new features. See discussion https://mail.python.org/pipermail/python-dev/2018-January/151718.html .

[issue17972] inspect module docs omits many functions

2018-01-14 Thread Paul Rudin
Paul Rudin added the comment: Although formatannotation is undocumented, its actually documented as a default value for one of the parameters of formatargspec, so it does form part of the module's public interface. However formatargspec is deprecated, so it's still OK to