[issue29120] Move hash randomisation initialisation out of Python/random.c

STINNER Victor added the comment: I prefered random.c name since hash initialization is only a small part of the file, most of file is the implementation of os.urandom() and os.getrandom() which is used a runtime. -- ___

[issue32687] wrong meaning of arg in Py_tracefunc doc

Change by miss-islington : -- pull_requests: +5219 ___ Python tracker ___

[issue32687] wrong meaning of arg in Py_tracefunc doc

Xiang Zhang added the comment: New changeset 9ed0aee27c249dada410a22fff4325a4a61df36d by Xiang Zhang in branch 'master': bpo-32687: Fix wrong meaning of args for PyTrace_LINE/CALL in documentation (#5361)

[issue32687] wrong meaning of arg in Py_tracefunc doc

Change by miss-islington : -- pull_requests: +5218 ___ Python tracker ___

[issue32685] Erroneous suggestion in print statement

Change by Sanyam Khurana : -- pull_requests: +5217 ___ Python tracker ___ ___

[issue32685] Erroneous suggestion in print statement

Change by Nitish : -- keywords: +patch pull_requests: +5216 stage: needs patch -> patch review ___ Python tracker ___

[issue32690] Return function locals() in order of creation?

Change by Nick Coghlan : -- assignee: -> ncoghlan ___ Python tracker ___ ___

[issue32690] Return function locals() in order of creation?

Guido van Rossum added the comment: Heh, that's old code! IIRC I wrote a lot of loops like that, it was a little C trick I had picked up that reduced the loop overhead (since comparing to 0 is quicker than comparing to a variable). And until 3.6 it didn't really matter. I

[issue17305] IDNA2008 encoding missing

Nathaniel Smith added the comment: Greg: That's bpo-28414. There's currently no motion towards builtin IDNA 2008 support (this bug), but I *think* in 3.7 the ssl module will be able to handle pre-encoded A-labels like that. I'm a little confused about the exact status right

[issue17305] IDNA2008 encoding missing

Greg Lindahl added the comment: I am avoiding Python's built-in libraries as much as possible in my aiohttp-based crawler because of this issue, but I cannot open a connection to https://xn--ho-hia.de because there is an 'IDNA does not round-trip' raise in the python 3.6

[issue30306] release arguments of contextmanager

Nick Coghlan added the comment: Thanks for the issue report and patch Martin, and sorry for the long delay in getting it merged! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue30306] release arguments of contextmanager

Nick Coghlan added the comment: New changeset a278ad2faa76ae61569a58f36e06ba8745f4a9b7 by Nick Coghlan in branch 'master': bpo-30306: Add missing NEWS entry (GH-5374) https://github.com/python/cpython/commit/a278ad2faa76ae61569a58f36e06ba8745f4a9b7 --

[issue32685] Erroneous suggestion in print statement

Nick Coghlan added the comment: They're the only characters we won't want to include as part of the suggestion, since they indicate the end of the statement. -- ___ Python tracker

[issue17044] Implement PEP 422: Simple class initialisation hook

Nick Coghlan added the comment: Indeed it should! Thanks for pointing that out :) -- resolution: -> out of date stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue32206] Run modules with pdb

Nick Coghlan added the comment: I checked the original PR, and I'm pretty sure the reference implementation is going to have the same bug. To keep the NEWS entries clear (since the buggy implementation already shipped in the alpha releases), I've created a new issue here:

[issue32691] "pdb -m " sets __main__.__package__ incorrectly

New submission from Nick Coghlan : For regular modules, the initial implementation of bpo-32206 sets __package__ to "module_name" instead of "module_name.rpartition('.')[0]". This is not correct, and will cause problems for relative imports. (From

[issue32206] Run modules with pdb

Nick Coghlan added the comment: New changeset fcf8b4c1022bc2d2f84dcef5d72eabf40a25ea19 by Nick Coghlan (Mario Corchero) in branch 'master': bpo-32206: Update pdb usage to include new module option (GH-5111)

[issue32690] Return function locals() in order of creation?

Nick Coghlan added the comment: The current oddity where the names will always appear in the reverse of declaration order comes from a C level loop in the frame object's "map_to_dict" helper function that loops in reverse [1]: ... for (j = nmap; --j >= 0; ) {

[issue32321] functools.reduce has a redundant guard or needs a pure Python fallback

Nick Coghlan added the comment: Reviewing the code and the CI test failures on the PR, the trick here is that functools isn't actually *using* functools.reduce, it's just re-exporting it if it's defined. So if you block importing of "_functools" (which the test suite does

[issue30306] release arguments of contextmanager

Change by Nick Coghlan : -- pull_requests: +5215 stage: -> patch review ___ Python tracker ___

[issue30306] release arguments of contextmanager

Nick Coghlan added the comment: New changeset dd0e087edc8f1e4d2c0913236b1a62a77d9db6d8 by Nick Coghlan (Martin Teichmann) in branch 'master': bpo-30306: release arguments of contextmanager (GH-1500)

[issue30306] release arguments of contextmanager

Nick Coghlan added the comment: Ouch, this clearly slipped off my review radar last year - I just picked it up again now while going through all my currently assigned issues before 3.7b1. While I still think the suggested refactoring above would be a good way to go,

[issue32664] Connector "|" missing between ImportError and LookupError

Mariatta Wijaya added the comment: Thanks! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue32606] Email Header Injection Protection Bypass

R. David Murray added the comment: Yes. There's this thing called Postel's Law that says you should be generous in what you accept and careful in what you emit. So most MTAs and MUAs try very hard to guess what a non-RFC-compliant email is trying to say, which

[issue29120] Move hash randomisation initialisation out of Python/random.c

Nick Coghlan added the comment: As part of the startup sequence refactoring, this file has been renamed to Python/bootstrap_hash.c, and _PyRandom_Init/Fini have been renamed to _Py_HashRandomization_Init/Fini. Relevant commit:

[issue32664] Connector "|" missing between ImportError and LookupError

Mariatta Wijaya added the comment: New changeset d331515847f0a053b929e5a4795715cb111f42b3 by Mariatta (Miss Islington (bot)) in branch '3.6': [3.6] bpo-32664: Add missing "|" connector in Exceptions doc (GH-1173) (GH-5372)

[issue27172] Undeprecate inspect.getfullargspec()

Change by Nick Coghlan : -- assignee: ncoghlan -> ___ Python tracker ___ ___

[issue32690] Return function locals() in order of creation?

Nathaniel Smith added the comment: What should happen for: def f(): if random.random() < 0.5: a = 1 b = 2 else: b = 1 a = 2 return locals() ? Right now co_varnames preserves the order that names were encountered when compiling, so

[issue32664] Connector "|" missing between ImportError and LookupError

Mariatta Wijaya added the comment: I will backport the change to 3.6. -- assignee: docs@python -> Mariatta nosy: +Mariatta ___ Python tracker

[issue32664] Connector "|" missing between ImportError and LookupError

Change by Roundup Robot : -- keywords: +patch pull_requests: +5214 stage: backport needed -> patch review ___ Python tracker

[issue14010] deeply nested itertools objects segfault

Change by ppperry : -- title: deeply nested filter segfaults -> deeply nested itertools objects segfault ___ Python tracker ___

[issue32690] Return function locals() in order of creation?

New submission from Guido van Rossum : Found in this thread: https://twitter.com/dabeaz/status/956264950430912512 Note that at the global level locals() indeed returns variables in order of definition. Ditto at class scope. Because those calls just return the actual dict.

[issue32606] Email Header Injection Protection Bypass

Nitish added the comment: RFC 5322[1] says that header field's name can't have space in it and the must be immediately followed by the ':' character. Is it common for SMTP servers to accept messages with ' ' before ':'? [1]

[issue32546] Unusual TypeError with dataclass decorator

Eric V. Smith added the comment: This has been fixed as part of #32513. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker

[issue32677] Add.isascii() to str, bytes and bytearray

Change by INADA Naoki : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue32677] Add.isascii() to str, bytes and bytearray

INADA Naoki added the comment: New changeset bea57060c863d0c3474c79350bd9c557f2ff0e7c by INADA Naoki in branch 'master': bpo-32677: Optimize str.isascii() (GH-5356) https://github.com/python/cpython/commit/bea57060c863d0c3474c79350bd9c557f2ff0e7c --

[issue32513] dataclasses: make it easier to use user-supplied special methods

Change by Eric V. Smith : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue32513] dataclasses: make it easier to use user-supplied special methods

Eric V. Smith added the comment: New changeset ea8fc52e75363276db23c6a8d7a689f79efce4f9 by Eric V. Smith in branch 'master': bpo-32513: Make it easier to override dunders in dataclasses. (GH-5366)

[issue32689] shutil.move raises AttributeError if first argument is a pathlib.Path object and destination is a directory

New submission from Craig Holmquist : >>> import os, pathlib, shutil >>> os.mkdir('test1') >>> os.mkdir('test2') >>> path = pathlib.Path('test1') >>> shutil.move(path, 'test2') Traceback (most recent call last): File "", line 1, in File "/usr/lib/python3.6/shutil.py",

[issue32685] Erroneous suggestion in print statement

Nitish added the comment: > For the right offset, I think we'll want to drop the initial XStrip call > added for bpo-32028 entirely, and instead calculate the right offset as a > PyUnicode_FindChar search for ";" (replacing it with the length of the input > string if

[issue30670] pprint for dict in sorted order or insert order?

Philippe added the comment: IMHO since Guido said that dictionary order is guaranteed going forward [1], the order should now be preserved in 3.6+ Getting a sorted pprint'ed dict in a Py3.6.1 was a surprise to me coming from Python2. The default ordered dict is to me

[issue32622] Implement loop.sendfile

Yury Selivanov added the comment: I think we've fixed everything. Closing this for now, Victor please reopen if buildbots misbehave. -- resolution: -> fixed status: open -> closed ___ Python tracker

[issue32436] Implement PEP 567

Change by Yury Selivanov : -- pull_requests: +5213 ___ Python tracker ___ ___

[issue32622] Implement loop.sendfile

Yury Selivanov added the comment: New changeset 2a2247ce5e1984eb2f2c41b269b38dbb795a60cf by Yury Selivanov in branch 'master': bpo-32622: Normalize ENOTCONN to ConnectionError on macOS (GH-5369)

[issue32221] Converting ipv6 address to string representation using getnameinfo() is wrong.

Yury Selivanov added the comment: Merged. Thanks, Mark! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue32221] Converting ipv6 address to string representation using getnameinfo() is wrong.

Yury Selivanov added the comment: New changeset 47c0b1f7d4115e6f15e6776c1f91d28e7d96fe0c by Yury Selivanov (Коренберг Марк) in branch 'master': bpo-32221: makeipaddr(): remove interface part + speedup (GH-4724)

[issue32622] Implement loop.sendfile

Yury Selivanov added the comment: New changeset ee72ac0683e685b134f67cb0c6612c664ecadb65 by Yury Selivanov (Elvis Pranskevichus) in branch 'master': bpo-32622: Fix AbstractEventLoop.sendfile signature in documentation. (GH-5368)

[issue32622] Implement loop.sendfile

Yury Selivanov added the comment: > AttributeError: 'NoneType' object has no attribute 'SSLContext' We've just pushed a fix for this. -- ___ Python tracker

[issue32622] Implement loop.sendfile

STINNER Victor added the comment: s390x Debian 3.x buildbot failed: http://buildbot.python.org/all/#/builders/13/builds/601 Exmaple: == ERROR: test_sendfile_ssl_pre_and_post_data

[issue32622] Implement loop.sendfile

Change by Yury Selivanov : -- pull_requests: +5212 ___ Python tracker ___ ___

[issue32665] pathlib.Path._from_parsed_parts should call cls.__new__(cls)

Pablo Galindo Salgado added the comment: Antoine, is the reason of calling object.__new__(cls) in `_from_parsed_parts` that the code does not raise on creation? -- ___ Python tracker

[issue32665] pathlib.Path._from_parsed_parts should call cls.__new__(cls)

Pablo Galindo Salgado added the comment: Sorry, the exception of object.__new__(cls) is AttributeError: _drv -- ___ Python tracker

[issue32665] pathlib.Path._from_parsed_parts should call cls.__new__(cls)

Pablo Galindo Salgado added the comment: This behaviour is because "parent" descriptor ends calling: @classmethod def _from_parsed_parts(cls, drv, root, parts, init=True): self = object.__new__(cls) self._drv = drv self._root = root

[issue32622] Implement loop.sendfile

Change by Elvis Pranskevichus : -- pull_requests: +5211 ___ Python tracker ___ ___

[issue32622] Implement loop.sendfile

Change by Andrew Svetlov : -- pull_requests: +5210 ___ Python tracker ___ ___

[issue32513] dataclasses: make it easier to use user-supplied special methods

Change by Eric V. Smith : -- keywords: +patch pull_requests: +5209 ___ Python tracker ___

[issue32622] Implement loop.sendfile

Yury Selivanov added the comment: New changeset b1a6ac4c4026d648b3d948945b734a4d0f175a3c by Yury Selivanov in branch 'master': bpo-32622: Enforce sendfile fallback policy for FALLBACK transports (#5364)

[issue32626] Subscript unpacking raises SyntaxError

Neil Girdhar added the comment: This came up already on python-ideas: https://groups.google.com/forum/#!topic/python-ideas/YOpT9fDQyFk I think this was an oversight, and I'm with Ben that it's unexpected. That said, this is usually the kind of thing that Guido likes

[issue32622] Implement loop.sendfile

Change by Yury Selivanov : -- pull_requests: +5208 ___ Python tracker ___ ___

[issue32622] Implement loop.sendfile

Change by Yury Selivanov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed type: -> enhancement ___ Python tracker

[issue17852] Built-in module _io can lose data from buffered files in reference cycles

Change by ppperry : -- title: Built-in module _io can lose data from buffered files at exit -> Built-in module _io can lose data from buffered files in reference cycles ___ Python tracker

[issue25095] test_httpservers hangs since Python 3.5

William Pickard added the comment: Alright, the PR is ready for review. -- ___ Python tracker ___

[issue17044] Implement PEP 422: Simple class initialisation hook

Cheryl Sabella added the comment: Since PEP 422 was withdrawn in favor of PEP 487, should this issue be closed? -- nosy: +csabella ___ Python tracker

[issue32206] Run modules with pdb

Mario Corchero added the comment: Hi Jason, thanks a lot! I’ll have a look to the bug you reported on Monday. Out for holidays atm ^^ -- ___ Python tracker

[issue32206] Run modules with pdb

Jason R. Coombs added the comment: Adopting the backport, I believe I've found a defect. I filed the defect with the backport as [backports.pdb 1](https://github.com/jaraco/backports.pdb/issues/1). Essentially, the issue is that `__package__` gets set to the module name

[issue32622] Implement loop.sendfile

New submission from Andrew Svetlov : New changeset 7c684073f951dd891021676ecfd86ffc18b8895e by Andrew Svetlov in branch 'master': bpo-32622: Implement loop.sendfile() (#5271) https://github.com/python/cpython/commit/7c684073f951dd891021676ecfd86ffc18b8895e

[issue31368] Add os.preadv() and os.pwritev()

YoSTEALTH added the comment: Thank you Pablo Galindo for your amazingly hard work. Also Victor Stinner for your guidance, thanks you :) -- ___ Python tracker

[issue32666] Valgrind documentation seems to need updating

Brett Cannon added the comment: I don't think there is anyone specific who maintains it. Just whomever wants to use it next and needs to fix it to make it work. -- ___ Python tracker

[issue25330] Docs for pkgutil.get_data inconsistent with semantics

Brett Cannon added the comment: Notice that the returning of None only has to do with searching for the *package*, not the *data file*. So I think the docs are still correct according to your example, Paul. -- ___ Python tracker

[issue32688] weird comment out line of code

Brett Cannon added the comment: I don't remember why that line was commented out to make the analyzer happy. -- ___ Python tracker

[issue32630] Migrate decimal to use PEP 567 context variables

Change by Yury Selivanov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue32630] Migrate decimal to use PEP 567 context variables

Yury Selivanov added the comment: New changeset f13f12d8daa587b5fcc66fe3ed1090a5dadab289 by Yury Selivanov in branch 'master': bpo-32630: Use contextvars in decimal (GH-5278) https://github.com/python/cpython/commit/f13f12d8daa587b5fcc66fe3ed1090a5dadab289 --

[issue32630] Migrate decimal to use PEP 567 context variables

Yury Selivanov added the comment: Thank you, Stefan. I've updated the PR with an asyncio+decimal test and run tests in refleak mode to make sure there's no regression there. If during the beta/rc period we see that contextvars isn't stable enough or something I'll

[issue8881] socket.getaddrinfo() should return named tuples

Cheryl Sabella added the comment: This one looks to be partly done due to #18720 and enums. >>> for item in socket.getaddrinfo(None, 0): ... print(item) ... (, , 6, '', ('::1', 0, 0, 0)) (, , 17, '', ('::1', 0, 0, 0)) (, , 0, '', ('::1', 0, 0, 0)) (, , 6, '',

[issue32436] Implement PEP 567

Yury Selivanov added the comment: New changeset bc4123b0b380edda774b8bff2fa1bcc96453b440 by Yury Selivanov in branch 'master': bpo-32436: Use PyThreadState_GET() in all hot paths (GH-5363) https://github.com/python/cpython/commit/bc4123b0b380edda774b8bff2fa1bcc96453b440

[issue32436] Implement PEP 567

Change by Yury Selivanov : -- pull_requests: +5207 ___ Python tracker ___ ___

[issue32611] Tkinter taskbar icon (Windows)

Minion Jim added the comment: Please see the attached gif for a demonstration (I am using Windows 10 Home) -- Added file: https://bugs.python.org/file47413/tkinter glitch.gif ___ Python tracker

[issue32513] dataclasses: make it easier to use user-supplied special methods

Eric V. Smith added the comment: I'm completely burned out on it, too. I'll get the code checked in today, then update the PEP later. I don't really want to add all of this reasoning to the PEP, but I guess I should. I think the gist of it is correct, in any event. We can

[issue32513] dataclasses: make it easier to use user-supplied special methods

Guido van Rossum added the comment: If Nick says it's okay it is okay. I think it's okay too but my brain doesn't want to start up today -- I suggest not waiting for me. -- ___ Python tracker

[issue32687] wrong meaning of arg in Py_tracefunc doc

Change by Xiang Zhang : -- keywords: +patch pull_requests: +5206 stage: -> patch review ___ Python tracker ___

[issue31368] Add os.preadv() and os.pwritev()

STINNER Victor added the comment: New changeset 4defba3b95ec0f52ce75b8466831d30fb5d333f3 by Victor Stinner (Pablo Galindo) in branch 'master': bpo-31368: Expose preadv and pwritev in the os module (#5239)

[issue25095] test_httpservers hangs since Python 3.5

William Pickard added the comment: Ok, I found another way to apply the solution to this issue, that is by adding the "Connection" header (with value of "close") to the client's request instead of the server's response. I'm going to use this other method as the client

[issue32688] weird comment out line of code

Xiang Zhang added the comment: Sorry, forget links, it's https://github.com/python/cpython/blob/master/Python/ceval.c#L3528 , and the commit is b94767ff44edf5d461d7cb1c8eb5160f83886358. -- ___ Python tracker

[issue32688] weird comment out line of code

New submission from Xiang Zhang : I find one line[1] is weirdly commented out. But I don't think profile here is any different with trace. In 2.7, this line is not commented out and the change happens in b94767ff, fixing clang warnings. -- messages: 310866 nosy:

[issue32687] wrong meaning of arg in Py_tracefunc doc

New submission from Xiang Zhang : The meaning of arg for PyTrace_Line and PyTrace_CALL is wrong, it is not always NULL but always Py_None. -- assignee: docs@python components: Documentation messages: 310865 nosy: docs@python, xiang.zhang priority: normal severity:

[issue32649] complete C API doc debug and profile part with new PyTrace_OPCODE

Change by Xiang Zhang : -- keywords: +patch pull_requests: +5205 stage: -> patch review ___ Python tracker ___

[issue32621] Problem of consistency in collection.abc documentation

Change by ppperry : -- title: Problem of consistence in collection.abc documentation -> Problem of consistency in collection.abc documentation ___ Python tracker

[issue32630] Migrate decimal to use PEP 567 context variables

Stefan Krah added the comment: On Fri, Jan 26, 2018 at 11:11:00PM +, STINNER Victor wrote: > vstinner@apu$ ./python -m perf compare_to master.json pr5278.json > Mean +- std dev: [master] 1.86 us +- 0.03 us -> [pr5278] 2.27 us +- 0.04 us: > 1.22x slower (+22%) > >

[issue32532] improve sys.settrace and sys.setprofile documentation

Change by Xiang Zhang : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue32532] improve sys.settrace and sys.setprofile documentation

Xiang Zhang added the comment: New changeset 60da99b8e2f7bf497569ae4d6c218866575729bf by Xiang Zhang in branch 'master': bpo-32532: Improve documentation of settrace and setprofile (#5359) https://github.com/python/cpython/commit/60da99b8e2f7bf497569ae4d6c218866575729bf

[issue31399] Let OpenSSL verify hostname and IP address

Christian Heimes added the comment: New changeset 61d478c71c5341cdc54e6bfb4ace4252852fd972 by Christian Heimes in branch 'master': bpo-31399: Let OpenSSL verify hostname and IP address (#3462) https://github.com/python/cpython/commit/61d478c71c5341cdc54e6bfb4ace4252852fd972

[issue32686] python3.6.4 build with --enable-optimzations hangs on macOS 10.13

Ned Deily added the comment: That sounds like the problem documented in Issue32517. As a temporary workaround, try building without using --enable-optimazations. -- nosy: +ned.deily title: python3.6.4 install hangs -> python3.6.4 build with --enable-optimzations

[issue32532] improve sys.settrace and sys.setprofile documentation

Change by Xiang Zhang : -- keywords: +patch pull_requests: +5204 stage: needs patch -> patch review ___ Python tracker ___

[issue32686] python3.6.4 install hangs

7stud <7s...@excite.com> added the comment: My os is OSX 10.13.2 -- ___ Python tracker ___ ___

[issue32686] python3.6.4 install hangs

7stud <7s...@excite.com> added the comment: Oh, yeah, I'm using Python-3.6.4.tgz for the install. -- ___ Python tracker ___

[issue32686] python3.6.4 install hangs

New submission from 7stud <7s...@excite.com>: I tried to install python3.6.4 on OSX 10.13.2. I followed the Build Instructions in the README.rst: ./configure make make test sudo make install After ./configure step, the end of the output said: --- If you want a release build

[issue32685] Erroneous suggestion in print statement

Nick Coghlan added the comment: Re-reading the code for _set_legacy_print_statement_msg, I noticed that we're not currently taking the "start" parameter into account, and that's the offset the compiler passes in to tell us where on the line it found the text "print ".

[issue31853] Use super().method instead of socket.method in SSLSocket

Change by Christian Heimes : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___

[issue31853] Use super().method instead of socket.method in SSLSocket

Christian Heimes added the comment: New changeset 746cc75541f31278864a10b995e7d009bd2ff053 by Christian Heimes (Mads Jensen) in branch 'master': bpo-31853: Replaced socket.method calls with super() in SSLSocket. (#4048)

[issue32685] Erroneous suggestion in print statement

Sanyam Khurana added the comment: Thanks for the report Mayank! As we discussed offline, it is indeed reproducible if someone uses `print` on the same line (such as in this case, where a loop is used). I will look into this issue. --

  1   2   >