[issue33018] Improve issubclass() error checking and message

New submission from Joshua Bronson : Creating this issue by request of INADA Naoki to discuss my proposed patch in https://github.com/python/cpython/pull/5944. Copy/pasting from that PR: If you try something like issubclass('not a class', str), you get a helpful error

[issue32999] issubclass(obj, abc.ABC) causes a segfault

Change by Joshua Bronson : -- nosy: +jab ___ Python tracker ___ ___ Python-bugs-list

[issue32999] issubclass(obj, abc.ABC) causes a segfault

Change by INADA Naoki : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue30008] OpenSSL 1.1.0 deprecated functions

Change by devurandom : -- nosy: +devurandom ___ Python tracker ___ ___ Python-bugs-list

[issue32999] issubclass(obj, abc.ABC) causes a segfault

miss-islington added the comment: New changeset d824b4e4afbe9cf02310e39b14402fb2aa271f8f by Miss Islington (bot) in branch '3.7': bpo-32999: Fix ABC.__subclasscheck__ crash (GH-6002)

[issue32999] issubclass(obj, abc.ABC) causes a segfault

Change by Joshua Bronson : -- pull_requests: +5780 ___ Python tracker ___ ___

[issue32999] issubclass(obj, abc.ABC) causes a segfault

Change by miss-islington : -- pull_requests: +5779 ___ Python tracker ___

[issue32999] issubclass(obj, abc.ABC) causes a segfault

INADA Naoki added the comment: New changeset fc7df0e664198cb05cafd972f190a18ca422989c by INADA Naoki in branch 'master': bpo-32999: Fix ABC.__subclasscheck__ crash (GH-6002) https://github.com/python/cpython/commit/fc7df0e664198cb05cafd972f190a18ca422989c --

[issue32969] Add more constants to zlib module

Change by Xiang Zhang : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue32969] Add more constants to zlib module

miss-islington added the comment: New changeset 7592c0a686a80b9fbe2e6d519a486aca58b3260b by Miss Islington (bot) in branch '3.6': bpo-32969: Expose some missing constants in zlib and fix the doc (GH-5988)

[issue32969] Add more constants to zlib module

miss-islington added the comment: New changeset c4d77a661138debbbe584b8b08410afc8719a9b1 by Miss Islington (bot) in branch '3.7': bpo-32969: Expose some missing constants in zlib and fix the doc (GH-5988)

[issue32969] Add more constants to zlib module

Change by miss-islington : -- pull_requests: +5778 ___ Python tracker ___

[issue32969] Add more constants to zlib module

Change by miss-islington : -- pull_requests: +5777 ___ Python tracker ___

[issue32969] Add more constants to zlib module

Xiang Zhang added the comment: New changeset bc3f2289b9007396bfb7f986bee477b6176c1822 by Xiang Zhang in branch 'master': bpo-32969: Expose some missing constants in zlib and fix the doc (GH-5988)

[issue33017] Special set-cookie setting will bypass Cookielib

New submission from LCatro : PoC (PHP Version): header('Set-Cookie: test=123; max-age=a'); // PoC 1 header('Set-Cookie: test=123; domain=;'); // PoC 2 header('Set-Cookie: test=123; version=a;'); // PoC 3 PoC 1 will trigger int() convert string to number from

[issue8840] truncate() semantics changed in 3.1.2

Change by A.M. Kuchling : -- keywords: +patch pull_requests: +5776 ___ Python tracker ___ ___

[issue32999] issubclass(obj, abc.ABC) causes a segfault

INADA Naoki added the comment: > BTW, do TypeErrors related to weak references deserve any treatment? Isn't it > a kind of coincidence that the error raised due to usage of WeakSet in > issubclass(obj, ABC) is what we expect? (Sorry, I'm not familiar with > WeakSets).

[issue33001] Buffer overflow vulnerability in os.symlink on Windows (CVE-2018-1000117)

Steve Dower added the comment: FYI, the CVE number for this issue is CVE-2018-1000117. -- title: Buffer overflow vulnerability in os.symlink on Windows -> Buffer overflow vulnerability in os.symlink on Windows (CVE-2018-1000117)

[issue22674] RFE: Add signal.strsignal(): string describing a signal

Change by Chris Rebert : -- nosy: +cvrebert ___ Python tracker ___ ___

[issue33016] nt._getfinalpathname may use uninitialized memory

Eryk Sun added the comment: The inconsistent use of VOLUME_NAME_NT and VOLUME_NAME_DOS was addressed incidentally in issue 29734, but that issue is primarily about the handle leaked when GetFinalPathNameByHandleW fails. That said, you've cleanly addressed the handle leak

[issue33016] nt._getfinalpathname may use uninitialized memory

Change by Alexey Izbyshev : -- keywords: +patch pull_requests: +5775 stage: -> patch review ___ Python tracker ___

[issue33016] nt._getfinalpathname may use uninitialized memory

New submission from Alexey Izbyshev : The first call of GetFinalPathNameByHandleW requests the required buffer size for the NT path (VOLUME_NAME_NT), while the second call receives the DOS path (VOLUME_NAME_DOS) in the allocated buffer. Usually, NT paths are longer than

[issue33010] os.path.isdir() returns True for broken directory symlinks or junctions

Eryk Sun added the comment: Thanks for the quick feedback and pushing back on this. We just have a broken mount point, unlike in Unix where it's a regular directory. so you're right to just query the basic info for all directory reparse points, without special-casing mount

[issue33000] IDLEX GUI consumes all RAM for scrollback buffer, uses 161Bytes / character stored

John Brearley added the comment: Hi Terry: The icon on my Win 7 desktop points to: "C:\WinPython\IDLEX (Python GUI).exe". This was part of the 430MB installer file WinPython-64bit-3.6.4.0Qt5b4.exe from https://sourceforge.net/projects/winpython. I attached a screen shot

[issue33010] os.path.isdir() returns True for broken directory symlinks or junctions

Alexey Izbyshev added the comment: Hmm, actually, my NFS example is probably bad. I've run an experiment, and stat() simply hangs in the case if the NFS server is down. -- ___ Python tracker

[issue33010] os.path.isdir() returns True for broken directory symlinks or junctions

Alexey Izbyshev added the comment: Thank you for the detailed response, Eryk! > A mount point is always a directory, even if the volume isn't currently > available. Do I understand correctly that you propose to additionally change os.path.exists() to return True for

[issue30235] Validate shutil supports path-like objects, update docs accordingly

Change by Marco Rougeth : -- keywords: +patch pull_requests: +5774 stage: test needed -> patch review ___ Python tracker ___

[issue32972] unittest.TestCase coroutine support

Yury Selivanov added the comment: > Doesn't that break when, for example, test methods are decorated with > unittest.mock.patch? No, it shouldn't break them if you wrap async methods carefully. Here's a metaclass that I wrote recently doing just that:

[issue32972] unittest.TestCase coroutine support

Petter S added the comment: > Also, I personally subclassed TestCase in many of my projects specifically to > add async support. To do that you have to use a metaclass to scan class' > namespace for 'async def' functions. Doesn't that break when, for example,

[issue29623] configparser.ConfigParser.read() does not accept Pathlib path as a single argument.

Change by Berker Peksag : -- pull_requests: -966 ___ Python tracker ___ ___

[issue29623] configparser.ConfigParser.read() does not accept Pathlib path as a single argument.

Change by Berker Peksag : -- pull_requests: -594 ___ Python tracker ___ ___

[issue32972] unittest.TestCase coroutine support

Yury Selivanov added the comment: > How is a separate base class better? :) It's very explicit that way. Also, I personally subclassed TestCase in many of my projects specifically to add async support. To do that you have to use a metaclass to scan class' namespace

[issue32972] unittest.TestCase coroutine support

Petter S added the comment: It's good to see others with the same idea as me. I just wrote https://github.com/python/cpython/pull/6005/commits/4d7e1837f235687c875e985e97701609fc1ac458 . In my opinion, there is no need for another test class. I completely agree

[issue33015] Fix function cast warning in thread_pthread.h

Change by Siddhesh Poyarekar : -- keywords: +patch pull_requests: +5773 stage: -> patch review ___ Python tracker ___

[issue33015] Fix function cast warning in thread_pthread.h

New submission from Siddhesh Poyarekar : The PyThread_start_new_thread function takes a void (*)(void *) as the function argument, which does not match with the pthread_create callback which has type void *(*)(void *). I've got a fix for this that adds a wrapper

[issue33009] Assertion failure in inspect.signature on unbound partialmethods

Change by Yury Selivanov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue33009] Assertion failure in inspect.signature on unbound partialmethods

miss-islington added the comment: New changeset 387a055261267f5fafd2c12eafef49759c94704f by Miss Islington (bot) in branch '3.6': bpo-33009: Fix inspect.signature() for single-parameter partialmethods. (GH-6004)

[issue33010] os.path.isdir() returns True for broken directory symlinks or junctions

Eryk Sun added the comment: Yes, it makes sense to call GetFileAttributes as the fast path, and then fall back on a slow path (i.e. create, query, close) for a directory reparse point. With GetFileInformationByHandleEx, the equivalent query is FileBasicInfo, which is

[issue33009] Assertion failure in inspect.signature on unbound partialmethods

miss-islington added the comment: New changeset 112f799666bac1bdbb320840d5fda3132255eb5e by Miss Islington (bot) in branch '3.7': bpo-33009: Fix inspect.signature() for single-parameter partialmethods. (GH-6004)

[issue4173] PDF documentation: long verbatim lines are cut off at right hand side

Cheryl Sabella added the comment: I just tested the PDF on the current version of the docs and this is no longer an issue. The original example given wraps correctly on the PDF output. -- nosy: +csabella resolution: -> works for me stage: -> resolved status: open

[issue32972] unittest.TestCase coroutine support

Zachary Ware added the comment: How is a separate base class better? :) Having a default coroutine runner on the standard TestCase means all you have to do to add async tests is tack an `async` onto the front of your method definition, and everything just works as it

[issue32388] Remove cross-version binary compatibility

Antoine Pitrou added the comment: Yes, let's retarget to 3.8. -- versions: +Python 3.8 -Python 3.7 ___ Python tracker ___

[issue32972] unittest.TestCase coroutine support

Yury Selivanov added the comment: > Instead of a separate base class, what about an overridable > `coroutine_runner` attribute that defaults to `asyncio.run`? How is that better? -- ___ Python tracker

[issue32972] unittest.TestCase coroutine support

Zachary Ware added the comment: Instead of a separate base class, what about an overridable `coroutine_runner` attribute that defaults to `asyncio.run`? -- nosy: +zach.ware ___ Python tracker

[issue33000] IDLEX GUI consumes all RAM for scrollback buffer, uses 161Bytes / character stored

Terry J. Reedy added the comment: I did not close either window before looking at the Task Manager number. Once your program is debugged, I cannot think of any advantage of running it through IDLE instead of directly with the Python interpreter. Since you repeat 'IDLEX' I

[issue32972] unittest.TestCase coroutine support

Yury Selivanov added the comment: I think the right approach would be to add an new base TestCase class: AsyncioTestCase. There other frameworks that have different event loop implementations, so we can't assume that an `async def` test should always be executed by

[issue32992] unittest: Automatically run coroutines in a loop

Yury Selivanov added the comment: This is a duplicate of issue 32972. Let's move the discussion there. -- resolution: -> duplicate stage: patch review -> resolved status: open -> closed superseder: -> unittest.TestCase coroutine support

[issue33009] Assertion failure in inspect.signature on unbound partialmethods

Change by miss-islington : -- pull_requests: +5772 ___ Python tracker ___

[issue33009] Assertion failure in inspect.signature on unbound partialmethods

Yury Selivanov added the comment: New changeset 8a387219bdfb6ee34928d6168ac42ca559f11c9a by Yury Selivanov in branch 'master': bpo-33009: Fix inspect.signature() for single-parameter partialmethods. (GH-6004)

[issue33009] Assertion failure in inspect.signature on unbound partialmethods

Change by miss-islington : -- pull_requests: +5771 ___ Python tracker ___

[issue32992] unittest: Automatically run coroutines in a loop

Yury Selivanov added the comment: I think the right approach would be to add an new base TestCase class: AsyncioTestCase. And you should use the `asyncio.run` function to run the coroutine. -- nosy: +yselivanov ___ Python

[issue32992] unittest: Automatically run coroutines in a loop

Change by Petter S : -- keywords: +patch pull_requests: +5770 stage: -> patch review ___ Python tracker ___

[issue31349] Embedded initialization ignores Py_SetProgramName()

Steve Dower added the comment: (That said, I didn't try again 3.7, so it may already be fixed there. But since we're still fixing problems with 3.6, we should do that one too.) -- ___ Python tracker

[issue31349] Embedded initialization ignores Py_SetProgramName()

Steve Dower added the comment: I just hit this myself (and embarrassingly, I recently touched this code everyone and forgot to fix this). Hopefully I get a chance to get to it, but patches are certainly welcome and I'll happily aim to get them into 3.6 onwards.

[issue33011] Embedded 3.6.4 distribution does not add script parent as sys.path[0]

Steve Dower added the comment: This is the intentional design of the embedded distribution. You need to update the ._pth file to include the directories that have files that are part of your app - it's not meant for running random scripts, that's the job of the normal

[issue33009] Assertion failure in inspect.signature on unbound partialmethods

Yury Selivanov added the comment: Yeah, that assertion needs to be tweaked a little bit. Created a PR. -- ___ Python tracker ___

[issue33009] Assertion failure in inspect.signature on unbound partialmethods

Change by Yury Selivanov : -- keywords: +patch pull_requests: +5769 stage: needs patch -> patch review ___ Python tracker ___

[issue33013] Underscore in str.format with x option

Cheryl Sabella added the comment: Thanks guys. I really thought I tried '{0:_x}'.format(123456789), but I guess I hadn't. Good to know that using format(123456879, '_x) is better. -- ___ Python tracker

[issue33014] Clarify doc string for str.isidentifier()

Sanyam Khurana added the comment: Hey David, I'm working on this issue. Will submit a PR in a while :) -- nosy: +CuriousLearner ___ Python tracker

[issue32642] add support for path-like objects in sys.path

Brett Cannon added the comment: 'make regen-all' should do it (but so will just running 'make -s -j' like any old build of CPython). On Mon, Mar 5, 2018, 12:43 Jay Yin, wrote: > > Jay Yin added the comment: > > I'm unsure how

[issue32991] AttributeError in doctest.DocTestFinder.find

Change by Jason R. Coombs : -- stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue33013] Underscore in str.format with x option

Eric V. Smith added the comment: The format specifier (here, 'x') always goes last. >>> '{0:_x}'.format(123456789) '75b_cd15' See https://docs.python.org/3/library/string.html#formatstrings for the details. Serhiy is correct that it's often easier to use format() instead

[issue33014] Clarify doc string for str.isidentifier()

New submission from David Beazley : This is a minor nit, but the doc string for str.isidentifier() states: Use keyword.iskeyword() to test for reserved identifiers such as "def" and "class". At first glance, I thought that it meant you'd do this (doesn't work):

[issue33013] Underscore in str.format with x option

Serhiy Storchaka added the comment: >>> format(123456789, '_x') '75b_cd15' -- nosy: +serhiy.storchaka resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker

[issue32999] issubclass(obj, abc.ABC) causes a segfault

Serhiy Storchaka added the comment: Could you please show examples with __suclasscheck__ returning True for non-class objects? -- ___ Python tracker

[issue32991] AttributeError in doctest.DocTestFinder.find

Jason R. Coombs added the comment: New changeset 5a0c3987abd6a71b4fadeb525477eb5f560e8514 by Jason R. Coombs (Miss Islington (bot)) in branch '3.7': bpo-32991: Restore expectation that inspect.getfile raises TypeError on namespace package (GH-5980) (GH-5997)

[issue20150] API change in string formatting with :s option should be documented in What's New.

Cheryl Sabella added the comment: I believe this has been added to the 3.4 What's New already: object.__format__() no longer accepts non-empty format strings, it now raises a TypeError instead. Using a non-empty string has been deprecated since Python 3.2. This change has

[issue33013] Underscore in str.format with x option

New submission from Cheryl Sabella : >From the doc >(https://docs.python.org/3/library/string.html#format-specification-mini-language): > The '_' option signals the use of an underscore for a thousands separator for > floating point presentation types and for integer

[issue33005] 3.7.0b2 Interpreter crash in dev mode (or with PYTHONMALLOC=debug) with 'python -X dev -c 'import os; os.fork()'

STINNER Victor added the comment: > Thank you! I can confirm that git commit > 31e2b76f7bbcb8278748565252767a8b7790ff27 on the 3.7 branch fixes the issue > for me. Cool. You can now continue your gevent tests using -X dev ;-) --

[issue33005] 3.7.0b2 Interpreter crash in dev mode (or with PYTHONMALLOC=debug) with 'python -X dev -c 'import os; os.fork()'

Jason Madden added the comment: Thank you! I can confirm that git commit 31e2b76f7bbcb8278748565252767a8b7790ff27 on the 3.7 branch fixes the issue for me. -- ___ Python tracker

[issue33000] IDLEX GUI consumes all RAM for scrollback buffer, uses 161Bytes / character stored

John Brearley added the comment: Hi Terry: I am exploring the value of a language specific editor and runtime environment. Its definitely a large step up from Windows Notepad and Gnome Gedit. Perhaps some notes in the IDLEX documentation regarding the development versus

[issue33008] urllib.request.parse_http_list incorrectly strips backslashes

Change by Ned Deily : -- nosy: +barry, orsenthil, r.david.murray ___ Python tracker ___ ___

[issue33005] 3.7.0b2 Interpreter crash in dev mode (or with PYTHONMALLOC=debug) with 'python -X dev -c 'import os; os.fork()'

STINNER Victor added the comment: Thanks Jason Madden for your bug report! I should now be fixed. You might want to try the 3.7 or master branch until the next 3.7 release: PEP 537 ("3.7.0 beta 3: 2018-03-26"). -- resolution: -> fixed stage: patch review ->

[issue33005] 3.7.0b2 Interpreter crash in dev mode (or with PYTHONMALLOC=debug) with 'python -X dev -c 'import os; os.fork()'

miss-islington added the comment: New changeset 31e2b76f7bbcb8278748565252767a8b7790ff27 by Miss Islington (bot) in branch '3.7': bpo-33005: Fix _PyGILState_Reinit() (GH-6001)

[issue33005] 3.7.0b2 Interpreter crash in dev mode (or with PYTHONMALLOC=debug) with 'python -X dev -c 'import os; os.fork()'

Change by miss-islington : -- pull_requests: +5768 ___ Python tracker ___

[issue33005] 3.7.0b2 Interpreter crash in dev mode (or with PYTHONMALLOC=debug) with 'python -X dev -c 'import os; os.fork()'

STINNER Victor added the comment: New changeset 5d92647102fac9e116b98ab8bbc632eeed501c34 by Victor Stinner in branch 'master': bpo-33005: Fix _PyGILState_Reinit() (#6001) https://github.com/python/cpython/commit/5d92647102fac9e116b98ab8bbc632eeed501c34 --

[issue32958] socket module calls with long host names can fail with idna codec error

Matt Eaton added the comment: Using Ubuntu 16.04 with the 3.6.0 tag I was also able to reproduce the same error reported: import socket h = "0123456789012345678901234567890123456789012345678901234567890123.example.com" socket.gethostbyname(h) Traceback (most recent

[issue32999] issubclass(obj, abc.ABC) causes a segfault

Alexey Izbyshev added the comment: OK, making a new implementation behave as the old one is fine with me too. BTW, do TypeErrors related to weak references deserve any treatment? Isn't it a kind of coincidence that the error raised due to usage of WeakSet in

[issue32999] issubclass(obj, abc.ABC) causes a segfault

Ivan Levkivskyi added the comment: Actually, the behaviour when __suclasscheck__ returns True for non-class objects may be used by some code. Even typing module did this, I tried to remove as much as possible of this, but I think there may be few such situations left.

[issue33012] Invalid function cast warnings with gcc 8 for METH_NOARGS

Charalampos Stratakis added the comment: We are getting hit by that quite often on Fedora, with the transition to gcc 8 and it creates unnecessary noise at our build logs. Thanks for working on that. When you sent your PR I can test it within our build system and verify

[issue33012] Invalid function cast warnings with gcc 8 for METH_NOARGS

Serhiy Storchaka added the comment: Argument Clinic generates the following declaration for the second parameter of METH_NOARGS functions: PyObject *Py_UNUSED(ignored) It would be nice to follow the same style. If the first parameter is of type PyObject*

[issue32999] issubclass(obj, abc.ABC) causes a segfault

Change by INADA Naoki : -- keywords: +patch pull_requests: +5767 stage: -> patch review ___ Python tracker ___

[issue33005] 3.7.0b2 Interpreter crash in dev mode (or with PYTHONMALLOC=debug) with 'python -X dev -c 'import os; os.fork()'

STINNER Victor added the comment: This bug is likely a regression on my work on Py_Main(): see bpo-32030. I proposed a fix: see attached PR 6001. -- ___ Python tracker

[issue33012] Invalid function cast warnings with gcc 8 for METH_NOARGS

New submission from Siddhesh Poyarekar : gcc 8 has added a new warning heuristic to detect invalid function casts and a stock python build seems to hit that warning quite often. The most common is the cast of a METH_NOARGS function (that uses just one argument)

[issue33005] 3.7.0b2 Interpreter crash in dev mode (or with PYTHONMALLOC=debug) with 'python -X dev -c 'import os; os.fork()'

Change by STINNER Victor : -- keywords: +patch pull_requests: +5766 stage: -> patch review ___ Python tracker ___

[issue33011] Embedded 3.6.4 distribution does not add script parent as sys.path[0]

Change by Cong Monkey : -- components: +Windows nosy: +paul.moore, steve.dower, tim.golden, zach.ware type: -> behavior ___ Python tracker

[issue33011] Embedded 3.6.4 distribution does not add script parent as sys.path[0]

New submission from Cong Monkey : Embedded 3.6.0 distribution does not insert script parent in sys.path[0], but the normal python do it. this make some failed, like when I try to do pip install future, it will failed as import src.future failed, which works for normal

[issue32911] Doc strings no longer stored in body of AST

INADA Naoki added the comment: There are no enough +1 for merging GH-5927 yet on the ML discussion. https://mail.python.org/pipermail/python-dev/2018-February/152311.html @Mark.Shannon, would you comment your opinion to the ML thread? For now, I don't want to break

[issue33010] os.path.isdir() returns True for broken directory symlinks or junctions

New submission from Alexey Izbyshev : os.path.isdir() violates its own documentation by returning True for broken directory symlinks or junctions, for which os.path.exists() returns False: >>> os.mkdir('b') >>> import _winapi >>> _winapi.CreateJunction('b', 'a') >>>

[issue29708] support reproducible Python builds

Alexandru Ardelean added the comment: Yeah, I also see it with 3.6.4. I wanted to try 3.7 to see if it's fixed by chance. Otherwise I may have to start digging deep into compilation logic. Looking here: https://tests.reproducible-builds.org/lede/lede_ar71xx.html More

[issue29708] support reproducible Python builds

Will Thompson added the comment: For what it's worth, in Endless OS we still saw slight variations between builds in the .pyc files, even with all the source files' mtimes set to the epoch (ie. equivalent to setting & supporting SOURCE_DATE_EPOCH, I believe). Looking

[issue33002] Making a class formattable as hex/oct integer with printf-style formatting requires both __int__ and __index__ for no good reason

Mark Dickinson added the comment: Agreed that this seems wrong. -- nosy: +eric.smith, mark.dickinson ___ Python tracker ___

[issue33009] Assertion failure in inspect.signature on unbound partialmethods

Serhiy Storchaka added the comment: This is not a crash, but an assertion failure. The assertion was added in issue30149. -- nosy: +serhiy.storchaka, yselivanov stage: -> needs patch title: inspect.signature crashes on unbound partialmethods -> Assertion