[issue34207] test_cmd_line test_utf8_mode test_warnings fail in all FreeBSD 3.x (3.8) buildbots

2018-08-23 Thread STINNER Victor
STINNER Victor added the comment: I confirm that "LC_ALL= LANG= LC_CTYPE= ./python -m test -v test_cmd_line -m test_non_ascii" fails on FreeBSD on the master branch, whereas it pass before commit d19d8d5279f156bc8f6736b5f16f069879b9519b. This commit introduced the regression. Thanks for

[issue34170] Py_Initialize(): computing path configuration must not have side effect (PEP 432)

2018-08-23 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +8342 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34207] test_cmd_line test_utf8_mode test_warnings fail in all FreeBSD 3.x (3.8) buildbots

2018-08-23 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +8341 stage: -> patch review ___ Python tracker ___ ___

[issue6700] inspect.getsource() returns incorrect source lines at the module level

2018-08-23 Thread Tal Einat
Change by Tal Einat : -- versions: +Python 2.7 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34436] Overallocation is never disabled in _PyBytes_FormatEx()

2018-08-23 Thread Alexey Izbyshev
Alexey Izbyshev added the comment: Thank you for benchmarking and merging, Victor! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue34423] Overflow when casting from double to time_t, and_PyTime_t.

2018-08-23 Thread STINNER Victor
STINNER Victor added the comment: I'm not sure that the pytime.c change in commit a853a8ba7850381d49b284295dd6f0dc491dbe44 is correct: diff --git a/Python/pytime.c b/Python/pytime.c index 8979adc219..f3c913226c 100644 --- a/Python/pytime.c +++ b/Python/pytime.c @@ -276,7 +278,6 @@ static int

[issue6700] inspect.getsource() returns incorrect source lines at the module level

2018-08-23 Thread Tal Einat
Change by Tal Einat : -- versions: +Python 3.8 -Python 3.5 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34423] Overflow when casting from double to time_t, and_PyTime_t.

2018-08-23 Thread STINNER Victor
STINNER Victor added the comment: It seems like a regression introduced by: commit a853a8ba7850381d49b284295dd6f0dc491dbe44 Author: Benjamin Peterson Date: Thu Sep 7 11:13:59 2017 -0700 bpo-31373: fix undefined floating-point demotions (#3396) --

[issue34436] Overallocation is never disabled in _PyBytes_FormatEx()

2018-08-23 Thread miss-islington
miss-islington added the comment: New changeset 945771b3c7a08f0b2b875905d517a1566477bfaf by Miss Islington (bot) in branch '3.6': bpo-34436: Fix check that disables overallocation for the last fmt specifier (GH-8826)

[issue34436] Overallocation is never disabled in _PyBytes_FormatEx()

2018-08-23 Thread miss-islington
miss-islington added the comment: New changeset 042082692b7fab7361a8c9d0fb792532bb77e293 by Miss Islington (bot) in branch '3.7': bpo-34436: Fix check that disables overallocation for the last fmt specifier (GH-8826)

[issue34436] Overallocation is never disabled in _PyBytes_FormatEx()

2018-08-23 Thread miss-islington
Change by miss-islington : -- pull_requests: +8340 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34436] Overallocation is never disabled in _PyBytes_FormatEx()

2018-08-23 Thread STINNER Victor
STINNER Victor added the comment: New changeset ccd99752675042bd5f67d332c5b0ed85ba1f2da3 by Victor Stinner (Alexey Izbyshev) in branch 'master': bpo-34436: Fix check that disables overallocation for the last fmt specifier (GH-8826)

[issue34436] Overallocation is never disabled in _PyBytes_FormatEx()

2018-08-23 Thread miss-islington
Change by miss-islington : -- pull_requests: +8339 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34436] Overallocation is never disabled in _PyBytes_FormatEx()

2018-08-23 Thread STINNER Victor
STINNER Victor added the comment: I ran a microbenchmark on PR 8826: ./python -m perf timeit -s 'fmt=b"%s%s"; args=(b"1", b"x"*(1024*1024))' 'fmt % args' -v -o patch.json $ python3 -m perf compare_to ref.json patch.json Mean +- std dev: [ref] 325 us +- 7 us -> [patch] 36.2 us +- 1.1 us:

[issue34436] Overallocation is never disabled in _PyBytes_FormatEx()

2018-08-23 Thread STINNER Victor
STINNER Victor added the comment: bytes % args has been optimized using the _PyBytesWriter API in bpo-25349: commit fa7762ec066aa3632a25b6a52bb7597b8f17c2f3. I converted my old benchmark from bpo-25349 to my new perf module:

<    1   2