[issue35226] mock.call equality surprisingly broken

2018-11-27 Thread Chris Withers
Chris Withers added the comment: Éric, doesn't look like I can add labels, what needs to happen for me to do so? (I was/am a core developer, just an extremely inactive one ;-), but happy to jump through whatever hoops necessary... ) -- ___ Python

[issue35334] urllib3 fails with type error exception, when cannot reach PyPI - urllib3.util.retry

2018-11-27 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: I think this is an issue with pip specifically with Ubuntu/Debian packaging causing the error. Please see https://github.com/pypa/pip/issues/3943, https://github.com/pypa/pip/issues/4779 and https://answers.launchpad.net/ubuntu/+question/659285 .

[issue35335] msgfmt should be able to merge more than one po file

2018-11-27 Thread s-ball
New submission from s-ball : GNU gettext msgfmt can merge several po files into one single mo file. The current version of msgfmt can only compile one po file to one mo file. After looking at the code, the enhancement should be simple to implement. Command line: if one output file is given

[issue35334] urllib3 fails with type error exception, when cannot reach PyPI - urllib3.util.retry

2018-11-27 Thread Arno-Can Uestuensoez
New submission from Arno-Can Uestuensoez : Hi, I am using the installation script *adafruit-pitft.sh* which tries to apply *urllib3* which itself tries to install nested dependencies, here *evdev* from PyPI. When the installation is offline - e.g. by internal mirror of debian/raspbian - PyPI

[issue28608] Support creating hardlink using `pathlib`

2018-11-27 Thread Alexandr Zamaraev
New submission from Alexandr Zamaraev : see https://python-forum.io/Thread-makin-hardlinks-with-pathlib-Path?pid=57399#pid57399 -- ___ Python tracker ___

[issue28608] Support creating hardlink using `pathlib`

2018-11-27 Thread Alexandr Zamaraev
Change by Alexandr Zamaraev : -- nosy: +shura_zam ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34100] Same constants in tuples are not merged while compile()

2018-11-27 Thread INADA Naoki
INADA Naoki added the comment: I agree that modifying tuple is bad idea in general case. But in case of constants, in-place modify is the easiest approach. Our purpose is "merging" constant. On the other hand, "build new tuple and replace old tuple" approach makes two same constant tuples.

[issue35322] test_datetime leaks memory on Windows

2018-11-27 Thread STINNER Victor
STINNER Victor added the comment: Oh, I see. unicode_encode_locale() has multiple bugs in the code handling errors :-( I don't think that my commit 3d4226a832cabc630402589cc671cc4035d504e5 introduced the memory leak triggered by test_datetime, it seems older. Python 3.7 also has the bug in

[issue34523] Choose the filesystem encoding before Python initialization (add _PyCoreConfig.filesystem_encoding)

2018-11-27 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +10006 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35322] test_datetime leaks memory on Windows

2018-11-27 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +10007 stage: -> patch review ___ Python tracker ___ ___

[issue23078] unittest.mock patch autospec doesn't work on staticmethods

2018-11-27 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the pings. I will work on this issue this weekend. Note that 3.4 and 3.5 are in security-fix-only mode now, so I removed them from the versions field. -- assignee: -> berker.peksag versions: -Python 3.4, Python 3.5

[issue23078] unittest.mock patch autospec doesn't work on staticmethods

2018-11-27 Thread John Parejko
John Parejko added the comment: Adding to the list of "I just ran into this". The patch submitted by fov seems straightforward enough: what can we do to help shepherd it along? -- nosy: +John Parejko2 ___ Python tracker

[issue33676] test_multiprocessing_fork: dangling threads warning

2018-11-27 Thread STINNER Victor
STINNER Victor added the comment: I *hope* that it will be enough :-/ -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.6, Python 3.8 ___ Python tracker

[issue33676] test_multiprocessing_fork: dangling threads warning

2018-11-27 Thread miss-islington
miss-islington added the comment: New changeset dd5293871703e6a12ffdde14eeaa86a73b7b0d99 by Miss Islington (bot) in branch '3.6': bpo-33676: Fix dangling thread in _test_multiprocessing (GH-10755) https://github.com/python/cpython/commit/dd5293871703e6a12ffdde14eeaa86a73b7b0d99 --

[issue33676] test_multiprocessing_fork: dangling threads warning

2018-11-27 Thread miss-islington
miss-islington added the comment: New changeset 80db40cdd6a58c9d66694a43ee9a7c06ab958373 by Miss Islington (bot) in branch '3.7': bpo-33676: Fix dangling thread in _test_multiprocessing (GH-10755) https://github.com/python/cpython/commit/80db40cdd6a58c9d66694a43ee9a7c06ab958373 --

[issue33676] test_multiprocessing_fork: dangling threads warning

2018-11-27 Thread miss-islington
Change by miss-islington : -- pull_requests: +10005 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33676] test_multiprocessing_fork: dangling threads warning

2018-11-27 Thread miss-islington
Change by miss-islington : -- pull_requests: +10004 stage: resolved -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue33676] test_multiprocessing_fork: dangling threads warning

2018-11-27 Thread STINNER Victor
STINNER Victor added the comment: New changeset b7278736b3ae158a7738057e3045bc767ced019e by Victor Stinner in branch 'master': bpo-33676: Fix dangling thread in _test_multiprocessing (GH-10755) https://github.com/python/cpython/commit/b7278736b3ae158a7738057e3045bc767ced019e --

[issue35333] Rename private structs to use names closer to types

2018-11-27 Thread STINNER Victor
Change by STINNER Victor : -- nosy: +nascheme, serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue35333] Rename private structs to use names closer to types

2018-11-27 Thread STINNER Victor
New submission from STINNER Victor : To prevent a compiler warning/error (on clang), I had modify Include/object.h and Include/pystate.h: * Replace "PyTypeObject" with "struct _typeobject" * Replace "PyInterpreterState" with "struct _is" * Replace "PyThreadState" with "struct _ts" => see

[issue33930] Segfault with deep recursion into object().__dir__

2018-11-27 Thread Ronald Oussoren
Ronald Oussoren added the comment: I don’t understand this either. For some reason the patch works when using the function and not when using the macro. I haven’t looked into this yet, and am currently traveling. I should have time to look into this starting December 5th when I’m back

[issue34855] batch file variables

2018-11-27 Thread Steve Dower
Steve Dower added the comment: Yep, good catch. That should be EXTERNALS_DIR in PCbuild/find_python.bat. -- components: +Windows keywords: +easy nosy: +paul.moore, steve.dower, tim.golden, zach.ware versions: +Python 3.6, Python 3.7 ___ Python

[issue35319] pkgutil.get_data() is a wrapper for a deprecated class

2018-11-27 Thread Brett Cannon
Brett Cannon added the comment: You can use importlib.resources to read data files and such from within a package as an alternative. -- nosy: +brett.cannon ___ Python tracker

[issue33676] test_multiprocessing_fork: dangling threads warning

2018-11-27 Thread STINNER Victor
STINNER Victor added the comment: The bug is still alive: https://buildbot.python.org/all/#/builders/168/builds/294 I found a bug using attached mp_debug.patch. I wrote PR 10755 to try to fix it. I have access to FreeBSD CURRENT buildbot. I only reproduced the bug once using: ./python -m

[issue35320] Writable __spec__.has_location attribute

2018-11-27 Thread Brett Cannon
Brett Cannon added the comment: The docs do not specify that has_location is read-only: https://docs.python.org/3/library/importlib.html#importlib.machinery.ModuleSpec.has_location . And PEPs are not updated once they are implemented as that would mean we would have to perpetually update

[issue35321] None _frozen_importlib.__spec__.origin attribute

2018-11-27 Thread Brett Cannon
Brett Cannon added the comment: I can replicate. Do note, though, that PEPs are not documentation once they are implemented; at that point the official docs are what should be followed. -- components: +Interpreter Core -Library (Lib) nosy: -docs@python stage: -> test needed type:

[issue33676] test_multiprocessing_fork: dangling threads warning

2018-11-27 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +10003 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35134] Add a new Include/cpython/ subdirectory for the "CPython API" with implementation details

2018-11-27 Thread STINNER Victor
STINNER Victor added the comment: New changeset 9bdd2de84c1af55fbc006d3f892313623bd0195c by Victor Stinner in branch 'master': bpo-35134: Don't define types twice in header files (GH-10754) https://github.com/python/cpython/commit/9bdd2de84c1af55fbc006d3f892313623bd0195c --

[issue35134] Add a new Include/cpython/ subdirectory for the "CPython API" with implementation details

2018-11-27 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +10002 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35134] Add a new Include/cpython/ subdirectory for the "CPython API" with implementation details

2018-11-27 Thread STINNER Victor
STINNER Victor added the comment: Oh cpython/pystate.h introduced this warning, when building Python with clang in release mode: In file included from Parser/node.c:3: In file included from ./Include/Python.h:107: In file included from ./Include/traceback.h:8: In file included from

[issue35240] Travis CI: xvfb-run: error: Xvfb failed to start

2018-11-27 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +10001 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35240] Travis CI: xvfb-run: error: Xvfb failed to start

2018-11-27 Thread STINNER Victor
STINNER Victor added the comment: "make doctest" has been added by commit 859c068e52a31e13e2b9bb6a3f861fa8c290cb0e of bpo-34962. -- ___ Python tracker ___

[issue35240] Travis CI: xvfb-run: error: Xvfb failed to start

2018-11-27 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +1 stage: -> patch review ___ Python tracker ___ ___

[issue35330] When using mock to wrap an existing object, side_effect requires return_value

2018-11-27 Thread Raymond Hettinger
Change by Raymond Hettinger : -- nosy: +lisroach ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35317] test_email: test_localtime_daylight_false_dst_true() fails depending on the timezone

2018-11-27 Thread STINNER Victor
STINNER Victor added the comment: Python 2.7 doesn't seem to be affected: $ TZ=UTC ./python -m test -v test_email Tests result: SUCCESS -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.6, Python 3.7

[issue35332] shutil.rmtree(..., ignore_errors=True) doesn't ignore errors from os.close()

2018-11-27 Thread Ronal Abraham
New submission from Ronal Abraham : These lines throw intermittently for me on AIX when removing a directory on NFS (python version 3.6.6-1), even when "ignore_errors=True": https://github.com/python/cpython/blob/v3.6.6rc1/Lib/shutil.py#L433

[issue33012] Invalid function cast warnings with gcc 8 for METH_NOARGS

2018-11-27 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Only one function cast warning is left, and it is a separate issue: issue33015. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue33012] Invalid function cast warnings with gcc 8 for METH_NOARGS

2018-11-27 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 1c607155c9e363489036ae6258b165a3fae75134 by Serhiy Storchaka in branch 'master': bpo-33012: Fix more invalid function cast warnings with gcc 8. (GH-10751) https://github.com/python/cpython/commit/1c607155c9e363489036ae6258b165a3fae75134

[issue33029] Invalid function cast warnings with gcc 8 for getter and setter functions

2018-11-27 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I have done this. Thank you for reporting about this issue. I don't have enough motivation for making a backport for 2.7. If someone want to do this, a PR is welcome. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed

[issue33012] Invalid function cast warnings with gcc 8 for METH_NOARGS

2018-11-27 Thread miss-islington
miss-islington added the comment: New changeset d5c8bd8e4cc04873254f0bd38895a6479c23c8aa by Miss Islington (bot) in branch '3.6': bpo-33012: Fix signatures of METH_NOARGS functions. (GH-10736) (GH-10748) https://github.com/python/cpython/commit/d5c8bd8e4cc04873254f0bd38895a6479c23c8aa

[issue33012] Invalid function cast warnings with gcc 8 for METH_NOARGS

2018-11-27 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: + ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35328] Set a environment variable for venv prompt

2018-11-27 Thread Baptiste Darthenay
Baptiste Darthenay added the comment: How the venv prompt name would be displayed in a project like Powerline? Or in VS Code? https://i.ibb.co/JHYrnk2/Screenshot-from-2018-11-27-19-41-47.png Or in my custom prompt?

[issue35312] lib2to3.pgen2.parse.ParseError is not roundtrip pickleable

2018-11-27 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset c57e6e2e52d5d8b4005753bed789d99ebe407fb6 by Serhiy Storchaka (Anthony Sottile) in branch 'master': bpo-35312: Make lib2to3.pgen2.parse.ParseError round-trip pickle-able. (GH-10710)

[issue33029] Invalid function cast warnings with gcc 8 for getter and setter functions

2018-11-27 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 29d2f3c47280f05795c9d4d70f4018cb1488f0ab by Serhiy Storchaka in branch '3.6': [3.6] bpo-33029: Fix signatures of getter and setter functions. (GH-10746) (GH-10749)

[issue33012] Invalid function cast warnings with gcc 8 for METH_NOARGS

2018-11-27 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset ad8ac54aa3d2323bdb5feb5e858a922840358187 by Serhiy Storchaka in branch '3.7': bpo-33012: Fix signatures of METH_NOARGS functions. (GH-10736) (GH-10748) https://github.com/python/cpython/commit/ad8ac54aa3d2323bdb5feb5e858a922840358187

[issue33012] Invalid function cast warnings with gcc 8 for METH_NOARGS

2018-11-27 Thread miss-islington
Change by miss-islington : -- pull_requests: +9998 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35331] Incorrect __module__ attribute for _struct.Struct and perhaps a few others

2018-11-27 Thread Dan Snider
New submission from Dan Snider : _struct.Struct not defining a valid __module__ by prefixing its tp_name slot with "_struct" is inconsistent with every other extension type which is available in the corresponding module globals. >From the documentation of the `tp_name` slot: Pointer to a

[issue35328] Set a environment variable for venv prompt

2018-11-27 Thread Anthony Sottile
Anthony Sottile added the comment: The current prompt works fine for me on zsh -- what's the bug here? zsh $ virtualenv venv --prompt '(wat)' Using real prefix '/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7' New python executable in /private/tmp/venv/bin/python3.7

[issue33029] Invalid function cast warnings with gcc 8 for getter and setter functions

2018-11-27 Thread miss-islington
miss-islington added the comment: New changeset 5ceb7018dc63fab96f81d05e62bbe704e9f10cb9 by Miss Islington (bot) in branch '3.7': bpo-33029: Fix signatures of getter and setter functions. (GH-10746) https://github.com/python/cpython/commit/5ceb7018dc63fab96f81d05e62bbe704e9f10cb9

[issue33029] Invalid function cast warnings with gcc 8 for getter and setter functions

2018-11-27 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +9997 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33012] Invalid function cast warnings with gcc 8 for METH_NOARGS

2018-11-27 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +9996 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33029] Invalid function cast warnings with gcc 8 for getter and setter functions

2018-11-27 Thread miss-islington
Change by miss-islington : -- pull_requests: +9995 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33029] Invalid function cast warnings with gcc 8 for getter and setter functions

2018-11-27 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset d4f9cf5545d6d8844e0726552ef2e366f5cc3abd by Serhiy Storchaka in branch 'master': bpo-33029: Fix signatures of getter and setter functions. (GH-10746) https://github.com/python/cpython/commit/d4f9cf5545d6d8844e0726552ef2e366f5cc3abd

[issue35330] When using mock to wrap an existing object, side_effect requires return_value

2018-11-27 Thread Noam Yorav-Raphael
New submission from Noam Yorav-Raphael : When using mock to wrap an existing object, and using side_effect to set a function to wrap a method, I would expect the wrapper function to be called instead of the wrapped function, and its return value to be returned. Instead, both the wrapper

[issue35326] ctypes cast and from_address cause crash on Windows 10

2018-11-27 Thread Eryk Sun
Eryk Sun added the comment: The default function result type is c_int, which truncates a 64-bit pointer to 32-bit. The attribute that needs to be set is singular restype, not plural restypes. Unfortunately ctypes objects have a dict, so you're not catching the typo in an obvious way.

[issue31512] Add non-elevated symlink support for dev mode Windows 10

2018-11-27 Thread Vidar Fauske
Vidar Fauske added the comment: Thanks! I addressed the comment, so hopefully this should be OK now. -- ___ Python tracker ___ ___

[issue33029] Invalid function cast warnings with gcc 8 for getter and setter functions

2018-11-27 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +9994 stage: needs patch -> patch review ___ Python tracker ___ ___

[issue35329] Documentation - capitalization issue

2018-11-27 Thread Hans Strijker
New submission from Hans Strijker : In the documentation I noticed "from Package import specific_submodule". I recon package should be all lowercase in accordance with pep8. (https://www.python.org/dev/peps/pep-0008/#package-and-module-names) It may be far from the most important bug ever,

[issue33029] Invalid function cast warnings with gcc 8 for getter and setter functions

2018-11-27 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- assignee: -> serhiy.storchaka versions: +Python 3.6, Python 3.7 ___ Python tracker ___ ___

[issue35322] test_datetime leaks memory on Windows

2018-11-27 Thread Alexey Izbyshev
Alexey Izbyshev added the comment: Correction: the fall-through in "else if (res == -3)" clause doesn't cause a memory leak, but still results in usage of uninitialized 'str'. -- ___ Python tracker

[issue35328] Set a environment variable for venv prompt

2018-11-27 Thread Baptiste Darthenay
Change by Baptiste Darthenay : -- keywords: +patch pull_requests: +9992 stage: -> patch review ___ Python tracker ___ ___

[issue34482] datetime: Tests for potential crashes due to non-UTF-8-encodable strings

2018-11-27 Thread Alexey Izbyshev
Alexey Izbyshev added the comment: The added test exposed a leak in unicode_encode_locale(). See msg330534. -- ___ Python tracker ___

[issue35322] test_datetime leaks memory on Windows

2018-11-27 Thread Alexey Izbyshev
Alexey Izbyshev added the comment: This is because of a leak of 'wstr' at https://github.com/python/cpython/blob/1005c84535191a72ebb7587d8c5636a065b7ed79/Objects/unicodeobject.c#L3476 . There is another leak and usage of uninitialized 'str' because the following "else if" clause doesn't

[issue35328] Set a environment variable for venv prompt

2018-11-27 Thread Baptiste Darthenay
New submission from Baptiste Darthenay : When creating a new virtual env with `python3 -m venv .venv --prompt env`, the prompt information is only used to set a temporary PS1. This information is lost when using custom prompt, for example with ZSH. I propose to set

[issue35227] [RFE] tarfile: support adding file objects without prior known size

2018-11-27 Thread Rémi Lapeyre
Rémi Lapeyre added the comment: I came across this thread while working on the PR, creating tarinfo as Lars Gustäbel suggests does not work since you still need to get the size before reading. Do you think the API should be different? -- ___

[issue35327] Using skipTest with subTest gives a misleading UI.

2018-11-27 Thread Rémi Lapeyre
Rémi Lapeyre added the comment: I think this is a nice output, taking a quick look at unittest source, all the information needed to display this is save in the TestResult object, showing skipped tests is done here: https://github.com/python/cpython/blob/master/Lib/unittest/runner.py#L85 It

[issue35327] Using skipTest with subTest gives a misleading UI.

2018-11-27 Thread Paul Ganssle
Paul Ganssle added the comment: @Rémi Interesting. Your suggested output does look clearer than the existing one, but it still doesn't indicate that anything *passed*. I think I like the way pytest does it the best, but if we can't expose the subtests as separate tests, I'd probably want it

[issue35327] Using skipTest with subTest gives a misleading UI.

2018-11-27 Thread Rémi Lapeyre
Rémi Lapeyre added the comment: Did you notice that `skipped 'Not supported'` will be displayed once per skipped subtest so changing your `for i in range(1, 3):` by `for i in range(1, 5):` will show: python3 -m unittest -v test_something (test2.SomeTest) ... skipped 'Not supported'

[issue35327] Using skipTest with subTest gives a misleading UI.

2018-11-27 Thread Paul Ganssle
Paul Ganssle added the comment: As "prior art" the way that pytest does this is to have parametrized tests show up as separate tests: import pytest @pytest.mark.parametrize("i", range(1, 3)) def test_something(i): if i > 1: pytest.skip('Not supported')

[issue35327] Using skipTest with subTest gives a misleading UI.

2018-11-27 Thread Paul Ganssle
New submission from Paul Ganssle : It seems that if you call skipTest *anywhere* in a test function, even in a subTest, the *entire* function gets marked as "skipped", even if only one sub-test is skipped. Example: import unittest class SomeTest(unittest.TestCase): def

[issue33012] Invalid function cast warnings with gcc 8 for METH_NOARGS

2018-11-27 Thread STINNER Victor
STINNER Victor added the comment: > New changeset 62be74290aca26d16f3f55ece7ff6dad14e60e8d by Serhiy Storchaka in > branch 'master': > bpo-33012: Fix invalid function cast warnings with gcc 8. (GH-6749) I still get something 100 warnings with GCC 8.2.1 on Fedora 29. I wrote PR 10744 to add

[issue33012] Invalid function cast warnings with gcc 8 for METH_NOARGS

2018-11-27 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +9991 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34022] 6 tests fail using SOURCE_DATE_EPOCH env var

2018-11-27 Thread Chih-Hsuan Yen
Chih-Hsuan Yen added the comment: Got it. Thanks for the pointer. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue34022] 6 tests fail using SOURCE_DATE_EPOCH env var

2018-11-27 Thread STINNER Victor
STINNER Victor added the comment: "What’s New In Python 3.7" mentions twice "build reproducibility": https://docs.python.org/dev/whatsnew/3.7.html -- ___ Python tracker ___

[issue34022] 6 tests fail using SOURCE_DATE_EPOCH env var

2018-11-27 Thread Chih-Hsuan Yen
Chih-Hsuan Yen added the comment: Looks like in https://github.com/python/cpython/pull/10327, Serhiy Storchaka considers fixing these issues for 3.8 only - "It is easier to skip the test on 3.7." and then remove the "needs backport to 3.7" label. How about changing the target version to 3.8

[issue34100] Same constants in tuples are not merged while compile()

2018-11-27 Thread STINNER Victor
STINNER Victor added the comment: merge_consts_recursive(): rather than modifying the 'key' tuple, would it make sense to *add* the new key to the cache? -- ___ Python tracker

[issue34100] Same constants in tuples are not merged while compile()

2018-11-27 Thread STINNER Victor
STINNER Victor added the comment: New changeset 1005c84535191a72ebb7587d8c5636a065b7ed79 by Victor Stinner in branch 'master': bpo-34100: Partially revert merge_consts_recursive() (GH-10743) https://github.com/python/cpython/commit/1005c84535191a72ebb7587d8c5636a065b7ed79 --

[issue33930] Segfault with deep recursion into object().__dir__

2018-11-27 Thread STINNER Victor
STINNER Victor added the comment: -_PyObject_GC_UNTRACK(m); +PyObject_GC_UnTrack(m); Can someone please explain me why this change has any impact? Does it mean that _PyObject_GC_UNTRACK() macro has a bug? The function is quite straighforward :-) void PyObject_GC_Track(void *op) {

[issue34100] Same constants in tuples are not merged while compile()

2018-11-27 Thread STINNER Victor
STINNER Victor added the comment: > New changeset c2e1607a51d7a17f143b5a34e8cff7c6fc58a091 by Miss Islington > (bot) (INADA Naoki) in branch 'master' This change introduced a lot of memory leaks (reference leaks): https://buildbot.python.org/all/#/builders/1/builds/422 The following change

[issue34100] Same constants in tuples are not merged while compile()

2018-11-27 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +9990 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33954] float.__format__('n') fails with _PyUnicode_CheckConsistency assertion error for locales with non-ascii thousands separator

2018-11-27 Thread STINNER Victor
STINNER Victor added the comment: Serhiy Storchaka: """ Objects/unicodeobject.c: In function ‘_PyUnicode_FastFill’: Objects/unicodeobject.c:10126:24: warning: passing argument 2 of ‘unicode_fill’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] """ Yeah, I was

[issue33954] float.__format__('n') fails with _PyUnicode_CheckConsistency assertion error for locales with non-ascii thousands separator

2018-11-27 Thread STINNER Victor
STINNER Victor added the comment: New changeset 54fa83e0a3f3b077763cb50705d7a7dbe4a40a4a by Victor Stinner in branch '3.6': bpo-33954: Rewrite FILL() macro of unicodeobject.c (GH-10740) https://github.com/python/cpython/commit/54fa83e0a3f3b077763cb50705d7a7dbe4a40a4a --

[issue33930] Segfault with deep recursion into object().__dir__

2018-11-27 Thread Gus Goulart
Gus Goulart added the comment: After a couple of rounds, this is the benchmark result I got for the attached patch. It seems to be a simple, non-performance degrading fix. python -m perf compare_to origin.json patch.json -G --min-speed=2 Slower (1): - sqlalchemy_declarative: 213 ms +- 4 ms

[issue35317] test_email: test_localtime_daylight_false_dst_true() fails depending on the timezone

2018-11-27 Thread miss-islington
miss-islington added the comment: New changeset b59fc311609aadaafaae68240127b4997b85859d by Miss Islington (bot) in branch '3.6': bpo-35317: Fix mktime() error in test_email (GH-10721) https://github.com/python/cpython/commit/b59fc311609aadaafaae68240127b4997b85859d --

[issue35317] test_email: test_localtime_daylight_false_dst_true() fails depending on the timezone

2018-11-27 Thread miss-islington
miss-islington added the comment: New changeset d669154ee52048f98ac63ba177f3fd1cf62f0174 by Miss Islington (bot) in branch '3.7': bpo-35317: Fix mktime() error in test_email (GH-10721) https://github.com/python/cpython/commit/d669154ee52048f98ac63ba177f3fd1cf62f0174 -- nosy:

[issue33029] Invalid function cast warnings with gcc 8 for getter and setter functions

2018-11-27 Thread Siddhesh Poyarekar
Siddhesh Poyarekar added the comment: Sorry I haven't had time to look into this since and it doesn't look like I'll be able to get to it in the next couple of weeks. I had a couple of patches in the github fork but they're pretty outdated and probably not even correct. If nobody gets to

[issue35134] Add a new Include/cpython/ subdirectory for the "CPython API" with implementation details

2018-11-27 Thread STINNER Victor
STINNER Victor added the comment: New changeset 480833808e918a1dcebbbcfd07d5a8de3c5c2a66 by Victor Stinner in branch 'master': bpo-35134: Update "make tags": add Include/cpython/ (GH-10739) https://github.com/python/cpython/commit/480833808e918a1dcebbbcfd07d5a8de3c5c2a66 --

[issue33954] float.__format__('n') fails with _PyUnicode_CheckConsistency assertion error for locales with non-ascii thousands separator

2018-11-27 Thread STINNER Victor
STINNER Victor added the comment: New changeset 7f9fb0f34555641722be5468b7fbd53dd3c0f1e2 by Victor Stinner in branch '3.7': bpo-33954: Rewrite FILL() macro of unicodeobject.c (GH-10738) https://github.com/python/cpython/commit/7f9fb0f34555641722be5468b7fbd53dd3c0f1e2 --

[issue35317] test_email: test_localtime_daylight_false_dst_true() fails depending on the timezone

2018-11-27 Thread miss-islington
Change by miss-islington : -- pull_requests: +9989 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33954] float.__format__('n') fails with _PyUnicode_CheckConsistency assertion error for locales with non-ascii thousands separator

2018-11-27 Thread STINNER Victor
STINNER Victor added the comment: New changeset 163403a63e9272fcd14707e344122c2e3c5e0244 by Victor Stinner in branch 'master': bpo-33954: Fix compiler warning in _PyUnicode_FastFill() (GH-10737) https://github.com/python/cpython/commit/163403a63e9272fcd14707e344122c2e3c5e0244 --

[issue35317] test_email: test_localtime_daylight_false_dst_true() fails depending on the timezone

2018-11-27 Thread miss-islington
Change by miss-islington : -- pull_requests: +9988 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35317] test_email: test_localtime_daylight_false_dst_true() fails depending on the timezone

2018-11-27 Thread STINNER Victor
STINNER Victor added the comment: New changeset cfaafda8e3e19764682abb4bd4c574accb784c42 by Victor Stinner in branch 'master': bpo-35317: Fix mktime() error in test_email (GH-10721) https://github.com/python/cpython/commit/cfaafda8e3e19764682abb4bd4c574accb784c42 --

[issue34022] 6 tests fail using SOURCE_DATE_EPOCH env var

2018-11-27 Thread STINNER Victor
STINNER Victor added the comment: > As https://github.com/python/cpython/pull/10327 has been merged, I think this > issue can be closed? The Versions field of this issue is set to Python 3.7, but 7 tests are failing with: $ SOURCE_DATE_EPOCH=0 ./python -m test -j0 -r -u all,-gui (...) 7

[issue33029] Invalid function cast warnings with gcc 8 for getter and setter functions

2018-11-27 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Can you provide your patches Siddhesh? -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue33012] Invalid function cast warnings with gcc 8 for METH_NOARGS

2018-11-27 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 62be74290aca26d16f3f55ece7ff6dad14e60e8d by Serhiy Storchaka in branch 'master': bpo-33012: Fix invalid function cast warnings with gcc 8. (GH-6749) https://github.com/python/cpython/commit/62be74290aca26d16f3f55ece7ff6dad14e60e8d

[issue33954] float.__format__('n') fails with _PyUnicode_CheckConsistency assertion error for locales with non-ascii thousands separator

2018-11-27 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +9987 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35134] Add a new Include/cpython/ subdirectory for the "CPython API" with implementation details

2018-11-27 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +9986 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33954] float.__format__('n') fails with _PyUnicode_CheckConsistency assertion error for locales with non-ascii thousands separator

2018-11-27 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +9985 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33954] float.__format__('n') fails with _PyUnicode_CheckConsistency assertion error for locales with non-ascii thousands separator

2018-11-27 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +9984 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33012] Invalid function cast warnings with gcc 8 for METH_NOARGS

2018-11-27 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 81524022d0c0df7a41f9b2b2df41e2ebe140e610 by Serhiy Storchaka in branch 'master': bpo-33012: Fix signatures of METH_NOARGS funstions. (GH-10736) https://github.com/python/cpython/commit/81524022d0c0df7a41f9b2b2df41e2ebe140e610 --

  1   2   >