[issue35429] Incorrect use of raise NotImplemented

2018-12-06 Thread Roman Yurchak
Roman Yurchak added the comment: Resolved in https://bugs.python.org/issue33023 -- resolution: -> duplicate ___ Python tracker ___

[issue34864] In Idle, Mac tabs make editor status line disappear.

2018-12-06 Thread miss-islington
miss-islington added the comment: New changeset 10665544a97b6616898faafc12ac9d06505d0690 by Miss Islington (bot) in branch '3.6': bpo-34864: warn if "Prefer tabs when opening documents" set to "Always" (GH-10464)

[issue35436] Add missing PyErr_NoMemory() calls

2018-12-06 Thread Zackery Spytz
New submission from Zackery Spytz : The attached PR adds some missing PyErr_NoMemory() calls. -- ___ Python tracker ___ ___

[issue35436] Add missing PyErr_NoMemory() calls

2018-12-06 Thread Zackery Spytz
Change by Zackery Spytz : -- keywords: +patch pull_requests: +10250 stage: -> patch review ___ Python tracker ___ ___

[issue35436] Add missing PyErr_NoMemory() calls

2018-12-06 Thread Zackery Spytz
Change by Zackery Spytz : -- components: Extension Modules, Interpreter Core nosy: ZackerySpytz priority: normal severity: normal status: open title: Add missing PyErr_NoMemory() calls type: behavior versions: Python 2.7, Python 3.6, Python 3.7, Python 3.8

[issue35435] Documentation of 3.3 is available

2018-12-06 Thread Steven D'Aprano
Steven D'Aprano added the comment: Documentation is available for all versions going back to Python 1.4. https://docs.python.org/release/1.4/ As it should be: I'm surely not the only person who has need to check old versions of the documentation from time to time. Not everyone is using the

[issue34864] In Idle, Mac tabs make editor status line disappear.

2018-12-06 Thread miss-islington
miss-islington added the comment: New changeset 2db190bb356d00422087e1286637887efb8d97c5 by Miss Islington (bot) in branch '3.7': bpo-34864: warn if "Prefer tabs when opening documents" set to "Always" (GH-10464)

[issue35435] Documentation of 3.3 is available

2018-12-06 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: It seems like all other versions (3.2, 3.1, 3.0) are still available too, just not updated anymore. I'm thinking it's ok to leave these documentation. While we don't support these versions anymore, they still exists, and they're even still available for

[issue34864] In Idle, Mac tabs make editor status line disappear.

2018-12-06 Thread miss-islington
Change by miss-islington : -- pull_requests: +10249 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34864] In Idle, Mac tabs make editor status line disappear.

2018-12-06 Thread miss-islington
Change by miss-islington : -- pull_requests: +10248 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34864] In Idle, Mac tabs make editor status line disappear.

2018-12-06 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 9ebe8794f003dadfff578a066ea503a3e37ffe1d by Terry Jan Reedy (Tal Einat) in branch 'master': bpo-34864: warn if "Prefer tabs when opening documents" set to "Always" (#10464)

[issue35435] Documentation of 3.3 is available

2018-12-06 Thread Stéphane Wirtel
New submission from Stéphane Wirtel : Today, I was looking for the doc of unittest.mock and the result from DuckDuckGo was this link: https://docs.python.org/3.3/library/unittest.mock-examples.html In the devguide, we stopped the support and everything about this version, in the bug tracker,

[issue32805] Possible integer overflow when call PyDTrace_GC_DONE()

2018-12-06 Thread Jeremy Kloth
Change by Jeremy Kloth : -- keywords: +patch pull_requests: +10247 stage: -> patch review ___ Python tracker ___ ___

[issue33023] Unable to copy ssl.SSLContext

2018-12-06 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 324e1790094708538acf2e7795f9c44e3732aaf7 by Serhiy Storchaka in branch '2.7': [2.7] bpo-33023: Fix NotImplemented to NotImplementedError. (GH-10934). (GH-11001) (GH-11008)

[issue35434] Wrong bpo linked in What's New in 3.8

2018-12-06 Thread miss-islington
miss-islington added the comment: New changeset 16501b70826695991b3a151dfc538f010be5c765 by Miss Islington (bot) (Mariatta) in branch 'master': bpo-35434 Fix wrong issue number in what's new in 3.8 (GH-11012) https://github.com/python/cpython/commit/16501b70826695991b3a151dfc538f010be5c765

[issue35434] Wrong bpo linked in What's New in 3.8

2018-12-06 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: Thanks! This has been fixed. -- nosy: +Mariatta resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue35434] Wrong bpo linked in What's New in 3.8

2018-12-06 Thread Mariatta Wijaya
Change by Mariatta Wijaya : -- keywords: +patch pull_requests: +10246 stage: -> patch review ___ Python tracker ___ ___

[issue34977] Release Windows Store app containing Python

2018-12-06 Thread Steve Dower
Change by Steve Dower : -- stage: patch review -> commit review ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue34977] Release Windows Store app containing Python

2018-12-06 Thread Steve Dower
Steve Dower added the comment: Making the release experimental as part of the next 3.7 update was approved by Ned (over email), so I merged the build. As soon as we snap for the RC I'll kick off an update and make the store page public, and hopefully can promote it enough to get eyes on it.

[issue34977] Release Windows Store app containing Python

2018-12-06 Thread Steve Dower
Steve Dower added the comment: New changeset 253209149389e6793a052034e1f2d97691086f18 by Steve Dower in branch '3.7': [3.7] bpo-34977: Add Windows App Store package (GH-10245) https://github.com/python/cpython/commit/253209149389e6793a052034e1f2d97691086f18 --

[issue34977] Release Windows Store app containing Python

2018-12-06 Thread Steve Dower
Steve Dower added the comment: New changeset 468a15aaf9206448a744fc5eab3fc21f51966aad by Steve Dower in branch 'master': bpo-34977: Add Windows App Store package (GH-10245) https://github.com/python/cpython/commit/468a15aaf9206448a744fc5eab3fc21f51966aad --

[issue35434] Wrong bpo linked in What's New in 3.8

2018-12-06 Thread Josh Rosenberg
New submission from Josh Rosenberg : https://docs.python.org/3.8/whatsnew/3.8.html#optimizations begins with: shutil.copyfile(), shutil.copy(), shutil.copy2(), shutil.copytree() and shutil.move() use platform-specific “fast-copy” syscalls on Linux, macOS and Solaris in order to copy the file

[issue35433] Correctly detect installed SDK versions

2018-12-06 Thread Steve Dower
Steve Dower added the comment: Looks good to me. I can't apply tags from my phone, apparently, so someone else will have to merge and mark the backport versions. -- ___ Python tracker

[issue35433] Correctly detect installed SDK versions

2018-12-06 Thread Jeremy Kloth
Change by Jeremy Kloth : -- nosy: +vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35433] Correctly detect installed SDK versions

2018-12-06 Thread Jeremy Kloth
Jeremy Kloth added the comment: Also, my buildbot *should* fail until this change is merged. -- ___ Python tracker ___ ___

[issue9566] Compilation warnings under x64 Windows

2018-12-06 Thread Jeremy Kloth
Jeremy Kloth added the comment: I've added two PRs (GH-11010 and GH-11011) along with bpo-35433 that should get 3.x warning free (finally!) on 64-bit Windows. -- ___ Python tracker

[issue9566] Compilation warnings under x64 Windows

2018-12-06 Thread Jeremy Kloth
Change by Jeremy Kloth : -- nosy: +jkloth ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue9566] Compilation warnings under x64 Windows

2018-12-06 Thread Jeremy Kloth
Change by Jeremy Kloth : -- pull_requests: +10245 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35267] reproducible deadlock with multiprocessing.Pool

2018-12-06 Thread Jonathan Gossage
Change by Jonathan Gossage : Added file: https://bugs.python.org/file47980/lock1.result.txt ___ Python tracker ___ ___ Python-bugs-list

[issue35267] reproducible deadlock with multiprocessing.Pool

2018-12-06 Thread Jonathan Gossage
Jonathan Gossage added the comment: This is a great example of abusing the multi-processing API and thus creating timing errors that lead to locks not being released. What is happening is that the example attempts to transmit data that is too big for the underlying pipe and this creates the

[issue9566] Compilation warnings under x64 Windows

2018-12-06 Thread Jeremy Kloth
Change by Jeremy Kloth : -- pull_requests: +10244 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35432] str.format and string.Formatter bug with French (and other) locale

2018-12-06 Thread Eric V. Smith
Eric V. Smith added the comment: Possibly related to issue 33954? -- nosy: +eric.smith ___ Python tracker ___ ___ Python-bugs-list

[issue35433] Correctly detect installed SDK versions

2018-12-06 Thread Jeremy Kloth
Change by Jeremy Kloth : -- keywords: +patch pull_requests: +10243 stage: -> patch review ___ Python tracker ___ ___

[issue35433] Correctly detect installed SDK versions

2018-12-06 Thread Jeremy Kloth
New submission from Jeremy Kloth : In the process of eliminating compiler warnings on my buildbot, I needed to update VS2015 to the latest toolset (VS2015 Update 3). This in turn now causes an error due about not having the required version of Windows SDK installed. It seems that the

[issue35431] The math module should provide a function for computing binomial coefficients

2018-12-06 Thread Raymond Hettinger
Raymond Hettinger added the comment: +1 I have wanted this a number of times. FWIW, most recently I wrote it like this: def comb(n, r): 'Equivalent to factorial(n) // (factorial(r) * factorial(n-r))' c = 1 r = min(r, n-r) for i in range(1, r+1):

[issue35431] The math module should provide a function for computing binomial coefficients

2018-12-06 Thread kellerfuchs
kellerfuchs added the comment: Yes, that was a copypasta mistake (and I also import factorial needlessly) as the file I prototyped it in had some other code for testing my proposed implementation. :) -- ___ Python tracker

[issue35431] The math module should provide a function for computing binomial coefficients

2018-12-06 Thread Steven D'Aprano
Steven D'Aprano added the comment: You import reduce but never use it :-) +1 for this, I certainly miss it too. -- nosy: +steven.daprano ___ Python tracker ___

[issue35432] str.format and string.Formatter bug with French (and other) locale

2018-12-06 Thread Bruno Chanal
New submission from Bruno Chanal : The short story: Small numbers are not displayed properly when using a French (language) locale or similar, and formatting output with str.format or string.Formatter(). The problem probably extends to other locales. Long story: --- $ lsb_release -a No LSB

[issue35430] Lib/argparse.py uses `is` for string comparison

2018-12-06 Thread Roman Yurchak
Roman Yurchak added the comment: Thanks, Alexey and Serhiy! Looking at the code more closely I would agree. I guess changing the value of the suppress object to something else to avoid the warning, has a potential of breaking code that relies on the current functionality and is not worth

[issue35430] Lib/argparse.py uses `is` for string comparison

2018-12-06 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I concur with Alexey. This is a correct use of the 'is' operator. -- nosy: +serhiy.storchaka resolution: -> not a bug stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue35431] The math module should provide a function for computing binomial coefficients

2018-12-06 Thread kellerfuchs
New submission from kellerfuchs : A recuring pain point, for me and for many others who use Python for mathematical computations, is that the standard library does not provide a function for computing binomial coefficients. I would like to suggest adding a function, in the math module, with

[issue33023] Unable to copy ssl.SSLContext

2018-12-06 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +10242 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35430] Lib/argparse.py uses `is` for string comparison

2018-12-06 Thread Alexey Izbyshev
Alexey Izbyshev added the comment: argparse.SUPPRESS is an opaque value to be used by argparse clients. It could be anything, it just happens to be a string. So the code doesn't compare strings but checks whether a supplied object *is* the opaque value. I do not see any problem with this

[issue33023] Unable to copy ssl.SSLContext

2018-12-06 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 7a2cf1e7d3bf300e98c702589d405734f4a8fcf8 by Serhiy Storchaka in branch '3.6': bpo-33023: Fix NotImplemented to NotImplementedError. (GH-10934). (GH-11001) https://github.com/python/cpython/commit/7a2cf1e7d3bf300e98c702589d405734f4a8fcf8

[issue33023] Unable to copy ssl.SSLContext

2018-12-06 Thread miss-islington
miss-islington added the comment: New changeset 6485aa6eb1024672f08afdd577e2b5792eb6b03c by Miss Islington (bot) in branch '3.7': bpo-33023: Fix NotImplemented to NotImplementedError. (GH-10934) https://github.com/python/cpython/commit/6485aa6eb1024672f08afdd577e2b5792eb6b03c --

[issue35430] Lib/argparse.py uses `is` for string comparison

2018-12-06 Thread Roman Yurchak
Change by Roman Yurchak : -- keywords: +patch pull_requests: +10241 stage: -> patch review ___ Python tracker ___ ___

[issue33023] Unable to copy ssl.SSLContext

2018-12-06 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +10240 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33023] Unable to copy ssl.SSLContext

2018-12-06 Thread miss-islington
Change by miss-islington : -- pull_requests: +10239 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33023] Unable to copy ssl.SSLContext

2018-12-06 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 42b1d6127bd8595522a78a75166ebb9fba74a6a2 by Serhiy Storchaka in branch 'master': bpo-33023: Fix NotImplemented to NotImplementedError. (GH-10934) https://github.com/python/cpython/commit/42b1d6127bd8595522a78a75166ebb9fba74a6a2 --

[issue35430] Lib/argparse.py uses `is` for string comparison

2018-12-06 Thread Roman Yurchak
New submission from Roman Yurchak : Lib/argparse.py uses `is` for string comparison, ` 221:if self.heading is not SUPPRESS and self.heading is not None: 247:if text is not SUPPRESS and text is not None: 251:if usage is not SUPPRESS: 256:if action.help is not

[issue35429] Incorrect use of raise NotImplemented

2018-12-06 Thread Roman Yurchak
Change by Roman Yurchak : -- keywords: +patch pull_requests: +10237 stage: -> patch review ___ Python tracker ___ ___

[issue35429] Incorrect use of raise NotImplemented

2018-12-06 Thread Roman Yurchak
New submission from Roman Yurchak : In two places in stdlib, `raise NotImplemented` is used instead of `raise NotImplementedError`. The former is not valid and produces, ``` >>> raise NotImplemented('message') Traceback (most recent call last): File "", line 1, in TypeError:

[issue35411] FTP tests of test_urllib2net fail on Travis CI: 425 Security: Bad IP connecting.

2018-12-06 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: test_urllib2net still fails on Travis CI. See for example https://api.travis-ci.org/v3/job/464509821/log.txt. -- nosy: +benjamin.peterson, ned.deily, serhiy.storchaka priority: normal -> release blocker status: closed -> open

[issue35428] xml.etree.ElementTree.tostring violates W3 standards allowing encoding='unicode' without error

2018-12-06 Thread EZ
New submission from EZ : The documentation[0] for 3.x of xml.etree.ElementTree.tostring is quite clear: > Use encoding="unicode" to generate a Unicode string. See also the creation of the problem: https://bugs.python.org/issue10942 This is a violation of W3 standards, referenced by the

[issue22005] datetime.__setstate__ fails decoding python2 pickle

2018-12-06 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: NumPy starves from the same issue. In NumPy this problem was solved by requiring encoding='latin1' passed to unpickler. It makes sense to use the same approach for datetime classes. -- versions: +Python 3.7, Python 3.8 -Python 2.7, Python 3.4,

[issue26415] Excessive peak memory consumption by the Python parser

2018-12-06 Thread A. Skrobov
A. Skrobov added the comment: @Serhiy: incredibly, this patch from 2.5 years ago required very minor changes to apply to the latest master. Shows how ossified the parser is :-) Now posted as https://github.com/python/cpython/pull/10995 -- ___

[issue26415] Excessive peak memory consumption by the Python parser

2018-12-06 Thread Roundup Robot
Change by Roundup Robot : -- keywords: +patch pull_requests: +10236 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue35427] logging UnicodeDecodeError from undecodable strftime output

2018-12-06 Thread Mark Dickinson
Mark Dickinson added the comment: Here's a bug report from someone else running into the same issue on Scrapy; looks like they worked around the issue by simply removing the timezone information from the `datefmt` (which is what we ended up doing, too):

[issue35427] logging UnicodeDecodeError from undecodable strftime output

2018-12-06 Thread Mark Dickinson
New submission from Mark Dickinson : We're seeing UnicodeDecodeErrors on Windows / Python 2.7 when using logging on a Japanese customer machine. The cause turns out to be in the log record formatting, where unicode fields are combined with non-decodable bytestrings coming from strftime. More

[issue33127] Python 2.7.14 won't build ssl module with Libressl 2.7.0

2018-12-06 Thread Roundup Robot
Change by Roundup Robot : -- pull_requests: +10235 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34987] A possible null pointer dereference in _pickle.c's save_reduce()

2018-12-06 Thread Zackery Spytz
Change by Zackery Spytz : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue35363] test_eintr: test_open() hangs randomly on x86-64 El Capitan 3.x buildbot

2018-12-06 Thread STINNER Victor
STINNER Victor added the comment: Follow-up: bpo-35425, "test_eintr fails randomly on AMD64 FreeBSD 10-STABLE Non-Debug 3.7: TypeError: 'int' object is not callable". -- ___ Python tracker

[issue35330] When using mock to wrap an existing object, side_effect requires return_value

2018-12-06 Thread Mario Corchero
Change by Mario Corchero : -- keywords: +patch pull_requests: +10234 stage: test needed -> patch review ___ Python tracker ___ ___

[issue35363] test_eintr: test_open() hangs randomly on x86-64 El Capitan 3.x buildbot

2018-12-06 Thread miss-islington
miss-islington added the comment: New changeset 3f0e8e225e2275d22c4bd2e8f8f212b6a8b849aa by Miss Islington (bot) in branch '3.6': bpo-35363: test_eintr uses print(flush=True) (GH-10990) https://github.com/python/cpython/commit/3f0e8e225e2275d22c4bd2e8f8f212b6a8b849aa --

[issue35363] test_eintr: test_open() hangs randomly on x86-64 El Capitan 3.x buildbot

2018-12-06 Thread miss-islington
miss-islington added the comment: New changeset 560fa4db17983ce37c1453c057901c627b2c3abc by Miss Islington (bot) in branch '3.7': bpo-35363: test_eintr uses print(flush=True) (GH-10990) https://github.com/python/cpython/commit/560fa4db17983ce37c1453c057901c627b2c3abc --

[issue35363] test_eintr: test_open() hangs randomly on x86-64 El Capitan 3.x buildbot

2018-12-06 Thread miss-islington
Change by miss-islington : -- pull_requests: +10233 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35363] test_eintr: test_open() hangs randomly on x86-64 El Capitan 3.x buildbot

2018-12-06 Thread STINNER Victor
STINNER Victor added the comment: New changeset 0644b33821b70efbf0ac1ec1fb8729b05796564a by Victor Stinner in branch 'master': bpo-35363: test_eintr uses print(flush=True) (GH-10990) https://github.com/python/cpython/commit/0644b33821b70efbf0ac1ec1fb8729b05796564a --

[issue35363] test_eintr: test_open() hangs randomly on x86-64 El Capitan 3.x buildbot

2018-12-06 Thread miss-islington
Change by miss-islington : -- pull_requests: +10232 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35426] test_signal.test_interprocess_signal() race condition

2018-12-06 Thread STINNER Victor
New submission from STINNER Victor : test_signal.test_interprocess_signal() has a race condition: with self.subprocess_send_signal(pid, "SIGUSR1") as child: # here self.wait_signal(child, 'SIGUSR1', SIGUSR1Exception) The test only except SIGUSR1Exception inside wait_signal(), but the

[issue33127] Python 2.7.14 won't build ssl module with Libressl 2.7.0

2018-12-06 Thread Roundup Robot
Change by Roundup Robot : -- pull_requests: +10231 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35425] test_eintr fails randomly on AMD64 FreeBSD 10-STABLE Non-Debug 3.7: TypeError: 'int' object is not callable

2018-12-06 Thread STINNER Victor
New submission from STINNER Victor : I don't understand the error, it doesn't make sense. It *seems* like faulthandler.cancel_dump_traceback_later attribute has been set to an int, but I don't see how it could be possible. Or the call raises the TypeError? But the call can be summarized to:

[issue35363] test_eintr: test_open() hangs randomly on x86-64 El Capitan 3.x buildbot

2018-12-06 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +10230 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35424] multiprocessing.Pool: emit ResourceWarning

2018-12-06 Thread miss-islington
miss-islington added the comment: New changeset e44b5b2afa6fe2966d8caff45e36c0980413bb86 by Miss Islington (bot) in branch '3.6': bpo-35424: test_multiprocessing: join 3 pools (GH-10986) https://github.com/python/cpython/commit/e44b5b2afa6fe2966d8caff45e36c0980413bb86 --

[issue35424] multiprocessing.Pool: emit ResourceWarning

2018-12-06 Thread miss-islington
miss-islington added the comment: New changeset b7c67c4d510a7a72a35983cc168dbb2ce796cb8c by Miss Islington (bot) in branch '3.7': bpo-35424: test_multiprocessing: join 3 pools (GH-10986) https://github.com/python/cpython/commit/b7c67c4d510a7a72a35983cc168dbb2ce796cb8c -- nosy:

[issue35378] multiprocessing.Pool.imaps iterators do not maintain alive the multiprocessing.Pool objects

2018-12-06 Thread Antoine Pitrou
Antoine Pitrou added the comment: I agree about making the multiprocessing API safer to use, but please let's have this discussion on a dedicated bug entry. -- ___ Python tracker

[issue35378] multiprocessing.Pool.imaps iterators do not maintain alive the multiprocessing.Pool objects

2018-12-06 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Ok, I will modify my PR to pass a weak reference and raise. -- ___ Python tracker ___ ___

[issue35378] multiprocessing.Pool.imaps iterators do not maintain alive the multiprocessing.Pool objects

2018-12-06 Thread STINNER Victor
STINNER Victor added the comment: See https://bugs.python.org/issue34172#msg331216 for a more general discussion about how the multiprocessing API is supposed tobe used and multiprocessing objects lifetime. -- ___ Python tracker

[issue35378] multiprocessing.Pool.imaps iterators do not maintain alive the multiprocessing.Pool objects

2018-12-06 Thread Antoine Pitrou
Antoine Pitrou added the comment: I think a weakref is fine. You don't have to *pass* a weakref: just pass a normal ref and let the Result object take a weakref (and a reference to the cache perhaps). -- ___ Python tracker

[issue35378] multiprocessing.Pool.imaps iterators do not maintain alive the multiprocessing.Pool objects

2018-12-06 Thread STINNER Victor
STINNER Victor added the comment: In general, I'm fine with adding a *weak* reference, especially if it helps to detect bugs. -- nosy: +vstinner ___ Python tracker ___

[issue35378] multiprocessing.Pool.imaps iterators do not maintain alive the multiprocessing.Pool objects

2018-12-06 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Although I think keeping the iterator is not a bad solution if done correctly, I think more and more that is not the best solution. @Antoine, would you be ok passing a weak reference to the iterator and raising if the pool is dead? I still think we

[issue35359] [2.7][Windows] Define _CRT_SECURE_NO_WARNINGS to build Modules\zlib\

2018-12-06 Thread STINNER Victor
Change by STINNER Victor : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue35424] multiprocessing.Pool: emit ResourceWarning

2018-12-06 Thread miss-islington
Change by miss-islington : -- pull_requests: +10228 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35424] multiprocessing.Pool: emit ResourceWarning

2018-12-06 Thread miss-islington
Change by miss-islington : -- pull_requests: +10229 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35424] multiprocessing.Pool: emit ResourceWarning

2018-12-06 Thread STINNER Victor
STINNER Victor added the comment: New changeset 388c8c208d9d09bd28289c1e4776b947d4d0f0f0 by Victor Stinner in branch 'master': bpo-35424: test_multiprocessing: join 3 pools (GH-10986) https://github.com/python/cpython/commit/388c8c208d9d09bd28289c1e4776b947d4d0f0f0 --

[issue35359] [2.7][Windows] Define _CRT_SECURE_NO_WARNINGS to build Modules\zlib\

2018-12-06 Thread STINNER Victor
STINNER Victor added the comment: New changeset 49cedc51a68b4cd2525c14ab02bd1a483d8be389 by Victor Stinner in branch '2.7': bpo-35359: Add _CRT_SECURE_NO_WARNINGS to pythoncore project (GH-10819) https://github.com/python/cpython/commit/49cedc51a68b4cd2525c14ab02bd1a483d8be389 --

[issue34172] multiprocessing.Pool and ThreadPool leak resources after being deleted

2018-12-06 Thread STINNER Victor
STINNER Victor added the comment: See also bpo-35424: "multiprocessing.Pool: emit ResourceWarning". I wrote 10986 to fix 2 tests which leak resources. I have a question. Why do tests have to call "pool.join()" after "with pool:"? When I use a file, I know that the resources are released

[issue35424] multiprocessing.Pool: emit ResourceWarning

2018-12-06 Thread STINNER Victor
STINNER Victor added the comment: While testing PR 10974, I found two tests which emits ResourceWarning. I wrote 10986 to fix them. -- ___ Python tracker ___

[issue35424] multiprocessing.Pool: emit ResourceWarning

2018-12-06 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +10227 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35384] The repr of ctypes.CArgObject fails for non-ascii character

2018-12-06 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue35384] The repr of ctypes.CArgObject fails for non-ascii character

2018-12-06 Thread miss-islington
miss-islington added the comment: New changeset f740818f3d92497c564d515a661039dc8434fc6c by Miss Islington (bot) in branch '3.7': bpo-35384: The repr of ctypes.CArgObject no longer fails for non-ascii character. (GH-10863)

[issue33709] test.support.FS_NONASCII returns incorrect result in Windows with non-US locale

2018-12-06 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue34172] multiprocessing.Pool and ThreadPool leak resources after being deleted

2018-12-06 Thread Antoine Pitrou
Antoine Pitrou added the comment: I agree that reverting in bugfix branches was the right thing to do. I think the fix should have remained in master, though. -- stage: patch review -> versions: -Python 2.7, Python 3.6, Python 3.7 ___ Python

[issue33709] test.support.FS_NONASCII returns incorrect result in Windows with non-US locale

2018-12-06 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 29a4cbff92862207eb9df9a970b3636b8b06ff5d by Serhiy Storchaka (native-api) in branch '2.7': [2.7] bpo-33709: test_ntpath and test_posixpath fail in Windows with ACP!=1252. (GH-7278) (GH-7279)

[issue34172] multiprocessing.Pool and ThreadPool leak resources after being deleted

2018-12-06 Thread STINNER Victor
STINNER Victor added the comment: I reverted the change in 2.7, 3.6, 3.7 and master branches because it introduces a regression and we are very close to a release: https://mail.python.org/pipermail/python-dev/2018-December/155920.html I don't want to have the pressure to push a quick fix. I

[issue35384] The repr of ctypes.CArgObject fails for non-ascii character

2018-12-06 Thread miss-islington
miss-islington added the comment: New changeset f9d8b686285926c985cfe88a8392a9a497c0a916 by Miss Islington (bot) in branch '3.6': bpo-35384: The repr of ctypes.CArgObject no longer fails for non-ascii character. (GH-10863)

[issue35384] The repr of ctypes.CArgObject fails for non-ascii character

2018-12-06 Thread miss-islington
Change by miss-islington : -- pull_requests: +10226 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30835] AttributeError when parsing multipart email with invalid non-decodable Content-Transfer-Encoding

2018-12-06 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- stage: -> test needed versions: +Python 3.8 -Python 3.5 ___ Python tracker ___ ___

[issue35378] multiprocessing.Pool.imaps iterators do not maintain alive the multiprocessing.Pool objects

2018-12-06 Thread Antoine Pitrou
Antoine Pitrou added the comment: Let's step back a bit here. This kind of code has never been supported. As Victor says, we should be careful not to add any potential sources of reference cycles. The reason the code originally "worked" is that it actually leaked the Pool object (and

[issue35384] The repr of ctypes.CArgObject fails for non-ascii character

2018-12-06 Thread miss-islington
Change by miss-islington : -- pull_requests: +10225 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35384] The repr of ctypes.CArgObject fails for non-ascii character

2018-12-06 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 3ffa8b9ba190101f674a0e524e482a83ed09cccd by Serhiy Storchaka in branch 'master': bpo-35384: The repr of ctypes.CArgObject no longer fails for non-ascii character. (GH-10863)

  1   2   >