[issue35454] Fix miscellaneous issues in error handling

2018-12-10 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 8855d9339858683c9b4fcd50b02a7bca526d4726 by Serhiy Storchaka in branch '3.6': [3.6] bpo-35454: Fix miscellaneous minor issues in error handling. (GH-11077) (GH-11106)

[issue35444] Unify and optimize the helper for getting a builtin object

2018-12-10 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +10336 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue26704] unittest.mock.patch: Double patching instance method: AttributeError: Mock object has no attribute '__name__'

2018-12-10 Thread Chris Withers
Chris Withers added the comment: Ah, yeah, I can see the blanket patch and a more local patch in a monorepo being a thing, cool, let's have a look! -- ___ Python tracker ___

[issue35454] Fix miscellaneous issues in error handling

2018-12-10 Thread miss-islington
miss-islington added the comment: New changeset 62674f3a36ec55f86a5f20ee028a37fbd549bd6c by Miss Islington (bot) in branch '3.7': bpo-35454: Fix miscellaneous minor issues in error handling. (GH-11077) https://github.com/python/cpython/commit/62674f3a36ec55f86a5f20ee028a37fbd549bd6c

[issue26704] unittest.mock.patch: Double patching instance method: AttributeError: Mock object has no attribute '__name__'

2018-12-10 Thread Anthony Sottile
Anthony Sottile added the comment: to be honest, I don't recall exactly given it's been 2 and a half years since the original report with no activity. if I recall correctly, this was encountered while upgrading the `mock` backport in yelp's monolithic repository. I want to say the reason

[issue35402] Upgrade macOS and Windows installers to Tcl 8.6.9 and Tk 8.6.9.1

2018-12-10 Thread Ned Deily
Ned Deily added the comment: The macOS installers will use Tcl 8.6.9 and Tk 8.6.9.1 starting with 3.7.2rc1 and 3.6.8rc1. Due to time constraints, the Windows builds will get updated later. -- title: Upgrade macOS (and Windows?) installer to Tcl/Tk 8.6.9.1 -> Upgrade macOS and

[issue35454] Fix miscellaneous issues in error handling

2018-12-10 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +10335 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35448] ConfigParser .read() - handling of nonexistent files

2018-12-10 Thread hongweipeng
Change by hongweipeng : -- nosy: +hongweipeng ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35402] Upgrade macOS (and Windows?) installer to Tcl/Tk 8.6.9.1

2018-12-10 Thread miss-islington
miss-islington added the comment: New changeset aa580508431d231677cfaa13ac9b6aa37538b9ef by Miss Islington (bot) in branch '2.7': bpo-35402: Update macOS installer to use Tcl 8.6.9 / Tk 8.6.9.1 (GH-11101) https://github.com/python/cpython/commit/aa580508431d231677cfaa13ac9b6aa37538b9ef

[issue35454] Fix miscellaneous issues in error handling

2018-12-10 Thread miss-islington
Change by miss-islington : -- pull_requests: +10334 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35454] Fix miscellaneous issues in error handling

2018-12-10 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 8905fcc85a6fc3ac394bc89b0bbf40897e9497a6 by Serhiy Storchaka in branch 'master': bpo-35454: Fix miscellaneous minor issues in error handling. (#11077) https://github.com/python/cpython/commit/8905fcc85a6fc3ac394bc89b0bbf40897e9497a6

[issue24928] mock.patch.dict spoils order of items in collections.OrderedDict

2018-12-10 Thread Chris Withers
Chris Withers added the comment: More tests are generally a good thing, so go for it :-) -- ___ Python tracker ___ ___

[issue28054] Diff for visually comparing actual with expected in mock.assert_called_with.

2018-12-10 Thread Chris Withers
Chris Withers added the comment: This is a tricky one as there's plenty of prior art, with pytest's assertion rewriting [1], testfixtures compare [2] and the stuff that unittest already does [3]. I don't think any solution should rely on a TestCase being used as pytest, which is the most

[issue35402] Upgrade macOS (and Windows?) installer to Tcl/Tk 8.6.9.1

2018-12-10 Thread miss-islington
miss-islington added the comment: New changeset 37607f26697351751165a042f91f04530ce333f7 by Miss Islington (bot) in branch '3.6': bpo-35402: Update macOS installer to use Tcl 8.6.9 / Tk 8.6.9.1 (GH-11101) https://github.com/python/cpython/commit/37607f26697351751165a042f91f04530ce333f7

[issue35444] Unify and optimize the helper for getting a builtin object

2018-12-10 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset bb86bf4c4eaa30b1f5192dab9f389ce0bb61114d by Serhiy Storchaka in branch 'master': bpo-35444: Unify and optimize the helper for getting a builtin object. (GH-11047)

[issue35402] Upgrade macOS (and Windows?) installer to Tcl/Tk 8.6.9.1

2018-12-10 Thread miss-islington
miss-islington added the comment: New changeset 3b9a0186c44d0c3e477c38fdc00203ec99aec912 by Miss Islington (bot) in branch '3.7': bpo-35402: Update macOS installer to use Tcl 8.6.9 / Tk 8.6.9.1 (GH-11101) https://github.com/python/cpython/commit/3b9a0186c44d0c3e477c38fdc00203ec99aec912

[issue26704] unittest.mock.patch: Double patching instance method: AttributeError: Mock object has no attribute '__name__'

2018-12-10 Thread Chris Withers
Chris Withers added the comment: Before we get too far: what's the use case for this double patching? -- ___ Python tracker ___

[issue35402] Upgrade macOS (and Windows?) installer to Tcl/Tk 8.6.9.1

2018-12-10 Thread miss-islington
Change by miss-islington : -- pull_requests: +10332 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35402] Upgrade macOS (and Windows?) installer to Tcl/Tk 8.6.9.1

2018-12-10 Thread miss-islington
Change by miss-islington : -- pull_requests: +10331 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35402] Upgrade macOS (and Windows?) installer to Tcl/Tk 8.6.9.1

2018-12-10 Thread miss-islington
Change by miss-islington : -- pull_requests: +10333 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35402] Upgrade macOS (and Windows?) installer to Tcl/Tk 8.6.9.1

2018-12-10 Thread Ned Deily
Ned Deily added the comment: New changeset 7cf3d8e25174c8871883e42f3240fd7f01efd3a8 by Ned Deily in branch 'master': bpo-35402: Update macOS installer to use Tcl 8.6.9 / Tk 8.6.9.1 (GH-11101) https://github.com/python/cpython/commit/7cf3d8e25174c8871883e42f3240fd7f01efd3a8 --

[issue35401] Upgrade Windows and macOS installers to use OpenSSL 1.1.0j / 1.0.2q

2018-12-10 Thread Ned Deily
Change by Ned Deily : -- assignee: christian.heimes -> priority: release blocker -> resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue35401] Upgrade Windows and macOS installers to use OpenSSL 1.1.0j / 1.0.2q

2018-12-10 Thread miss-islington
miss-islington added the comment: New changeset 55076cc0ffd1b7602d67f3a9a420d6261ffd5c89 by Miss Islington (bot) in branch '2.7': [3.6] bpo-35401: Update macOS installer to OpenSSL 1.0.2q (GH-11095) https://github.com/python/cpython/commit/55076cc0ffd1b7602d67f3a9a420d6261ffd5c89

[issue35402] Upgrade macOS (and Windows?) installer to Tcl/Tk 8.6.9.1

2018-12-10 Thread Ned Deily
Change by Ned Deily : -- keywords: +patch pull_requests: +10330 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue35401] Upgrade Windows and macOS installers to use OpenSSL 1.1.0j / 1.0.2q

2018-12-10 Thread miss-islington
miss-islington added the comment: New changeset c37923ece75721c21b06f7e3645d2838c2452e18 by Miss Islington (bot) in branch '3.7': bpo-35401: Update macOS installer to OpenSSL 1.1.0j (GH-11094) https://github.com/python/cpython/commit/c37923ece75721c21b06f7e3645d2838c2452e18 --

[issue35401] Upgrade Windows and macOS installers to use OpenSSL 1.1.0j / 1.0.2q

2018-12-10 Thread miss-islington
Change by miss-islington : -- pull_requests: +10329 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35401] Upgrade Windows and macOS installers to use OpenSSL 1.1.0j / 1.0.2q

2018-12-10 Thread miss-islington
miss-islington added the comment: New changeset 419b5ffc2ca46d7adf0be6216ca3a6e40028e50f by Miss Islington (bot) (Ned Deily) in branch '3.6': [3.6] bpo-35401: Update macOS installer to OpenSSL 1.0.2q (GH-11095) https://github.com/python/cpython/commit/419b5ffc2ca46d7adf0be6216ca3a6e40028e50f

[issue35401] Upgrade Windows and macOS installers to use OpenSSL 1.1.0j / 1.0.2q

2018-12-10 Thread miss-islington
Change by miss-islington : -- pull_requests: +10328 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35401] Upgrade Windows and macOS installers to use OpenSSL 1.1.0j / 1.0.2q

2018-12-10 Thread miss-islington
miss-islington added the comment: New changeset 3ec982640f89f6ce56dd2699a81e0bd834ae0c95 by Miss Islington (bot) (Ned Deily) in branch 'master': bpo-35401: Update macOS installer to OpenSSL 1.1.0j (GH-11094) https://github.com/python/cpython/commit/3ec982640f89f6ce56dd2699a81e0bd834ae0c95

[issue35401] Upgrade Windows and macOS installers to use OpenSSL 1.1.0j / 1.0.2q

2018-12-10 Thread Ned Deily
Change by Ned Deily : -- pull_requests: +10327 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34977] Release Windows Store app containing Python

2018-12-10 Thread miss-islington
miss-islington added the comment: New changeset 9bb306d586e3f1a48db40bd9519412de4fff3ee8 by Miss Islington (bot) in branch '3.7': bpo-34977: Remove unused preprocessor definition (GH-11092) https://github.com/python/cpython/commit/9bb306d586e3f1a48db40bd9519412de4fff3ee8 -- nosy:

[issue35401] Upgrade Windows and macOS installers to use OpenSSL 1.1.0j / 1.0.2q

2018-12-10 Thread Ned Deily
Change by Ned Deily : -- pull_requests: +10326 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34977] Release Windows Store app containing Python

2018-12-10 Thread miss-islington
Change by miss-islington : -- pull_requests: +10325 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34977] Release Windows Store app containing Python

2018-12-10 Thread Steve Dower
Steve Dower added the comment: New changeset d5a6a389d492c5e3d7933bafbd5252fd86ac4d49 by Steve Dower in branch 'master': bpo-34977: Remove unused preprocessor definition (GH-11092) https://github.com/python/cpython/commit/d5a6a389d492c5e3d7933bafbd5252fd86ac4d49 --

[issue35456] asyncio.Task.set_result() and set_exception() missing docstrings (and Liskov sub. principle)

2018-12-10 Thread Ned Deily
Change by Ned Deily : -- components: +asyncio nosy: +asvetlov, yselivanov ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue34977] Release Windows Store app containing Python

2018-12-10 Thread Steve Dower
Steve Dower added the comment: Luckily, just noticed that I introduced a bug as part of splitting up the original PR into two. It wasn't going to have an impact until the package was properly installed from the store, but without the proper directory resolution in there (since the variable

[issue35456] asyncio.Task.set_result() and set_exception() missing docstrings (and Liskov sub. principle)

2018-12-10 Thread Yahya Abou Imran
New submission from Yahya Abou Imran : In asyncio.Task help: | set_exception(self, exception, /) | Mark the future done and set an exception. | | If the future is already done when this method is called, raises | InvalidStateError. | | set_result(self, result,

[issue34977] Release Windows Store app containing Python

2018-12-10 Thread Steve Dower
Change by Steve Dower : -- pull_requests: +10324 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35401] Upgrade Windows and macOS installers to use OpenSSL 1.1.0j / 1.0.2q

2018-12-10 Thread Steve Dower
Steve Dower added the comment: New changeset 3c8bd22b8f0d7f57261b9d3c90e56447cd5acf94 by Steve Dower in branch '2.7': bpo-35401: Updates Windows build to OpenSSL 1.0.2q (GH-11089) https://github.com/python/cpython/commit/3c8bd22b8f0d7f57261b9d3c90e56447cd5acf94 --

[issue35401] Upgrade Windows and macOS installers to use OpenSSL 1.1.0j / 1.0.2q

2018-12-10 Thread miss-islington
miss-islington added the comment: New changeset d1fb21209bca0620ece849e05cca97bce861c996 by Miss Islington (bot) in branch '3.7': bpo-35401: Update Windows build to OpenSSL 1.1.0j (GH-11088) https://github.com/python/cpython/commit/d1fb21209bca0620ece849e05cca97bce861c996 -- nosy:

[issue35453] pathlib.Path: glob and rglob should accept PathLike patterns

2018-12-10 Thread Cristian Ciupitu
Cristian Ciupitu added the comment: Err, I meant os.path.join instead of os.path.combine. -- ___ Python tracker ___ ___

[issue34977] Release Windows Store app containing Python

2018-12-10 Thread Steve Dower
Steve Dower added the comment: New changeset 0e4ad88ff8956d9289ab0a1314636ac15b374459 by Steve Dower in branch '3.7': bpo-34977: Add Windows App Store package (GH-11027) https://github.com/python/cpython/commit/0e4ad88ff8956d9289ab0a1314636ac15b374459 --

[issue35401] Upgrade Windows and macOS installers to use OpenSSL 1.1.0j / 1.0.2q

2018-12-10 Thread Steve Dower
Change by Steve Dower : -- pull_requests: +10323 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35401] Upgrade Windows and macOS installers to use OpenSSL 1.1.0j / 1.0.2q

2018-12-10 Thread miss-islington
Change by miss-islington : -- pull_requests: +10322 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35401] Upgrade Windows and macOS installers to use OpenSSL 1.1.0j / 1.0.2q

2018-12-10 Thread Steve Dower
Steve Dower added the comment: New changeset 309d7207f691b3eaa988d2293b9d023943982a9f by Steve Dower in branch '3.6': bpo-35401: Updates Windows build to OpenSSL 1.0.2q (GH-11089) https://github.com/python/cpython/commit/309d7207f691b3eaa988d2293b9d023943982a9f --

[issue35401] Upgrade Windows and macOS installers to use OpenSSL 1.1.0j / 1.0.2q

2018-12-10 Thread Steve Dower
Steve Dower added the comment: New changeset 4824385fec0a1de99b4183f995a3e4923771bf64 by Steve Dower in branch 'master': bpo-35401: Update Windows build to OpenSSL 1.1.0j (GH-11088) https://github.com/python/cpython/commit/4824385fec0a1de99b4183f995a3e4923771bf64 --

[issue35433] Correctly detect installed SDK versions

2018-12-10 Thread David Bolen
David Bolen added the comment: Ah, got it (and see the pipelines comment by Steve). Jeremy, I suspect you might actually be able to restart the most recent 3.6 builds on my builders since you were the committer. It changed in Sep to only allow python-core users and the "owner" of the

[issue35433] Correctly detect installed SDK versions

2018-12-10 Thread Jeremy Kloth
Jeremy Kloth added the comment: > Oh, it's not the installation itself, I'm just wondering if allowing a newer > version is ok too? The original PR (included in 3.7, 3.x) uses the latest discovered SDK, but Steve stated that that logic broke the Pipelines build, so I reworked to PR to just

[issue35433] Correctly detect installed SDK versions

2018-12-10 Thread David Bolen
David Bolen added the comment: Oh, it's not the installation itself, I'm just wondering if allowing a newer version is ok too? Of course, it doesn't preclude expanding the build script in the future, so I've installed 15063 to both Win8/10 workers. I don't currently have access to restart

[issue34977] Release Windows Store app containing Python

2018-12-10 Thread Steve Dower
Steve Dower added the comment: New changeset 0cd6391fd890368ea1743dac50c366b42f2fd126 by Steve Dower in branch 'master': bpo-34977: Add Windows App Store package (GH-11027) https://github.com/python/cpython/commit/0cd6391fd890368ea1743dac50c366b42f2fd126 --

[issue35433] Correctly detect installed SDK versions

2018-12-10 Thread Jeremy Kloth
Jeremy Kloth added the comment: Well, if VS2015 is installed, the simplest way to have the required SDK(s) is to go to Control Panel -> Uninstall -> Microsoft Visual Studio (Community) 2015 Click Modify. Expand "Windows and Web Development" Expand "Universal Windows App Development Tools"

[issue35433] Correctly detect installed SDK versions

2018-12-10 Thread David Bolen
David Bolen added the comment: Hmm, VS2015 started as a full installation (with UI), probably right from its initial release. The build tools only installation (v141) is for VS2017. Best I can tell I'm at update 1 - my update version in the registry is 14.0.24720 (plus I have a .1

[issue35433] Correctly detect installed SDK versions

2018-12-10 Thread Jeremy Kloth
Jeremy Kloth added the comment: I forgot to mention that the presence of UseWindows81SDK in the build log indicates that the Build Tools are at most at version 1.2 (included with VS2015 Update 1) which should still work (it's what I tested against), but the difference may be the standalone

[issue35433] Correctly detect installed SDK versions

2018-12-10 Thread Jeremy Kloth
Jeremy Kloth added the comment: A quick look at the good build log does indicate that the 8.1 SDK was being used (vars UseWindows81SDK=true and WindowsTargetPlatformVersion=8.1) which is the default behavior for VS2015 if a matching (from python.props) Win10SDK cannot be found. It seems

[issue35433] Correctly detect installed SDK versions

2018-12-10 Thread David Bolen
David Bolen added the comment: (and the working log) -- Added file: https://bugs.python.org/file47986/msbuild-win10-good.log ___ Python tracker ___

[issue35433] Correctly detect installed SDK versions

2018-12-10 Thread David Bolen
David Bolen added the comment: > So before the change, the 16299 SDK wasn't being detected either, but perhaps > the 10240 one was? So I'm just confused It does seems likely that 10240 of the UCRT was being used (based on the attached msbuild logs). Howevr, the UCRT warning in the

[issue34977] Release Windows Store app containing Python

2018-12-10 Thread Steve Dower
Steve Dower added the comment: Thanks, Paul. Appreciate it :) Doing a final call before I hit merge in an hour or so. Right now: * full release build works * full test pass on all CI + custom buildbots work * prior test package made it to the store * docs clearly show it may change again Any

[issue35433] Correctly detect installed SDK versions

2018-12-10 Thread Steve Dower
Steve Dower added the comment: So before the change, the 16299 SDK wasn't being detected either, but perhaps the 10240 one was? That had some known issues in the debug UCRT, which is why the version gets printed out towards the end of the build. The only thing I can think of would be the

[issue35433] Correctly detect installed SDK versions

2018-12-10 Thread David Bolen
David Bolen added the comment: (sorry for the rapid updates) I'm also fairly sure that none of my workers have update 3 for VS2015. They do however all have VS2017 - but I think VS2015 still gets picked for 3.6 if both are present, right? So that's another variable, in that my workers

[issue35454] Fix miscellaneous issues in error handling

2018-12-10 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: No. It is very hard to reproduce these errors. -- ___ Python tracker ___ ___ Python-bugs-list

[issue35454] Fix miscellaneous issues in error handling

2018-12-10 Thread Charalampos Stratakis
Charalampos Stratakis added the comment: Maybe a release blocker for 3.7.2 and 3.6.8? -- nosy: +cstratak, ned.deily ___ Python tracker ___

[issue35433] Correctly detect installed SDK versions

2018-12-10 Thread David Bolen
David Bolen added the comment: Oh, since my reading comprehension must be low today, it appears like Jeremy actually had a closer situation previously as I'm in now, with a later (not older) version of the SDK that wasn't in the list. Which is interesting, since he got an error about the

[issue35433] Correctly detect installed SDK versions

2018-12-10 Thread David Bolen
David Bolen added the comment: Well, correct me if I'm wrong, but installing 15063 would then match one of the checks, and become the selected SDK, so be expected to work fine, right? I think (not sure) that the issue with my Win8/10 workers is they only have the later 16299. So in that

[issue35433] Correctly detect installed SDK versions

2018-12-10 Thread Steve Dower
Steve Dower added the comment: Both io.h and stddef.h are from the UCRT, which *may* go through a different detection process than the rest of the WinSDK. That might be the cause. The "didn't find any supported SDKs" behavior is to try and use the earliest, which should fail, but all the

[issue35433] Correctly detect installed SDK versions

2018-12-10 Thread Steve Dower
Steve Dower added the comment: I'm also looking at it, so please don't revert it just yet. I just installed 10.0.15063 onto my dev machine to test another 3.6 fix and it worked fine, so perhaps there's an option that is off here? -- resolution: fixed ->

[issue35401] Upgrade Windows and macOS installers to use OpenSSL 1.1.0j / 1.0.2q

2018-12-10 Thread Steve Dower
Change by Steve Dower : -- pull_requests: +10321 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35401] Upgrade Windows and macOS installers to use OpenSSL 1.1.0j / 1.0.2q

2018-12-10 Thread Steve Dower
Change by Steve Dower : -- keywords: +patch pull_requests: +10320 stage: -> patch review ___ Python tracker ___ ___

[issue35426] test_signal.test_interprocess_signal() race condition

2018-12-10 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +10319 stage: -> patch review ___ Python tracker ___ ___

[issue35433] Correctly detect installed SDK versions

2018-12-10 Thread David Bolen
David Bolen added the comment: I'm not that familiar (ok, at all) with the build process configuration, but in looking at the changes to python.props, it appears to now enforce the minimum in the build process regardless of whether it is found, whereas before the build tool was allowed to

[issue35412] test_future4 ran no test

2018-12-10 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +10318 stage: -> patch review ___ Python tracker ___ ___

[issue35425] test_eintr fails randomly on AMD64 FreeBSD 10-STABLE Non-Debug 3.7: TypeError: 'int' object is not callable

2018-12-10 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I logged in into the buildbot and try to reproduce that. After 230 iterations of `test_eintr` I cannot reproduce the signal problem. Maybe this is an interaction with some other test -- ___ Python

[issue35425] test_eintr fails randomly on AMD64 FreeBSD 10-STABLE Non-Debug 3.7: TypeError: 'int' object is not callable

2018-12-10 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Could it be that there is another test that is sending SIGALRM but does not disarm the ITIMER_REAL timer before restoring the previous handler? --- TypeError: 'int' object is not callable Can it be that thread.file has some custom

[issue35433] Correctly detect installed SDK versions

2018-12-10 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: This commit broke the following (at least) the buildbots: https://buildbot.python.org/all/#/builders/38/builds/751 https://buildbot.python.org/all/#/builders/31/builds/719 can someone work on a fix? Otherwise we would have to revert the commit per our

[issue35257] Avoid leaking linker flags into distutils: add PY_LDFLAGS_NODIST

2018-12-10 Thread Charalampos Stratakis
Charalampos Stratakis added the comment: The PR is pending another round of review. -- ___ Python tracker ___ ___ Python-bugs-list

[issue34616] implement "Async exec"

2018-12-10 Thread Matthias Bussonnier
Matthias Bussonnier added the comment: > Or actually there are two options to think about: you can submit a general > talk, or submit a talk to the language summit. (Or write two talks and do > both, I guess.) They're pretty different – the summit is a more informal > thing (no video,

[issue35338] set union/intersection/difference could accept zero arguments

2018-12-10 Thread Josh Rosenberg
Josh Rosenberg added the comment: Given the "feature" in question isn't actually an intended feature (just an accident of how unbound methods work), I'm closing this. We're not going to try to make methods callable without self. -- resolution: -> wont fix stage: -> resolved

[issue35438] Cleanup extension functions using _PyObject_LookupSpecial

2018-12-10 Thread Josh Rosenberg
Josh Rosenberg added the comment: Agreed with everything in Serhiy's comments. This patch disregards why _PyObject_LookupSpecial and the various _Py_IDENTIFIER related stuff was created in the first place (to handle a non-trivial task efficiently/correctly) in favor of trying to avoid

[issue26704] unittest.mock.patch: Double patching instance method: AttributeError: Mock object has no attribute '__name__'

2018-12-10 Thread Anthony Sottile
Anthony Sottile added the comment: I've opened a PR with the test included: https://github.com/python/cpython/pull/11085 -- ___ Python tracker ___

[issue26704] unittest.mock.patch: Double patching instance method: AttributeError: Mock object has no attribute '__name__'

2018-12-10 Thread Anthony Sottile
Change by Anthony Sottile : -- pull_requests: +10317 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34616] implement "Async exec"

2018-12-10 Thread Nathaniel Smith
Nathaniel Smith added the comment: > I'm thinking of submitting a talk at PyCon to explain what we've discover so > far in IPython. You totally should! Or actually there are two options to think about: you can submit a general talk, or submit a talk to the language summit. (Or write two

[issue34977] Release Windows Store app containing Python

2018-12-10 Thread Steve Dower
Steve Dower added the comment: Paul (and anyone else) - the below link should go directly to just the commit with the docs update. I did a slight rearrangement of the install docs to make the options clearer, and wrote up *just* enough info on nuget to help people use it right (I hope).

[issue35433] Correctly detect installed SDK versions

2018-12-10 Thread Steve Dower
Change by Steve Dower : -- resolution: -> fixed status: open -> closed versions: +Python 3.6 ___ Python tracker ___ ___

[issue35433] Correctly detect installed SDK versions

2018-12-10 Thread Steve Dower
Steve Dower added the comment: New changeset f04cc5fc0d2f644cccb57543aae487ee30091924 by Steve Dower (Jeremy Kloth) in branch '3.6': [3.6] bpo-35433: Properly detect installed SDK versions (GH-11009) https://github.com/python/cpython/commit/f04cc5fc0d2f644cccb57543aae487ee30091924

[issue35448] ConfigParser .read() - handling of nonexistent files

2018-12-10 Thread David Heiberg
Change by David Heiberg : -- nosy: +dheiberg ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35438] Cleanup extension functions using _PyObject_LookupSpecial

2018-12-10 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: There is nothing wrong with using private C API in the implementation of standard CPython extensions. This API was designed for this. In contrary, there are problems with your code: * It is less efficient. String objects are created and destroyed twice

[issue34616] implement "Async exec"

2018-12-10 Thread pmpp
pmpp added the comment: i already use prompt_toolkit on droid as it uses concurrent futures for completion and threads are allowed on that platform, and yeah it is quite good. but no way to use it on emscripten where cpython is 100% async ( it uses dummy_threading to load asyncio ). best

[issue34977] Release Windows Store app containing Python

2018-12-10 Thread Jeremy Kloth
Jeremy Kloth added the comment: See also bpo-35450: venv module doesn't create a copy of python binary by default -- nosy: +jkloth ___ Python tracker ___

[issue34616] implement "Async exec"

2018-12-10 Thread Matthias Bussonnier
Matthias Bussonnier added the comment: In IPython we use `prompt_toolkit` which does already provide a async readline alternative. Also have a look at https://github.com/ipython/ipython/blob/320d21bf56804541b27deb488871e488eb96929f/IPython/core/interactiveshell.py#L121-L150 Seem to be

[issue35403] support application/wasm in mimetypes and http.server

2018-12-10 Thread R. David Murray
R. David Murray added the comment: We don't generally add a mime type until it is a de-jure or de-facto standard. If it is still in testing it is probably too soon to add it. For testing, you can always add it yourself in your code via the api that mimetypes provides. --

[issue31823] Opaque default value for close_fds argument in Popen.__init__

2018-12-10 Thread Gregory P. Smith
Gregory P. Smith added the comment: In 3.6 this help(subprocess.Popen.__init__) is accurate and encourages looking at the docs. In 3.7 and later it'll simply report close_fds=True in the siguature as that is the case in 3.7 onwards. I see nothing to fix here. -- nosy:

[issue34616] implement "Async exec"

2018-12-10 Thread pmpp
pmpp added the comment: indeed adding async flag to compile and providing some 'aexec' is a very good idea ! *an async repl is really usefull when stuck with a threadless python* ( specific engines, or emscripten cpython ) "top-level async is invalid syntax" : Rewinding the readline

[issue31823] Opaque default value for close_fds argument in Popen.__init__

2018-12-10 Thread Gregory P. Smith
Change by Gregory P. Smith : -- versions: -Python 3.6 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35438] Cleanup extension functions using _PyObject_LookupSpecial

2018-12-10 Thread Eddie Elizondo
Eddie Elizondo added the comment: I also fixed the title to properly reflect what this is trying to achieve. -- ___ Python tracker ___

[issue34616] implement "Async exec"

2018-12-10 Thread Matthias Bussonnier
Matthias Bussonnier added the comment: So through time our heuristic to check wether a code should be async or not grew: https://github.com/ipython/ipython/blob/320d21bf56804541b27deb488871e488eb96929f/IPython/core/async_helpers.py#L94-L165 There also seem to be some code that uses

[issue35438] Cleanup extension functions using _PyObject_LookupSpecial

2018-12-10 Thread Eddie Elizondo
Change by Eddie Elizondo : -- title: Extension modules using non-API functions -> Cleanup extension functions using _PyObject_LookupSpecial ___ Python tracker ___

[issue35438] Extension modules using non-API functions

2018-12-10 Thread Eddie Elizondo
Eddie Elizondo added the comment: @vstinner: Sorry for not being clear - The intention of this change is two-fold: 1) Simplify the implementation of these functions. 2) Reduce the surface area of the C-API. Given that the same functionality can be achieved with public functions of the C-API.

[issue35438] Extension modules using non-API functions

2018-12-10 Thread STINNER Victor
STINNER Victor added the comment: > Three extension modules: _testcapimodule.c, posixmodule.c, and mathmodule.c > are using `_PyObject_LookupSpecial` which is not API. I don't understand the issue that you are trying to solve. Yes, Python builtin extensions use private functions of the C

[issue35438] Extension modules using non-API functions

2018-12-10 Thread Eddie Elizondo
Change by Eddie Elizondo : -- keywords: +patch pull_requests: +10316 stage: -> patch review ___ Python tracker ___ ___

[issue34977] Release Windows Store app containing Python

2018-12-10 Thread Steve Dower
Steve Dower added the comment: New changeset b264c609853eae9dbb45c6dbee11e84ae3927e88 by Steve Dower in branch '3.7': [3.7] bpo-34977: Use venv redirector instead of original python.exe on Windows (GH-11029) https://github.com/python/cpython/commit/b264c609853eae9dbb45c6dbee11e84ae3927e88

[issue34977] Release Windows Store app containing Python

2018-12-10 Thread Steve Dower
Steve Dower added the comment: New changeset 1c3de541e64f75046b20cdd27bada1557e550bcd by Steve Dower in branch 'master': bpo-34977: Use venv redirector instead of original python.exe on Windows (GH-11029) https://github.com/python/cpython/commit/1c3de541e64f75046b20cdd27bada1557e550bcd

  1   2   >