[issue33817] PyString_FromFormatV() fails to build empty strings

2019-01-11 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue35494] Inaccurate error message for f-string

2019-01-11 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 58159ef856846d0235e0779aeb6013d70499570d by Serhiy Storchaka in branch 'master': bpo-35494: Improve syntax error messages for unbalanced parentheses in f-string. (GH-11161)

[issue35494] Inaccurate error message for f-string

2019-01-11 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue33817] PyString_FromFormatV() fails to build empty strings

2019-01-11 Thread miss-islington
miss-islington added the comment: New changeset d39c19255910b9dce08c595f511597e98b09e91f by Miss Islington (bot) in branch '3.7': bpo-33817: Fix _PyBytes_Resize() for empty bytes object. (GH-11516) https://github.com/python/cpython/commit/d39c19255910b9dce08c595f511597e98b09e91f --

[issue33817] PyString_FromFormatV() fails to build empty strings

2019-01-11 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 08a81df05004147ee174ece645679576ab867860 by Serhiy Storchaka in branch '2.7': bpo-33817: Fix _PyString_Resize() and _PyUnicode_Resize() for empty strings. (GH-11515)

[issue33817] PyString_FromFormatV() fails to build empty strings

2019-01-11 Thread miss-islington
Change by miss-islington : -- pull_requests: +11129, 11130 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33817] PyString_FromFormatV() fails to build empty strings

2019-01-11 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 44cc4822bb3799858201e61294c5863f93ec12e2 by Serhiy Storchaka in branch 'master': bpo-33817: Fix _PyBytes_Resize() for empty bytes object. (GH-11516) https://github.com/python/cpython/commit/44cc4822bb3799858201e61294c5863f93ec12e2

[issue33817] PyString_FromFormatV() fails to build empty strings

2019-01-11 Thread miss-islington
Change by miss-islington : -- pull_requests: +11129 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35725] Using for...in.. generator-iterator

2019-01-11 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: I was also typing a similar reply and Steve explained it better :) Just to add there is a note on implicit next call on a for loop in the documentation. https://docs.python.org/3/reference/expressions.html#generator.__next__ > Starts the execution

[issue34838] Improve arg clinic code generation for cases with type checking

2019-01-11 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___ ___

[issue35582] Argument Clinic: inline parsing code for functions with only positional parameters

2019-01-11 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I do not expect significant changes in higher-level benchmarks. But if there are some, they can be shown on speed.python.org. I this all work on this stage is finished. -- resolution: -> fixed stage: patch review -> resolved status: open ->

[issue35725] Using for...in.. generator-iterator

2019-01-11 Thread Steven D'Aprano
Steven D'Aprano added the comment: This is not a bug, it is standard behaviour for all iterators, not just generators. For loops work by calling next() on the iterator object, if you call next() on the same object inside the loop, that has the effect of advancing the for loop. You say: >

[issue35719] Optimize multi-argument math functions

2019-01-11 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset d0d3e99120b19a4b800f0f381b2807c93aeecf0e by Serhiy Storchaka in branch 'master': bpo-35719: Optimize multi-argument math functions. (GH-11527) https://github.com/python/cpython/commit/d0d3e99120b19a4b800f0f381b2807c93aeecf0e --

[issue35719] Optimize multi-argument math functions

2019-01-11 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue35582] Argument Clinic: inline parsing code for functions with only positional parameters

2019-01-11 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 793426687509be24a42663a27e568cc92dcc07f6 by Serhiy Storchaka in branch 'master': bpo-35582: Inline arguments tuple unpacking in handwritten code. (GH-11524) https://github.com/python/cpython/commit/793426687509be24a42663a27e568cc92dcc07f6

[issue34838] Improve arg clinic code generation for cases with type checking

2019-01-11 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset cb08a71c5c534f33d9486677534dafb087c30e8c by Serhiy Storchaka (Ammar Askar) in branch 'master': bpo-34838: Use subclass_of for math.dist. (GH-9659) https://github.com/python/cpython/commit/cb08a71c5c534f33d9486677534dafb087c30e8c --

[issue29734] os.stat handle leak

2019-01-11 Thread Eryk Sun
Eryk Sun added the comment: The os__getfinalpathname_impl handle leak and VOLUME_NAME_NT problems were fixed in another issue. However, PR 740 also includes fixes for handle leaks in os.stat, specifically in win32_xstat_impl and get_target_path. -- stage: -> patch review title:

[issue35725] Using for...in.. generator-iterator

2019-01-11 Thread Yoong Hor Meng
New submission from Yoong Hor Meng : def f(): print('-- Start --') yield 1 print('-- Middle --') yield 2 print('-- Finished --') yield 3 gen = f() for x in gen: print('Another things ...') next(gen) The output: -- Start -- Another things ... -- Middle -- --

[issue34838] Improve arg clinic code generation for cases with type checking

2019-01-11 Thread Ammar Askar
Ammar Askar added the comment: Great job Serhiy, your work on argument clinic has encompassed the previous PR very well. I've updated it for the changes. -- ___ Python tracker

[issue14802] Python fails to compile with VC11 ARM configuration

2019-01-11 Thread Roundup Robot
Change by Roundup Robot : -- keywords: +patch, patch, patch, patch pull_requests: +11125, 11126, 11127, 11128 stage: -> patch review ___ Python tracker ___

[issue14802] Python fails to compile with VC11 ARM configuration

2019-01-11 Thread Roundup Robot
Change by Roundup Robot : -- keywords: +patch, patch, patch pull_requests: +11125, 11126, 11128 stage: -> patch review ___ Python tracker ___

[issue14802] Python fails to compile with VC11 ARM configuration

2019-01-11 Thread Roundup Robot
Change by Roundup Robot : -- keywords: +patch, patch pull_requests: +11125, 11126 stage: -> patch review ___ Python tracker ___

[issue14802] Python fails to compile with VC11 ARM configuration

2019-01-11 Thread Roundup Robot
Change by Roundup Robot : -- keywords: +patch pull_requests: +11125 stage: -> patch review ___ Python tracker ___ ___

[issue35723] Add "time zone index" cache to datetime objects

2019-01-11 Thread Eric N. Vander Weele
Change by Eric N. Vander Weele : -- nosy: +ericvw ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35718] Cannot initialize the distutils "force" command-option

2019-01-11 Thread Terry J. Reedy
Change by Terry J. Reedy : -- title: Cannot initialize the "force" command-option -> Cannot initialize the distutils "force" command-option ___ Python tracker ___

[issue35423] Signal handling machinery still relies on "pending calls".

2019-01-11 Thread Eric Snow
Change by Eric Snow : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue35712] Make NotImplemented unusable in boolean context

2019-01-11 Thread Terry J. Reedy
Terry J. Reedy added the comment: I consider it a nice feature of Python that all builtin objects, and, AFAIK (and Josh, apparently), all stdlib class instances, have a boolean value. (I am aware of numpy's element-wise behavior.) I hate to give this up. This is part of Python's general

[issue35724] Check for main interpreter when checking for "main" thread (for signal handling)

2019-01-11 Thread Eric Snow
Change by Eric Snow : -- keywords: +patch, patch pull_requests: +11123, 11124 stage: needs patch -> patch review ___ Python tracker ___

[issue35724] Check for main interpreter when checking for "main" thread (for signal handling)

2019-01-11 Thread Eric Snow
Change by Eric Snow : -- keywords: +patch pull_requests: +11123 stage: needs patch -> patch review ___ Python tracker ___ ___

[issue35423] Signal handling machinery still relies on "pending calls".

2019-01-11 Thread Eric Snow
Eric Snow added the comment: New changeset fdf282d609fd172d52b59a6f1f062eb701494528 by Eric Snow in branch 'master': bpo-35423: Stop using the "pending calls" machinery for signals. (gh-10972) https://github.com/python/cpython/commit/fdf282d609fd172d52b59a6f1f062eb701494528 --

[issue35717] enum.Enum error on sys._getframe(2)

2019-01-11 Thread Ivan Levkivskyi
Change by Ivan Levkivskyi : -- nosy: +levkivskyi ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35724] Check for main interpreter when checking for "main" thread (for signal handling)

2019-01-11 Thread Eric Snow
New submission from Eric Snow : The code in Modules/signalsmodule.c (as well as a few other places in the code) has a concept of a "main" thread. It's the OS thread where Py_Initialize() was called (and likely the process's original thread). For various good reasons, we ensure that signal

[issue35582] Argument Clinic: inline parsing code for functions with only positional parameters

2019-01-11 Thread Antoine Pitrou
Antoine Pitrou added the comment: Are there any numbers on higher-level benchmarks? -- nosy: +pitrou ___ Python tracker ___ ___

[issue35723] Add "time zone index" cache to datetime objects

2019-01-11 Thread Paul Ganssle
Paul Ganssle added the comment: One other thing I might mention here is that I did explore the idea of storing this cache on the tzinfo implementation itself, but it is problematic for a number of reasons: 1. It would either need to use some sort of expiring cache (lru, ttl) or require a

[issue35723] Add "time zone index" cache to datetime objects

2019-01-11 Thread Paul Ganssle
Change by Paul Ganssle : -- keywords: +patch pull_requests: +11122 stage: -> patch review ___ Python tracker ___ ___

[issue35723] Add "time zone index" cache to datetime objects

2019-01-11 Thread Paul Ganssle
New submission from Paul Ganssle : When examining the performance characteristics of pytz, I realized that pytz's eager calculation of tzname, offset and DST gives it an implicit cache that makes it much faster for repeated queries to .utcoffset(), .dst() and/or .tzname() though the eager

[issue35722] disable_existing_loggers does not apply to the root logger

2019-01-11 Thread Géry
New submission from Géry : In the logging package, the parameter disable_existing_loggers used in logging.config.dictConfig and logging.config.fileConfig does not apply to the root logger. More precisely, its disabled attribute remains unchanged (while it is set to True for non-root loggers).

[issue35721] _UnixSubprocessTransport leaks socket pair if Popen fails

2019-01-11 Thread Niklas Fiekas
New submission from Niklas Fiekas : Output of attached test case: non-existing indeed subprocess-exec-test.py:11: ResourceWarning: unclosed print("non-existing indeed") ResourceWarning: Enable tracemalloc to get the object allocation traceback subprocess-exec-test.py:11: ResourceWarning:

[issue35718] Cannot initialize the "force" command-option

2019-01-11 Thread Opher Shachar
Opher Shachar added the comment: (from the PR11526) In this build_py subclass I initialize force to 1, but when reaching byte_compile() we find out it was reset to None. from setuptools.command.build_py import build_py as _build_py class build_py(_build_py): def

[issue35720] Memory leak in Modules/main.c:pymain_parse_cmdline_impl when using the CLI flag

2019-01-11 Thread Roundup Robot
Change by Roundup Robot : -- keywords: +patch, patch pull_requests: +6, 7 stage: -> patch review ___ Python tracker ___

[issue35720] Memory leak in Modules/main.c:pymain_parse_cmdline_impl when using the CLI flag

2019-01-11 Thread Roundup Robot
Change by Roundup Robot : -- keywords: +patch, patch, patch pull_requests: +6, 7, 8 stage: -> patch review ___ Python tracker ___

[issue35720] Memory leak in Modules/main.c:pymain_parse_cmdline_impl when using the CLI flag

2019-01-11 Thread Roundup Robot
Change by Roundup Robot : -- keywords: +patch pull_requests: +6 stage: -> patch review ___ Python tracker ___ ___

[issue35720] Memory leak in Modules/main.c:pymain_parse_cmdline_impl when using the CLI flag

2019-01-11 Thread Lucas Cimon
New submission from Lucas Cimon : Hi. I think I have found a minor memory leak in Modules/main.c:pymain_parse_cmdline_impl. When the loop in the pymain_read_conf function in this same file calls pymain_init_cmdline_argv a 2nd time, the pymain->command buffer of wchar_t is overriden and the

[issue35719] Optimize multi-argument math functions

2019-01-11 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch, patch, patch pull_requests: +3, 4, 5 stage: -> patch review ___ Python tracker ___

[issue35719] Optimize multi-argument math functions

2019-01-11 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch, patch pull_requests: +3, 4 stage: -> patch review ___ Python tracker ___

[issue35719] Optimize multi-argument math functions

2019-01-11 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +3 stage: -> patch review ___ Python tracker ___ ___

[issue34569] test__xxsubinterpreters.ShareableTypeTests._assert_values fails on AIX - 32-bit mode

2019-01-11 Thread Eric Snow
Eric Snow added the comment: Thanks, Michael. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue35719] Optimize multi-argument math functions

2019-01-11 Thread Serhiy Storchaka
New submission from Serhiy Storchaka : The proposed PR makes multi-argument functions in the math module atan2(), copysign(), remainder() and hypot() to use the fast call convention and inline arguments tuple unpacking. Results: $ ./python -m timeit -s "from math import atan2" "atan2(1.0,

[issue34569] test__xxsubinterpreters.ShareableTypeTests._assert_values fails on AIX - 32-bit mode

2019-01-11 Thread Eric Snow
Eric Snow added the comment: New changeset a909460a09cca79bd051c45b02e650862a57dbd9 by Eric Snow (Michael Felt) in branch 'master': bpo-34569: Fix subinterpreter 32-bit ABI, pystate.c/_new_long_object() (gh-9127)

[issue35718] Cannot initialize the "force" command-option

2019-01-11 Thread Éric Araujo
Éric Araujo added the comment: Could you tell how you found the problem, i.e. what are you trying to do? -- ___ Python tracker ___

[issue35718] Cannot initialize the "force" command-option

2019-01-11 Thread Opher Shachar
Change by Opher Shachar : -- keywords: +patch, patch, patch, patch pull_requests: +11109, 0, 1, 2 stage: -> patch review ___ Python tracker ___

[issue35718] Cannot initialize the "force" command-option

2019-01-11 Thread Opher Shachar
Change by Opher Shachar : -- keywords: +patch, patch, patch pull_requests: +11109, 0, 2 stage: -> patch review ___ Python tracker ___

[issue35718] Cannot initialize the "force" command-option

2019-01-11 Thread Opher Shachar
Change by Opher Shachar : -- keywords: +patch pull_requests: +11109 stage: -> patch review ___ Python tracker ___ ___

[issue35718] Cannot initialize the "force" command-option

2019-01-11 Thread Opher Shachar
Change by Opher Shachar : -- keywords: +patch, patch pull_requests: +11109, 0 stage: -> patch review ___ Python tracker ___

[issue34838] Improve arg clinic code generation for cases with type checking

2019-01-11 Thread Ammar Askar
Ammar Askar added the comment: Sounds good, I'll take a look at the changes and update the PR accordingly. -- ___ Python tracker ___

[issue35717] enum.Enum error on sys._getframe(2)

2019-01-11 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +11108 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35582] Argument Clinic: inline parsing code for functions with only positional parameters

2019-01-11 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Just inlining the arg tuple unpacking in iter() give only 10% speed up. I would not apply this optimization for such small difference. But with converting it to fast call it looks more interesting. -- ___

[issue35717] enum.Enum error on sys._getframe(2)

2019-01-11 Thread STINNER Victor
STINNER Victor added the comment: > That PR does not go with this issue. ;) It does. You removed the link to PR 11523 which is a fix for this issue. -- ___ Python tracker

[issue35582] Argument Clinic: inline parsing code for functions with only positional parameters

2019-01-11 Thread STINNER Victor
STINNER Victor added the comment: $ ./python -m timeit "iter(())" Unpatched: 500 loops, best of 5: 82.8 nsec per loop Patched:500 loops, best of 5: 56.3 nsec per loop That's quite significant. Oh, it's because you converted builtin_iter() from METH_VARARGS to METH_FASTCALL at

[issue35717] enum.Enum error on sys._getframe(2)

2019-01-11 Thread Ethan Furman
Change by Ethan Furman : -- pull_requests: -11107 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35717] enum.Enum error on sys._getframe(2)

2019-01-11 Thread STINNER Victor
STINNER Victor added the comment: > Hi, PR https://github.com/python/cpython/pull/11521 should fix the issue. It's PR 11523. -- ___ Python tracker ___

[issue35717] enum.Enum error on sys._getframe(2)

2019-01-11 Thread Ethan Furman
Ethan Furman added the comment: That PR does not go with this issue. ;) -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue35582] Argument Clinic: inline parsing code for functions with only positional parameters

2019-01-11 Thread Stefan Behnel
Stefan Behnel added the comment: Nice! Well done, Serhiy! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35582] Argument Clinic: inline parsing code for functions with only positional parameters

2019-01-11 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: PR 11524 performs the same kind of changes as PR 11520, but for handwritten code (only if this causes noticeable speed up). Also iter() is now use the fast call convention. $ ./python -m timeit "iter(())" Unpatched: 500 loops, best of 5: 82.8 nsec

[issue35717] enum.Enum error on sys._getframe(2)

2019-01-11 Thread Rémi Lapeyre
Rémi Lapeyre added the comment: Hi, PR https://github.com/python/cpython/pull/11521 should fix the issue. -- ___ Python tracker ___

[issue35717] enum.Enum error on sys._getframe(2)

2019-01-11 Thread Rémi Lapeyre
Change by Rémi Lapeyre : -- keywords: +patch pull_requests: +11107 stage: test needed -> patch review ___ Python tracker ___ ___

[issue35582] Argument Clinic: inline parsing code for functions with only positional parameters

2019-01-11 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +11104, 11105, 11106 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue35582] Argument Clinic: inline parsing code for functions with only positional parameters

2019-01-11 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +11104, 11105 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue17467] Enhancement: give mock_open readline() and readlines() methods

2019-01-11 Thread Rémi Lapeyre
Change by Rémi Lapeyre : -- pull_requests: +11101, 11102, 11103 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue17467] Enhancement: give mock_open readline() and readlines() methods

2019-01-11 Thread Rémi Lapeyre
Change by Rémi Lapeyre : -- pull_requests: +11101, 11102 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35582] Argument Clinic: inline parsing code for functions with only positional parameters

2019-01-11 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +11104 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue17467] Enhancement: give mock_open readline() and readlines() methods

2019-01-11 Thread Rémi Lapeyre
Change by Rémi Lapeyre : -- pull_requests: +11101 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35717] enum.Enum error on sys._getframe(2)

2019-01-11 Thread Ethan Furman
Ethan Furman added the comment: Marking this as "easy". It needs a test showing the failing behavior, then the fix. -- keywords: +easy ___ Python tracker ___

[issue35717] enum.Enum error on sys._getframe(2)

2019-01-11 Thread Rémi Lapeyre
Change by Rémi Lapeyre : -- nosy: +remi.lapeyre ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue27015] subprocess.CalledProcessError's repr changes based on kwargs, and doesn't unpickle

2019-01-11 Thread Rémi Lapeyre
Change by Rémi Lapeyre : -- nosy: +remi.lapeyre ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue31855] mock_open is not compatible with read(n) (and pickle.load)

2019-01-11 Thread Rémi Lapeyre
Change by Rémi Lapeyre : -- keywords: +patch, patch, patch pull_requests: +11098, 11099, 11100 stage: -> patch review ___ Python tracker ___

[issue31855] mock_open is not compatible with read(n) (and pickle.load)

2019-01-11 Thread Rémi Lapeyre
Change by Rémi Lapeyre : -- keywords: +patch, patch pull_requests: +11098, 11099 stage: -> patch review ___ Python tracker ___ ___

[issue31855] mock_open is not compatible with read(n) (and pickle.load)

2019-01-11 Thread Rémi Lapeyre
Change by Rémi Lapeyre : -- keywords: +patch pull_requests: +11098 stage: -> patch review ___ Python tracker ___ ___

[issue31855] mock_open is not compatible with read(n) (and pickle.load)

2019-01-11 Thread Rémi Lapeyre
Rémi Lapeyre added the comment: The off-by-one error in a test added for an unrelated issue (#17467) makes me think @michael.foord just made a mistake in the test. > mock_open docs mentions about using a customized mock for complex cases I think it's more for complex things like fetching data

[issue35712] Make NotImplemented unusable in boolean context

2019-01-11 Thread Guido van Rossum
Guido van Rossum added the comment: I agree. On Thu, Jan 10, 2019 at 11:24 PM Serhiy Storchaka wrote: > > Serhiy Storchaka added the comment: > > This is a common mistake. Even the default implementation of object.__ne__ > had a bug, fixed only 4 years ago in issue21408. There were several

[issue35582] Argument Clinic: inline parsing code for functions with only positional parameters

2019-01-11 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 2a39d251f07d4c620e3b9a1848e3d1eb3067be64 by Serhiy Storchaka in branch 'master': bpo-35582: Argument Clinic: Optimize the "all boring objects" case. (GH-11520) https://github.com/python/cpython/commit/2a39d251f07d4c620e3b9a1848e3d1eb3067be64

[issue35718] Cannot initialize the "force" command-option

2019-01-11 Thread Opher Shachar
New submission from Opher Shachar : When creating a custom Command (or sub-classing one) we cannot initialize in "initialize_options()" the "force" option to 1, because Command.__init__ resets it to None after the call to self.initialize_options(). -- components: Distutils messages:

[issue35582] Argument Clinic: inline parsing code for functions with only positional parameters

2019-01-11 Thread STINNER Victor
STINNER Victor added the comment: $ ./python -m timeit -s "from operator import add" "add(1, 2)" Unpatched: 500 loops, best of 5: 40.7 nsec per loop Patched:1000 loops, best of 5: 32.6 nsec per loop We should stop you, or the timing will become negative if you continue!

[issue35582] Argument Clinic: inline parsing code for functions with only positional parameters

2019-01-11 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: PR 11520 additionally replaces PyArg_UnpackTuple() and _PyArg_UnpackStack() with _PyArg_CheckPositional() and inlined code in Argument Clinic. Some examples for PR 11520: $ ./python -m timeit "'abc'.strip()" Unpatched: 500 loops, best of 5: 51.2 nsec

[issue35582] Argument Clinic: inline parsing code for functions with only positional parameters

2019-01-11 Thread STINNER Victor
STINNER Victor added the comment: > I can trigger a benchmark run on speed.python.org once the change is merged. Aha, it seems like Serhiy has more optimizations to come: PR #11520. @Serhiy: tell me when you are done, so I can trigger a new benchmark run. --

[issue35717] enum.Enum error on sys._getframe(2)

2019-01-11 Thread Ethan Furman
Ethan Furman added the comment: Looks like the following code: if module is None: try: module = sys._getframe(2).f_globals['__name__'] except (AttributeError, ValueError) as exc: pass needs to have `KeyError` added to the

[issue35582] Argument Clinic: inline parsing code for functions with only positional parameters

2019-01-11 Thread STINNER Victor
STINNER Victor added the comment: I converted msg333446 into attached bench.py using perf. Results on my laptop: vstinner@apu$ ./python -m perf compare_to ref.json inlined.json --table -G +-+-+--+ | Benchmark | ref

[issue35582] Argument Clinic: inline parsing code for functions with only positional parameters

2019-01-11 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +11095, 11096, 11097 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue35582] Argument Clinic: inline parsing code for functions with only positional parameters

2019-01-11 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +11095 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35582] Argument Clinic: inline parsing code for functions with only positional parameters

2019-01-11 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +11095, 11096 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35717] enum.Enum error on sys._getframe(2)

2019-01-11 Thread STINNER Victor
STINNER Victor added the comment: The bug has been reported in my perf project: https://github.com/vstinner/perf/issues/49 -- ___ Python tracker ___

[issue35717] enum.Enum error on sys._getframe(2)

2019-01-11 Thread STINNER Victor
New submission from STINNER Victor : sys._getframe(2) fails in the following example: code = "from enum import Enum; Enum('Animal', 'ANT BEE CAT DOG')" code = compile(code, "", "exec") global_ns = {} local_ls = {} exec(code, global_ns, local_ls) Error with Python 3.7.2 (Fedora 29): Traceback

[issue35716] CLOCK_MONOTONIC_RAW available on macOS

2019-01-11 Thread Ronald Oussoren
Ronald Oussoren added the comment: Victor, the binaries are build on the macOS version mentioned in the download. That is, the modern 64-bit installers are build on macOS 10.9 with the 10.9 SDK, the older 32/64-bit intel installers are build on macOS 10.6 with the 10.6 SDK. With some work

[issue32710] test_asyncio: ProactorEventLoopTests sendfile tests leak references on Windows

2019-01-11 Thread STINNER Victor
STINNER Victor added the comment: Ok, _overlapped.Overlapped should now have a few less memory leaks :-) -- ___ Python tracker ___

[issue34838] Improve arg clinic code generation for cases with type checking

2019-01-11 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: PR 9659 is mostly superseded by issue35582. But it may contain other changes. Ammar, do you mind to create a new PR or merge the old PR with the current master? -- ___ Python tracker

[issue32710] test_asyncio: ProactorEventLoopTests sendfile tests leak references on Windows

2019-01-11 Thread miss-islington
miss-islington added the comment: New changeset 059997d78ed1a1a5a364b1846ac972c98c704927 by Miss Islington (bot) in branch '3.7': bpo-32710: Fix _overlapped.Overlapped memory leaks (GH-11489) https://github.com/python/cpython/commit/059997d78ed1a1a5a364b1846ac972c98c704927 --

[issue35582] Argument Clinic: inline parsing code for functions with only positional parameters

2019-01-11 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 4fa9591025b6a098f3d6402e5413ee6740ede6c5 by Serhiy Storchaka in branch 'master': bpo-35582: Argument Clinic: inline parsing code for positional parameters. (GH-11313)

[issue24746] doctest 'fancy diff' formats incorrectly strip trailing whitespace

2019-01-11 Thread STINNER Victor
STINNER Victor added the comment: All Refleaks buildots are back to green, thanks ;-) -- ___ Python tracker ___ ___

[issue32710] test_asyncio: ProactorEventLoopTests sendfile tests leak references on Windows

2019-01-11 Thread miss-islington
Change by miss-islington : -- pull_requests: +11092, 11093, 11094 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue32710] test_asyncio: ProactorEventLoopTests sendfile tests leak references on Windows

2019-01-11 Thread miss-islington
Change by miss-islington : -- pull_requests: +11092, 11093 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

  1   2   >