[issue36697] inspect.getclosurevars returns wrong globals dict

Change by Nitish : -- nosy: +nitishch ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35824] http.cookies._CookiePattern modifying regular expressions

MeiK added the comment: I found that using http.cookiejar.parse_ns_headers would cause some of the previous tests to fail, and if you think this method is workable, I can follow it to write a new one and pass all the tests. -- nosy: -martin.panter, xtreak

[issue35824] http.cookies._CookiePattern modifying regular expressions

MeiK added the comment: You are right, I saw the agreed way of parsing in RFC6265[1], it seems that you should not use regular expressions. I used http.cookiejar to update the code, but it failed to pass the test:

[issue36511] Add Windows ARM32 buildbot

Change by Paul Monson : -- keywords: +patch pull_requests: +12843 stage: -> patch review ___ Python tracker ___ ___

[issue16079] list duplicate test names with patchcheck

Raymond Hettinger added the comment: Should the unittest module grow a feature to scan for duplicate methods? I imagine that duplicate methods are a common problem. Possibly, inheriting from unittest can be accompanied by a metaclass that has __prepare__ with special dictionary that

[issue9194] winreg:fixupMultiSZ should check that P < Q in the inner loop

Steve Dower added the comment: Declaring this done - Ned can take the backport to 3.6 if/when he feels like it. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue9194] winreg:fixupMultiSZ should check that P < Q in the inner loop

miss-islington added the comment: New changeset 84efbaecaf50b771cc7a95fd9dd9602bd31de305 by Miss Islington (bot) (Zackery Spytz) in branch '2.7': [2.7] bpo-9194: Fix the bounds checking in winreg.c's fixupMultiSZ() (GH-12687) (GH-12916)

[issue9194] winreg:fixupMultiSZ should check that P < Q in the inner loop

Change by Zackery Spytz : -- pull_requests: +12842 stage: backport needed -> patch review ___ Python tracker ___ ___

[issue35824] http.cookies._CookiePattern modifying regular expressions

daniel hahler added the comment: http.cookiejar parses this correctly, using http2time: >>> import http.cookiejar >>> http.cookiejar.parse_ns_headers(["has_recent_activity=1; path=/; expires=Mon, 22 Apr 2019 23:27:18 -"]) [[('has_recent_activity', '1'), ('path', '/'),

[issue35824] http.cookies._CookiePattern modifying regular expressions

daniel hahler added the comment: Another example of a value that fails to parse is if "-" is used instead of "GMT", which is the case with GitHub: > Set-Cookie: has_recent_activity=1; path=/; expires=Mon, 22 Apr 2019 23:27:18 > - So using a regular expression here to only parse the

[issue36695] Change (regression?) in v3.8.0a3 doctest output after capturing the stderr output from a raised warning

Brian Skinn added the comment: TBH, now that I've tweaked tox and CI just not to run the doctests on 3.8, I don't really need this to be fixed. This seems like such an edge case -- a doctest catching a warning with a message containing single quotes -- it might not really be worth the

[issue29940] Add follow_wrapped=True option to help()

Change by Emmanuel Arias : -- keywords: +patch pull_requests: +12841 stage: -> patch review ___ Python tracker ___ ___

[issue29183] Unintuitive error handling in wsgiref when a crash happens in write() or close()

Change by Berker Peksag : -- keywords: +patch pull_requests: +12840 stage: -> patch review ___ Python tracker ___ ___

[issue36699] building for riscv multilib (patch attached)

Change by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue11588] Add "necessarily inclusive" groups to argparse

Change by Mike Auty : -- nosy: +ikelos ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36688] _dummy_thread lacks an RLock implementaiton

Brett Cannon added the comment: Basically _thread.RLock was added without an equivalent in _dummy_thread. Add that and it will fix the issue. It probably wouldn't be too hard since you have to implement it as if it's single-threaded and there's already a lock class in _dummy_thread to work

[issue36624] cleanup the stdlib and tests with regard to sys.platform usage

Steve Dower added the comment: I like this, though I don't like using the platform module here and would prefer sys.platform to be canonical (until there's a need to differentiate - e.g. some tests coming for Windows ARM32 will need to be more specific). In general, I'd like fewer tests to

[issue36661] Missing dataclass decorator import in dataclasses module docs

Brett Cannon added the comment: I also don't think it's critical to make examples within a module's docs work like a doctest. Plus I discourage importing objects directly off of modules anyway and this would actually promote that. -- nosy: +brett.cannon

[issue36698] Shell restart when error message contains non-BMP characters

Terry J. Reedy added the comment: You are correct about reason. This is essentially a duplicate of #22742, but I am leaving it open for now because the behavior is worse and there is additional information in the tracebacks. The lines for IDLE internals are normally removed, but the

[issue36695] Change (regression?) in v3.8.0a3 doctest output after capturing the stderr output from a raised warning

Brett Cannon added the comment: If you look at that commit that Thomas made all it did was change where the string was grabbed from, not what type of object was used. So it doesn't make any sense as to why that would cause any specific change, so I think this may be doctest's doing.

[issue36680] duplicate method definition in Lib/test/test_importlib/test_util.py

Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue22742] IDLE shows traceback when printing non-BMP character

Terry J. Reedy added the comment: On my puzzlement above: repr(s) is a string of 3 characters -- s bracketed by quote characters. print(repr(s)) fails. I am not sure how s gets expanded to the full escape in IDLE. ascii(s) expands all non-ascii and adds extra quotes. Need to check Shell

[issue18564] Integer overflow in the socket function parsing a Bluetooth address

Steve Dower added the comment: According to a couple of scanf docs I found, the '%x' format expects to write into unsigned int*, just as we already do. So it shouldn't be possible to overflow there. The following line (or-ing all the values and checking that it's less than 256) handles the

[issue36681] duplicate method definition in Lib/test/test_logging.py

Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue36679] duplicate method definition in Lib/test/test_genericclass.py

Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue36683] duplicate method definition in Lib/test/test_utf8_mode.py

Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue36682] duplicate method definitions in Lib/test/test_sys_setprofile.py

Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue36679] duplicate method definition in Lib/test/test_genericclass.py

Steve Dower added the comment: New changeset d437012cdd4a38b5b3d05f139d5f0a28196e4769 by Steve Dower (Windson yang) in branch 'master': bpo-36679: Rename duplicate test_class_getitem function (GH-12892) https://github.com/python/cpython/commit/d437012cdd4a38b5b3d05f139d5f0a28196e4769

[issue36680] duplicate method definition in Lib/test/test_importlib/test_util.py

Steve Dower added the comment: New changeset c442b1c486db5cb0aa589b43f73385d9cc5706e3 by Steve Dower (Windson yang) in branch 'master': bpo-36680: Rename duplicate test_source_from_cache_path_like_arg function (GH-12893)

[issue36678] duplicate method definitions in Lib/test/test_dataclasses.py

Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue36681] duplicate method definition in Lib/test/test_logging.py

Steve Dower added the comment: New changeset 3d6f61edb8a6161148b3cf3eeb291408cc91154a by Steve Dower (Windson yang) in branch 'master': bpo-36681: Remove duplicate test_regression_29220 function (GH-12894) https://github.com/python/cpython/commit/3d6f61edb8a6161148b3cf3eeb291408cc91154a

[issue36683] duplicate method definition in Lib/test/test_utf8_mode.py

Steve Dower added the comment: New changeset f51dd4feb0794b7659f281173da9d8a04317d134 by Steve Dower (Windson yang) in branch 'master': bpo-36683: Rename duplicate test_io_encoding to test_pyio_encoding (GH-12896)

[issue36682] duplicate method definitions in Lib/test/test_sys_setprofile.py

Steve Dower added the comment: New changeset 007d0b0188a16273a5850d89857ecef97c1f4595 by Steve Dower (Windson yang) in branch 'master': bpo-36682: Rename duplicate tests in test_sys_setprofile (GH-12895) https://github.com/python/cpython/commit/007d0b0188a16273a5850d89857ecef97c1f4595

[issue36678] duplicate method definitions in Lib/test/test_dataclasses.py

Steve Dower added the comment: New changeset be372d73b4c59026134a7e722ece34367c3bd3b6 by Steve Dower (Windson yang) in branch 'master': bpo-36678: Rename duplicate tests in test_dataclasses (GH-12899) https://github.com/python/cpython/commit/be372d73b4c59026134a7e722ece34367c3bd3b6

[issue36700] base64 has old references that should be updated

New submission from Paul Hoffman : The documentation for base64 library has an RFC that is obsolete. -- assignee: docs@python components: Documentation messages: 340668 nosy: docs@python, paulehoffman priority: normal pull_requests: 12839 severity: normal status: open title: base64 has

[issue36699] building for riscv multilib (patch attached)

New submission from Andreas K. Hüttel : Hi. I have been trying to install Python on a (well prototype of a) risc-v multilib Gentoo system, where the system library directory is /usr/lib64/lp64d (!). See as reference for the directories

[issue33608] Add a cross-interpreter-safe mechanism to indicate that an object may be destroyed.

Steve Dower added the comment: New changeset 264490797ad936868c54b3d4ceb0343e7ba4be76 by Steve Dower in branch 'master': bpo-33608: Normalize atomic macros so that they all expect an atomic struct (GH-12877) https://github.com/python/cpython/commit/264490797ad936868c54b3d4ceb0343e7ba4be76

[issue29940] Add follow_wrapped=True option to help()

Change by Emmanuel Arias : -- nosy: +eamanu ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32892] Remove specific constant AST types in favor of ast.Constant

Miro Hrončok added the comment: Mako (now fixed) https://github.com/sqlalchemy/mako/issues/287 -- nosy: +hroncok ___ Python tracker ___

[issue36672] A compiler warning in winreg.SetValue()

miss-islington added the comment: New changeset 36aecc0079af0ec65add8ffb5bcdea9a594baca4 by Miss Islington (bot) in branch '3.7': bpo-36672: Fix a compiler warning in winreg.SetValue() (GH-12882) https://github.com/python/cpython/commit/36aecc0079af0ec65add8ffb5bcdea9a594baca4 --

[issue9194] winreg:fixupMultiSZ should check that P < Q in the inner loop

miss-islington added the comment: New changeset 7038deed09784a03e2a7bad500f0054d29876ae7 by Miss Islington (bot) in branch '3.7': bpo-9194: Fix the bounds checking in winreg.c's fixupMultiSZ() (GH-12687) https://github.com/python/cpython/commit/7038deed09784a03e2a7bad500f0054d29876ae7

[issue36672] A compiler warning in winreg.SetValue()

Change by miss-islington : -- pull_requests: +12838 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36672] A compiler warning in winreg.SetValue()

Steve Dower added the comment: New changeset 34366b7f914eedbcc33aebe882098a2199ffaf82 by Steve Dower (Zackery Spytz) in branch 'master': bpo-36672: Fix a compiler warning in winreg.SetValue() (GH-12882) https://github.com/python/cpython/commit/34366b7f914eedbcc33aebe882098a2199ffaf82

[issue9194] winreg:fixupMultiSZ should check that P < Q in the inner loop

Steve Dower added the comment: Thanks Zackery! I've merged this main part of the fix (though it requires a manual backport to 2.7). As it's a buffer overrun, I've sent it back to 3.6 as well. Eryk - thanks for the additional detail. I wonder whether it would be just as easy to guarantee an

[issue36698] Shell restart when error message contains non-BMP characters

New submission from TheMathsGod : When attempting to raise an error with a message containing non-BMP characters (Unicode ordinals above U+0x), the python shell displays a long traceback including several UnicodeEncodeErrors and then restarts. Example: >>> raise Exception('\U0001f603')

[issue9194] winreg:fixupMultiSZ should check that P < Q in the inner loop

Change by miss-islington : -- pull_requests: +12837 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue9194] winreg:fixupMultiSZ should check that P < Q in the inner loop

Change by miss-islington : -- pull_requests: +12836 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue9194] winreg:fixupMultiSZ should check that P < Q in the inner loop

Steve Dower added the comment: New changeset 56ed86490cb8221c874d432461d77702437f63e5 by Steve Dower (Zackery Spytz) in branch 'master': bpo-9194: Fix the bounds checking in winreg.c's fixupMultiSZ() (GH-12687) https://github.com/python/cpython/commit/56ed86490cb8221c874d432461d77702437f63e5

[issue29734] os.stat handle leak

Berker Peksag added the comment: New changeset 6ef726af3ec106013c7c4261ddb306854f2b1778 by Berker Peksag in branch 'master': bpo-29734: Cleanup test_getfinalpathname_handles test (GH-12908) https://github.com/python/cpython/commit/6ef726af3ec106013c7c4261ddb306854f2b1778 -- nosy:

[issue36695] Change (regression?) in v3.8.0a3 doctest output after capturing the stderr output from a raised warning

Brian Skinn added the comment: , it seems like the problem must somehow stem from the new commit using frame.f_code.co_filename (or the C equivalent), instead of using __file__ as previously. Consider this warn2.py, similar to the other but with no single quotes in the warning message:

[issue29734] os.stat handle leak

Change by Berker Peksag : -- pull_requests: +12835 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28113] Remove Py_CreateSymbolicLinkW

Berker Peksag added the comment: Py_CreateSymbolicLinkW() has been removed in bpo-31512. PR 12907 updates tests to use support.TESTN. -- ___ Python tracker ___

[issue28113] Remove Py_CreateSymbolicLinkW

Change by Berker Peksag : -- pull_requests: +12834 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36695] Change (regression?) in v3.8.0a3 doctest output after capturing the stderr output from a raised warning

Karthikeyan Singaravelan added the comment: > Karthikeyan, my apologies for the slow reply -- I posted this right before I > went to bed. No problem, thanks for the simplified program. I wrote a similar one based on doctest that fails with commit and passes before it. I am still confused

[issue36690] A typing error in demo rpython.py

Berker Peksag added the comment: Thank you! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue36690] A typing error in demo rpython.py

Berker Peksag added the comment: New changeset 5407aaf18b8d33d0a327991db366457ac6fead2d by Berker Peksag (Miss Islington (bot)) in branch '3.7': bpo-36690: Fix typo in Tools/demo/rpython.py (GH-12903) https://github.com/python/cpython/commit/5407aaf18b8d33d0a327991db366457ac6fead2d

[issue36695] Change (regression?) in v3.8.0a3 doctest output after capturing the stderr output from a raised warning

Brian Skinn added the comment: Here is warn.py, a minimal no-dependency repro script: ``` import doctest class Tester: r"""Provide docstring for testing. >>> import warnings >>> from contextlib import redirect_stderr >>> from io import StringIO >>> sio = StringIO()

[issue36690] A typing error in demo rpython.py

Berker Peksag added the comment: New changeset d59b662e490d3fae662c5f81fa5248f0445d2158 by Berker Peksag (周家未) in branch 'master': bpo-36690: Fix typo in Tools/demo/rpython.py (GH-12903) https://github.com/python/cpython/commit/d59b662e490d3fae662c5f81fa5248f0445d2158 -- nosy:

[issue36690] A typing error in demo rpython.py

Change by miss-islington : -- pull_requests: +12833 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36696] possible multiple regressions on AIX

Inada Naoki added the comment: Maybe, XLC doesn't support -D name. -Dname should be used instead. -- nosy: +inada.naoki ___ Python tracker ___

[issue36523] Add docstring to io.IOBase.writelines

Change by Inada Naoki : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue36523] Add docstring to io.IOBase.writelines

Inada Naoki added the comment: New changeset 1100ae8f3fb1d5a8f6f5638919196bd8fab66de9 by Inada Naoki (Marcin Niemira) in branch '3.7': bpo-36523: Add docstring to io.IOBase.writelines (GH-12683) https://github.com/python/cpython/commit/1100ae8f3fb1d5a8f6f5638919196bd8fab66de9 --

[issue36695] Change (regression?) in v3.8.0a3 doctest output after capturing the stderr output from a raised warning

Brian Skinn added the comment: Karthikeyan, my apologies for the slow reply -- I posted this right before I went to bed. To emphasize, the change to the formatting of the string contents, by adding the filename, I think is not problematic: I'm using ellipses to elide everything before and

[issue36523] Add docstring to io.IOBase.writelines

Change by Marcin Niemira : -- pull_requests: +12832 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36523] Add docstring to io.IOBase.writelines

Inada Naoki added the comment: New changeset ab86521a9d731e39bd9056420bb7774fd144 by Inada Naoki (Marcin Niemira) in branch 'master': bpo-36523: Add docstring to io.IOBase.writelines (GH-12683) https://github.com/python/cpython/commit/ab86521a9d731e39bd9056420bb7774fd144 --

[issue36695] Change (regression?) in v3.8.0a3 doctest output after capturing the stderr output from a raised warning

Thomas Kluyver added the comment: It's not obvious to me why that change to finding the source file related to the warning should affect the format of the warning message printed. It might be something that could be fixed in the warning module. But I don't understand where it's going wrong

[issue36697] inspect.getclosurevars returns wrong globals dict

Change by Karthikeyan Singaravelan : -- nosy: +yselivanov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36697] inspect.getclosurevars returns wrong globals dict

New submission from Noitul : >>> import inspect >>> a = 0 >>> b = 1 >>> def abc(): >>> return a.b >>>

[issue36690] A typing error in demo rpython.py

Change by SilentGhost : -- nosy: +gvanrossum ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29940] Add follow_wrapped=True option to help()

Change by Karthikeyan Singaravelan : -- nosy: +rhettinger versions: +Python 3.8 -Python 2.7, Python 3.3, Python 3.4, Python 3.5, Python 3.6, Python 3.7 ___ Python tracker ___

[issue36695] Change (regression?) in v3.8.0a3 doctest output after capturing the stderr output from a raised warning

Karthikeyan Singaravelan added the comment: I tried bisecting and got to this commit 11a896652ee98aa44e59ed25237f9efb56635dcf (issue33375) . Seems this changes warning reporting output to add filename. I guess it's better to change the doctest to adopt this change. I have added the devs on

[issue36690] A typing error in demo rpython.py

Change by Roundup Robot : -- keywords: +patch pull_requests: +12831 stage: needs patch -> patch review ___ Python tracker ___ ___

[issue36696] possible multiple regressions on AIX

New submission from Michael Felt : My AIX bot has been very consistent - only the multiprocessing tests failing when run by bot, but 4 or 5 days ago 3 to 5 additional tests - that, afaik, had never failed before, are now failing. These may also be compiler related specifics, or the presence

[issue36695] Change (regression?) in v3.8.0a3 doctest output after capturing the stderr output from a raised warning

Karthikeyan Singaravelan added the comment: Can you please attach a single and standalone file without dependencies like attrs so that it would help in bisecting the issue? -- nosy: +xtreak ___ Python tracker