[issue38164] polishing asyncio Streams API

Kyle Stanley added the comment: Closed by the new asyncio stream API reversion in GH-16485 and GH-16482. -- stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue38242] Revert the new asyncio Streams API

Change by Kyle Stanley : -- status: closed -> open ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38242] Revert the new asyncio Streams API

Change by Kyle Stanley : -- stage: resolved -> commit review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38242] Revert the new asyncio Streams API

Kyle Stanley added the comment: > I've reverted the code. Andrew, would really appreciate if you could quickly > do a post commit review. Oops, I'll reopen it. -- ___ Python tracker

[issue38242] Revert the new asyncio Streams API

Change by Kyle Stanley : -- stage: commit review -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list

[issue38242] Revert the new asyncio Streams API

Yury Selivanov added the comment: New changeset 1c19d656a79a00f58361ceb61c0a6d1faf90c686 by Yury Selivanov in branch '3.8': bpo-38242: Revert "bpo-36889: Merge asyncio streams (GH-13251)" (#16482) (#16485) https://github.com/python/cpython/commit/1c19d656a79a00f58361ceb61c0a6d1faf90c686

[issue38242] Revert the new asyncio Streams API

Yury Selivanov added the comment: I've reverted the code. Andrew, would really appreciate if you could quickly do a post commit review. -- stage: patch review -> commit review ___ Python tracker

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

Yury Selivanov added the comment: New changeset 1c19d656a79a00f58361ceb61c0a6d1faf90c686 by Yury Selivanov in branch '3.8': bpo-38242: Revert "bpo-36889: Merge asyncio streams (GH-13251)" (#16482) (#16485) https://github.com/python/cpython/commit/1c19d656a79a00f58361ceb61c0a6d1faf90c686

[issue38163] AsyncMock child mocks should detect their type

Lisa Roach added the comment: New changeset 21f24ead90c22d0e2c2ebf14a64b37d99de54b33 by Lisa Roach in branch '3.8': [3.8] bpo-38163: Child mocks detect their type as sync or async (GH-16471) (GH-16484) https://github.com/python/cpython/commit/21f24ead90c22d0e2c2ebf14a64b37d99de54b33

[issue38163] AsyncMock child mocks should detect their type

Change by Lisa Roach : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

Change by Yury Selivanov : -- pull_requests: +16071 pull_request: https://github.com/python/cpython/pull/16485 ___ Python tracker ___

[issue38242] Revert the new asyncio Streams API

Change by Yury Selivanov : -- pull_requests: +16070 pull_request: https://github.com/python/cpython/pull/16485 ___ Python tracker ___

[issue38163] AsyncMock child mocks should detect their type

Change by Lisa Roach : -- pull_requests: +16069 pull_request: https://github.com/python/cpython/pull/16484 ___ Python tracker ___

[issue38242] Revert the new asyncio Streams API

Yury Selivanov added the comment: New changeset 6758e6e12a71ef5530146161881f88df1fa43382 by Yury Selivanov in branch 'master': bpo-38242: Revert "bpo-36889: Merge asyncio streams (GH-13251)" (#16482) https://github.com/python/cpython/commit/6758e6e12a71ef5530146161881f88df1fa43382

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

Yury Selivanov added the comment: New changeset 6758e6e12a71ef5530146161881f88df1fa43382 by Yury Selivanov in branch 'master': bpo-38242: Revert "bpo-36889: Merge asyncio streams (GH-13251)" (#16482) https://github.com/python/cpython/commit/6758e6e12a71ef5530146161881f88df1fa43382

[issue38163] AsyncMock child mocks should detect their type

Lisa Roach added the comment: New changeset 3667e1ee6c90e6d3b6a745cd590ece87118f81ad by Lisa Roach in branch 'master': bpo-38163: Child mocks detect their type as sync or async (GH-16471) https://github.com/python/cpython/commit/3667e1ee6c90e6d3b6a745cd590ece87118f81ad --

[issue37096] Add large-file tests for modules using sendfile(2)

Change by Giampaolo Rodola' : -- components: +Tests -Library (Lib) resolution: -> fixed stage: patch review -> resolved status: open -> closed type: -> enhancement versions: +Python 3.9 -Python 3.8 ___ Python tracker

[issue37096] Add large-file tests for modules using sendfile(2)

Giampaolo Rodola' added the comment: New changeset 5bcc6d89bcb622a6786fff632fabdcaf67dbb4e2 by Giampaolo Rodola in branch 'master': bpo-37096: Add large-file tests for modules using sendfile(2) (GH-13676) https://github.com/python/cpython/commit/5bcc6d89bcb622a6786fff632fabdcaf67dbb4e2

[issue38045] enum.Flag instance creation is slow

Change by hongweipeng : -- pull_requests: +16068 pull_request: https://github.com/python/cpython/pull/16483 ___ Python tracker ___

[issue38161] AsyncMock add `.awaited` like `.called`

Lisa Roach added the comment: New changeset 36e7e4aabb662e86e9dace1a6447492f45868654 by Lisa Roach (Miss Islington (bot)) in branch '3.8': bpo-38161: Removes _AwaitEvent from AsyncMock. (GH-16443) (GH-16481) https://github.com/python/cpython/commit/36e7e4aabb662e86e9dace1a6447492f45868654

[issue38136] Remove AsyncMock.assert_awaited_*

Change by Lisa Roach : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue38093] Update MagicMock __aenter__ and __aexit__ to return AsyncMock's

Change by Lisa Roach : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue38108] Everything in Mock should inherit from Base

Change by Lisa Roach : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue38242] Revert the new asyncio Streams API

Change by Yury Selivanov : -- pull_requests: +16066 pull_request: https://github.com/python/cpython/pull/16482 ___ Python tracker ___

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

Change by Yury Selivanov : -- pull_requests: +16067 pull_request: https://github.com/python/cpython/pull/16482 ___ Python tracker ___

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

Tim Peters added the comment: Ah, nevermind my last comment - yes. handle_weakrefs will clear all weakrefs to the objects we know are trash. -- ___ Python tracker ___

[issue38161] AsyncMock add `.awaited` like `.called`

Change by miss-islington : -- pull_requests: +16065 pull_request: https://github.com/python/cpython/pull/16481 ___ Python tracker ___

[issue38108] Everything in Mock should inherit from Base

Lisa Roach added the comment: New changeset b76ab352405df105c2d459fc66ef8dc98e47b37c by Lisa Roach (Miss Islington (bot)) in branch '3.8': bpo-38108: Makes mock objects inherit from Base (GH-16060) (GH-16470) https://github.com/python/cpython/commit/b76ab352405df105c2d459fc66ef8dc98e47b37c

[issue38161] AsyncMock add `.awaited` like `.called`

Lisa Roach added the comment: New changeset 25e115ec00b5f75e3589c9f21013c47c21e1753f by Lisa Roach in branch 'master': bpo-38161: Removes _AwaitEvent from AsyncMock. (GH-16443) https://github.com/python/cpython/commit/25e115ec00b5f75e3589c9f21013c47c21e1753f --

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

Tim Peters added the comment: > I see that handle_weakrefs() calls _PyWeakref_ClearRef() and that > will clear the weakref even if it doesn't have callback. So, I > think that takes care for the hole I was worried about. I.e. a > __del__ method could have a weakref to an non-valid object. >

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

Tim Peters added the comment: > Note that my flags show that W *is* in 'unreachable'. It has > to be otherwise F would not have tp_clear called on it. Right! W holds a strong reference to F, so if W were thought to be reachable, F would be too. But F isn't. > But when delete_garbage()

[issue38308] Add optional weighting to statistics.harmonic_mean()

Steven D'Aprano added the comment: Sounds like a great idea to me. Thanks, Steven -- ___ Python tracker ___ ___ Python-bugs-list

[issue38318] Issues linking with ncurses and tinfo (cannot resolve symbols)

Change by Ammar Askar : -- nosy: +skrah, twouters ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38318] Issues linking with ncurses and tinfo (cannot resolve symbols)

Michael Everitt added the comment: May have confused the '_readline' extension with the '_ncurses' extension .. apologies! attaching build.log from x86_64. -- Added file: https://bugs.python.org/file48632/build-x86_64-uclibc.log ___ Python

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

Neil Schemenauer added the comment: > We can have finalizer code running during delete_garbage(). That > code should not have access to non-valid objects. Weakrefs seem be > a way to violate that. handle_weakrefs() take care of some of them > but it seems there are other issues. I see that

[issue38318] Issues linking with ncurses and tinfo (cannot resolve symbols)

New submission from Michael Everitt : tinfo library detection as part of ncurses is inconsistent, and causes build failure when expected symbols aren't found at link-time. This breaks compilation of the 'readline' module as the attached log shows. It seems to work in some configurations and

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

Neil Schemenauer added the comment: > Fleshing out something I left implicit: if there's a trash object T > with a finalizer but we don't KNOW it's trash, we won't force-run its > finalizer before delete_garbage starts either. Then, really the same > thing: we may tp_clear some piece of trash

[issue23284] Improve termcap detection in setup.py

Change by Michael Everitt : -- nosy: +veremitz ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

Neil Schemenauer added the comment: Since W is in the unreachable set, we should not be executing its callback. Would the attached rough patch (gc_disable_wr_callback.txt) be a possible fix? When we find W inside handle_weakrefs(), we mark it as trash and will not execute the callback.

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

Neil Schemenauer added the comment: I hacked up my copy of CPython to add flags to PyObject to see the GC state of objects. That makes it easier to know if an object is in the 'unreachable' list or not. > We must know that F is trash, else we never would have called tp_clear(F). Yup. In

[issue38242] Revert the new asyncio Streams API

Change by Guido van Rossum : -- nosy: -gvanrossum ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38164] polishing asyncio Streams API

Change by Caleb Hattingh : -- nosy: +cjrh ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38242] Revert the new asyncio Streams API

Change by Caleb Hattingh : -- nosy: +cjrh ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33135] Define field prefixes for the various config structs

Change by STINNER Victor : -- Removed message: https://bugs.python.org/msg353517 ___ Python tracker ___ ___ Python-bugs-list

[issue33135] Define field prefixes for the various config structs

STINNER Victor added the comment: (Oops, I posted a comment to the wrong issue, it was a comment for bpo-38317.) -- ___ Python tracker ___

[issue33135] Define field prefixes for the various config structs

STINNER Victor added the comment: Warnings options priority are badly documented. The latest major change was bpo-20361 when -b command line option changed to get the highest priority (-b > -W). -- ___ Python tracker

[issue38317] PyConfig (PEP 587): PyConfig.warnoptions should have the highest priority

STINNER Victor added the comment: Oh, the documentation in the PEP 587 was also wrong. I updated it: https://github.com/python/peps/commit/16bc2821eeb09b4692c372a5a359fd28993cd29b The "warnings options priority" is currently not documented at:

[issue38317] PyConfig (PEP 587): PyConfig.warnoptions should have the highest priority

miss-islington added the comment: New changeset c9ed9e6fc76323ed537fb79d4232bcd27d82c57e by Miss Islington (bot) in branch '3.8': bpo-38317: Fix PyConfig.warnoptions priority (GH-16478) https://github.com/python/cpython/commit/c9ed9e6fc76323ed537fb79d4232bcd27d82c57e -- nosy:

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

Tim Peters added the comment: Fleshing out something I left implicit: if there's a trash object T with a finalizer but we don't KNOW it's trash, we won't force-run its finalizer before delete_garbage starts either. Then, really the same thing: we may tp_clear some piece of trash T's

[issue38317] PyConfig (PEP 587): PyConfig.warnoptions should have the highest priority

Change by miss-islington : -- pull_requests: +16064 pull_request: https://github.com/python/cpython/pull/16479 ___ Python tracker ___

[issue38317] PyConfig (PEP 587): PyConfig.warnoptions should have the highest priority

STINNER Victor added the comment: New changeset fb4ae152a9930f0e00cae8b2807f534058cf341a by Victor Stinner in branch 'master': bpo-38317: Fix PyConfig.warnoptions priority (GH-16478) https://github.com/python/cpython/commit/fb4ae152a9930f0e00cae8b2807f534058cf341a --

[issue38317] PyConfig (PEP 587): PyConfig.warnoptions should have the highest priority

Change by STINNER Victor : -- keywords: +patch pull_requests: +16063 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16478 ___ Python tracker ___

[issue38317] PyConfig (PEP 587): PyConfig.warnoptions should have the highest priority

New submission from STINNER Victor : The PEP 587 says that PyConfig.warnoptions has the highest priority for warnings options: https://www.python.org/dev/peps/pep-0587/#priority-and-rules But in the current implementation, PyConfig.warnoptions has... the lowest priority :-( Attached PR not

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

Tim Peters added the comment: Sorry, this is very hard for me - broke an arm near the shoulder on Tuesday, and between bouts of pain and lack of good sleep, concentration is nearly impossible. Typing with one hand just makes it worse :-( We must know that F is trash, else we never would

[issue38316] docs: Code object's "co_stacksize" field is described with mistake

Ammar Askar added the comment: Yeah, that parenthesized bit seems a bit weird: co_stacksize really has nothing to do with the number of variables, it's just that certain opcodes (https://docs.python.org/3/library/dis.html#python-bytecode-instructions) push and pop off the stack,

[issue38304] PEP 587 implementation is not ABI forward compatible

STINNER Victor added the comment: > Both it and struct_size should be removed, as we don't support updating an > embedded Python runtime to a new X.Y.0 release without rebuilding the > embedding application. See my reply on python-dev:

[issue38304] PEP 587 implementation is not ABI forward compatible

STINNER Victor added the comment: > The hidden _config_version field wasn't in the accepted PEP. It was in the accepted PEP and I replaced it with struct_size: https://github.com/python/peps/commit/afa38c0bef7738b8fcc3173daee8488e0420833d I suggest to discuss the issue on the thread that I

[issue38316] docs: Code object's "co_stacksize" field is described with mistake

New submission from Paul Sokolovsky : CPython's Data Model -> Internal types -> Code objects, direct link as of version 3.7 is: https://docs.python.org/3.7/reference/datamodel.html?highlight=co_stacksize#index-55 , states following: * "co_nlocals is the number of local variables used by the

[issue38313] Crash/No start

Zachary Ware added the comment: Sorry, but you've given us no information to work with here. Which version of Python? Which version of Windows? What exactly are you trying to do? What error message do you get? Which distribution of Python are you using? How did you install it? Have

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

Neil Schemenauer added the comment: Victor: > I'm surprised that the function would be seen as "unreachable" if > it's reference counter was equal to 135: If all those references are contained within that garbage set, it is possible. Pablo: > For the weakref to be handled correctly the

[issue38302] __rpow__ not reached when __ipow__ returns NotImplemented

Ammar Askar added the comment: This isn't the ternary form of pow(), the documentation there is referring to the `pow(base, exp, modulus)`. -- nosy: +ammar2 ___ Python tracker

[issue38315] Provide defaultdict variant that passes key to default_factory

Raymond Hettinger added the comment: The __missing__() method already fulfills this need: class DoubleDict(dict): def __missing__(self, key): return key * 2 If desired, it can also add entries: class DoubleDict(dict): def __missing__(self, key):

[issue38302] __rpow__ not reached when __ipow__ returns NotImplemented

hongweipeng added the comment: The document says(https://docs.python.org/3.9/reference/datamodel.html?highlight=__rpow__#object.__rpow__)： >Note that ternary pow() will not try calling __rpow__() (the coercion rules >would become too complicated). -- nosy: +hongweipeng

[issue38315] Provide defaultdict variant that passes key to default_factory

New submission from Mark Amery : There seems to be at least some demand for the ability to have the key being accessed be passed to the factory function of a defaultdict. See e.g. https://stackoverflow.com/q/2912231/1709587 (13k views) or previous enhancement suggestion

[issue36274] http.client cannot send non-ASCII request lines

Change by Jason R. Coombs : -- pull_requests: +16062 pull_request: https://github.com/python/cpython/pull/16476 ___ Python tracker ___

[issue38216] Fix for issue30458 (HTTP Header Injection) prevents crafting invalid requests

Change by Jason R. Coombs : -- pull_requests: +16061 pull_request: https://github.com/python/cpython/pull/16476 ___ Python tracker ___

[issue38216] Fix for issue30458 (HTTP Header Injection) prevents crafting invalid requests

Change by Jason R. Coombs : -- pull_requests: +16059 pull_request: https://github.com/python/cpython/pull/16475 ___ Python tracker ___

[issue36274] http.client cannot send non-ASCII request lines

Change by Jason R. Coombs : -- pull_requests: +16060 pull_request: https://github.com/python/cpython/pull/16475 ___ Python tracker ___

[issue38019] asyncio subprocess AttributeError: 'NoneType' object has no attribute '_add_reader' / '_remove_reader'

Change by Andrew Svetlov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue38216] Fix for issue30458 (HTTP Header Injection) prevents crafting invalid requests

Jason R. Coombs added the comment: > Someone should look at how to do similar in 2.7 _if_ the project(s) that > complained about the problem rely on such behavior in their last 2.7 > compatible releases. Looking at the history, it seems that only two projects were mentioned, CherryPy and

[issue38314] Implement unix read_pipe.is_reading() method

Andrew Svetlov added the comment: Nothing special. There is UnixReadPipeTransportTests test cases inside Lib/test/test_asyncio/test_unix_events.py This class has a bunch of tests for pause_reading() / resume_reading(). Test(s) for is_reading() can be built in the same way. --

[issue20504] cgi.FieldStorage, multipart, missing Content-Length

Change by Ned Deily : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.9 -Python 3.4, Python 3.5, Python 3.6 ___ Python tracker

[issue38314] Implement unix read_pipe.is_reading() method

Shubham Upreti added the comment: I would like to take this up. I am a beginner and any more instructions you want to give me. -- nosy: +shubh07 ___ Python tracker ___

[issue38019] asyncio subprocess AttributeError: 'NoneType' object has no attribute '_add_reader' / '_remove_reader'

miss-islington added the comment: New changeset 19cd5951ec4480c7cfcbcc379b36902312cfb8b8 by Miss Islington (bot) in branch '3.8': bpo-38019: correctly handle pause/resume reading of closed asyncio unix pipe (GH-16472)

[issue38019] asyncio subprocess AttributeError: 'NoneType' object has no attribute '_add_reader' / '_remove_reader'

miss-islington added the comment: New changeset 1c3e4691bb41fa070d6f4836cb03005123e53e4b by Miss Islington (bot) in branch '3.7': bpo-38019: correctly handle pause/resume reading of closed asyncio unix pipe (GH-16472)

[issue38019] asyncio subprocess AttributeError: 'NoneType' object has no attribute '_add_reader' / '_remove_reader'

Andrew Svetlov added the comment: New changeset 58498bc7178608b1ab031994ca09c43889ce3e76 by Andrew Svetlov in branch 'master': bpo-38019: correctly handle pause/resume reading of closed asyncio unix pipe (GH-16472)

[issue38019] asyncio subprocess AttributeError: 'NoneType' object has no attribute '_add_reader' / '_remove_reader'

Change by miss-islington : -- pull_requests: +16058 pull_request: https://github.com/python/cpython/pull/16474 ___ Python tracker ___

[issue38019] asyncio subprocess AttributeError: 'NoneType' object has no attribute '_add_reader' / '_remove_reader'

Change by miss-islington : -- pull_requests: +16057 pull_request: https://github.com/python/cpython/pull/16473 ___ Python tracker ___

[issue38308] Add optional weighting to statistics.harmonic_mean()

Change by Mark Dickinson : -- nosy: +mark.dickinson ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38314] Implement unix read_pipe.is_reading() method

Andrew Svetlov added the comment: The issue is easy, basically we need the following code plus a test def is_reading(self): return not self._paused and not self._closing -- keywords: +newcomer friendly type: -> enhancement ___ Python

[issue38314] Implement unix read_pipe.is_reading() method

New submission from Andrew Svetlov : Sockets support it, there is no reason for missing the method in unix pipe. -- components: asyncio messages: 353494 nosy: asvetlov, yselivanov priority: normal severity: normal status: open title: Implement unix read_pipe.is_reading() method

[issue38019] asyncio subprocess AttributeError: 'NoneType' object has no attribute '_add_reader' / '_remove_reader'

Change by Andrew Svetlov : -- keywords: +patch pull_requests: +16056 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16472 ___ Python tracker ___

[issue38164] polishing asyncio Streams API

Kyle Stanley added the comment: This should no longer be a release blocker for 3.8 with the reversion of the new asyncio streaming API in GH-16455. -- nosy: +aeros167 ___ Python tracker

[issue20504] cgi.FieldStorage, multipart, missing Content-Length

Pierre Quentel added the comment: Now that the PR has been merged, can someone close the issue ? -- ___ Python tracker ___ ___

[issue38306] High level API for loop.run_in_executor(None, ...)?

Andrew Svetlov added the comment: I'd like to see how thread pools integrate with (not existing yet bug planned for 3.9) task groups before pushing forward the proposed approach. -- ___ Python tracker

[issue38304] PEP 587 implementation is not ABI forward compatible

Ned Deily added the comment: Nick, do you consider this a 3.8.0 release blocker? If so, you should reopen it and mark it as such, since the 3.8.0rc1 cutoff is imminent. -- nosy: +ned.deily ___ Python tracker

[issue24464] "sqlite3_enable_shared_cache" deprecation warning when compiling with macOS system SQLite3

Ned Deily added the comment: Also, I notice that, while there is docstring help for sqlite3.enable_shared_cache, it does not seem to be mentioned in the sqlite3 module doc page in the Library reference. -- ___ Python tracker

[issue24464] "sqlite3_enable_shared_cache" deprecation warning when compiling with macOS system SQLite3

Ned Deily added the comment: Now that this has come up again, it's worth noting Ronald's comment in msg295954 from duplicate Issue30646: "See also . Apple basically disabled this function starting at macOS 10.7, that's why there's a

[issue38304] PEP 587 implementation is not ABI forward compatible

Nick Coghlan added the comment: The hidden _config_version field wasn't in the accepted PEP. Both it and struct_size should be removed, as we don't support updating an embedded Python runtime to a new X.Y.0 release without rebuilding the embedding application. -- nosy: +ncoghlan

[issue30646] SQLite: sqlite3_enable_shared_cache() is deprecated

Change by Ned Deily : -- resolution: third party -> duplicate superseder: -> Got warning when compiling sqlite3 module on Mac OS X ___ Python tracker ___

[issue24464] Got warning when compiling sqlite3 module on Mac OS X

Change by David CARLIER : -- pull_requests: +16055 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16469 ___ Python tracker ___

[issue38311] Building with macoS system SQLite3 generates sqlite3_enable_shared_cache deprecation warning

Ned Deily added the comment: Sorry, I should have checked: this issue has come up at least a couple of times before, for example, Issue30646 and Issue24464 (still open with a slightly more compex patch). Let's just close this issue as a duplicate of the earlier one and continue any new

[issue38311] Building with macoS system SQLite3 generates sqlite3_enable_shared_cache deprecation warning

New submission from Ned Deily : Thanks for the PR! As noted in my review comment of it, I believe a more robust approach would be needed to ensure that builds still work properly when building with a local copy of SQLite on macOS (not the system-supplied one), a common occurrence.