[issue38319] shutil.copyfile(): os.sendfile() fails with OverflowError on 32-bit system

2019-09-30 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: Looks like it worked: https://buildbot.python.org/all/#/builders/176/builds/1383 -- ___ Python tracker ___

[issue38319] shutil.copyfile(): os.sendfile() fails with OverflowError on 32-bit system

2019-09-30 Thread Giampaolo Rodola'
Change by Giampaolo Rodola' : -- versions: +Python 3.8 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38333] add type signatures to library function docs

2019-09-30 Thread Guido van Rossum
Guido van Rossum added the comment: Even if this not desirable for the source code, it still makes sense to add the types to the docs, at least when they are simple and compact. The proposed notation from PEP 604 ('|' for unions) might help with compactness. Many docs are unnecessarily

[issue38333] add type signatures to library function docs

2019-09-30 Thread Raymond Hettinger
Change by Raymond Hettinger : -- assignee: docs@python -> gvanrossum nosy: +gvanrossum ___ Python tracker ___ ___ Python-bugs-list

[issue38333] add type signatures to library function docs

2019-09-30 Thread Raymond Hettinger
Raymond Hettinger added the comment: I believe there was an explicit decision not to do this. For the time being, optional typing is still optional. -- nosy: +rhettinger ___ Python tracker

[issue38333] add type signatures to library function docs

2019-09-30 Thread paul rubin
New submission from paul rubin : It would be nice if the library reference manual had type signatures for all the stdlib functions at some point. It might be possible to extract a lot of them automatically from typeshed and semi-automatically paste them into the doc files. It might also be

[issue38319] shutil.copyfile(): os.sendfile() fails with OverflowError on 32-bit system

2019-09-30 Thread miss-islington
Change by miss-islington : -- pull_requests: +16093 pull_request: https://github.com/python/cpython/pull/16506 ___ Python tracker ___

[issue38319] shutil.copyfile(): os.sendfile() fails with OverflowError on 32-bit system

2019-09-30 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: New changeset 94e165096fd65e8237e60de570fb609604ab94c9 by Giampaolo Rodola in branch 'master': bpo-38319: Fix shutil._fastcopy_sendfile(): set sendfile() max block size (GH-16491)

[issue38329] macOS python.org installers only add or modify framework Versions/Current symlink for Python 2.x installs, not Python 3.x

2019-09-30 Thread Ned Deily
Ned Deily added the comment: Thanks for the reminder. Unfortunately, the macOS installer is working as designed. As discussed at length in Issue18117 (and elsewhere), building using the -framework Python, either directly in compiler calls or indirectly through Xcode is problematic because

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

2019-09-30 Thread Neil Schemenauer
Neil Schemenauer added the comment: I worked some on trying to create a unit test this evening. Attached is my best result so far (gc_weakref_bug_demo.py). It requires that you enable the 'xx' module so we have a container object without tp_traverse. We should probably add one to

[issue32689] shutil.move raises AttributeError if first argument is a pathlib.Path object and destination is a directory

2019-09-30 Thread Guido van Rossum
Guido van Rossum added the comment: 3.9 only! -- nosy: +gvanrossum resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.9 -Python 3.6, Python 3.7, Python 3.8 ___ Python tracker

[issue38332] invalid content-transfer-encoding in encoded-word causes KeyError

2019-09-30 Thread Emmanuel Arias
Emmanuel Arias added the comment: Hello, I am not a email expert, but according to RFC 1342 the enconding can be either "B" or "Q". So, I think is reasonable that when a not correct enconding is set, should be raise an exception I think that we can improve the message raising a more

[issue32689] shutil.move raises AttributeError if first argument is a pathlib.Path object and destination is a directory

2019-09-30 Thread miss-islington
miss-islington added the comment: New changeset cf57cabef82c4689ce9796bb1fcdb125fa05efcb by Miss Islington (bot) (Maxwell A McKinnon) in branch 'master': bpo-32689: Updates shutil.move to allow for Path objects to be used as source arg (GH-15326)

[issue38325] [Windows] test_winconsoleio failures

2019-09-30 Thread Eryk Sun
Eryk Sun added the comment: Does test_partial_reads fail for you when run separately? If so, it's for a different reason. Otherwise, there may have been text left in the input buffer from test_input that led to the failure, which is a separate problem that needs to be addressed via

[issue38321] Compiler warnings when building Python 3.8

2019-09-30 Thread Ma Lin
Ma Lin added the comment: Other warnings: c:\vstinner\python\master\objects\longobject.c(420): warning C4244: 'function': conversion from 'unsigned __int64' to 'sdigit', possible loss of data c:\vstinner\python\master\objects\longobject.c(428): warning C4267: 'function': conversion from

[issue38332] invalid content-transfer-encoding in encoded-word causes KeyError

2019-09-30 Thread Emmanuel Arias
Change by Emmanuel Arias : -- nosy: +eamanu ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38321] Compiler warnings when building Python 3.8

2019-09-30 Thread Ma Lin
Ma Lin added the comment: On my Windows, some non-ASCII characters cause this warning: d:\dev\cpython\modules\expat\xmltok.c : warning C4819: The file contains a character that cannot be represented in the current code page (936). Save the file in Unicode format to prevent

[issue38332] invalid content-transfer-encoding in encoded-word causes KeyError

2019-09-30 Thread Andrei Troie
New submission from Andrei Troie : The following will cause a KeyError on email.message.get() import email import email.policy text = "Subject: =?us-ascii?X?somevalue?=" eml = email.message_from_string(text, policy=email.policy.default) eml.get('Subject') This is caused by the fact that the

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

2019-09-30 Thread Neil Schemenauer
Change by Neil Schemenauer : -- nosy: +benjamin.peterson, larry, ned.deily versions: +Python 2.7, Python 3.5, Python 3.6, Python 3.7 ___ Python tracker ___

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

2019-09-30 Thread Neil Schemenauer
Neil Schemenauer added the comment: I created GH-16502. I'm not exactly sure of the process of making a revert on a branch like '3.8' so hopefully it is correct. The code change is exactly what has been reverted in 3.8. The net effect will be as if the revert was never done. --

[issue37725] "make clean" should remove PGO task data

2019-09-30 Thread Neil Schemenauer
Change by Neil Schemenauer : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue38326] Concerns with the last minute changes to the PEP 587 API

2019-09-30 Thread Gregory P. Smith
Change by Gregory P. Smith : -- nosy: +gregory.p.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

2019-09-30 Thread Neil Schemenauer
Change by Neil Schemenauer : -- pull_requests: +16092 pull_request: https://github.com/python/cpython/pull/16502 ___ Python tracker ___

[issue38331] Exec not recognizing global variables inside function

2019-09-30 Thread Huyston
New submission from Huyston : This seems like a bug for me, forgive me if its not. Consider the following script: def func(): print(var) my_globals = {'func':func,'var':14} exec("print(var);func()",my_globals,my_globals) This is the output: 14 Traceback (most recent call last): File

[issue38330] httplib specifies content-length when transfer-encoding present

2019-09-30 Thread apmatthews
Change by apmatthews : -- keywords: +patch pull_requests: +16090 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16501 ___ Python tracker ___

[issue38304] PEP 587 implementation is not ABI forward compatible

2019-09-30 Thread STINNER Victor
STINNER Victor added the comment: I reopen the issue since there seems to be disagreement about the whole feature (provide a stable ABI for embedded Python): see bpo-38326. -- resolution: fixed -> status: closed -> open ___ Python tracker

[issue38326] Concerns with the last minute changes to the PEP 587 API

2019-09-30 Thread STINNER Victor
STINNER Victor added the comment: > Binary compatibility of an embedding-only struct is totally unnecessary, as > posted on the thread. Well, I'm fine with removing PyConfig.struct_size right now. I wrote two PRs to remove it: * PR 16500 (code) * https://github.com/python/peps/pull/1185

[issue38322] Azure Pipelines: appx tests fail: init_fs_encoding: failed to get the Python codec of the filesystem encoding

2019-09-30 Thread Steve Dower
Steve Dower added the comment: Either way, the paths in the latest tests [1] seem to be fine, and they all passed, so I don't think this is a release blocker anymore. Thanks, Victor! [1]:

[issue38322] Azure Pipelines: appx tests fail: init_fs_encoding: failed to get the Python codec of the filesystem encoding

2019-09-30 Thread Steve Dower
Steve Dower added the comment: > I checked why sys.executable is not normalized in the the "appx build". > PC\python_uwp.cpp calls set_process_name() which sets PyConfig.executable and > the path is not normalized. If PyConfig.executable is set explicitly, the > path is left unchanged:

[issue38304] PEP 587 implementation is not ABI forward compatible

2019-09-30 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +16089 pull_request: https://github.com/python/cpython/pull/16500 ___ Python tracker ___

[issue38330] httplib specifies content-length when transfer-encoding present

2019-09-30 Thread apmatthews
New submission from apmatthews : RFC 7230 3.3.2 states "A sender MUST NOT send a Content-Length header field in any message that contains a Transfer-Encoding header field." When trying to perform a chunked request: import httplib http = httplib.HTTPSConnection('google.com')

[issue38325] [Windows] test_winconsoleio failures

2019-09-30 Thread STINNER Victor
STINNER Victor added the comment: Until a fix is found, can we mark the tests as "known to fail" on a specific Windows version? (So test_winconsoleio doesn't fail anymore.) -- ___ Python tracker

[issue38322] Azure Pipelines: appx tests fail: init_fs_encoding: failed to get the Python codec of the filesystem encoding

2019-09-30 Thread STINNER Victor
STINNER Victor added the comment: > Adding in the appx _layout_ test (it's the whole test suite in an "installed" > layout) was easier to do in CI than creating a buildbot config, so I threw it > in as a test and then left it on. It's certainly not been failing this whole > time. I'm fine

[issue38322] Azure Pipelines: appx tests fail: init_fs_encoding: failed to get the Python codec of the filesystem encoding

2019-09-30 Thread STINNER Victor
STINNER Victor added the comment: > The bug was probably exposed due to a change in path initialization (there's > been a few changes here recently ;) ) that stopped normalising prefix. You > can see that sys.executable in your dumped path has additional "." in the > path, and that's never

[issue38325] [Windows] test_winconsoleio failures

2019-09-30 Thread Eryk Sun
Eryk Sun added the comment: Apparently handling non-BMP codes is broken in recent builds of the new console in Windows 10. I see this problem in build 18362 as well. It seems there have been updates that have changed the naive way the console used to handle surrogate codes as just regular

[issue38329] Top level symlinks are broken in the Python 3.7.4 framework for macOS.

2019-09-30 Thread Kevin Packard
New submission from Kevin Packard : The macOS installer for Python 3.7.4 places "Python.framework" into /Library/Frameworks/ However, the top-level symlinks inside the framework are broken for "Headers" and "Resources". Because of this, the framework can not be imported into an Xcode

[issue38321] Compiler warnings when building Python 3.8

2019-09-30 Thread STINNER Victor
STINNER Victor added the comment: New changeset aca8c406ada3bb547765b262bed3ac0cc6be8dd3 by Victor Stinner in branch 'master': bpo-38321: Fix _testcapimodule.c warning (GH-16494) https://github.com/python/cpython/commit/aca8c406ada3bb547765b262bed3ac0cc6be8dd3 --

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

2019-09-30 Thread Łukasz Langa
Łukasz Langa added the comment: If either of you resurrects tp_clear in functions in the next 12 hours or so, I'll merge it. -- ___ Python tracker ___

[issue38324] [Windows] test_locale and test__locale failures on Windows

2019-09-30 Thread STINNER Victor
STINNER Victor added the comment: > Also, since these seem to be on your own machine, I'm guessing your locale is > not en-US? Oh, the behavior of setlocale() depends on my system locale? Yeah, my system is configured in French, sorry I don't recall the locale name. --

[issue37945] [Windows] locale.getdefaultlocale() issues on Windows: test_locale.test_getsetlocale_issue1813()

2019-09-30 Thread STINNER Victor
Change by STINNER Victor : -- title: test_locale failing -> [Windows] locale.getdefaultlocale() issues on Windows: test_locale.test_getsetlocale_issue1813() ___ Python tracker

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

2019-09-30 Thread Neil Schemenauer
Neil Schemenauer added the comment: > Is introducing tp_clear on functions a thing that has ABI consequences? In > other words, if we take our time on this, would it land in 3.8.1 or 3.9.0? I think it should not have ABI consequences. However, I see the addition of tp_clear as a new

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

2019-09-30 Thread Tim Peters
Tim Peters added the comment: Łukasz, all type objects have tp_clear slots, and always did. The patch in question put something useful in the function object's tp_clear slot instead of leaving it NULL. No interface, as such, changes either way. --

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

2019-09-30 Thread Łukasz Langa
Łukasz Langa added the comment: Now we only need a volunteer to prepare a PR to revert the revert... :> -- ___ Python tracker ___

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

2019-09-30 Thread Tim Peters
Tim Peters added the comment: Yes, it's better to have tp_clear than not for a variety of reasons (including setting examples of best practice). Best I can tell, the patch for BPO-33418 was reverted _only_ to worm around the crash in _this_ report. That's no longer needed. Or, if it is,

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

2019-09-30 Thread Łukasz Langa
Łukasz Langa added the comment: Is introducing tp_clear on functions a thing that has ABI consequences? In other words, if we take our time on this, would it land in 3.8.1 or 3.9.0? I'm kind of nervous about the rate of change in the past 48 hours. --

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

2019-09-30 Thread Neil Schemenauer
Neil Schemenauer added the comment: > Would [func tp_clear] help with memory usage in functions or was BPO-33418 > addressed in another way since? Having a tp_clear for all container objects that can be involved in reference cycles will help the GC free memory. BPO-33418 may be contrived

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

2019-09-30 Thread Tim Peters
Tim Peters added the comment: It's unclear to me whether BPO-33418 was a bug or a contrived annoyance :-) If someone believes it was worth addressing, then what it did is the only way to fix it, so should be restored now. -- ___ Python tracker

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

2019-09-30 Thread Łukasz Langa
Łukasz Langa added the comment: > If that PR is applied, I think we should also restore tp_clear for functions > (revert GH-15826). If that's safe and easy, let's go for it. Would it help with memory usage in functions or was BPO-33418 addressed in another way since? --

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

2019-09-30 Thread miss-islington
Change by miss-islington : -- pull_requests: +16088 pull_request: https://github.com/python/cpython/pull/16499 ___ Python tracker ___

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

2019-09-30 Thread Tim Peters
Tim Peters added the comment: FWIW, I agree with Neil in all respects about the release: his patch is the best approach, plugs segfaulting holes that have been there for many years, and the earlier patches aren't needed anymore. -- ___ Python

[issue38328] Speed up the creation time of constant list literals.

2019-09-30 Thread Brandt Bucher
Change by Brandt Bucher : -- keywords: +patch pull_requests: +16087 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16498 ___ Python tracker ___

[issue33325] Optimize sequences of constants in the compiler

2019-09-30 Thread Brandt Bucher
Change by Brandt Bucher : -- pull_requests: +16086 pull_request: https://github.com/python/cpython/pull/16498 ___ Python tracker ___

[issue38328] Speed up the creation time of constant list literals.

2019-09-30 Thread Brandt Bucher
New submission from Brandt Bucher : The attached PR contains a small change to the peephole optimizer that converts sequences of: LOAD_CONST(a), LOAD_CONST(b), ..., BUILD_LIST(n) to LOAD_CONST((a, b, ...)), BUILD_LIST_UNPACK(1) The improvement quickly becomes significant for lists larger

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

2019-09-30 Thread Tim Peters
Tim Peters added the comment: Neil, my brief msg 10 minutes before yours suggested the same thing (just clear the weakref), so it must be right ;-) -- ___ Python tracker ___

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

2019-09-30 Thread Neil Schemenauer
Neil Schemenauer added the comment: Oops, I linked to wrong PR, my proposed fix is GH-16495. It is the same as what Tim suggests in his last comment. -- ___ Python tracker

[issue38302] __rpow__ not reached when __ipow__ returns NotImplemented

2019-09-30 Thread hongweipeng
hongweipeng added the comment: Oh, I see. Thank you. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

2019-09-30 Thread Neil Schemenauer
Neil Schemenauer added the comment: > Why setting it back to release blocker? As far as I recall, this issue is not > a Python 3.8 regression. The regression which triggered this old and existing > bug has been fixed, see previous comments. I leave it up to our glorious release manager to

[issue38297] Imports at top of module is often not used

2019-09-30 Thread Brett Cannon
Brett Cannon added the comment: So it's a bit misleading to use the stdlib as a guideline because there are reasons we do this in certain spots. E.g. the os module purposefully does function-level imports to make startup cheaper. importlib does this to minimize how many modules need to be

[issue38303] Make audioop PEP-384 compatible

2019-09-30 Thread Tyler Kieft
Change by Tyler Kieft : -- keywords: +patch pull_requests: +16085 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16497 ___ Python tracker ___

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

2019-09-30 Thread Tim Peters
Tim Peters added the comment: Neil, how about this alternative: leave the weakref implementation alone. If we find a trash weakref, simply clear it instead. That would prevent callbacks too, & would also prevent the weakref from being used to retrieve its possibly-trash-too referent.

[issue38326] Concerns with the last minute changes to the PEP 587 API

2019-09-30 Thread Nick Coghlan
Change by Nick Coghlan : -- keywords: +patch pull_requests: +16084 stage: commit review -> patch review pull_request: https://github.com/python/cpython/pull/16496 ___ Python tracker

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

2019-09-30 Thread Neil Schemenauer
Change by Neil Schemenauer : -- pull_requests: +16083 pull_request: https://github.com/python/cpython/pull/16495 ___ Python tracker ___

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

2019-09-30 Thread Tim Peters
Tim Peters added the comment: > Would the attached rough patch (gc_disable_wr_callback.txt) > be a possible fix? When we find W inside handle_weakrefs(), > we mark it as trash and will not execute the callback. It's semantically correct since we never wanted to execute a callback from a

[issue37398] contextlib.ContextDecorator decorating async functions

2019-09-30 Thread Krzysztof Wróblewski
Change by Krzysztof Wróblewski : -- nosy: +Krzysztof Wróblewski ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue38324] [Windows] test_locale and test__locale failures on Windows

2019-09-30 Thread Tim Golden
Tim Golden added the comment: This is the existing issue https://bugs.python.org/issue37945 which I haven't had time to progress. Please feel free to follow up -- ___ Python tracker

[issue38321] Compiler warnings when building Python 3.8

2019-09-30 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset c9a413ede47171a224c72dd34122005170caaad4 by Vinay Sajip (Victor Stinner) in branch 'master': bpo-38321: Fix PyCStructUnionType_update_stgdict() warning (GH-16492) https://github.com/python/cpython/commit/c9a413ede47171a224c72dd34122005170caaad4

[issue22273] abort when passing certain structs by value using ctypes

2019-09-30 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset c9a413ede47171a224c72dd34122005170caaad4 by Vinay Sajip (Victor Stinner) in branch 'master': bpo-38321: Fix PyCStructUnionType_update_stgdict() warning (GH-16492) https://github.com/python/cpython/commit/c9a413ede47171a224c72dd34122005170caaad4

[issue38242] Revert the new asyncio Streams API

2019-09-30 Thread Bruce Merry
Change by Bruce Merry : -- nosy: +bmerry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38326] Concerns with the last minute changes to the PEP 587 API

2019-09-30 Thread Łukasz Langa
Change by Łukasz Langa : -- versions: +Python 3.8, Python 3.9 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38327] Creating set with empty string returns empty set

2019-09-30 Thread Emil Bode
Emil Bode added the comment: You're right, I tested with set('a'), which gave me a set of size one, but generalized it here to 'somestring'. Maybe I'm just too loose with using set, instead of {} Sorry to bother you -- ___ Python tracker

[issue38327] Creating set with empty string returns empty set

2019-09-30 Thread Ammar Askar
Ammar Askar added the comment: I think the key thing you're missing here is that the set() constructor can take any arbitrary iterable (https://docs.python.org/3/library/functions.html#func-set). It simply goes over all the elements inside and adds them all to the set. This is no different

[issue38327] Creating set with empty string returns empty set

2019-09-30 Thread Emil Bode
Emil Bode added the comment: Some details about my setup: Python 3.7.1, Spyder 3.3.2 IPython 7.2.0 under Windows 10 64-bit -- ___ Python tracker ___

[issue38327] Creating set with empty string returns empty set

2019-09-30 Thread Emil Bode
New submission from Emil Bode : Initializing/creating a new set with an empty string via the set-command returns an empty set instead of set with the empty string. As in: While set('somestring') gives me a set of size one, set('') gives me an empty set (of size zero), just as set() would do

[issue38324] [Windows] test_locale and test__locale failures on Windows

2019-09-30 Thread Steve Dower
Steve Dower added the comment: This is a known issue (forgetting the number right now) - Linux-style locales don't work on Windows, and so there's a normalization function that has to be completely rewritten. Also, since these seem to be on your own machine, I'm guessing your locale is not

[issue35360] Update SQLite to 3.28 in Windows and macOS installer builds

2019-09-30 Thread Steve Dower
Steve Dower added the comment: Please file a new issue -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38322] Azure Pipelines: appx tests fail: init_fs_encoding: failed to get the Python codec of the filesystem encoding

2019-09-30 Thread Steve Dower
Steve Dower added the comment: The bug was probably exposed due to a change in path initialization (there's been a few changes here recently ;) ) that stopped normalising prefix. You can see that sys.executable in your dumped path has additional "." in the path, and that's never been the

[issue38326] Concerns with the last minute changes to the PEP 587 API

2019-09-30 Thread Steve Dower
Steve Dower added the comment: (Continuing from the email thread, so read that for context if you haven't) Binary compatibility of an embedding-only struct is totally unnecessary, as posted on the thread. There's no feasible way to embed cross-Python versions on any platform, so we should

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

2019-09-30 Thread STINNER Victor
STINNER Victor added the comment: > 2019-09-30 14:41:36 lukasz.langaset priority: release blocker Why setting it back to release blocker? As far as I recall, this issue is not a Python 3.8 regression. The regression which triggered this old and existing bug has been fixed, see

[issue38006] Crash in remove() weak reference callback of weakref.WeakValueDictionary at Python exit

2019-09-30 Thread Łukasz Langa
Change by Łukasz Langa : -- priority: -> release blocker ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38248] inconsistency in asyncio.Task between cancellation while running vs. cancellation immediately after it finishes

2019-09-30 Thread STINNER Victor
STINNER Victor added the comment: New changeset efe74b6369a8d08f27c69703fcc1686966e51068 by Victor Stinner in branch 'master': bpo-38321: Fix _asynciomodule.c compiler warning (GH-16493) https://github.com/python/cpython/commit/efe74b6369a8d08f27c69703fcc1686966e51068 -- nosy:

[issue38321] Compiler warnings when building Python 3.8

2019-09-30 Thread STINNER Victor
STINNER Victor added the comment: New changeset efe74b6369a8d08f27c69703fcc1686966e51068 by Victor Stinner in branch 'master': bpo-38321: Fix _asynciomodule.c compiler warning (GH-16493) https://github.com/python/cpython/commit/efe74b6369a8d08f27c69703fcc1686966e51068 --

[issue38326] Concerns with the last minute changes to the PEP 587 API

2019-09-30 Thread Nick Coghlan
Nick Coghlan added the comment: (I'm currently working a PR for this that Victor can review) -- assignee: -> ncoghlan ___ Python tracker ___

[issue38315] Provide defaultdict variant that passes key to default_factory

2019-09-30 Thread Mark Amery
Mark Amery added the comment: I'm aware of __missing__. However, I don't think its existence is by itself a knockdown argument against doing this. __missing__ also fulfils the need satisfied by defaultdict, yet Python still has both - and the latter is almost always more convenient to use

[issue38321] Compiler warnings when building Python 3.8

2019-09-30 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +16082 pull_request: https://github.com/python/cpython/pull/16494 ___ Python tracker ___

[issue38248] inconsistency in asyncio.Task between cancellation while running vs. cancellation immediately after it finishes

2019-09-30 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +16081 pull_request: https://github.com/python/cpython/pull/16493 ___ Python tracker ___

[issue38321] Compiler warnings when building Python 3.8

2019-09-30 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +16080 pull_request: https://github.com/python/cpython/pull/16493 ___ Python tracker ___

[issue22273] abort when passing certain structs by value using ctypes

2019-09-30 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +16079 pull_request: https://github.com/python/cpython/pull/16492 ___ Python tracker ___

[issue38321] Compiler warnings when building Python 3.8

2019-09-30 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +16078 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16492 ___ Python tracker ___

[issue38321] Compiler warnings when building Python 3.8

2019-09-30 Thread STINNER Victor
STINNER Victor added the comment: And more: c:\vstinner\python\master\modules\_testcapimodule.c(6409): warning C4146: unary minus operator applied to unsigned type, result still unsigned -- ___ Python tracker

[issue38321] Compiler warnings when building Python 3.8

2019-09-30 Thread STINNER Victor
STINNER Victor added the comment: Other warnings: c:\vstinner\python\master\objects\longobject.c(420): warning C4244: 'function': conversion from 'unsigned __int64' to 'sdigit', possible loss of data c:\vstinner\python\master\objects\longobject.c(428): warning C4267: 'function': conversion

[issue38326] Concerns with the last minute changes to the PEP 587 API

2019-09-30 Thread Nick Coghlan
New submission from Nick Coghlan : (Nosy list is RM, PEP 587 BDFL-Delegate, PEP 587 author) Filing as a release blocker, given that I don't think we should ship rc1 until consensus has been reached on the last minute changes to the PEP 587 configuration API. Thread at

[issue38319] shutil.copyfile(): os.sendfile() fails with OverflowError on 32-bit system

2019-09-30 Thread Giampaolo Rodola'
Change by Giampaolo Rodola' : -- keywords: +patch pull_requests: +16077 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16491 ___ Python tracker

[issue38322] Azure Pipelines: appx tests fail: init_fs_encoding: failed to get the Python codec of the filesystem encoding

2019-09-30 Thread STINNER Victor
STINNER Victor added the comment: Facts: * appx tests are not run on buildbots * appx tests are not run in pre-commit CI of pull requests * appx tests seem to only be run on Azure Pipelines of the branches (like 3.8 and master) * the fixed bug likely existed since Python 3.6: static int

[issue38324] [Windows] test_locale and test__locale failures on Windows

2019-09-30 Thread STINNER Victor
Change by STINNER Victor : -- components: +Tests, Windows nosy: +paul.moore, steve.dower, tim.golden, zach.ware title: test_locale and test__locale failures on Windows -> [Windows] test_locale and test__locale failures on Windows versions: +Python 3.8, Python 3.9

[issue38325] [Windows] test_winconsoleio failures

2019-09-30 Thread STINNER Victor
New submission from STINNER Victor : On Windows 10 version 1903, test_winconsoleio even when run from cmd.exe console. C:\vstinner\python\3.8>python -m test -v test_winconsoleio Running Release|x64 interpreter... == CPython 3.8.0b4+ (heads/pr/16490:8a204fd07c, Sep 30 2019, 14:29:53) [MSC

[issue38324] test_locale and test__locale failures on Windows

2019-09-30 Thread STINNER Victor
New submission from STINNER Victor : On Windows 10 version 1903, 3 locale tests fail: vstinner@WIN C:\vstinner\python\3.8>python -m test -v test_locale test__locale == ERROR: test_getsetlocale_issue1813

[issue38319] shutil.copyfile(): os.sendfile() fails with OverflowError on 32-bit system

2019-09-30 Thread STINNER Victor
STINNER Victor added the comment: Similar failure on ARMv7 Debian buster 3.x: https://buildbot.python.org/all/#/builders/176/builds/1372 pythoninfo: sys.maxsize: 2147483647 -- ___ Python tracker

[issue38323] test_ayncio: test_close_kill_running() hangs on AMD64 RHEL7 Refleaks 3.x

2019-09-30 Thread STINNER Victor
New submission from STINNER Victor : test_asyncio fails once on AMD64 RHEL7 Refleaks 3.x, and then test_close_kill_running() was killed after 3h 15 min. I guess that it hangs, but I'm not 100% sure. When test_asyncio was re-run, it seems like test_asyncio was run 3x successful but it hanged

[issue38322] Azure Pipelines: appx tests fail: init_fs_encoding: failed to get the Python codec of the filesystem encoding

2019-09-30 Thread STINNER Victor
STINNER Victor added the comment: New changeset dec39716ca93ee2e8d9b94915ece33014eb58e9e by Victor Stinner in branch 'master': bpo-38322: Fix gotlandmark() of PC/getpathp.c (GH-16489) https://github.com/python/cpython/commit/dec39716ca93ee2e8d9b94915ece33014eb58e9e --

[issue38322] Azure Pipelines: appx tests fail: init_fs_encoding: failed to get the Python codec of the filesystem encoding

2019-09-30 Thread STINNER Victor
STINNER Victor added the comment: New changeset 18c4ba9f33868761e374a725d497902863d59ea9 by Victor Stinner in branch '3.8': bpo-38322: Fix gotlandmark() of PC/getpathp.c (GH-16490) https://github.com/python/cpython/commit/18c4ba9f33868761e374a725d497902863d59ea9 --

  1   2   >