[issue38461] 3.8 Release Notes: "curses" misspelled as "ncurses"

Change by Raymond Hettinger : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue38463] 3.8 Release Notes: Link to SSLContext.post_handshake_auth missing

Change by Raymond Hettinger : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue38461] 3.8 Release Notes: "curses" misspelled as "ncurses"

Raymond Hettinger added the comment: New changeset c09379bd6ebdd896547008c641e8899a1e36aa42 by Raymond Hettinger (Miss Islington (bot)) in branch '3.8': bpo-38461 and bpo-38463: Minor fixes to Whatsnew 3.8 (GH-16761) (GH-16762)

[issue38463] 3.8 Release Notes: Link to SSLContext.post_handshake_auth missing

Raymond Hettinger added the comment: New changeset c09379bd6ebdd896547008c641e8899a1e36aa42 by Raymond Hettinger (Miss Islington (bot)) in branch '3.8': bpo-38461 and bpo-38463: Minor fixes to Whatsnew 3.8 (GH-16761) (GH-16762)

[issue38463] 3.8 Release Notes: Link to SSLContext.post_handshake_auth missing

Change by miss-islington : -- pull_requests: +16335 pull_request: https://github.com/python/cpython/pull/16762 ___ Python tracker ___

[issue38463] 3.8 Release Notes: Link to SSLContext.post_handshake_auth missing

Raymond Hettinger added the comment: New changeset 61a6db5e79921b89b9e2a154990f01f5f3150213 by Raymond Hettinger in branch 'master': bpo-38461 and bpo-38463: Minor fixes to Whatsnew 3.8 (GH-16761) https://github.com/python/cpython/commit/61a6db5e79921b89b9e2a154990f01f5f3150213 --

[issue38461] 3.8 Release Notes: "curses" misspelled as "ncurses"

Change by miss-islington : -- pull_requests: +16334 pull_request: https://github.com/python/cpython/pull/16762 ___ Python tracker ___

[issue38461] 3.8 Release Notes: "curses" misspelled as "ncurses"

Raymond Hettinger added the comment: New changeset 61a6db5e79921b89b9e2a154990f01f5f3150213 by Raymond Hettinger in branch 'master': bpo-38461 and bpo-38463: Minor fixes to Whatsnew 3.8 (GH-16761) https://github.com/python/cpython/commit/61a6db5e79921b89b9e2a154990f01f5f3150213 --

[issue38461] 3.8 Release Notes: "curses" misspelled as "ncurses"

Change by Raymond Hettinger : -- keywords: +patch pull_requests: +16332 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16761 ___ Python tracker

[issue38463] 3.8 Release Notes: Link to SSLContext.post_handshake_auth missing

Change by Raymond Hettinger : -- keywords: +patch pull_requests: +16333 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16761 ___ Python tracker

[issue38469] PEP 572 : assignment expression to a global variable in a comprehension

Change by miss-islington : -- pull_requests: +16331 pull_request: https://github.com/python/cpython/pull/16760 ___ Python tracker ___

[issue38469] PEP 572 : assignment expression to a global variable in a comprehension

Pablo Galindo Salgado added the comment: New changeset fd5c414880b2e05720b9cf14ab0b0d7ae2b7d925 by Pablo Galindo in branch 'master': bpo-38469: Handle named expression scope with global/nonlocal keywords (GH-16755)

[issue38460] 3.8 Release Notes: document asyncio exception changes

Raymond Hettinger added the comment: Yuri, would you propose an entry for this? -- assignee: rhettinger -> yselivanov ___ Python tracker ___

[issue38460] 3.8 Release Notes: document asyncio exception changes

Change by Raymond Hettinger : -- Removed message: https://bugs.python.org/msg354595 ___ Python tracker ___ ___ Python-bugs-list

[issue38464] documentation for NormalDist.quantiles(): missing argument

Raymond Hettinger added the comment: New changeset 36f62860f631acefd7988b76901863339ffa26c9 by Raymond Hettinger (Miss Islington (bot)) in branch '3.8': bpo-38464: Document parameter for NormalDist.quantiles() (GH-16757) (GH-16758)

[issue38464] documentation for NormalDist.quantiles(): missing argument

Change by Raymond Hettinger : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue38464] documentation for NormalDist.quantiles(): missing argument

Change by miss-islington : -- pull_requests: +16330 pull_request: https://github.com/python/cpython/pull/16758 ___ Python tracker ___

[issue38464] documentation for NormalDist.quantiles(): missing argument

Raymond Hettinger added the comment: New changeset 8a6cbf8adb68aa2c43a48769af92e50d5ca1539d by Raymond Hettinger in branch 'master': bpo-38464: Document parameter for NormalDist.quantiles() (GH-16757) https://github.com/python/cpython/commit/8a6cbf8adb68aa2c43a48769af92e50d5ca1539d

[issue38464] documentation for NormalDist.quantiles(): missing argument

Change by Raymond Hettinger : -- keywords: +patch pull_requests: +16329 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16757 ___ Python tracker

[issue38464] documentation for NormalDist.quantiles(): missing argument

Raymond Hettinger added the comment: Thanks for noticing.. Will get that fixed up shortly. -- assignee: docs@python -> rhettinger ___ Python tracker ___

[issue38112] Compileall improvements

Pablo Galindo Salgado added the comment: The AMD64 Windows7 SP1 3.x buildbot has been failing for a while since commit 4267c989e7fc6cd528e8a1d04a07fac5cca85ec7, please take a look at https://bugs.python.org/issue38470. -- nosy: +pablogsal ___

[issue38470] test_compileall fails in AMD64 Windows7 SP1 3.x

New submission from Pablo Galindo Salgado : This buildbot has been failing for a long time (example failure https://buildbot.python.org/all/#/builders/40/builds/3291) since https://github.com/python/cpython/commit/4267c989e7fc6cd528e8a1d04a07fac5cca85ec7:

[issue38334] zipfile: Seeking encrypted file breaks after seeking backwards

Change by Daniel Hillier : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38469] PEP 572 : assignment expression to a global variable in a comprehension

Pablo Galindo Salgado added the comment: > But is it really important enough to violate the desired "rc1 == release" > invariant? I created the fix because many other bug fixes have been merged since rc1 already so apologies if it seemed a bit precipitate. Let's see what the release

[issue38469] PEP 572 : assignment expression to a global variable in a comprehension

Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +16328 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/16755 ___ Python tracker

[issue38469] PEP 572 : assignment expression to a global variable in a comprehension

Guido van Rossum added the comment: Thanks for working on a fix. But is it really important enough to violate the desired "rc1 == release" invariant? It's up to the release manager. -- ___ Python tracker

[issue38469] PEP 572 : assignment expression to a global variable in a comprehension

Pablo Galindo Salgado added the comment: I am working on a fix now, se we can merge it before the final release -- ___ Python tracker ___

[issue38379] finalizer resurrection in gc

Tim Peters added the comment: Everything here has been addressed, so closing this. zleak.py can apparently run forever now without leaking a byte :-) -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python

[issue38469] PEP 572 : assignment expression to a global variable in a comprehension

Guido van Rossum added the comment: It's a bug, but it's honestly such an odd corner case that I don't think this should hold up the 3.8.0 release. Let's fix it in 3.9 and backport it to 3.8.1. -- priority: release blocker -> normal stage: -> needs patch

[issue38469] PEP 572 : assignment expression to a global variable in a comprehension

Pablo Galindo Salgado added the comment: I think this is a bug in the symtable_extend_namedexpr_scope function because when visiting the stack in reverse order and finding a function block is always assigning the scope as DEF_NONLOCAL. Marking also as a release blocker unless Nick, Guido or

[issue38469] PEP 572 : assignment expression to a global variable in a comprehension

Change by Pablo Galindo Salgado : -- versions: +Python 3.9 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38469] PEP 572 : assignment expression to a global variable in a comprehension

Change by Pablo Galindo Salgado : -- nosy: +emilyemorehouse, gvanrossum, ncoghlan, pablogsal ___ Python tracker ___ ___

[issue38410] Possible fatal errors due to _PyEval_SetAsyncGen{Finalizer, Firstiter}()

Łukasz Langa added the comment: Unfortunately at this point we will have to leave the ABI as is. We are in fact promising to lock it by Beta 3 so quite a long time ago. -- versions: -Python 3.8 ___ Python tracker

[issue38469] PEP 572 : assignment expression to a global variable in a comprehension

New submission from Pierre Quentel : PEP 572 says that "an assignment expression occurring in a (...) comprehension (...) binds the target in the containing scope, honoring a nonlocal or global declaration for the target in that scope, if one exists." In Appendix B, the PEP shows this

[issue38467] Misspelled argument names for typing.get_origin and get_args

Change by Ivan Levkivskyi : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue38467] Misspelled argument names for typing.get_origin and get_args

miss-islington added the comment: New changeset c732660b7b18352ba8524ac78d39975afe4392ef by Miss Islington (bot) in branch '3.8': bpo-38467: Fix argument name of typing functions (GH-16753) https://github.com/python/cpython/commit/c732660b7b18352ba8524ac78d39975afe4392ef -- nosy:

[issue38467] Misspelled argument names for typing.get_origin and get_args

Ivan Levkivskyi added the comment: New changeset fdfe2833ace93021278fe4c41c40e1d08d70abf9 by Ivan Levkivskyi (Sebastian Rittau) in branch 'master': bpo-38467: Fix argument name of typing functions (GH-16753) https://github.com/python/cpython/commit/fdfe2833ace93021278fe4c41c40e1d08d70abf9

[issue38467] Misspelled argument names for typing.get_origin and get_args

Change by miss-islington : -- pull_requests: +16327 pull_request: https://github.com/python/cpython/pull/16754 ___ Python tracker ___

[issue38014] ./configure on recent macOS versions can fail with multiple "present but cannot be compiled" messages

Ned Deily added the comment: Thanks for the input, @jmr! I realize that what I wrote was ambiguous so to clarify I *have* tested that example with the final release versions of Catalina and Xcode 11.1 and could not reproduce. Just for fun, I've also tested with the latest developer

[issue38467] Misspelled argument names for typing.get_origin and get_args

Sebastian Rittau added the comment: https://github.com/python/cpython/pull/16753 -- ___ Python tracker ___ ___ Python-bugs-list

[issue38467] Misspelled argument names for typing.get_origin and get_args

Change by Sebastian Rittau : -- keywords: +patch pull_requests: +16326 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16753 ___ Python tracker

[issue38467] Misspelled argument names for typing.get_origin and get_args

Ivan Levkivskyi added the comment: I think adjusting the docs would be less disruptive than changing implementation. Would you like to make a PR? -- ___ Python tracker ___

[issue38467] Misspelled argument names for typing.get_origin and get_args

Change by Karthikeyan Singaravelan : -- nosy: +levkivskyi ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38460] 3.8 Release Notes: document asyncio exception changes

Raymond Hettinger added the comment: Please put all suggestions in a single tracker entry. Having multiple entries is more of a hindrance than a help. -- assignee: docs@python -> rhettinger ___ Python tracker

[issue38463] 3.8 Release Notes: Link to SSLContext.post_handshake_auth missing

Change by Raymond Hettinger : -- assignee: docs@python -> rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue38461] 3.8 Release Notes: "curses" misspelled as "ncurses"

Change by Raymond Hettinger : -- assignee: -> rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28556] typing.py upgrades

miss-islington added the comment: New changeset e742826531d4369cb1eff65337fa95fd67de8d42 by Miss Islington (bot) in branch '3.8': bpo-28556: Remove another mention of metaclass of Generic in typing docs (GH-16743)

[issue28556] typing.py upgrades

miss-islington added the comment: New changeset 20d1f49a0008e7c306cbe34dcc1b7d6e62dc3d24 by Miss Islington (bot) in branch '3.7': bpo-28556: Remove another mention of metaclass of Generic in typing docs (GH-16743)

[issue28556] typing.py upgrades

Change by miss-islington : -- pull_requests: +16324 pull_request: https://github.com/python/cpython/pull/16750 ___ Python tracker ___

[issue28556] typing.py upgrades

miss-islington added the comment: New changeset 8144095707f87bdee6f3e1bbb15283ea61381be6 by Miss Islington (bot) (Ivan Levkivskyi) in branch 'master': bpo-28556: Remove another mention of metaclass of Generic in typing docs (GH-16743)

[issue28556] typing.py upgrades

Change by miss-islington : -- pull_requests: +16325 pull_request: https://github.com/python/cpython/pull/16751 ___ Python tracker ___

[issue38468] Refactor python-config.in - use getvar()

Change by Joannah Nanjekye : -- keywords: +patch pull_requests: +16323 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16749 ___ Python tracker

[issue38468] Refactor python-config.in - use getvar()

New submission from Joannah Nanjekye : Use getvar for all still existing sysconfig.get_config_var() calls. -- messages: 354591 nosy: nanjekyejoannah priority: normal severity: normal status: open title: Refactor python-config.in - use getvar() versions: Python 3.9

[issue38462] Typo (nam ing) in import system docs

Change by Eric V. Smith : -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker ___ ___

[issue38467] Misspelled argument names for typing.get_origin and get_args

New submission from Sebastian Rittau : The arguments for typing.get_origin() and typing.get_args() are named "typ" in the documentation (https://docs.python.org/3.8/library/typing.html#typing.get_origin), while they are named "tp" in the implementation. Important if used as keyword argument.

[issue38460] 3.8 Release Notes: document asyncio exception changes

Change by Ned Deily : -- nosy: +akuchling, asvetlov, rhettinger, yselivanov ___ Python tracker ___ ___ Python-bugs-list mailing

[issue38461] 3.8 Release Notes: "curses" misspelled as "ncurses"

Change by Ned Deily : -- nosy: +akuchling, rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38463] 3.8 Release Notes: Link to SSLContext.post_handshake_auth missing

Change by Ned Deily : -- nosy: +akuchling, rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38379] finalizer resurrection in gc

Pablo Galindo Salgado added the comment: New changeset 466326dcdf038b948d94302c315be407c73e60d1 by Pablo Galindo in branch 'master': bpo-38379: Don't block collection of unreachable objects when some objects resurrect (GH-16687)

[issue38466] threading.excepthook doc talks about "object"

New submission from Sebastian Rittau : The documentation of threading.excepthook (https://docs.python.org/3.8/library/threading.html#threading.excepthook) talks about "object", when it only has a "thread" attribute: "Storing object using a custom hook can resurrect it if it is set to an

[issue38465] The type of ob_exports in PyByteArrayObject become Py_ssize_t.

hai shi added the comment: sorry, typo error. # the ob_exports would be overflow in 32 bit machine when i = 2**31. --> # the ob_exports would be overflow in 64 bit machine when i = 2**31. -- ___ Python tracker

[issue38465] The type of ob_exports in PyByteArrayObject become Py_ssize_t.

Change by hai shi : -- keywords: +patch pull_requests: +16322 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16746 ___ Python tracker ___

[issue38465] The type of ob_exports in PyByteArrayObject become Py_ssize_t.

New submission from hai shi : for a code example: ``` v = [] b = bytearray(0x) for i in range(2**31+1) # the ob_exports would be overflow in 32 bit machine when i = 2**31. v.append(memoryview(b)) ``` IMHO, i thought converting the type of ob_exports to Py_ssize_t is fine. PS: I

[issue38462] Typo (nam ing) in import system docs

Roy Smith added the comment: Yeah, that's weird. Looks like this may be a Chrome bug. I'm seeing it in Chrome (Version 77.0.3865.90 (Official Build) (64-bit)), but not Safari. This is on MacOS (High Sierra). In the attached screenshot, I narrowed the window a bit. In the second

[issue38464] documentation for NormalDist.quantiles(): missing argument

New submission from Sebastian Rittau : The documentation for NormalDist.quantiles() (https://docs.python.org/3.8/library/statistics.html#statistics.NormalDist) is missing the "n" argument from the definition. -- assignee: docs@python components: Documentation messages: 354584 nosy:

[issue38462] Typo (nam ing) in import system docs

Eric V. Smith added the comment: I'm not seeing this in either the master or 3.5 branches. Perhaps this is being done locally by your browser? Unfortunately I can't find a way for github to link to a specific line in a .rst file, but when I look at the source code and

[issue38463] 3.8 Release Notes: Link to SSLContext.post_handshake_auth missing

New submission from Sebastian Rittau : The link to SSLContext.post_handshake_auth in the "ssl" section in the release notes is missing. -- assignee: docs@python components: Documentation messages: 354582 nosy: docs@python, srittau priority: normal severity: normal status: open title:

[issue38462] Typo (nam ing) in import system docs

New submission from Roy Smith : In https://docs.python.org/3.5/reference/import.html#importsystem, section "5.2 Packages", second sentence, the word "naming" is broken across two lines. In 3.7.5rc1 as well. Didn't check any others. -- assignee: docs@python components: Documentation

[issue38014] ./configure on recent macOS versions can fail with multiple "present but cannot be compiled" messages

Joshua Root added the comment: The crash reported by BMinas is reputedly related to the -fstack-check option, which is said to be on by default when MACOSX_DEPLOYMENT_TARGET=10.15. I've been unable to confirm whether there was just a bug in the beta, or if it's still a problem on the final

[issue38461] 3.8 Release Notes: "curses" misspelled as "ncurses"

New submission from Sebastian Rittau : The "curses" module is misspelled and sorted as "ncurses" in the release notes. -- messages: 354579 nosy: srittau priority: normal severity: normal status: open title: 3.8 Release Notes: "curses" misspelled as "ncurses"

[issue38431] dataclasses.InitVar breaks with typing.Optional

Serhiy Storchaka added the comment: Thank you for your contribution Samuel! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue38460] 3.8 Release Notes: document asyncio exception changes

New submission from Sebastian Rittau : In Python 3.8 asyncio exceptions were consolidated into the new module "asyncio.exceptions". Previously they were spread out over several modules. While the documentation always mandated to import the exceptions from top-level "asyncio", code that

[issue38431] dataclasses.InitVar breaks with typing.Optional

miss-islington added the comment: New changeset 6da52ac411947d1a7958bbad831fcf8dfc8c95fe by Miss Islington (bot) in branch '3.8': bpo-38431: Fix __repr__ method of InitVar to work with typing objects. (GH-16702)

[issue38202] A fatal error in test_dictviews

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue38202] A fatal error in test_dictviews

Serhiy Storchaka added the comment: New changeset b16e382c446d76ede22780b15c75f43c5f132e25 by Serhiy Storchaka (Zackery Spytz) in branch 'master': bpo-38202: Fix a crash in dict_view & non-itearble. (GH-16241) https://github.com/python/cpython/commit/b16e382c446d76ede22780b15c75f43c5f132e25

[issue38431] dataclasses.InitVar breaks with typing.Optional

Serhiy Storchaka added the comment: New changeset 793cb85437299a3da3d74fe65480d720af330cbb by Serhiy Storchaka (Samuel Colvin) in branch 'master': bpo-38431: Fix __repr__ method of InitVar to work with typing objects. (GH-16702)

[issue38431] dataclasses.InitVar breaks with typing.Optional

Change by miss-islington : -- pull_requests: +16321 pull_request: https://github.com/python/cpython/pull/16744 ___ Python tracker ___

[issue28869] __module__ attribute is not set correctly for a class created by direct metaclass call

Serhiy Storchaka added the comment: PR 14166 now fixes the issue in more generic way. It skips one additional frame when type.__new__ is called not directly from type.__call__. -- ___ Python tracker

[issue38459] typing: Classes that inherit `Generic[...]` indirectly aren't considered generic.

Ivan Levkivskyi added the comment: The docs for typing module are clear about this: ``` Using a generic class without specifying type parameters assumes Any for each position. ``` There is also an example involving a base class. -- resolution: -> not a bug stage: -> resolved

[issue28556] typing.py upgrades

Change by Ivan Levkivskyi : -- pull_requests: +16320 pull_request: https://github.com/python/cpython/pull/16743 ___ Python tracker ___

[issue38378] os.sendfile() has improperly named parameter

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue38397] __init_subclass__ causes TypeError when used with more standard library metaclasses (such as EnumMeta)

Change by retnikt : -- type: -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38378] os.sendfile() has improperly named parameter

Serhiy Storchaka added the comment: New changeset 140a7d1f3579e778656a6b6bfad72489e9870a4d by Serhiy Storchaka in branch 'master': bpo-38378: Rename parameters "out" and "in" of os.sendfile(). (GH-16742) https://github.com/python/cpython/commit/140a7d1f3579e778656a6b6bfad72489e9870a4d

[issue38459] typing: Classes that inherit `Generic[...]` indirectly aren't considered generic.

John Lennon added the comment: BTW I don't mind creating a PR for that issue if there will be an agreement on what is the desired behavior here. -- ___ Python tracker ___

[issue38459] typing: Classes that inherit `Generic[...]` indirectly aren't considered generic.

Change by Karthikeyan Singaravelan : -- nosy: +gvanrossum, levkivskyi ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue38459] typing: Classes that inherit `Generic[...]` indirectly aren't considered generic.

John Lennon added the comment: However, if I change the signature to: ```python class SomeImplMapping(GenericMapping[KT, VT]): ``` Everything works just fine. And that's not really clear for me: we already have declared the generic types, we can not change the amount of those arguments,

[issue38459] typing: Classes that inherit `Generic[...]` indirectly aren't considered generic.

New submission from John Lennon : Given the file `example.py` with the following contents: ```python from typing import Generic, TypeVar KT = TypeVar("KT") VT = TypeVar("VT") class GenericMapping(Generic[KT, VT]): pass class SomeImplMapping(GenericMapping): pass a:

[issue38378] os.sendfile() has improperly named parameter

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +16319 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16742 ___ Python tracker

[issue38457] __package__ is None in __init__.py until an import is used

Yuval S added the comment: * It should be python[23] -m x.test, of course. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue38440] Possible new issues with IDLE

Raymond Hettinger added the comment: ⛏烙 -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38440] Possible new issues with IDLE

Change by Raymond Hettinger : -- Removed message: https://bugs.python.org/msg354566 ___ Python tracker ___ ___ Python-bugs-list

[issue38440] Possible new issues with IDLE

Raymond Hettinger added the comment: * Am running 3.8.0rc1 on macOS Mojave 10.14.6. * My Python is the stock mac 64-build from python.org. * Started IDLE from a terminal with: $ python3.8 -m idlelib.idle * Yes, the box is "Your program is still running!\nDo you want to kill it?" * I'm