[issue40291] socket library support for CAN_J1939

2020-04-14 Thread Karl Ding
Change by Karl Ding : -- keywords: +patch pull_requests: +18886 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19538 ___ Python tracker ___

[issue38583] The activate script in Windows is not correct for venvs created in git-bash

2020-04-14 Thread Mark Mikofski
Mark Mikofski added the comment: Would you consider just handling activate for windows directly in the lib/venv/__init__.py method "install_scripts(self, context, path)" https://github.com/python/cpython/blob/4f98f465f14e7258c5b18a62c5aa114dbe1174d8/Lib/venv/__init__.py#L382 if not

[issue40291] socket library support for CAN_J1939

2020-04-14 Thread Karl Ding
New submission from Karl Ding : It would be nice to have support J1939 sockets. Support for J1939 landed as part of the SAE J1939 SocketCAN patches, which are available after the Linux 5.4rc1 kernel. This is another protocol family for SocketCAN, much like the existing support for ISOTP and

[issue40284] Add mapping methods to types.SimpleNamespace

2020-04-14 Thread Glenn Linderman
Glenn Linderman added the comment: Here's what I have. Maybe it would be better if parse and dump were under or dunder names, although I think parse was in the original implementation I found. Is this the derived from the same original as PyPI dotable? Not sure. -- Added file:

[issue40284] Add mapping methods to types.SimpleNamespace

2020-04-14 Thread Glenn Linderman
Glenn Linderman added the comment: Yes, I laud this effort. I don't care if it is called SimpleNamespace (which I didn't use because it was insufficient), or anything else, but it would be extremely handy to have this battery. I eventually found one called Dotable (or did I rename it to

[issue40290] Add z_score to statistics.NormalDist

2020-04-14 Thread Raymond Hettinger
New submission from Raymond Hettinger : I've had a couple of requests for a z-score method, once to produce an actual z-score for output and another as a way of normalizing gaussian inputs for machine learning. Proposed: >>> iq = NormalDist(100, 15) >>> iq.zscore(142) 2.8 Same

[issue39522] AST Unparser with unicode kinded constants

2020-04-14 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I checked and all current buildbot failures are related to the refleak in test_threading so I think this issue is fixed. I will close the issue, please reopen of I missed something or you would like to address something else :) -- resolution:

[issue39522] AST Unparser with unicode kinded constants

2020-04-14 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I think that this was fixes by PR19525 and PR19523. For instance, the buildbot you mentioned is green when building those PRs: https://buildbot.python.org/all/#/builders/500/builds/289 -- ___ Python

[issue28002] ast.unparse can't roundtrip some f-strings

2020-04-14 Thread Shantanu
Shantanu added the comment: Now that `ast.unparse` is being added to stdlib, I thought I'd bump this thread. The third party library `astunparse` (which attempts to support multiple Python versions while staying very close to Tools/parser/unparse.py) has an implementation that works for

[issue40289] "highlighting" how to get Python's Scripts directory in the documentation

2020-04-14 Thread thautwarm
Change by thautwarm : -- assignee: -> docs@python components: +Documentation nosy: +docs@python versions: +Python 3.5, Python 3.6, Python 3.7, Python 3.8, Python 3.9 ___ Python tracker

[issue40289] "highlighting" how to get Python's Scripts directory in the documentation

2020-04-14 Thread thautwarm
New submission from thautwarm : Currently it's barely impossible for us to search about "How to get where Scripts directory/folder is". If we google this, we can only get answers about '__file__', which is far from the expectation. The correct information lies on -

[issue36780] Interpreter exit blocks waiting for futures of shut-down ThreadPoolExecutors

2020-04-14 Thread Kyle Stanley
Kyle Stanley added the comment: > Agreed, and that is precisely what I suggested in my previous comment. The > attached PR already deals with the executor-specific part of the wait, but it > would be straightforward to have it also affect the executor to create daemon > threads, and the

[issue40277] Improve repr for _tuplegetter objects

2020-04-14 Thread Ammar Askar
Change by Ammar Askar : -- keywords: +patch nosy: +ammar2 nosy_count: 1.0 -> 2.0 pull_requests: +18885 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19537 ___ Python tracker

[issue40288] atexit module should not be loaded more than once per interpreter

2020-04-14 Thread STINNER Victor
New submission from STINNER Victor : Since Python 3.7, it's possible to load the atexit module more than once: commit 776407fe893fd42972c7e3f71423d9d86741d07c Author: Marcel Plch Date: Wed Dec 20 11:17:58 2017 +0100 bpo-31901: atexit callbacks should be run at subinterpreter shutdown

[issue40268] Reorganize pycore_pystate.h header

2020-04-14 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +18884 pull_request: https://github.com/python/cpython/pull/19536 ___ Python tracker ___

[issue40268] Reorganize pycore_pystate.h header

2020-04-14 Thread STINNER Victor
STINNER Victor added the comment: New changeset 4f98f465f14e7258c5b18a62c5aa114dbe1174d8 by Victor Stinner in branch 'master': bpo-40268: Remove unused imports in pylifecycle.c (GH-19533) https://github.com/python/cpython/commit/4f98f465f14e7258c5b18a62c5aa114dbe1174d8 --

[issue39481] Implement PEP 585 (Type Hinting Generics In Standard Collections)

2020-04-14 Thread Guido van Rossum
Guido van Rossum added the comment: Thanks! -- --Guido (mobile) -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue40287] SpooledTemporaryFile.seek returns None

2020-04-14 Thread amcinnes
New submission from amcinnes : The documentation says SpooledTemporaryFile "operates exactly as TemporaryFile() does". seek() would be expected to return the new absolute position; this is what it does for TemporaryFile, and is the documented behaviour of seek() in IOBase. But for

[issue40170] [C API] Make PyTypeObject structure an opaque structure in the public C API

2020-04-14 Thread STINNER Victor
STINNER Victor added the comment: On python-dev, Ronald Oussoren asked to add support for the buffer protocol in PyType_FromSpec() and PyTypeSpec API: Ronald: > BTW. This will require growing the PyTypeSpec ABI a little, there are > features you cannot implement using that API for example

[issue39573] [C API] Make PyObject an opaque structure in the limited C API

2020-04-14 Thread STINNER Victor
STINNER Victor added the comment: PyType_FromSpec() and PyType_Spec API are not currently compatible with opaque PyObject. Example: --- #define PyObject_HEADPyObject ob_base; typedef struct { PyObject_HEAD ... } MyObject; static PyType_Spec type_spec = { .name = "MyObject",

[issue40268] Reorganize pycore_pystate.h header

2020-04-14 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +18883 pull_request: https://github.com/python/cpython/pull/19533 ___ Python tracker ___

[issue40268] Reorganize pycore_pystate.h header

2020-04-14 Thread STINNER Victor
STINNER Victor added the comment: New changeset 361dcdcefc80f5729ed18ac0ef73327794fbf400 by Victor Stinner in branch 'master': bpo-40268: Remove unused osdefs.h includes (GH-19532) https://github.com/python/cpython/commit/361dcdcefc80f5729ed18ac0ef73327794fbf400 --

[issue39522] AST Unparser with unicode kinded constants

2020-04-14 Thread STINNER Victor
STINNER Victor added the comment: Many buildbots failed. Example: https://buildbot.python.org/all/#/builders/500/builds/288 == FAIL: test_annotations (test.test_future.AnnotationsFutureTestCase)

[issue39522] AST Unparser with unicode kinded constants

2020-04-14 Thread STINNER Victor
STINNER Victor added the comment: commit aade1cc453698e1bc48861b16955c2c2219ec521 Author: Batuhan Taşkaya Date: Tue Apr 14 21:55:01 2020 +0300 bpo-395222: Correctly unparse unicode prefix in ast_unparse.c (GH-19512) -- nosy: +vstinner ___

[issue40268] Reorganize pycore_pystate.h header

2020-04-14 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +18882 pull_request: https://github.com/python/cpython/pull/19532 ___ Python tracker ___

[issue40268] Reorganize pycore_pystate.h header

2020-04-14 Thread STINNER Victor
STINNER Victor added the comment: New changeset d9ea5cae1d07e1ee8b03540a9367c26205e0e360 by Victor Stinner in branch 'master': bpo-40268: Remove unused pycore_pymem.h includes (GH-19531) https://github.com/python/cpython/commit/d9ea5cae1d07e1ee8b03540a9367c26205e0e360 --

[issue39481] Implement PEP 585 (Type Hinting Generics In Standard Collections)

2020-04-14 Thread Ethan Smith
Ethan Smith added the comment: I went through the list I generated and it seems that the ipaddress._BaseNetwork and mmap.mmap cases are the only one I saw that shouldn't be generic. I will submit a PR to revert those. The only item left after that which I know of is _lru_cache_wrapper. On

[issue40268] Reorganize pycore_pystate.h header

2020-04-14 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +18881 pull_request: https://github.com/python/cpython/pull/19531 ___ Python tracker ___

[issue40268] Reorganize pycore_pystate.h header

2020-04-14 Thread STINNER Victor
STINNER Victor added the comment: New changeset 4a21e57fe55076c77b0ee454e1994ca544d09dc0 by Victor Stinner in branch 'master': bpo-40268: Remove unused structmember.h includes (GH-19530) https://github.com/python/cpython/commit/4a21e57fe55076c77b0ee454e1994ca544d09dc0 --

[issue40268] Reorganize pycore_pystate.h header

2020-04-14 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +18880 pull_request: https://github.com/python/cpython/pull/19530 ___ Python tracker ___

[issue40268] Reorganize pycore_pystate.h header

2020-04-14 Thread STINNER Victor
STINNER Victor added the comment: New changeset 62183b8d6d49e59c6a98bbdaa65b7ea1415abb7f by Victor Stinner in branch 'master': bpo-40268: Remove explicit pythread.h includes (#19529) https://github.com/python/cpython/commit/62183b8d6d49e59c6a98bbdaa65b7ea1415abb7f --

[issue40268] Reorganize pycore_pystate.h header

2020-04-14 Thread STINNER Victor
STINNER Victor added the comment: See also bpo-2897: Deprecate structmember.h. -- ___ Python tracker ___ ___ Python-bugs-list

[issue40268] Reorganize pycore_pystate.h header

2020-04-14 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +18879 pull_request: https://github.com/python/cpython/pull/19529 ___ Python tracker ___

[issue40270] activate (or include) json1 extension in sqlite

2020-04-14 Thread Ammar Askar
Change by Ammar Askar : -- keywords: +patch nosy: +ammar2 nosy_count: 5.0 -> 6.0 pull_requests: +18878 stage: test needed -> patch review pull_request: https://github.com/python/cpython/pull/19528 ___ Python tracker

[issue39481] Implement PEP 585 (Type Hinting Generics In Standard Collections)

2020-04-14 Thread Guido van Rossum
Guido van Rossum added the comment: New changeset d01628e411752ee6849f862cae66a1c69fe512b7 by Ethan Smith in branch 'master': bpo-39481: PEP 585 for dataclasses, mailbox, contextvars (GH-19425) https://github.com/python/cpython/commit/d01628e411752ee6849f862cae66a1c69fe512b7 --

[issue40284] Add mapping methods to types.SimpleNamespace

2020-04-14 Thread Raymond Hettinger
Raymond Hettinger added the comment: > I'm not saying that there is no need for such tool. > I am just asking to leave SimpleNamespace unchanged. I really don't see the downside. It doesn't impair SimpleNamespace in any way. Why would we add another type with substantially the same

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

2020-04-14 Thread STINNER Victor
STINNER Victor added the comment: New changeset b894b669c98cc365b84cbb8d20f531f1d0686f59 by Victor Stinner in branch '3.7': Update libregrtest from master (GH-19517) https://github.com/python/cpython/commit/b894b669c98cc365b84cbb8d20f531f1d0686f59 --

[issue37531] Fix regrtest timeout for subprocesses: regrtest -jN --timeout=SECONDS

2020-04-14 Thread STINNER Victor
STINNER Victor added the comment: New changeset b894b669c98cc365b84cbb8d20f531f1d0686f59 by Victor Stinner in branch '3.7': Update libregrtest from master (GH-19517) https://github.com/python/cpython/commit/b894b669c98cc365b84cbb8d20f531f1d0686f59 --

[issue38502] regrtest: use process groups

2020-04-14 Thread STINNER Victor
STINNER Victor added the comment: New changeset b894b669c98cc365b84cbb8d20f531f1d0686f59 by Victor Stinner in branch '3.7': Update libregrtest from master (GH-19517) https://github.com/python/cpython/commit/b894b669c98cc365b84cbb8d20f531f1d0686f59 --

[issue37957] Allow regrtest to receive a file with test (and subtests) to ignore

2020-04-14 Thread STINNER Victor
STINNER Victor added the comment: New changeset b894b669c98cc365b84cbb8d20f531f1d0686f59 by Victor Stinner in branch '3.7': Update libregrtest from master (GH-19517) https://github.com/python/cpython/commit/b894b669c98cc365b84cbb8d20f531f1d0686f59 --

[issue36842] Implement PEP 578

2020-04-14 Thread STINNER Victor
STINNER Victor added the comment: New changeset b894b669c98cc365b84cbb8d20f531f1d0686f59 by Victor Stinner in branch '3.7': Update libregrtest from master (GH-19517) https://github.com/python/cpython/commit/b894b669c98cc365b84cbb8d20f531f1d0686f59 -- nosy: +vstinner

[issue40286] Add getrandbytes() method to random.Random

2020-04-14 Thread Raymond Hettinger
Raymond Hettinger added the comment: If we have to have this, the method name should be differentiated from getrandbits() because the latter returns an integer. I suggest just random.bytes(n), the same as numpy. > Python already has three functions to generate random bytes: Now, there

[issue40255] Fixing Copy on Writes from reference counting

2020-04-14 Thread STINNER Victor
STINNER Victor added the comment: This feature seems to be driven by Instagram use case. Are there other users who would benefit of that? Is it a common use case to load big data and then fork to use preloaded data? PR 19474 has a maintenance cost: * new configuration option * new macro *

[issue40282] random.getrandbits(0) should succeed

2020-04-14 Thread STINNER Victor
STINNER Victor added the comment: I created bpo-40286: Add getrandbytes() method to random.Random. -- ___ Python tracker ___ ___

[issue40286] Add getrandbytes() method to random.Random

2020-04-14 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +18877 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19527 ___ Python tracker ___

[issue40286] Add getrandbytes() method to random.Random

2020-04-14 Thread STINNER Victor
New submission from STINNER Victor : The random module lacks a getrandbytes() method which leads developers to be creative how to generate bytes: https://stackoverflow.com/questions/5495492/random-byte-string-in-python It's a common use request: * bpo-13396 in 2011 * bpo-27096 in 2016 *

[issue35569] OSX: Enable IPV6_RECVPKTINFO

2020-04-14 Thread Erlend Egeberg Aasland
Change by Erlend Egeberg Aasland : -- pull_requests: +18876 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/19526 ___ Python tracker

[issue40284] Add mapping methods to types.SimpleNamespace

2020-04-14 Thread STINNER Victor
STINNER Victor added the comment: > Providing this tool would instantly benefit a broad class of json users. I'm not saying that there is no need for such tool. I am just asking to leave SimpleNamespace unchanged. -- ___ Python tracker

[issue40282] random.getrandbits(0) should succeed

2020-04-14 Thread STINNER Victor
STINNER Victor added the comment: > That is feature creep and no user has requested it. Python already provides such function in the secrets module, so I'm not sure if what you mean that "no users has requested it". secrets.token_bytes() exists because there is a need for such function.

[issue40284] Add mapping methods to types.SimpleNamespace

2020-04-14 Thread Raymond Hettinger
Raymond Hettinger added the comment: > I would prefer that SimpleNamespace remains as simple as it is This doesn't affect the simplicity of the current API at all. If you don't need the feature, you won't even notice the extension. > If you want to add the mapping protocol, I suggest you

[issue40284] Add mapping methods to types.SimpleNamespace

2020-04-14 Thread STINNER Victor
STINNER Victor added the comment: I would prefer that SimpleNamespace remains as simple as it is: https://docs.python.org/dev/library/types.html#types.SimpleNamespace "A simple object subclass that provides attribute access to its namespace" If you want to add the mapping protocol, I suggest

[issue40284] Add mapping methods to types.SimpleNamespace

2020-04-14 Thread Raymond Hettinger
Raymond Hettinger added the comment: Only the magic methods need to be added: __getitem__, __setitem__, and __delitem__, __contains__, __len__, and __iter__. The non-dunder names risk incursion into user-space names. >>> SimpleNamespace(username1='value1', username2='value2')

[issue40284] Add mapping methods to types.SimpleNamespace

2020-04-14 Thread Raymond Hettinger
New submission from Raymond Hettinger : types.SimpleNamespace() would be much more usable if it were more substitutable for dictionaries. In particular, it would be wonderful to be able to use object_hook=SimpleNamespace in json.load(): Current: catalog = json.load(f)

[issue40282] random.getrandbits(0) should succeed

2020-04-14 Thread Antoine Pitrou
Antoine Pitrou added the comment: I agree I don't *need* it per se. However, I suspect that for non-exports it would be easier than `getrandbits(nbytes * 8).to_bytes(nbytes, 'endian')`. As for `secrets.token_bytes()`, it's not really adequate for regular pseudo-random data generation when

[issue40282] random.getrandbits(0) should succeed

2020-04-14 Thread Raymond Hettinger
Raymond Hettinger added the comment: Why not use secrets.token_bytes() or randrange(2**b).to_bytes()? Do you really need an API extension? -- nosy: +tim.peters ___ Python tracker

[issue40282] random.getrandbits(0) should succeed

2020-04-14 Thread Antoine Pitrou
Change by Antoine Pitrou : -- components: +Library (Lib) ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40282] random.getrandbits(0) should succeed

2020-04-14 Thread Antoine Pitrou
Change by Antoine Pitrou : -- stage: -> needs patch ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40282] random.getrandbits(0) should succeed

2020-04-14 Thread Antoine Pitrou
Antoine Pitrou added the comment: About a hypothetical getrandbytes(), probably 90% of my uses of getrandbits() have been to generate random bytestrings. -- ___ Python tracker

[issue40282] random.getrandbits(0) should succeed

2020-04-14 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I do not want to open an issue if I know that the idea will be rejected. -- ___ Python tracker ___

[issue39522] AST Unparser with unicode kinded constants

2020-04-14 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 33986465bde2a2188537c4ef6cdb6055e348f31f by Pablo Galindo in branch 'master': bpo-39522: Always initialise kind attribute in constant ast nodes (GH-19525) https://github.com/python/cpython/commit/33986465bde2a2188537c4ef6cdb6055e348f31f

[issue39522] AST Unparser with unicode kinded constants

2020-04-14 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue39522] AST Unparser with unicode kinded constants

2020-04-14 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 43aeefa41915e4d3b0e68bbd4268c1c378a72dce by Batuhan Taşkaya in branch 'master': bpo-39522: Use _PyUnicodeWriter_WriteStr instead of PyUnicode_AS_DATA (GH-19523)

[issue39522] AST Unparser with unicode kinded constants

2020-04-14 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- nosy: +pablogsal nosy_count: 1.0 -> 2.0 pull_requests: +18875 pull_request: https://github.com/python/cpython/pull/19525 ___ Python tracker

[issue40282] random.getrandbits(0) should succeed

2020-04-14 Thread Raymond Hettinger
Raymond Hettinger added the comment: +0 for having getrandbits(0) return 0. Conceptually, it is reasonable. Practically, it is a bit inconvenient because the ValueError may have to be moved upstream to the _randbelow() methods. -1 for getrandbytes(). That is feature creep and no user has

[issue36780] Interpreter exit blocks waiting for futures of shut-down ThreadPoolExecutors

2020-04-14 Thread Hrvoje Nikšić
Hrvoje Nikšić added the comment: > The only way I could see this to work as intended without making any changes > to threading would be to optionally use daemon threads and avoid joining the > threads in `executor.shutdown()` if `wait_at_exit` is set to False in the > constructor for the

[issue40249] __import__ doesn't honour globals

2020-04-14 Thread Stefan Seefeld
Stefan Seefeld added the comment: I'm not entirely sure, but have to admit that the sentence "The function imports the module name, potentially using the given globals and locals to determine how to interpret the name in a package context." is a bit obscure. What does "determine how to

[issue36780] Interpreter exit blocks waiting for futures of shut-down ThreadPoolExecutors

2020-04-14 Thread Kyle Stanley
Kyle Stanley added the comment: > ThreadPoolExecutor introduces additional waiting of its own, and it is this > wait the PR adds an option to disable. [next post] > Thanks for the clarification, I didn't know about the change to non-daemon > threads. > I still think this patch is useful,

[issue9216] FIPS support for hashlib

2020-04-14 Thread miss-islington
Change by miss-islington : -- pull_requests: +18874 pull_request: https://github.com/python/cpython/pull/19524 ___ Python tracker ___

[issue9216] FIPS support for hashlib

2020-04-14 Thread miss-islington
miss-islington added the comment: New changeset 4c0a31fb08407ba043688ad1c21102dd4cb99146 by Miro Hrončok in branch 'master': bpo-9216: Nobody expects the geohashing FIPS inquisition (GH-19520) https://github.com/python/cpython/commit/4c0a31fb08407ba043688ad1c21102dd4cb99146 -- nosy:

[issue40249] __import__ doesn't honour globals

2020-04-14 Thread Brett Cannon
Brett Cannon added the comment: How would you propose changing the wording found at https://docs.python.org/3/library/functions.html?highlight=__import__#__import__? -- nosy: +brett.cannon ___ Python tracker

[issue40260] modulefinder traceback regression starting on Windows

2020-04-14 Thread Steve Dower
Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue40260] modulefinder traceback regression starting on Windows

2020-04-14 Thread miss-islington
miss-islington added the comment: New changeset 59047fab0ef37f583c9e7c3a48d67792fd10ff91 by Miss Islington (bot) in branch '3.8': bpo-40260: Update modulefinder to use io.open_code() and respect coding comments (GH-19488)

[issue39522] AST Unparser with unicode kinded constants

2020-04-14 Thread Batuhan Taskaya
Change by Batuhan Taskaya : -- pull_requests: +18873 pull_request: https://github.com/python/cpython/pull/19523 ___ Python tracker ___

[issue23082] pathlib relative_to() can give confusing error message

2020-04-14 Thread Steve Dower
Steve Dower added the comment: I agree it's worth improving the error message (and probably the docs too). It's never made clear that relative_to only looks deeper (won't ever generate leading ".." parts) - the closest hint in the docs is that os.path.relpath is different (and that isn't

[issue40260] modulefinder traceback regression starting on Windows

2020-04-14 Thread Steve Dower
Steve Dower added the comment: New changeset d42e5820631cd66ee1eab8f610d4b58f3dfdd81c by Barry in branch 'master': bpo-40260: Update modulefinder to use io.open_code() and respect coding comments (GH-19488) https://github.com/python/cpython/commit/d42e5820631cd66ee1eab8f610d4b58f3dfdd81c

[issue40260] modulefinder traceback regression starting on Windows

2020-04-14 Thread miss-islington
Change by miss-islington : -- nosy: +miss-islington nosy_count: 7.0 -> 8.0 pull_requests: +18872 pull_request: https://github.com/python/cpython/pull/19522 ___ Python tracker

[issue36780] Interpreter exit blocks waiting for futures of shut-down ThreadPoolExecutors

2020-04-14 Thread Kyle Stanley
Kyle Stanley added the comment: > I don't think there's much ThreadPoolExecutor can do. If you drop the > references to the threads, they still exist and they still be waited upon at > interpreter exit. > > The solution is for you to avoid having hanging threads. In the particular > case

[issue40267] Error message differs when an expression is in an fstring

2020-04-14 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- keywords: +patch pull_requests: +18871 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19521 ___ Python tracker

[issue40282] random.getrandbits(0) should succeed

2020-04-14 Thread Mark Dickinson
Mark Dickinson added the comment: This was discussed previously in #37000. I agree that `getrandbits(0)` should succeed. -- ___ Python tracker ___

[issue40282] random.getrandbits(0) should succeed

2020-04-14 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Seconded. And I wish to add the getrandbytes() method. -- nosy: +serhiy.storchaka ___ Python tracker ___

[issue40255] Fixing Copy on Writes from reference counting

2020-04-14 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > I'm not sure what you mean here by "balanced ref count" or by "work" :) What > will happen anytime an immortal object gets into the GC, for any reason, is > that the GC will "subtract" cyclic references and see that the immortal > object still has

[issue9216] FIPS support for hashlib

2020-04-14 Thread Miro Hrončok
Change by Miro Hrončok : -- nosy: +hroncok nosy_count: 17.0 -> 18.0 pull_requests: +18870 pull_request: https://github.com/python/cpython/pull/19520 ___ Python tracker ___

[issue40260] modulefinder traceback regression starting on Windows

2020-04-14 Thread Steve Dower
Steve Dower added the comment: Thanks, Barry! I tweaked your NEWS entry a little, so once CI completes I'll merge and backport. -- ___ Python tracker ___

[issue32033] The pwd module implementation incorrectly sets some attributes to None

2020-04-14 Thread miss-islington
miss-islington added the comment: New changeset 8821200d85657ef3bbec78dcb43694449c05e896 by Miss Islington (bot) in branch '3.7': bpo-32033: Fix test_pwd failures on Android (GH-19502) https://github.com/python/cpython/commit/8821200d85657ef3bbec78dcb43694449c05e896 --

[issue36780] Interpreter exit blocks waiting for futures of shut-down ThreadPoolExecutors

2020-04-14 Thread Hrvoje Nikšić
Hrvoje Nikšić added the comment: Thanks for the clarification, I didn't know about the change to non-daemon threads. I still think this patch is useful, and won't harm general use because it is opt-in, just like daemon threads themselves. I suggest to update the PR to specify non-waiting

[issue32033] The pwd module implementation incorrectly sets some attributes to None

2020-04-14 Thread miss-islington
miss-islington added the comment: New changeset 1e1dbdf23f7a18f53a3257badc3541973831f2c4 by Miss Islington (bot) in branch '3.8': bpo-32033: Fix test_pwd failures on Android (GH-19502) https://github.com/python/cpython/commit/1e1dbdf23f7a18f53a3257badc3541973831f2c4 --

[issue40255] Fixing Copy on Writes from reference counting

2020-04-14 Thread Carl Meyer
Carl Meyer added the comment: I think the concerns about "perfect" behavior in corner cases are in general irrelevant here. In the scenarios where this optimization matters, there is no quantitative change that occurs at 100% coverage. Preventing 99% of CoW is 99% as good as preventing

[issue40255] Fixing Copy on Writes from reference counting

2020-04-14 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > But if said objects (isolated and untracked before and now tracked) acquire > strong references to immortal objects, those objects will be visited when the > gc starts calculating the isolated cycles and that requires a balanced > reference count

[issue36780] Interpreter exit blocks waiting for futures of shut-down ThreadPoolExecutors

2020-04-14 Thread Antoine Pitrou
Antoine Pitrou added the comment: I think there's a misunderstanding: "wait_at_exit" will make the *executor* forget about the threads, but Python itself still knows about them, and it waits for them to end at interpreter shutdown. These threads were daemon threads in 3.8, so your patch

[issue32033] The pwd module implementation incorrectly sets some attributes to None

2020-04-14 Thread STINNER Victor
STINNER Victor added the comment: It's now fixed in master and backports to 3.7 and 3.8 will be merged as soon as the CI pass. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue32033] The pwd module implementation incorrectly sets some attributes to None

2020-04-14 Thread miss-islington
Change by miss-islington : -- pull_requests: +18869 pull_request: https://github.com/python/cpython/pull/19519 ___ Python tracker ___

[issue36780] Interpreter exit blocks waiting for futures of shut-down ThreadPoolExecutors

2020-04-14 Thread Hrvoje Nikšić
Hrvoje Nikšić added the comment: > I don't think there's much ThreadPoolExecutor can do. If you drop the > references to the threads, they still exist and they still be waited upon at > interpreter exit. ThreadPoolExecutor introduces additional waiting of its own, and it is this wait the

[issue32033] The pwd module implementation incorrectly sets some attributes to None

2020-04-14 Thread miss-islington
Change by miss-islington : -- nosy: +miss-islington nosy_count: 4.0 -> 5.0 pull_requests: +18868 pull_request: https://github.com/python/cpython/pull/19518 ___ Python tracker

[issue32033] The pwd module implementation incorrectly sets some attributes to None

2020-04-14 Thread STINNER Victor
STINNER Victor added the comment: New changeset 96515e9f6785328c52ebc5d4ce60e0087a9adc2d by Zackery Spytz in branch 'master': bpo-32033: Fix test_pwd failures on Android (GH-19502) https://github.com/python/cpython/commit/96515e9f6785328c52ebc5d4ce60e0087a9adc2d --

[issue40170] [C API] Make PyTypeObject structure an opaque structure in the public C API

2020-04-14 Thread STINNER Victor
STINNER Victor added the comment: New changeset 675d9a3d7afc767a2818c84da7ba4bf4181dcf26 by Hai Shi in branch 'master': bpo-40170: Convert PyObject_IS_GC() macro to a function (GH-19464) https://github.com/python/cpython/commit/675d9a3d7afc767a2818c84da7ba4bf4181dcf26 --

[issue40255] Fixing Copy on Writes from reference counting

2020-04-14 Thread Gregory P. Smith
Gregory P. Smith added the comment: Marking everything as immortal/eternal after you've loaded your common code & data but before you do your forking is thenorm for this kind of serving system. You already presumably have a defined lifetime for the processes so they'll likely be set to die

[issue36780] Interpreter exit blocks waiting for futures of shut-down ThreadPoolExecutors

2020-04-14 Thread Antoine Pitrou
Antoine Pitrou added the comment: I don't think there's much ThreadPoolExecutor can do. If you drop the references to the threads, they still exist and they still be waited upon at interpreter exit. The solution is for you to avoid having hanging threads. In the particular case of TCP

[issue36780] Interpreter exit blocks waiting for futures of shut-down ThreadPoolExecutors

2020-04-14 Thread Antoine Pitrou
Change by Antoine Pitrou : -- nosy: +aeros ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40260] modulefinder traceback regression starting on Windows

2020-04-14 Thread Barry Alan Scott
Barry Alan Scott added the comment: io.open_code() used in the patch. -- components: -Windows ___ Python tracker ___ ___

[issue40255] Fixing Copy on Writes from reference counting

2020-04-14 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > all objects that are tracked by the gc also, all the objects that are reachable from objects tracked by the gc. -- ___ Python tracker

  1   2   >