[issue40966] Remove redundant var in PyErr_NewException

2020-06-12 Thread hai shi
Change by hai shi : -- keywords: +patch pull_requests: +20043 stage: -> patch review pull_request: https://github.com/python/cpython/pull/20850 ___ Python tracker ___

[issue40966] Remove redundant var in PyErr_NewException

2020-06-12 Thread hai shi
New submission from hai shi : Looks like `classname` in PyErr_NewException() is redundant: https://github.com/python/cpython/blob/master/Python/errors.c#L1082 -- components: Interpreter Core messages: 371438 nosy: shihai1991 priority: normal severity: normal status: open title: Remove

[issue40925] Remove redundant macros used for stack manipulation in interpreter

2020-06-12 Thread hai shi
Change by hai shi : -- nosy: +shihai1991 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40740] Missing api-ms-win-core-path-l1-1.0.dll for python-3.9.0b1-amd64.exe Under Win7

2020-06-12 Thread Mark Hammond
Mark Hammond added the comment: Can we get this mentioned somewhere? Eg, https://www.python.org/downloads/release/python-390b3/ doesn't mention anything about minimum versions. https://www.python.org/downloads/windows/ also has prominent notices like "Note that Python 3.8.3rc1 cannot be

[issue40275] test.support has way too many imports

2020-06-12 Thread hai shi
Change by hai shi : -- pull_requests: +20042 pull_request: https://github.com/python/cpython/pull/20849 ___ Python tracker ___ ___

[issue40894] asyncio.gather() cancelled() always False

2020-06-12 Thread Caleb Hattingh
Caleb Hattingh added the comment: Kyle is correct. By analogy with Kyle's example, the following example has no gather, only two nested futures: ``` # childfut.py import asyncio async def f(fut): await fut async def g(t): await asyncio.sleep(t) async def main(): fut_g =

[issue33881] dataclasses should use NFKC to find duplicate members

2020-06-12 Thread శ్రీనివాస్ రెడ్డి తాటిపర్తి
Srinivas Reddy Thatiparthy(శ్రీనివాస్ రెడ్డి తాటిపర్తి) added the comment: I am convinced by Raymond’s argument. Hence closing the PR. -- ___ Python tracker ___

[issue40498] Holding spacebar on button widget permanently makes it SUNKEN even after release (and wait).

2020-06-12 Thread Ned Deily
Ned Deily added the comment: I agree that, if the problem is reproducible with wish, it's not a tkinter issue (which is just a wrapper around Tk calls). You may want to pursue it with the Tk project: https://core.tcl-lang.org/index.html -- nosy: +ned.deily resolution: -> third

[issue37193] Memory leak while running TCP/UDPServer with socketserver.ThreadingMixIn

2020-06-12 Thread Ned Deily
Ned Deily added the comment: > Any chance this can get into Python 3.7? Perhaps but there's a lot that needs to be done yet. Like any bugfix, it needs to be reviewed, merged to master, and get some buildbot exposure first before it is backported anywhere. --

[issue40965] Segfault when importing unittest module

2020-06-12 Thread The Comet
New submission from The Comet : The following program will segfault the interpreter: #include int main() { Py_Initialize(); PyRun_SimpleString("import unittest"); Py_Finalize(); Py_Initialize(); PyRun_SimpleString("import unittest"); /* segfault here */

[issue1635741] Py_Finalize() doesn't clear all Python objects at exit

2020-06-12 Thread Dong-hee Na
Change by Dong-hee Na : -- pull_requests: +20041 pull_request: https://github.com/python/cpython/pull/20848 ___ Python tracker ___

[issue37193] Memory leak while running TCP/UDPServer with socketserver.ThreadingMixIn

2020-06-12 Thread Jason R. Coombs
Jason R. Coombs added the comment: Thanks for the notice Ned. I've revived the PR and addressed all the comments from Victor. Any chance this can get into Python 3.7? -- ___ Python tracker

[issue40925] Remove redundant macros used for stack manipulation in interpreter

2020-06-12 Thread Raymond Hettinger
Raymond Hettinger added the comment: I don't see any advantage to making this change. The current code is readable and the macros have an obvious interpretation. We also know that they generate clean code on every compiler we've come across and on 32 bits. Also, this should be marked as

[issue27729] Provide a better error message when the file path is too long on Windows

2020-06-12 Thread Eryk Sun
Eryk Sun added the comment: Thanks for working on a PR, Zackery. Note that we can't rely on GetLastError() in PyErr_SetFromErrnoWithFilenameObjects. It may be called in contexts where the thread's LastErrorValue is no longer related to the C errno value. My suggestion in msg272427 was

[issue39666] IDLE: Factor out similar code in editor and hyperparser

2020-06-12 Thread Cheryl Sabella
Cheryl Sabella added the comment: PR20847 is an implementation with the parser function in hyperparser instead of EditorWindow. -- ___ Python tracker ___

[issue39666] IDLE: Factor out similar code in editor and hyperparser

2020-06-12 Thread Cheryl Sabella
Change by Cheryl Sabella : -- pull_requests: +20040 pull_request: https://github.com/python/cpython/pull/20847 ___ Python tracker ___

[issue40925] Remove redundant macros used for stack manipulation in interpreter

2020-06-12 Thread Dennis Sweeney
Change by Dennis Sweeney : Removed file: https://bugs.python.org/file49229/master_perf.txt ___ Python tracker ___ ___ Python-bugs-list

[issue40925] Remove redundant macros used for stack manipulation in interpreter

2020-06-12 Thread Dennis Sweeney
Change by Dennis Sweeney : Removed file: https://bugs.python.org/file49228/pushpop_perf.txt ___ Python tracker ___ ___ Python-bugs-list

[issue40925] Remove redundant macros used for stack manipulation in interpreter

2020-06-12 Thread Dennis Sweeney
Change by Dennis Sweeney : Added file: https://bugs.python.org/file49230/perf_diff.txt ___ Python tracker ___ ___ Python-bugs-list mailing

[issue37556] Launcher help does not mention configuration options

2020-06-12 Thread miss-islington
miss-islington added the comment: New changeset b3e6783423f58597419abae343dd1d5dcc02a7e3 by Steve (Gadget) Barnes in branch 'master': bpo-37556 Extend help to include latest overrides (GH-14701) https://github.com/python/cpython/commit/b3e6783423f58597419abae343dd1d5dcc02a7e3 --

[issue37556] Launcher help does not mention configuration options

2020-06-12 Thread miss-islington
Change by miss-islington : -- pull_requests: +20039 pull_request: https://github.com/python/cpython/pull/20846 ___ Python tracker ___

[issue37193] Memory leak while running TCP/UDPServer with socketserver.ThreadingMixIn

2020-06-12 Thread Gregory P. Smith
Change by Gregory P. Smith : -- versions: +Python 3.10, Python 3.8, Python 3.9 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue40164] Upgrade Windows and macOS installer builds to OpenSSL 1.1.1g

2020-06-12 Thread Ned Deily
Ned Deily added the comment: Thanks, Steve and Srinivas! -- priority: deferred blocker -> versions: +Python 3.10 ___ Python tracker ___

[issue37556] Launcher help does not mention configuration options

2020-06-12 Thread Cheryl Sabella
Cheryl Sabella added the comment: @steve.dower, please re-review this PR when you get a chance. Thank you! -- nosy: +cheryl.sabella ___ Python tracker ___

[issue33881] dataclasses should use NFKC to find duplicate members

2020-06-12 Thread Raymond Hettinger
Raymond Hettinger added the comment: I recommend leaving the code as-is. AFAICT, the situation almost never arises in practice, and if it did, the existing SyntaxError is clear. Given that the rest of that language uses a SyntaxError, there isn't a net benefit for switching to TypeError:

[issue40925] Remove redundant macros used for stack manipulation in interpreter

2020-06-12 Thread Dennis Sweeney
Change by Dennis Sweeney : Added file: https://bugs.python.org/file49229/master_perf.txt ___ Python tracker ___ ___ Python-bugs-list

[issue40925] Remove redundant macros used for stack manipulation in interpreter

2020-06-12 Thread Dennis Sweeney
Dennis Sweeney added the comment: I just added PR 20845, but I'm concerned about performance. I'm attaching the results of a run of pyperformance before and after PR 20845. -- Added file: https://bugs.python.org/file49228/pushpop_perf.txt ___

[issue33315] Allow queue.Queue to be used in type annotations

2020-06-12 Thread Sam Bull
Change by Sam Bull : -- nosy: +dreamsorcerer ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40925] Remove redundant macros used for stack manipulation in interpreter

2020-06-12 Thread Dennis Sweeney
Change by Dennis Sweeney : -- nosy: +Dennis Sweeney nosy_count: 3.0 -> 4.0 pull_requests: +20038 pull_request: https://github.com/python/cpython/pull/20845 ___ Python tracker

[issue27729] Provide a better error message when the file path is too long on Windows

2020-06-12 Thread Zackery Spytz
Change by Zackery Spytz : -- keywords: +patch nosy: +ZackerySpytz nosy_count: 6.0 -> 7.0 pull_requests: +20037 stage: test needed -> patch review pull_request: https://github.com/python/cpython/pull/20844 ___ Python tracker

[issue40164] Upgrade Windows and macOS installer builds to OpenSSL 1.1.1g

2020-06-12 Thread Steve Dower
Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue40896] Missing links to Source Code in Documentation pages

2020-06-12 Thread Roundup Robot
Change by Roundup Robot : -- keywords: +patch nosy: +python-dev nosy_count: 7.0 -> 8.0 pull_requests: +20036 stage: -> patch review pull_request: https://github.com/python/cpython/pull/20843 ___ Python tracker

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +20035 stage: -> patch review pull_request: https://github.com/python/cpython/pull/20842 ___ Python tracker

[issue40164] Upgrade Windows and macOS installer builds to OpenSSL 1.1.1g

2020-06-12 Thread Steve Dower
Steve Dower added the comment: New changeset 617af99312ca36ad5a08db764858caf11c92a2c0 by Steve Dower in branch '3.7': bpo-40164: Update Windows OpenSSL to 1.1.1g (GH-20834) https://github.com/python/cpython/commit/617af99312ca36ad5a08db764858caf11c92a2c0 --

[issue40164] Upgrade Windows and macOS installer builds to OpenSSL 1.1.1g

2020-06-12 Thread Steve Dower
Steve Dower added the comment: New changeset 7e57c367d65f3d0219978b465dc00da15ae3724c by Steve Dower in branch '3.8': bpo-40164: Update Windows OpenSSL to 1.1.1g (GH-20834) https://github.com/python/cpython/commit/7e57c367d65f3d0219978b465dc00da15ae3724c --

[issue40913] time.sleep ignores errors on Windows

2020-06-12 Thread Steve Dower
Steve Dower added the comment: > If WaitForSingleObjectEx fails, do you think the system error code should be > raised as an OSError? It's invalid (and unfixable) internal state, so perhaps SystemError makes the most sense? There's no point catching it in most cases. Or since we don't want

[issue40164] Upgrade Windows and macOS installer builds to OpenSSL 1.1.1g

2020-06-12 Thread miss-islington
miss-islington added the comment: New changeset 166d7234b5ae07f78feb5ddfb3026fbd2a1a36e2 by Miss Islington (bot) in branch '3.9': bpo-40164: Update Windows OpenSSL to 1.1.1g (GH-20834) https://github.com/python/cpython/commit/166d7234b5ae07f78feb5ddfb3026fbd2a1a36e2 --

[issue39645] Expand concurrent.futures.Future's public API

2020-06-12 Thread jakirkham
Change by jakirkham : -- nosy: +jakirkham ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40164] Upgrade Windows and macOS installer builds to OpenSSL 1.1.1g

2020-06-12 Thread Steve Dower
Change by Steve Dower : -- pull_requests: +20033 pull_request: https://github.com/python/cpython/pull/20840 ___ Python tracker ___

[issue40164] Upgrade Windows and macOS installer builds to OpenSSL 1.1.1g

2020-06-12 Thread Steve Dower
Change by Steve Dower : -- pull_requests: +20034 pull_request: https://github.com/python/cpython/pull/20841 ___ Python tracker ___

[issue34480] _markupbase.py fails with UnboundLocalError on invalid keyword in marked section

2020-06-12 Thread Leonard Richardson
Leonard Richardson added the comment: I'm the maintainer of Beautiful Soup. I learned about this issue when one of my users filed a bug for it against Beautiful Soup (https://bugs.launchpad.net/beautifulsoup/+bug/1883264). BeautifulSoupHTMLParser (my subclass of html.parser.HTMLParser)

[issue40164] Upgrade Windows and macOS installer builds to OpenSSL 1.1.1g

2020-06-12 Thread Steve Dower
Steve Dower added the comment: New changeset 80d827c3cb041ae72b9b0572981c50bdd1fe2cab by Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) in branch 'master': bpo-40164: Update Windows OpenSSL to 1.1.1g (GH-20834)

[issue40164] Upgrade Windows and macOS installer builds to OpenSSL 1.1.1g

2020-06-12 Thread miss-islington
Change by miss-islington : -- pull_requests: +20032 pull_request: https://github.com/python/cpython/pull/20839 ___ Python tracker ___

[issue40960] Fix the example in hashlib documentarion

2020-06-12 Thread Marcelo
Marcelo added the comment: ooops, thank you! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37910] argparse wrapping fails with metavar="" (no metavar)

2020-06-12 Thread Raymond Hettinger
Raymond Hettinger added the comment: Paul, what do you think about the PR? -- nosy: +rhettinger ___ Python tracker ___ ___

[issue37910] argparse wrapping fails with metavar="" (no metavar)

2020-06-12 Thread Raymond Hettinger
Change by Raymond Hettinger : -- versions: +Python 3.10 -Python 2.7, Python 3.5, Python 3.6, Python 3.7, Python 3.8, Python 3.9 ___ Python tracker ___

[issue40164] Upgrade Windows and macOS installer builds to OpenSSL 1.1.1g

2020-06-12 Thread Steve Dower
Steve Dower added the comment: Okay, new sources and build are up, so I retriggered the PR. If it's all good, I'll merge and backport. -- ___ Python tracker ___

[issue40913] time.sleep ignores errors on Windows

2020-06-12 Thread Eryk Sun
Eryk Sun added the comment: If WaitForSingleObjectEx fails, do you think the system error code should be raised as an OSError? Probably an invalid-handle or access-denied error is too cryptic here. It may be better to raise something like RuntimeError('time.sleep(): invalid SIGINT event

[issue40964] Connection to IMAP server cyrus.andrew.cmu.edu hangs

2020-06-12 Thread Ned Deily
Ned Deily added the comment: New changeset 0abb70ec93bfc6724199b7dd6c89294ce7d83072 by Ned Deily (Christian Heimes) in branch '3.7': bpo-40964: disable remote IMAP tests (GH-20836) https://github.com/python/cpython/commit/0abb70ec93bfc6724199b7dd6c89294ce7d83072 --

[issue40964] Connection to IMAP server cyrus.andrew.cmu.edu hangs

2020-06-12 Thread Ned Deily
Ned Deily added the comment: New changeset adce133378be75bcac4d61fd62a151852555000f by Ned Deily (Christian Heimes) in branch '3.8': bpo-40964: disable remote IMAP tests (GH-20836) https://github.com/python/cpython/commit/adce133378be75bcac4d61fd62a151852555000f --

[issue40964] Connection to IMAP server cyrus.andrew.cmu.edu hangs

2020-06-12 Thread Ned Deily
Ned Deily added the comment: New changeset f91917908749cb595113f8d8428ae1d6241f0392 by Ned Deily (Christian Heimes) in branch '3.9': bpo-40964: disable remote IMAP tests (GH-20836) https://github.com/python/cpython/commit/f91917908749cb595113f8d8428ae1d6241f0392 --

[issue40964] Connection to IMAP server cyrus.andrew.cmu.edu hangs

2020-06-12 Thread Christian Heimes
Change by Christian Heimes : -- type: -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40913] time.sleep ignores errors on Windows

2020-06-12 Thread Steve Dower
Steve Dower added the comment: You could test this by getting the event and CloseHandle-ing it. A function to do this could be added to _testcapimodule. It'd have to run in its own process, but we have (a few) helpers around for this. Given the concerns, I don't think we should change this

[issue40913] time.sleep ignores errors on Windows

2020-06-12 Thread Steve Dower
Steve Dower added the comment: ... equally happy without an explicit test in anything that's only prerelease right now. -- ___ Python tracker ___

[issue40964] Connection to IMAP server cyrus.andrew.cmu.edu hangs

2020-06-12 Thread Christian Heimes
Christian Heimes added the comment: The remote server is having intermittent issues. Sometimes all three servers behind the host are gone, sometimes they block all packages. # nmap -vv cyrus.andrew.cmu.edu Starting Nmap 7.80 ( https://nmap.org ) at 2020-06-12 20:52 CEST Warning: Hostname

[issue40964] Connection to IMAP server cyrus.andrew.cmu.edu hangs

2020-06-12 Thread Ned Deily
Ned Deily added the comment: New changeset 08b1bbab6bfa1ff726db13a9fc3885329f73dca4 by Christian Heimes in branch 'master': bpo-40964: disable remote IMAP tests (GH-20836) https://github.com/python/cpython/commit/08b1bbab6bfa1ff726db13a9fc3885329f73dca4 --

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > This line is wrong though, since PyUnicode_GET_LENGTH returns the length in > code points Whoops! Thanks for pointing that out. In any case, the patch still shows that the ASAN error goes away by limiting the access to the string so I suppose that

[issue33881] dataclasses should use NFKC to find duplicate members

2020-06-12 Thread శ్రీనివాస్ రెడ్డి తాటిపర్తి
Change by Srinivas Reddy Thatiparthy(శ్రీనివాస్ రెడ్డి తాటిపర్తి) : -- nosy: +thatiparthy nosy_count: 4.0 -> 5.0 pull_requests: +20031 pull_request: https://github.com/python/cpython/pull/20837 ___ Python tracker

[issue40964] Connection to IMAP server cyrus.andrew.cmu.edu hangs

2020-06-12 Thread Christian Heimes
Change by Christian Heimes : -- keywords: +patch pull_requests: +20030 stage: -> patch review pull_request: https://github.com/python/cpython/pull/20836 ___ Python tracker

[issue40164] Upgrade Windows and macOS installer builds to OpenSSL 1.1.1g

2020-06-12 Thread Steve Dower
Steve Dower added the comment: Thanks. Your PR will start to work once I've done the updated build, so don't worry about the failure right now. OpenSSL updates require build manager involvement, so it's blocked on me :) -- ___ Python tracker

[issue40964] Connection to IMAP server cyrus.andrew.cmu.edu hangs

2020-06-12 Thread Christian Heimes
Change by Christian Heimes : -- assignee: -> christian.heimes ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue40964] Connection to IMAP server cyrus.andrew.cmu.edu hangs

2020-06-12 Thread Christian Heimes
New submission from Christian Heimes : All buildbots and tests are currently failing because connections cyrus.andrew.cmu.edu:143 (IMAP) and cyrus.andrew.cmu.edu:993 (IMAPS) are hanging. -- components: Tests messages: 371403 nosy: christian.heimes, lukasz.langa, ned.deily priority:

[issue40855] statistics.stdev ignore xbar argument

2020-06-12 Thread Raymond Hettinger
Change by Raymond Hettinger : -- keywords: +patch pull_requests: +20029 stage: -> patch review pull_request: https://github.com/python/cpython/pull/20835 ___ Python tracker

[issue40164] Upgrade Windows and macOS installer builds to OpenSSL 1.1.1g

2020-06-12 Thread శ్రీనివాస్ రెడ్డి తాటిపర్తి
Srinivas Reddy Thatiparthy(శ్రీనివాస్ రెడ్డి తాటిపర్తి) added the comment: Steve, I have done it. And I didn't see your reply. -- ___ Python tracker ___

[issue40164] Upgrade Windows and macOS installer builds to OpenSSL 1.1.1g

2020-06-12 Thread శ్రీనివాస్ రెడ్డి తాటిపర్తి
Change by Srinivas Reddy Thatiparthy(శ్రీనివాస్ రెడ్డి తాటిపర్తి) : -- nosy: +thatiparthy nosy_count: 9.0 -> 10.0 pull_requests: +20028 pull_request: https://github.com/python/cpython/pull/20834 ___ Python tracker

[issue40164] Upgrade Windows and macOS installer builds to OpenSSL 1.1.1g

2020-06-12 Thread Steve Dower
Steve Dower added the comment: Yeah, I'll get onto it now. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue40963] distutils make_zipfile uses random order

2020-06-12 Thread ghost43
New submission from ghost43 : I am trying to generate .zip sdists for a project in a reproducible manner, using setuptoools. The generated zips differ in the order of packed files. The root cause of the non-determinicity is using os.walk() in make_zipfile here:

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: > +Py_ssize_t linesize = PyUnicode_GET_LENGTH(line); This line is wrong though, since PyUnicode_GET_LENGTH returns the length in code points and PyUnicode_DecodeUTF8 expects the number of bytes. For non-ascii input this would push the caret further

[issue40890] Dict views should be introspectable

2020-06-12 Thread Raymond Hettinger
Change by Raymond Hettinger : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue40890] Dict views should be introspectable

2020-06-12 Thread Raymond Hettinger
Raymond Hettinger added the comment: New changeset 3ee0e48b0376a710c08eec6f30e4181563b192a2 by Dennis Sweeney in branch 'master': bpo-40890: Add `mapping` property to dict views (GH-20749) https://github.com/python/cpython/commit/3ee0e48b0376a710c08eec6f30e4181563b192a2 --

[issue40955] subprocess_fork_exec leaks memory when extra_groups are supplied

2020-06-12 Thread Christian Heimes
Christian Heimes added the comment: 3.8 and 3.7 don't have the code path and are not affected. -- components: +Extension Modules -FreeBSD resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 3.7, Python 3.8

[issue40955] subprocess_fork_exec leaks memory when extra_groups are supplied

2020-06-12 Thread miss-islington
miss-islington added the comment: New changeset ee3f7fee94915ab4f34c92d6c89b211de476660d by Miss Islington (bot) in branch '3.9': bpo-40955: Fix memory leak in subprocess module (GH-20825) https://github.com/python/cpython/commit/ee3f7fee94915ab4f34c92d6c89b211de476660d --

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Ok, I was able to reproduce: ❯ gcc --version gcc (GCC) 10.1.0 Copyright (C) 2020 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR

[issue39827] setting a locale that uses comma as decimal separator breaks tkinter.DoubleVar

2020-06-12 Thread E. Paine
E. Paine added the comment: Is this a problem exclusive to tkinter? I ran the following code, and it appears to be an issue with the builtin 'float' method: >>> import locale >>> locale.setlocale(locale.LC_NUMERIC, 'de_DE.utf8') 'de_DE.utf8' >>> float("1,2") ValueError: could not convert

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: > Can you run the test suite before/after of pyflakes to make sure we don't > introduce any regression to double check? If everything looks fine, open a PR > :) The exact same errors before and after! I'll wait on the PR though till someone has checked

[issue40955] subprocess_fork_exec leaks memory when extra_groups are supplied

2020-06-12 Thread miss-islington
Change by miss-islington : -- pull_requests: +20027 pull_request: https://github.com/python/cpython/pull/20833 ___ Python tracker ___

[issue40955] subprocess_fork_exec leaks memory when extra_groups are supplied

2020-06-12 Thread miss-islington
Change by miss-islington : -- pull_requests: +20026 pull_request: https://github.com/python/cpython/pull/20832 ___ Python tracker ___

[issue40955] subprocess_fork_exec leaks memory when extra_groups are supplied

2020-06-12 Thread miss-islington
miss-islington added the comment: New changeset 0d3350daa8123a3e16d4a534b6e873eb12c10d7c by Christian Heimes in branch 'master': bpo-40955: Fix memory leak in subprocess module (GH-20825) https://github.com/python/cpython/commit/0d3350daa8123a3e16d4a534b6e873eb12c10d7c -- nosy:

[issue40955] subprocess_fork_exec leaks memory when extra_groups are supplied

2020-06-12 Thread miss-islington
Change by miss-islington : -- pull_requests: +20025 pull_request: https://github.com/python/cpython/pull/20831 ___ Python tracker ___

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Can you run the test suite before/after of pyflakes to make sure we don't introduce any regression to double check? If everything looks fine, open a PR :) -- ___ Python tracker

[issue40219] ttk LabeledScale: label covered by hidden element

2020-06-12 Thread Terry J. Reedy
Terry J. Reedy added the comment: Right. LabelScale is a tkinter.ttk extension, like OptionMenu. If I do the PR, I would call the placeholder 'dummy' since it is permanent (not removed after initialization). I'd like to see what happens without it and expand the comment to a line like

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: I'm guessing that some parts of the conversion code were only there to circumvent issues in displaying the error messages that weren't pegen's fault. These were fixed by Guido in GH-20072, so I think we can delete some of them. For example, this patch

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Well, I think the solution here is to clip the col_offset to the line length and maybe adding assert that the difference is not bigger than 1. -- ___ Python tracker

[issue40962] Add documentation for asyncio._set_running_loop()

2020-06-12 Thread Eugene Huang
New submission from Eugene Huang : In the pull request https://github.com/python/asyncio/pull/452#issue-92245081 the linked comment says that `asyncio._set_running_loop()` is part of the public asyncio API and will be documented, but I couldn't find any references to this function in

[issue39073] [security] email module incorrect handling of CR and LF newline characters in Address objects.

2020-06-12 Thread Larry Hastings
Larry Hastings added the comment: New changeset f91a0b6df14d6c5133fe3d5889fad7d84fc0c046 by Victor Stinner in branch '3.5': bpo-39073: validate Address parts to disallow CRLF (#19007) (#20450) https://github.com/python/cpython/commit/f91a0b6df14d6c5133fe3d5889fad7d84fc0c046 --

[issue40935] Links to Python3 docs for some libs return 404

2020-06-12 Thread Edison Abahurire
Edison Abahurire added the comment: @Ned, I'm going to search through the docs for any links that may need redirecting, and provide their python3 alternatives. -- ___ Python tracker

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: > What happens with: >>> "Ṕýţĥòñ" + Exact same thing. The offset is 16 at the start and gets decreased to 15 in the line I linked to in my previous post. And then col_offset gets converted to col_number which is 9, which seems correct. Although it is

[issue40945] TKinter.Tk.geometry(Tk.winfo_geometry()) should be idempotent

2020-06-12 Thread Ben Li-Sauerwine
Ben Li-Sauerwine added the comment: Thanks for clarifying. Using Tk.geometry() instead of Tk.winfo_geometry() does indeed resolve the issue on Linux. Weird that using Tk.winfo_geometry() is idempotent under Windows, though. -- ___ Python tracker

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > returns an object that is one character shorter than the col_offset and > that's how we get to the situation you mentioned. What happens with: >>> "Ṕýţĥòñ" + -- ___ Python tracker

[issue40670] supplying an empty string to timeit causes an IndentationError

2020-06-12 Thread Roundup Robot
Change by Roundup Robot : -- nosy: +python-dev nosy_count: 6.0 -> 7.0 pull_requests: +20024 pull_request: https://github.com/python/cpython/pull/20830 ___ Python tracker ___

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: > Note that although we could just exit if the length of the line is smaller > than the column offset before calling > https://github.com/python/cpython/blob/master/Parser/pegen.c#L148 (I assume > that is the problem) is more important to understand how

[issue40955] subprocess_fork_exec leaks memory when extra_groups are supplied

2020-06-12 Thread Gregory P. Smith
Change by Gregory P. Smith : -- title: subprocess_fork_exec leaks memory -> subprocess_fork_exec leaks memory when extra_groups are supplied ___ Python tracker ___

[issue39035] Travis CI fail on backports: pyvenv not installed

2020-06-12 Thread Larry Hastings
Larry Hastings added the comment: New changeset f88b578949a034f511dd1b4c1c161351b3ee0db8 by Inada Naoki in branch '3.5': bpo-39035: travis: Update image to xenial (#17623) https://github.com/python/cpython/commit/f88b578949a034f511dd1b4c1c161351b3ee0db8 -- nosy: +larry

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > Is the only way to get gcc-10.1 to build from source? Because currently my > internet connection is too slow to get all of gcc downloaded and `apt install > gcc-10` installs 10.0.1, which I'm getting totally unrelated erros with. If your package

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: Is the only way to get gcc-10.1 to build from source? Because currently my internet connection is too slow to get all of gcc downloaded and `apt install gcc-10` installs 10.0.1, which I'm getting totally unrelated erros with. --

[issue40961] os.putenv should be documented as not affecting os.getenv's return value

2020-06-12 Thread Daniel Martin
New submission from Daniel Martin : I find this behavior extremely surprising: $ ABC=def python Python 3.7.4 (v3.7.4:e09359112e, Jul 8 2019, 14:54:52) [Clang 6.0 (clang-600.0.57)] on darwin Type "help", "copyright", "credits" or "license" for more information. >>> import os >>>

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Oh, I was confused by this: > Running Pablo's examples in the REPL does not reproduce the errors either: I thought you meant that you could not reproduce the crash also with my patch. For the ASAN, you may need the newer gcc and other stuff. I was

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: > Lysandros, are you using a debug build? The assert() won't trigger if you > don't have run configure with --with-pydebug. BTW I'm not talking about the assert not triggering. I'm only saying that ASAN/UBSAN do not report an error when running `yield

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: I now configured Python with ./configure --with-pydebug --with-address-sanitizer --with-undefined-behavior-sanitizer. -- ___ Python tracker

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: Let me try that. I'm currently using gcc 9.3. -- ___ Python tracker ___ ___ Python-bugs-list

  1   2   >